January 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-netif[master]: stream: Undeprecate osmo_stream_srv_set_segmentation_cb()

by fixeria

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39412?usp=email ) Change subject: stream: Undeprecate osmo_stream_srv_set_segmentation_cb() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39412?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icec7ed9e16eb92a2384c16ff5b3e7011205e767c Gerrit-Change-Number: 39412 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 10:16:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 4 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...

by pespin

Attention is currently required from: csaba.sipos. pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 3: (2 comments) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/127f96c9_9708fb48?usp… : PS3, Line 617: { 0x01, "BCF" }, /* Base Control Function */ can we have defines or enum for all of these? https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/044694a7_6d4f9a6b?usp… : PS3, Line 638: { 0x0, "Enabled" }, can we have defines or enum for all of these? Plus, below you seem to use 0xff as "state invalid" or alike, so it probablyh makes sense to add that one to the defines/enums. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 3 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Comment-Date: Mon, 27 Jan 2025 10:11:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 4 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: run: add --autoreconf-in-src-copy arg

by fixeria

Attention is currently required from: lynxis lazus, neels, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39405?usp=email ) Change subject: testenv: run: add --autoreconf-in-src-copy arg ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39405?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5c38ce69dc39823d12be574c74a654d2fa6ed8fb Gerrit-Change-Number: 39405 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Jan 2025 08:04:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 4 weeks

1
0
0 0

[S] Change in libgtpnl[master]: dev_create: support returning -EEXIST

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/39160?usp=email ) Change subject: dev_create: support returning -EEXIST ...................................................................... dev_create: support returning -EEXIST Check if netlink has set errno to EEXIST and return -EEXIST in gtp_dev_create() and gtp_dev_create_sgsn(). Users of the function can use this to delete the GTP device and try creating it again. Related: SYS#7240 Change-Id: Ib99bd8eed854014a5c9118c23e4058a41f3145f2 --- M src/gtp-rtnl.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gtp-rtnl.c b/src/gtp-rtnl.c index e0db921..87c7c3f 100644 --- a/src/gtp-rtnl.c +++ b/src/gtp-rtnl.c @@ -25,6 +25,7 @@ #include <unistd.h> #include <string.h> #include <time.h> +#include <errno.h> #include <libmnl/libmnl.h> #include <net/if.h> @@ -143,7 +144,15 @@ EXPORT_SYMBOL(gtp_dev_create); int gtp_dev_create(int dest_ns, const char *gtp_ifname, int fd0, int fd1) { - return _gtp_dev_create(dest_ns, gtp_ifname, fd0, fd1, GTP_ROLE_GGSN); + int rc; + + errno = 0; + rc = _gtp_dev_create(dest_ns, gtp_ifname, fd0, fd1, GTP_ROLE_GGSN); + + if (rc < 0 && errno) + return -errno; + + return rc; } EXPORT_SYMBOL(gtp_dev_create_sgsn); -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/39160?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ib99bd8eed854014a5c9118c23e4058a41f3145f2 Gerrit-Change-Number: 39160 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 4 weeks

1
0
0 0

[S] Change in libgtpnl[master]: dev_create: support returning -EEXIST

by fixeria

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libgtpnl/+/39160?usp=email ) Change subject: dev_create: support returning -EEXIST ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/39160?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ib99bd8eed854014a5c9118c23e4058a41f3145f2 Gerrit-Change-Number: 39160 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 27 Jan 2025 07:48:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 4 weeks

1
0
0 0

[L] Change in ...osmo-s1gw[master]: Add GSMTAP logging handler

by osmith

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email ) Change subject: Add GSMTAP logging handler ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: it looks good from a quick glance, however the build fails: ``` ===> Compiling src/logger_gsmtap_h.erl failed src/logger_gsmtap_h.erl:61:17: syntax error before: 0.0 src/logger_gsmtap_h.erl:84:2: Warning: behaviour logger_handler undefined ``` -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iea884e2ca146b852c64bd9f135d8c71f4c925f09 Gerrit-Change-Number: 39415 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Jan 2025 07:46:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 4 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: Remove unsupport test cases

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email ) Change subject: SGSN: Remove unsupport test cases ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261/comment/3835445f_c9d4… : PS3, Line 7: Remove (nitpick: you're actually disabling and not removing them) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1506324300fe3864069706d5b05860e7b44cd895 Gerrit-Change-Number: 39261 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 26 Jan 2025 06:56:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 4 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...

by fixeria

Attention is currently required from: csaba.sipos. fixeria has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 3: Code-Review-1 (3 comments) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/35fc4681_b4938778?usp… : PS3, Line 1823: if (find_element Could you please explain the idea of using `if` statement without the actual body? I may be missing something, but it looks like the logic would be the same if you remove `if` here and below. https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/bea33940_aa6aeecd?usp… : PS3, Line 1825: get_object_identity_string(object_id_state[4]), object_id_state[5], get_object_state_string(object_id_state[10])); Please align this line to the opening brace `(` and make sure to not exceed the line length of 120 characters. https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/b5dffafa_a827d9c8?usp… : PS3, Line 1853: if (find_element Again, what's the idea here? If the element must be present according to the protocol specification, then I would expect a logic like this: ``` if (!find_element(noh->data, len_data, NOKIA_EI_OBJ_ID, object_identity, sizeof(object_identity)) { LOG_BTS(bts, DNM, LOGL_NOTICE, "Missing NOKIA_EI_OBJ_ID\n"); return -EINVAL; } ``` If it's optional, then you should not be accessing `object_identity` and `object_state` unconditionally below, because they may contain garbage. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 3 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Comment-Date: Sun, 26 Jan 2025 06:52:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 4 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: enable GSMTAP logging

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39417?usp=email ) Change subject: s1gw: enable GSMTAP logging ...................................................................... s1gw: enable GSMTAP logging Change-Id: Ie787844e5b77b415260526f5abde78762c6b09db Depends: osmo-s1gw.git Iea884e2ca146b852c64bd9f135d8c71f4c925f09 --- M s1gw/osmo-s1gw.config 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/39417/1 diff --git a/s1gw/osmo-s1gw.config b/s1gw/osmo-s1gw.config index 8fcd994..a20ce0f 100644 --- a/s1gw/osmo-s1gw.config +++ b/s1gw/osmo-s1gw.config @@ -23,8 +23,13 @@ {kernel, [{logger_level, debug}, {logger, - [{handler, default, logger_std_h, - #{formatter => + [{handler, gsmtap, logger_gsmtap_h, + #{level => debug, + config => #{rem_addr => "127.0.0.1", + app_name => "OsmoS1GW"}}}, + {handler, default, logger_std_h, + #{level => info, + formatter => {logger_color_formatter, #{legacy_header => false, single_line => false, template => [time, " ", color, "[", level, "]", -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39417?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie787844e5b77b415260526f5abde78762c6b09db Gerrit-Change-Number: 39417 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 4 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...

by csaba.sipos

csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 3 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 25 Jan 2025 23:50:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

4 months, 4 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025