January 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: Pass ownership of Rx xua_msg up the stack [2/2]

by pespin

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Pass ownership of Rx xua_msg up the stack [2/2] ...................................................................... Pass ownership of Rx xua_msg up the stack [2/2] This is the second step patch where we also pass ownership on Rx path so that forwarded xua_msgs can be passed back to the Tx path without freeing them. For SUA there's no change needed and we keep freeing the rx xua_msg right at the end of sua_rx_msg() since there's no actual path forwarding a xua_msg object back into Tx path, it always goes through upper layers using newly allocated primitives. Related: SYS#7112 Change-Id: Icf3b4dda550637f722a9fe56d0313f49c8a2964e --- M src/ipa.c M src/m3ua.c M src/xua_rkm.c 3 files changed, 58 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/97/39397/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Icf3b4dda550637f722a9fe56d0313f49c8a2964e Gerrit-Change-Number: 39397 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

5 months

1
0
0 0

[M] Change in libosmo-sigtran[master]: Pass xua_msg down to xua_as_transmit_msg

by pespin

Attention is currently required from: osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39398?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Pass xua_msg down to xua_as_transmit_msg ...................................................................... Pass xua_msg down to xua_as_transmit_msg This finally allows having access to msg values such as OPC and SLS at the point in code where decision is taken to route the message to one ASP inside the AS. This will be needed to properly implemented ASP loadsharing within an AS. Related: SYS#7112 Change-Id: I70e5d33c7537dc0b72b5abced876e69018cc0829 --- M src/ipa.c M src/m3ua.c M src/sua.c M src/xua_as_fsm.c M src/xua_as_fsm.h M src/xua_internal.h M src/xua_msg.h 7 files changed, 60 insertions(+), 51 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/98/39398/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39398?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I70e5d33c7537dc0b72b5abced876e69018cc0829 Gerrit-Change-Number: 39398 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

5 months

1
0
0 0

[M] Change in libosmo-sigtran[master]: Pass xua_msg down to xua_as_transmit_msg

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39398?usp=email ) Change subject: Pass xua_msg down to xua_as_transmit_msg ...................................................................... Patch Set 2: (1 comment) File src/xua_as_fsm.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39398/comment/905daf24_a8e8a… : PS2, Line 17: ownsership transferred. > ```suggestion […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39398?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I70e5d33c7537dc0b72b5abced876e69018cc0829 Gerrit-Change-Number: 39398 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Jan 2025 13:44:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

5 months

1
0
0 0

[M] Change in libosmo-sigtran[master]: Pass ownership of Rx xua_msg up the stack [2/2]

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397?usp=email ) Change subject: Pass ownership of Rx xua_msg up the stack [2/2] ...................................................................... Patch Set 2: (6 comments) File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/5c3ed8de_79da6… : PS2, Line 304: ownsership > ```suggestion […] Done File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/75c4fd44_9fbb0… : PS2, Line 627: ownsership > ```suggestion […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/face901f_936e4… : PS2, Line 784: goto out; > missing `xua_msg_free(xua);` since it doesn't go through any `m3ua_rx_*`? Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/ca94c065_7591f… : PS2, Line 815: err = m3ua_gen_error_msg(M3UA_ERR_UNSUPP_MSG_CLASS, msg); > missing `xua_msg_free(xua);` since it doesn't go through any `m3ua_rx_*`? Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/cc0dcb96_2711f… : PS2, Line 1015: return M3UA_ERR_UNSUPP_MSG_TYPE; > ```suggestion […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397/comment/ebc82a1d_e61f3… : PS2, Line 1019: return M3UA_ERR_UNSUPP_MSG_TYPE; > ```suggestion […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Icf3b4dda550637f722a9fe56d0313f49c8a2964e Gerrit-Change-Number: 39397 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Jan 2025 13:43:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

5 months

1
0
0 0

[S] Change in osmo-bsc[master]: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39386?usp=email ) Change subject: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2 ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I420da09c248fc2e58bfac3e91fe38bddb1de4018 Gerrit-Change-Number: 39386 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

5 months

1
0
0 0

[S] Change in libosmo-abis[master]: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39384?usp=email ) Change subject: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2 ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3735728e309f5c0368f6c21edde160c4f86aee01 Gerrit-Change-Number: 39384 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

5 months

1
0
0 0

[S] Change in libosmo-sigtran[master]: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39383?usp=email ) Change subject: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2 ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2be4d3a650fa5231f2fdd55325a8d9238d1ba70c Gerrit-Change-Number: 39383 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

5 months

1
0
0 0

[S] Change in libosmo-netif[master]: examples,tests: stream: use new osmo_stream_{cli,srv}_set_segmentatio...

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39382?usp=email ) Change subject: examples,tests: stream: use new osmo_stream_{cli,srv}_set_segmentation_cb2 ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5d6131c65ad6d47f1567dde498a0637c48a0fde9 Gerrit-Change-Number: 39382 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

5 months

1
0
0 0

[S] Change in osmo-remsim[master]: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39385?usp=email ) Change subject: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2 ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I02c55179a144e3bbd1f760f5429e16c6e327111e Gerrit-Change-Number: 39385 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org>

5 months

1
0
0 0

[S] Change in osmo-remsim[master]: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39385?usp=email ) Change subject: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2 ...................................................................... Patch Set 1: (1 comment) File src/rspro_client_fsm.c: https://gerrit.osmocom.org/c/osmo-remsim/+/39385/comment/924d3830_f867de18?… : PS1, Line 142: static int srvc_ipa_segmentation_cb2(struct osmo_stream_cli *cli, struct msgb *msg) : { : return osmo_ipa_segmentation_cb(msg); : } : > yeah, let's un-deprecate the old API. thanks. Done Here: https://gerrit.osmocom.org/c/libosmo-netif/+/39412 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I02c55179a144e3bbd1f760f5429e16c6e327111e Gerrit-Change-Number: 39385 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 24 Jan 2025 13:26:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025