January 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-dev[master]: gen_makefile: modernize generator for "regen"

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39402?usp=email ) Change subject: gen_makefile: modernize generator for "regen" ...................................................................... Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39402?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I345d2ae64a0afd5fe71d483c7dfe6a2ce2248c74 Gerrit-Change-Number: 39402 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Jan 2025 10:14:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: fix f-string without placeholders

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/39401?usp=email ) Change subject: gen_makefile: fix f-string without placeholders ...................................................................... gen_makefile: fix f-string without placeholders gen_makefile.py:604:17: F541 [*] f-string without any placeholders Change-Id: I77b38247fb38136f77f89d40669b2df378dca192 --- M gen_makefile.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified laforge: Looks good to me, but someone else must approve diff --git a/gen_makefile.py b/gen_makefile.py index 18af686..7d73df8 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -601,7 +601,7 @@ ldconfig_without_sudo=' \\\n\t\t--ldconfig-without-sudo' if args.ldconfig_without_sudo else '', make_check='' if args.make_check else " \\\n\t\t--no-make-check", docker_cmd=f' \\\n\t\t--docker-cmd "{args.docker_cmd}"' if args.docker_cmd else '', - build_debug=f' \\\n\t\t--build-debug' if args.build_debug else '', + build_debug=' \\\n\t\t--build-debug' if args.build_debug else '', auto_distclean=' \\\n\t\t--auto-distclean' if args.auto_distclean else '', ) -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I77b38247fb38136f77f89d40669b2df378dca192 Gerrit-Change-Number: 39401 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: fix f-string without placeholders

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39401?usp=email ) Change subject: gen_makefile: fix f-string without placeholders ...................................................................... Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I77b38247fb38136f77f89d40669b2df378dca192 Gerrit-Change-Number: 39401 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Jan 2025 10:14:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: fix variable assigned but never used

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/39400?usp=email ) Change subject: gen_makefile: fix variable assigned but never used ...................................................................... gen_makefile: fix variable assigned but never used gen_makefile.py:147:7: F841 Local variable `l` is assigned to but never used gen_makefile.py:313:5: F841 Local variable `target` is assigned to but never used Change-Id: Ib938d3336d395bfed3e5194dcf86ae5d56f99984 --- M gen_makefile.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: osmith: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/gen_makefile.py b/gen_makefile.py index 22882bd..18af686 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -144,7 +144,7 @@ def extend_dict(self, d): for k,v in d.items(): - l = self.extend(k, v) + self.extend(k, v) def read_projects_deps(path): 'Read deps config and return tuples of (project_name, which-other-to-build-first).' @@ -310,7 +310,6 @@ touch $@ ''' elif buildsystem == "meson": - target = "test" if check else "compile" test_line = "" # TODO: currently tests don't pass in this env # if check: -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39400?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ib938d3336d395bfed3e5194dcf86ae5d56f99984 Gerrit-Change-Number: 39400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: fix variable assigned but never used

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39400?usp=email ) Change subject: gen_makefile: fix variable assigned but never used ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39400?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ib938d3336d395bfed3e5194dcf86ae5d56f99984 Gerrit-Change-Number: 39400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Jan 2025 10:14:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: fix variable assigned but never used

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39400?usp=email ) Change subject: gen_makefile: fix variable assigned but never used ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39400?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ib938d3336d395bfed3e5194dcf86ae5d56f99984 Gerrit-Change-Number: 39400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Jan 2025 10:14:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[S] Change in osmo-bsc[master]: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39386?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2 ...................................................................... Patch Set 1: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I420da09c248fc2e58bfac3e91fe38bddb1de4018 Gerrit-Change-Number: 39386 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Jan 2025 10:03:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[S] Change in osmo-bsc[master]: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39386?usp=email ) Change subject: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I420da09c248fc2e58bfac3e91fe38bddb1de4018 Gerrit-Change-Number: 39386 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Jan 2025 10:03:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[M] Change in osmo-dev[master]: gen_makefile: modernize gen_make

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39403?usp=email ) Change subject: gen_makefile: modernize gen_make ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39403?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I03350986c07226889b618869ec74a95be8712e3e Gerrit-Change-Number: 39403 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Jan 2025 10:03:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[M] Change in osmo-dev[master]: gen_makefile: modernize generator for "regen"

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39402?usp=email ) Change subject: gen_makefile: modernize generator for "regen" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39402?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I345d2ae64a0afd5fe71d483c7dfe6a2ce2248c74 Gerrit-Change-Number: 39402 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 Jan 2025 10:03:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025