Attention is currently required from: csaba.sipos. pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 3: (2 comments) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/127f96c9_9708fb48?usp=... : PS3, Line 617: { 0x01, "BCF" }, /* Base Control Function */ can we have defines or enum for all of these? https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/044694a7_6d4f9a6b?usp=... : PS3, Line 638: { 0x0, "Enabled" }, can we have defines or enum for all of these? Plus, below you seem to use 0xff as "state invalid" or alike, so it probablyh makes sense to add that one to the defines/enums. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 3 Gerrit-Owner: csaba.sipos <metro4@freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: csaba.sipos <metro4@freemail.hu> Gerrit-Comment-Date: Mon, 27 Jan 2025 10:11:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No