January 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: SGSN: Remove unsupport test cases

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email ) Change subject: SGSN: Remove unsupport test cases ...................................................................... SGSN: Remove unsupport test cases The functionality for ACL based authentication (only use the IMSI, but don't request information from the HLR) will be removed from the SGSN. Change-Id: I1506324300fe3864069706d5b05860e7b44cd895 --- M sgsn/SGSN_Tests.ttcn M sgsn/expected-results.xml 2 files changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/39261/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 794d23f..ca99a02 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -3435,12 +3435,7 @@ execute( TC_attach_gsup_lu_timeout() ); execute( TC_attach_gsup_lu_reject() ); execute( TC_attach_combined() ); - execute( TC_attach_accept_all() ); - execute( TC_attach_closed() ); execute( TC_attach_no_imsi_response() ); - execute( TC_attach_closed_add_vty(), 20.0 ); - execute( TC_attach_check_subscriber_list(), 20.0 ); - execute( TC_attach_detach_check_subscriber_list(), 20.0 ); execute( TC_attach_check_complete_resend() ); execute( TC_hlr_location_cancel_request_update(), 20.0 ); execute( TC_hlr_location_cancel_request_withdraw(), 20.0 ); diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml index f901f6d..d91871e 100644 --- a/sgsn/expected-results.xml +++ b/sgsn/expected-results.xml @@ -21,12 +21,7 @@ </failure> </testcase> <testcase classname='SGSN_Tests' name='TC_attach_combined' time='MASKED'/> - <testcase classname='SGSN_Tests' name='TC_attach_accept_all' time='MASKED'/> - <testcase classname='SGSN_Tests' name='TC_attach_closed' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_no_imsi_response' time='MASKED'/> - <testcase classname='SGSN_Tests' name='TC_attach_closed_add_vty' time='MASKED'/> - <testcase classname='SGSN_Tests' name='TC_attach_check_subscriber_list' time='MASKED'/> - <testcase classname='SGSN_Tests' name='TC_attach_detach_check_subscriber_list' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_check_complete_resend' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_hlr_location_cancel_request_update' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_hlr_location_cancel_request_withdraw' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1506324300fe3864069706d5b05860e7b44cd895 Gerrit-Change-Number: 39261 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: remove TC_attach_no_imei_response

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39260?usp=email ) Change subject: SGSN: remove TC_attach_no_imei_response ...................................................................... SGSN: remove TC_attach_no_imei_response The SGSN doesn't request the IMEI via Identity Response anymore. This information is requested via Authentication/Ciphering Req/Resp. Change-Id: I42dc927513fb54b0fd2d07dda4cf8d4646b9f351 --- M sgsn/SGSN_Tests.ttcn M sgsn/expected-results.xml 2 files changed, 0 insertions(+), 48 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/39260/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 43da288..794d23f 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -1687,52 +1687,6 @@ f_cleanup(); } -/* Attempt an attach, but loose the Identification Request (IMEI) */ -private function f_TC_attach_no_imei_response(charstring id) runs on BSSGP_ConnHdlr { - var integer count_req := 0; - var MobileL3_CommonIE_Types.MobileIdentityLV mi; - - f_send_l3(ts_GMM_ATTACH_REQ(f_mi_get_lv(), f_random_RAI(), true, false, omit, omit)); - - alt { - [] BSSGP[0].receive(tr_GMM_ATTACH_REJECT(?)) { - /* break */ - } - [] BSSGP[0].receive(tr_GMM_ID_REQ('001'B)) { - mi := valueof(ts_MI_IMSI_LV(g_pars.imsi)); - f_send_l3(ts_GMM_ID_RESP(mi)); - repeat; - } - [] BSSGP[0].receive(tr_GMM_ID_REQ('010'B)) { - /* ignore ID REQ IMEI */ - count_req := count_req + 1; - repeat; - } - } - if (count_req != 5) { - setverdict(fail, "Did not received GMM ID Request Type IMEI 5 times!"); - mtc.stop; - } - setverdict(pass); -} - -testcase TC_attach_no_imei_response() runs on test_CT { - /* MS -> SGSN: Attach Request IMSI - * MS <- SGSN: Identity Request IMSI (optional) - * MS -> SGSN: Identity Response IMSI (optional) - * MS <- SGSN: Identity Request IMEI - * MS -x SGSN: no response - * MS <- SGSN: re-send: Identity Request IMEI 4x - * MS <- SGSN: Attach Reject - */ - var BSSGP_ConnHdlr vc_conn; - f_init(); - f_sleep(1.0); - vc_conn := f_start_handler(refers(f_TC_attach_no_imei_response), testcasename(), g_gb, 32, 60.0); - vc_conn.done; - f_cleanup(); -} - /* Attempt an attach, but loose the Identification Request (IMSI) */ private function f_TC_attach_no_imsi_response(charstring id) runs on BSSGP_ConnHdlr { var integer count_req := 0; @@ -3483,7 +3437,6 @@ execute( TC_attach_combined() ); execute( TC_attach_accept_all() ); execute( TC_attach_closed() ); - execute( TC_attach_no_imei_response() ); execute( TC_attach_no_imsi_response() ); execute( TC_attach_closed_add_vty(), 20.0 ); execute( TC_attach_check_subscriber_list(), 20.0 ); diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml index bdd0f29..f901f6d 100644 --- a/sgsn/expected-results.xml +++ b/sgsn/expected-results.xml @@ -23,7 +23,6 @@ <testcase classname='SGSN_Tests' name='TC_attach_combined' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_accept_all' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_closed' time='MASKED'/> - <testcase classname='SGSN_Tests' name='TC_attach_no_imei_response' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_no_imsi_response' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_closed_add_vty' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_check_subscriber_list' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39260?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I42dc927513fb54b0fd2d07dda4cf8d4646b9f351 Gerrit-Change-Number: 39260 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: f_cellid_to_RAI: fix spaces vs tabs

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39253?usp=email ) Change subject: f_cellid_to_RAI: fix spaces vs tabs ...................................................................... f_cellid_to_RAI: fix spaces vs tabs Change-Id: Ic1927729dd0d205f1bd866423c8dfdf91caf597d --- M sgsn/SGSN_Tests.ttcn 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/39253/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index a7833fd..a39e346 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -210,17 +210,17 @@ /* mcc_mnc is encoded as of 24.008 10.5.5.15 */ var BcdMccMnc mcc_mnc := cell_id.ra_id.lai.mcc_mnc; - var RoutingAreaIdentificationV ret := { - mccDigit1 := mcc_mnc[0], - mccDigit2 := mcc_mnc[1], - mccDigit3 := mcc_mnc[2], - mncDigit3 := mcc_mnc[3], - mncDigit1 := mcc_mnc[4], - mncDigit2 := mcc_mnc[5], - lac := int2oct(cell_id.ra_id.lai.lac, 2), - rac := int2oct(cell_id.ra_id.rac, 1) - } - return ret; + var RoutingAreaIdentificationV ret := { + mccDigit1 := mcc_mnc[0], + mccDigit2 := mcc_mnc[1], + mccDigit3 := mcc_mnc[2], + mncDigit3 := mcc_mnc[3], + mncDigit1 := mcc_mnc[4], + mncDigit2 := mcc_mnc[5], + lac := int2oct(cell_id.ra_id.lai.lac, 2), + rac := int2oct(cell_id.ra_id.rac, 1) + } + return ret; }; private function f_BssgpCellId_to_GTP_CellId(in BssgpCellId cell_id) return GTP_CellId -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39253?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic1927729dd0d205f1bd866423c8dfdf91caf597d Gerrit-Change-Number: 39253 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

8 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255?usp=email ) Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit ...................................................................... SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit Extend the TC_attach_gmm_attach_req_while_gmm_attach by "loosing" an ID Req message. Change-Id: I8d208c0a98675238dba439ab3e75758293928588 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 89 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/39255/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index f8b9213..71b55c7 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -2073,10 +2073,11 @@ * MS <- SGSN: Identity Request IMSI * MS -> SGSN: Identity Response IMSI * MS -> SGSN: Attach Request (2nd) - * SGS -> HLR: SAI Request - * SGS <- HLR: SAI Response - * MS <- SGSN: Identity Request IMEI - * MS -> SGSN: Identity Response IMEI + * SGSN -> HLR: SAI Request + * SGSN <- HLR: SAI Response + * MS <- SGSN: Auth Req + * MS <- SGSN: Auth Resp + * SGSN <-> HLR: ULA/ISD * MS <- SGSN: Attach Accept * MS -> SGSN: Attach Complete */ @@ -2088,6 +2089,89 @@ f_cleanup(); } +/* The main difference to f_TC_attach_gmm_attach_req_while_gmm_attach is the *lost* of the first ID Req */ +private function f_TC_attach_gmm_attach_req_while_gmm_attach_retransmit(charstring id) runs on BSSGP_ConnHdlr { + var integer count_req := 0; + var MobileL3_CommonIE_Types.MobileIdentityLV mi; + var RoutingAreaIdentificationV rand_rai := f_random_RAI(); + var PDU_L3_SGSN_MS l3_mt; + + g_pars.vec := f_gen_auth_vec_3g(); + g_pars.p_tmsi := f_random_ptmsi(suffix := '01'O); + + f_send_l3(ts_GMM_ATTACH_REQ(f_mi_get_lv(), rand_rai, true, false, omit, omit)); + + alt { + [] BSSGP[0].receive(tr_GMM_ATTACH_REJECT(?)) { + setverdict(fail, "Unexpected GMM ATTACH REJECT"); + mtc.stop; + } + [] BSSGP[0].receive(tr_GMM_ID_REQ('001'B)) { + mi := valueof(ts_MI_IMSI_LV(g_pars.imsi)); + f_send_l3(ts_GMM_ATTACH_REQ(f_mi_get_lv(), rand_rai, true, false, omit, omit)); + } + } + + alt { + [] BSSGP[0].receive(tr_GMM_ATTACH_REJECT(?)) { + setverdict(fail, "Unexpected GMM ATTACH REJECT"); + mtc.stop; + } + [] BSSGP[0].receive(tr_GMM_ID_REQ('001'B)) { + mi := valueof(ts_MI_IMSI_LV(g_pars.imsi)); + f_send_l3(ts_GMM_ID_RESP(mi)); + repeat; + } + [] BSSGP[0].receive(tr_GMM_ID_REQ('010'B)) { + /* send out a second GMM_Attach Request. + * If the SGSN follows the rules, this 2nd ATTACH REQ should be ignored, because + * of the same content */ + mi := valueof(ts_MI_IMEI_LV(g_pars.imei)); + repeat; + } + [] as_gmm_auth(umts_aka_challenge := true, expect_sai := true) {}; + } + f_sleep(1.0); + + /* we've sent already a IMEI answer, we should NOT asked again for IMEI */ + alt { + [] as_gmm_gsup_lu_isd() { repeat; }; + [] BSSGP[0].receive(tr_GMM_ATTACH_REJECT(?)) { + setverdict(fail, "Unexpected GMM ATTACH REJECT"); + mtc.stop; + } + [] BSSGP[0].receive(tr_GMM_ATTACH_ACCEPT('001'B, ?, ?)) -> value l3_mt { + f_process_attach_accept(l3_mt.msgs.gprs_mm.attachAccept); + f_send_l3(ts_GMM_ATTACH_COMPL); + setverdict(pass); + /* FIXME: Extract P-TMSI, if any. Only send Complete if necessary */ + } + } +} + +testcase TC_attach_gmm_attach_req_while_gmm_attach_retransmit() runs on test_CT { + /* Testing if the SGSN ignore Attach Request with the exact same content */ + /* MS -> SGSN: Attach Request TMSI + * MS <- SGSN: Identity Request IMSI + * MS -> SGSN: Attach Request (2nd) + * MS <- SGSN: Identity Request IMSI (retrans) + * SGSN -> HLR: SAI Request + * SGSN <- HLR: SAI Response + * MS <- SGSN: Auth Req + * MS <- SGSN: Auth Resp + * SGSN <-> HLR: ULA/ISD + * MS <- SGSN: Attach Accept + * MS -> SGSN: Attach Complete + */ + var BSSGP_ConnHdlr vc_conn; + f_init(); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_TC_attach_gmm_attach_req_while_gmm_attach_retransmit), testcasename(), g_gb, 39); + vc_conn.done; + f_cleanup(); +} + + private function f_TC_attach_usim_resync(charstring id) runs on BSSGP_ConnHdlr { var RoutingAreaIdentificationV old_ra := f_random_RAI(); @@ -3375,6 +3459,7 @@ execute( TC_attach_pdp_act_user_error_ind_ggsn() ); execute( TC_attach_pdp_act_gmm_detach() ); execute( TC_attach_gmm_attach_req_while_gmm_attach() ); + execute( TC_attach_gmm_attach_req_while_gmm_attach_retransmit() ); execute( TC_xid_empty_l3() ); execute( TC_xid_n201u() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d208c0a98675238dba439ab3e75758293928588 Gerrit-Change-Number: 39255 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email ) Change subject: SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case ...................................................................... SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case The SGSN has changed the behavior: - removed auth-policy - not supported anymore - require authentication Change-Id: I026499844940d4c3d82b0fbd61be636c6ca348e6 --- M sgsn/BSSGP_ConnHdlr.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 18 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/39254/1 diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn index 1af9181..12819b7 100644 --- a/sgsn/BSSGP_ConnHdlr.ttcn +++ b/sgsn/BSSGP_ConnHdlr.ttcn @@ -531,6 +531,10 @@ /* T3302, T3319, T3323, T3312_ext, T3324 */ } +function f_random_ptmsi(OCT1 suffix := '00'O) return OCT4 { + return 'C0'O & f_rnd_octstring(2) & suffix; +} + function f_random_RAI(HEX0_3n mcc := '262'H, HEX0_3n mnc := '42'H) return RoutingAreaIdentificationV { return f_RAI(mcc, mnc, f_rnd_octstring(2), f_rnd_octstring(1)); } diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index a39e346..f8b9213 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -2024,6 +2024,9 @@ var RoutingAreaIdentificationV rand_rai := f_random_RAI(); var PDU_L3_SGSN_MS l3_mt; + g_pars.vec := f_gen_auth_vec_3g(); + g_pars.p_tmsi := f_random_ptmsi(suffix := '01'O); + f_send_l3(ts_GMM_ATTACH_REQ(f_mi_get_lv(), rand_rai, true, false, omit, omit)); alt { @@ -2034,30 +2037,23 @@ [] BSSGP[0].receive(tr_GMM_ID_REQ('001'B)) { mi := valueof(ts_MI_IMSI_LV(g_pars.imsi)); f_send_l3(ts_GMM_ID_RESP(mi)); + f_send_l3(ts_GMM_ATTACH_REQ(f_mi_get_lv(), rand_rai, true, false, omit, omit)); repeat; } [] BSSGP[0].receive(tr_GMM_ID_REQ('010'B)) { /* send out a second GMM_Attach Request. * If the SGSN follows the rules, this 2nd ATTACH REQ should be ignored, because * of the same content */ - f_send_l3(ts_GMM_ATTACH_REQ(f_mi_get_lv(), rand_rai, true, false, omit, omit)); mi := valueof(ts_MI_IMEI_LV(g_pars.imei)); - f_send_l3(ts_GMM_ID_RESP(mi)); + repeat; } + [] as_gmm_auth(umts_aka_challenge := true, expect_sai := true) {}; } f_sleep(1.0); /* we've sent already a IMEI answer, we should NOT asked again for IMEI */ alt { - [] BSSGP[0].receive(tr_GMM_ID_REQ('001'B)) { - mi := valueof(ts_MI_IMSI_LV(g_pars.imsi)); - f_send_l3(ts_GMM_ID_RESP(mi)); - repeat; - } - [] BSSGP[0].receive(tr_GMM_ID_REQ('010'B)) { - setverdict(fail, "Unexpected GMM ID REQ (IMEI)."); - mtc.stop; - } + [] as_gmm_gsup_lu_isd() { repeat; }; [] BSSGP[0].receive(tr_GMM_ATTACH_REJECT(?)) { setverdict(fail, "Unexpected GMM ATTACH REJECT"); mtc.stop; @@ -2073,19 +2069,20 @@ testcase TC_attach_gmm_attach_req_while_gmm_attach() runs on test_CT { /* Testing if the SGSN ignore Attach Request with the exact same content */ - /* MS -> SGSN: Attach Request IMSI - * MS <- SGSN: Identity Request IMSI (optional) - * MS -> SGSN: Identity Response IMSI (optional) - * MS <- SGSN: Identity Request IMEI + /* MS -> SGSN: Attach Request TMSI + * MS <- SGSN: Identity Request IMSI + * MS -> SGSN: Identity Response IMSI * MS -> SGSN: Attach Request (2nd) - * MS <- SGSN: Identity Response IMEI + * SGS -> HLR: SAI Request + * SGS <- HLR: SAI Response + * MS <- SGSN: Identity Request IMEI + * MS -> SGSN: Identity Response IMEI * MS <- SGSN: Attach Accept * MS -> SGSN: Attach Complete */ var BSSGP_ConnHdlr vc_conn; f_init(); f_sleep(1.0); - f_vty_config(SGSNVTY, "sgsn", "auth-policy accept-all"); vc_conn := f_start_handler(refers(f_TC_attach_gmm_attach_req_while_gmm_attach), testcasename(), g_gb, 39); vc_conn.done; f_cleanup(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I026499844940d4c3d82b0fbd61be636c6ca348e6 Gerrit-Change-Number: 39254 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

8 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: GSUP_Templates: Purge MS Request: allow the Message class IE to be pr...

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39235?usp=email ) Change subject: GSUP_Templates: Purge MS Request: allow the Message class IE to be present ...................................................................... GSUP_Templates: Purge MS Request: allow the Message class IE to be present Change-Id: I367f63fe5286e39ba51de94729455d2638f19c6f --- M library/GSUP_Templates.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: daniel: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 3335125..cbe4566 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -485,7 +485,7 @@ template GSUP_PDU tr_GSUP_PURGE_MS_REQ(template hexstring imsi, template GSUP_CnDomain dom := ?) := tr_GSUP(OSMO_GSUP_MSGT_PURGE_MS_REQUEST, { - tr_GSUP_IE_IMSI(imsi), *, tr_GSUP_IE_CnDomain(dom) }); + tr_GSUP_IE_IMSI(imsi), *, tr_GSUP_IE_CnDomain(dom), * }); template (value) GSUP_PDU ts_GSUP_PURGE_MS_RES(hexstring imsi) := ts_GSUP(OSMO_GSUP_MSGT_PURGE_MS_RESULT, { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39235?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I367f63fe5286e39ba51de94729455d2638f19c6f Gerrit-Change-Number: 39235 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

8 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: GSUP_Templates: Purge MS Request: allow the Message class IE to be pr...

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39235?usp=email ) Change subject: GSUP_Templates: Purge MS Request: allow the Message class IE to be present ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39235?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I367f63fe5286e39ba51de94729455d2638f19c6f Gerrit-Change-Number: 39235 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 08 Jan 2025 17:34:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months

1
0
0 0

[M] Change in osmo-ggsn[master]: gtpie: add gtp_encaps a modern encapsulation method

by pespin

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/39032?usp=email ) Change subject: gtpie: add gtp_encaps a modern encapsulation method ...................................................................... Patch Set 4: (1 comment) File gtp/gtpie.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/39032/comment/0fa517a5_96ddf341?us… : PS4, Line 956: int gtpie_encaps3(union gtpie_member **ies, unsigned int ie_len, in th e.h files it shows up like "union gtpie_member **ies". Better use same syntax everywhere. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39032?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I8bb086c568e07052c52d880df06049490346e91e Gerrit-Change-Number: 39032 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 08 Jan 2025 14:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

8 months

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: add missing element names

by csaba.sipos

Attention is currently required from: laforge. csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39252?usp=email ) Change subject: nokia_site: add missing element names ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39252/comment/6f16739d_f3db05f2?usp… : PS1, Line 551: if > you're changing the original "If" to "if". […] I did not change anything, this is how it "comes". This is a typo in the "source". If you want I can fix it, but then it will not be consistent with the "source". -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia4026bbe458817e164b756847229cf6a90d02865 Gerrit-Change-Number: 39252 Gerrit-PatchSet: 1 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 08 Jan 2025 14:05:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

8 months

1
0
0 0

[M] Change in osmo-ggsn[master]: gtpie: add gtp_encaps a modern encapsulation method

by lynxis lazus

Attention is currently required from: laforge, lynxis lazus. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39032?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: gtpie: add gtp_encaps a modern encapsulation method ...................................................................... gtpie: add gtp_encaps a modern encapsulation method No idea why the previous ones started at the second IE. Further add more length arguments to the encapsulation method. Change-Id: I8bb086c568e07052c52d880df06049490346e91e --- M gtp/gtpie.c M include/osmocom/gtp/gtpie.h 2 files changed, 188 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/32/39032/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39032?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I8bb086c568e07052c52d880df06049490346e91e Gerrit-Change-Number: 39032 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025