Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/39238?usp=email )
Change subject: gtp: add internal functions gtp_reqv1c/gtp_respv1c
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> The build fails because the new function are "defined but not used"
Then it's a sign they should be added in the patch adding those messages :)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39238?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: If1a60a2ea08b74aaf23485e036b9632f38ab4bda
Gerrit-Change-Number: 39238
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 08 Jan 2025 18:18:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39264?usp=email )
Change subject: L3_Templates: add MM cause codes
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39264?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I396ddaf5b08faddcf002317307dcc20840898aa9
Gerrit-Change-Number: 39264
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 08 Jan 2025 18:16:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email )
Change subject: SGSN: add testcases for PDP Context Status
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/19b87696_b14a… :
PS3, Line 2592: f_send_l3(ts_GMM_RAU_REQ(f_mi_get_lv(), GPRS_UPD_T_RA, old_ra := g_pars.ra, pdp_status := '2000'O /* NSAPI 5 */), ran_index);
we should probably have this somehow stored in "apars", and generate the pdp_status with a function from there.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5a29e667f53cc2834fbddd2c5dc901d3e6ae72c7
Gerrit-Change-Number: 39262
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 08 Jan 2025 18:15:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39257?usp=email )
Change subject: SGSN: TC_attach_gsup_lu_timeout: increase timeout to 35 seconds
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
we should ideally change the timeout to a lower value instead, to avoid increasing testsuite runtime by 1 minute...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39257?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie882dd39f3c606e5fe00162fcf17c47b9f713d49
Gerrit-Change-Number: 39257
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 08 Jan 2025 18:10:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No