January 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: TC_attach_gsup_lu_timeout: increase timeout to 35 seconds

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39257?usp=email ) Change subject: SGSN: TC_attach_gsup_lu_timeout: increase timeout to 35 seconds ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie882dd39f3c606e5fe00162fcf17c47b9f713d49 Gerrit-Change-Number: 39257 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 08 Jan 2025 18:09:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email ) Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/9e9c7fa1_1b48… : PS3, Line 12: message, the old GMM Attach should be discard silently and a new dicarded? File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/04fc79fb_c4c7… : PS3, Line 2215: /* FIXME: Extract P-TMSI, if any. Only send Complete if necessary */ what about this? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc Gerrit-Change-Number: 39256 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 08 Jan 2025 18:08:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: TC_attach_gmm_attach_req_while_gmm_attach: fix TC plan comment

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39266?usp=email ) Change subject: TC_attach_gmm_attach_req_while_gmm_attach: fix TC plan comment ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39266?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I58068490eec8333c7ea5d7c47668f97616ab5ff1 Gerrit-Change-Number: 39266 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 08 Jan 2025 18:08:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255?usp=email ) Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit ...................................................................... Patch Set 3: Code-Review-1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255/comment/d07170d5_2303… : PS3, Line 10: by "loosing" an ID Req message. losing File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255/comment/e2a6ddc4_a239… : PS3, Line 2125: /* send out a second GMM_Attach Request. same here, this is not true here, no second GMM attach here... please re-read the whole test. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d208c0a98675238dba439ab3e75758293928588 Gerrit-Change-Number: 39255 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 08 Jan 2025 18:07:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email ) Change subject: SGSN: TC_attach_gmm_attach_req_while_gmm_attach: fix test case ...................................................................... Patch Set 2: Code-Review-1 (4 comments) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/fa700165_4bcb… : PS2, Line 534: function f_random_ptmsi(OCT1 suffix := '00'O) return OCT4 { library/Osmocom_Gb_Types.ttcn 3872: function f_gprs_tlli_random() return OCT4 { 3873- var OCT4 tlli := f_rnd_octstring(4); 3874- return tlli or4b 'c0000000'O; 3875- } 3876- 3877-} with { encode "RAW" }; File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/69a635d3_8b81… : PS2, Line 2088: f_vty_config(SGSNVTY, "sgsn", "auth-policy accept-all"); why was this removed? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/b5e74039_ffe6… : PS2, Line 2044: /* send out a second GMM_Attach Request. this comment no longer matches the code, you moved the second attach above... I wonder why did you move it. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254/comment/26f7e967_9af5… : PS2, Line 2050: [] as_gmm_auth(umts_aka_challenge := true, expect_sai := true) {}; AFAIU the auth is exected to happen at the end of the whole alt? maybe simply move it outside to expect it to happen after the other messages. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I026499844940d4c3d82b0fbd61be636c6ca348e6 Gerrit-Change-Number: 39254 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 08 Jan 2025 18:06:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: add internal functions gtp_reqv1c/gtp_respv1c

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/39238?usp=email ) Change subject: gtp: add internal functions gtp_reqv1c/gtp_respv1c ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: The build fails because the new function are "defined but not used" -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: If1a60a2ea08b74aaf23485e036b9632f38ab4bda Gerrit-Change-Number: 39238 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 08 Jan 2025 18:05:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: TC_attach_gmm_attach_req_while_gmm_attach: fix TC plan comment

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39266?usp=email ) Change subject: TC_attach_gmm_attach_req_while_gmm_attach: fix TC plan comment ...................................................................... TC_attach_gmm_attach_req_while_gmm_attach: fix TC plan comment Change-Id: I58068490eec8333c7ea5d7c47668f97616ab5ff1 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/39266/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 627581f..71b55c7 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -2073,10 +2073,11 @@ * MS <- SGSN: Identity Request IMSI * MS -> SGSN: Identity Response IMSI * MS -> SGSN: Attach Request (2nd) - * SGS -> HLR: SAI Request - * SGS <- HLR: SAI Response - * MS <- SGSN: Identity Request IMEI - * MS -> SGSN: Identity Response IMEI + * SGSN -> HLR: SAI Request + * SGSN <- HLR: SAI Response + * MS <- SGSN: Auth Req + * MS <- SGSN: Auth Resp + * SGSN <-> HLR: ULA/ISD * MS <- SGSN: Attach Accept * MS -> SGSN: Attach Complete */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39266?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I58068490eec8333c7ea5d7c47668f97616ab5ff1 Gerrit-Change-Number: 39266 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

5 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: add testcases for PDP Context Status

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: SGSN: add testcases for PDP Context Status ...................................................................... SGSN: add testcases for PDP Context Status Both the network and the UE can add a TLV which describes the active PDPs from their perspective. Change-Id: I5a29e667f53cc2834fbddd2c5dc901d3e6ae72c7 --- M library/L3_Templates.ttcn M sgsn/SGSN_Tests.ttcn M sgsn/expected-results.xml 3 files changed, 222 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/39262/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a29e667f53cc2834fbddd2c5dc901d3e6ae72c7 Gerrit-Change-Number: 39262 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

5 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed ...................................................................... SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed Add a TC to to simulate multiple GMM Attach with a different content. When receiving a GMM Attach while in an Attach, but with a different message, the old GMM Attach should be discard silently and a new GMM Attach procedure should be initiated. Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc --- M sgsn/SGSN_Tests.ttcn M sgsn/expected-results.xml 2 files changed, 71 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/39256/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc Gerrit-Change-Number: 39256 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

5 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit ...................................................................... SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_retransmit Extend the TC_attach_gmm_attach_req_while_gmm_attach by "loosing" an ID Req message. Change-Id: I8d208c0a98675238dba439ab3e75758293928588 --- M sgsn/SGSN_Tests.ttcn M sgsn/expected-results.xml 2 files changed, 85 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/39255/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d208c0a98675238dba439ab3e75758293928588 Gerrit-Change-Number: 39255 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

5 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025