September 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: vty: Add new "show cs7 instance <0-15> point-codes" command

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38181?usp=email ) Change subject: vty: Add new "show cs7 instance <0-15> point-codes" command ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: continuation from https://gerrit.osmocom.org/c/libosmo-sccp/+/32299 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38181?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2908dc5d9f18610352b7ed7ec8ca814ae3736359 Gerrit-Change-Number: 38181 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 16 Sep 2024 14:41:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 2 weeks

1
0
0 0

[S] Change in libosmo-sccp[master]: vty: Add new "show cs7 instance <0-15> point-codes" command

by laforge

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32299?usp=email ) Change subject: vty: Add new "show cs7 instance <0-15> point-codes" command ...................................................................... Abandoned continued in https://gerrit.osmocom.org/c/libosmo-sigtran/+/38181 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I2908dc5d9f18610352b7ed7ec8ca814ae3736359 Gerrit-Change-Number: 32299 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: vty: Add new "show cs7 instance <0-15> point-codes" command

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38181?usp=email ) Change subject: vty: Add new "show cs7 instance <0-15> point-codes" command ...................................................................... vty: Add new "show cs7 instance <0-15> point-codes" command This is a command supported on Cisco ITP. Change-Id: I2908dc5d9f18610352b7ed7ec8ca814ae3736359 --- M src/osmo_ss7_vty.c 1 file changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/81/38181/1 diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index f1b0a1c..87b6335 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -311,6 +311,34 @@ return CMD_SUCCESS; } +DEFUN(show_cs7_pc, show_cs7_pc_cmd, + "show cs7 instance <0-15> point-codes", + SHOW_STR CS7_STR INST_STR INST_STR "Point Codes we are responding to\n") +{ + int id = atoi(argv[0]); + struct osmo_ss7_instance *inst; + + inst = osmo_ss7_instance_find(id); + if (!inst) { + vty_out(vty, "No SS7 instance %d found%s", id, VTY_NEWLINE); + return CMD_WARNING; + } + + vty_out(vty, "CS7 Point Code Type Status%s", VTY_NEWLINE); + vty_out(vty, "-------------- ---------- ---------------%s", VTY_NEWLINE); + if (osmo_ss7_pc_is_valid(inst->cfg.primary_pc)) { + vty_out(vty, "%s %s %s%s", osmo_ss7_pointcode_print(inst, inst->cfg.primary_pc), + "local", "active", VTY_NEWLINE); + } + if (osmo_ss7_pc_is_valid(inst->cfg.secondary_pc)) { + vty_out(vty, "%s %s %s%s", osmo_ss7_pointcode_print(inst, inst->cfg.secondary_pc), + "secondary", "active", VTY_NEWLINE); + } + + return CMD_SUCCESS; +} + + /* TODO: Links + Linksets */ /*********************************************************************** @@ -2980,6 +3008,7 @@ NO_STR "Disable quirk to work around interop issues\n", "\n", "\n", 0); + install_lib_element_ve(&show_cs7_pc_cmd); install_lib_element_ve(&show_cs7_user_cmd); install_lib_element_ve(&show_cs7_xua_cmd); install_lib_element_ve(&show_cs7_xua_trans_proto_cmd); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38181?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2908dc5d9f18610352b7ed7ec8ca814ae3736359 Gerrit-Change-Number: 38181 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: SS7: Support secondary point codes

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38180?usp=email ) Change subject: SS7: Support secondary point codes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: continuation from https://gerrit.osmocom.org/c/libosmo-sccp/+/32298 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3c4c0d89d2a0ea36aa5df0887225d99a16b810f0 Gerrit-Change-Number: 38180 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 16 Sep 2024 14:37:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 2 weeks

1
0
0 0

[S] Change in libosmo-sccp[master]: SS7: Support secondary point codes

by laforge

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32298?usp=email ) Change subject: SS7: Support secondary point codes ...................................................................... Abandoned continued at https://gerrit.osmocom.org/c/libosmo-sigtran/+/38180 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I3c4c0d89d2a0ea36aa5df0887225d99a16b810f0 Gerrit-Change-Number: 32298 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: SS7: Support secondary point codes

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38180?usp=email ) Change subject: SS7: Support secondary point codes ...................................................................... SS7: Support secondary point codes osmo_ss7 so far only supported a single local point code per cs7 instance: The primary point code. Let's add support for a secondary point code, just like it is the case in Cisco ITP. Change-Id: I3c4c0d89d2a0ea36aa5df0887225d99a16b810f0 --- M TODO-RELEASE M include/osmocom/sigtran/osmo_ss7.h M src/osmo_ss7.c M src/osmo_ss7_vty.c M tests/vty/ss7_asp_test.vty 5 files changed, 31 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/80/38180/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..935cda8 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-sigtran API change struct osmo_ss7_instance has new member 'secondary_pc' diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index 155e05a..049c7d8 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -96,12 +96,12 @@ char *name; char *description; uint32_t primary_pc; - /* secondary PCs */ /* capability PCs */ uint8_t network_indicator; struct osmo_ss7_pc_fmt pc_fmt; bool permit_dyn_rkm_alloc; struct llist_head sccp_address_book; + uint32_t secondary_pc; } cfg; }; diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 74b0f50..55d3d02 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -332,6 +332,7 @@ return NULL; inst->cfg.primary_pc = OSMO_SS7_PC_INVALID; + inst->cfg.secondary_pc = OSMO_SS7_PC_INVALID; inst->cfg.id = id; LOGSS7(inst, LOGL_INFO, "Creating SS7 Instance\n"); @@ -1134,7 +1135,9 @@ OSMO_ASSERT(ss7_initialized); if (osmo_ss7_pc_is_valid(inst->cfg.primary_pc) && pc == inst->cfg.primary_pc) return true; - /* FIXME: Secondary and Capability Point Codes */ + if (osmo_ss7_pc_is_valid(inst->cfg.secondary_pc) && pc == inst->cfg.secondary_pc) + return true; + /* FIXME: Capability Point Codes */ return false; } diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 9d58fb6..f1b0a1c 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -234,7 +234,23 @@ return CMD_SUCCESS; } -/* TODO: cs7 secondary-pc */ +DEFUN_ATTR(cs7_secondary_pc, cs7_secondary_pc_cmd, + "secondary-pc POINT_CODE", + "Configure the local Secondary Point Code\n" + "Point Code\n", + CMD_ATTR_IMMEDIATE) +{ + struct osmo_ss7_instance *inst = vty->index; + int pc = osmo_ss7_pointcode_parse(inst, argv[0]); + if (pc < 0 || !osmo_ss7_pc_is_valid((uint32_t)pc)) { + vty_out(vty, "Invalid point code (%s)%s", argv[0], VTY_NEWLINE); + return CMD_WARNING; + } + + inst->cfg.secondary_pc = pc; + return CMD_SUCCESS; +} + /* TODO: cs7 capability-pc */ DEFUN_ATTR(cs7_permit_dyn_rkm, cs7_permit_dyn_rkm_cmd, "xua rkm routing-key-allocation (static-only|dynamic-permitted)", @@ -2812,6 +2828,11 @@ osmo_ss7_pointcode_print(inst, inst->cfg.primary_pc), VTY_NEWLINE); + if (osmo_ss7_pc_is_valid(inst->cfg.secondary_pc)) { + vty_out(vty, " secondary-pc %s%s", + osmo_ss7_pointcode_print(inst, inst->cfg.secondary_pc), VTY_NEWLINE); + } + if (inst->cfg.permit_dyn_rkm_alloc) vty_out(vty, " xua rkm routing-key-allocation dynamic-permitted%s", VTY_NEWLINE); @@ -2972,6 +2993,7 @@ install_lib_element(L_CS7_NODE, &cfg_description_cmd); install_lib_element(L_CS7_NODE, &cs7_net_ind_cmd); install_lib_element(L_CS7_NODE, &cs7_point_code_cmd); + install_lib_element(L_CS7_NODE, &cs7_secondary_pc_cmd); install_lib_element(L_CS7_NODE, &cs7_pc_format_cmd); install_lib_element(L_CS7_NODE, &cs7_pc_format_def_cmd); install_lib_element(L_CS7_NODE, &cs7_pc_delimiter_cmd); diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty index 7168d20..b565557 100644 --- a/tests/vty/ss7_asp_test.vty +++ b/tests/vty/ss7_asp_test.vty @@ -104,6 +104,7 @@ description .TEXT network-indicator (international | national | reserved | spare) point-code POINT_CODE + secondary-pc POINT_CODE point-code format <1-24> [<1-23>] [<1-22>] point-code format default point-code delimiter (default|dash) @@ -123,6 +124,7 @@ description Save human-readable description of the object network-indicator Configure the Network Indicator point-code Configure the local Point Code + secondary-pc Configure the local Secondary Point Code xua SIGTRAN xxxUA related asp Configure Application Server Process no Negate a command or set its defaults -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3c4c0d89d2a0ea36aa5df0887225d99a16b810f0 Gerrit-Change-Number: 38180 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: coverity CID#216830

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38178?usp=email ) Change subject: coverity CID#216830 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: continuation of https://gerrit.osmocom.org/c/libosmo-sccp/+/37995 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38178?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e6283154268f97a66b2b3f2ec8e3e9631424434 Gerrit-Change-Number: 38178 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 16 Sep 2024 14:32:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: TC_ims_reregistration: Expect re-register using existing ip...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38179?usp=email ) Change subject: asterisk: TC_ims_reregistration: Expect re-register using existing ipsec ctx ...................................................................... asterisk: TC_ims_reregistration: Expect re-register using existing ipsec ctx Change-Id: I8d100dbba6cddfa5f31437c9cdc8c48f1bbd5701 --- M asterisk/Asterisk_Tests.ttcn M asterisk/IMS_ConnectionHandler.ttcn 2 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/38179/1 diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index 20e01e7..dccf9fa 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -706,11 +706,11 @@ f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.registrar_sip_record.addr))); as_IMS_register(); - /* Re-Register: This should optimally be a as_IMS_2nd_register() instead... */ timer Trereg; Trereg.start(int2float(g_pars.subscr.registrar_expires) - 5.0); + g_pars.subscr.registrar_expires := c_def_expires; alt { - [] as_IMS_register(); + [] as_IMS_2nd_register(); [] Trereg.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str(g_name & ": Timeout waiting for re-registration")); } @@ -730,8 +730,8 @@ f_AMI_IMS_register(pars); - /* Re-Register: if this was a 2nd REGISTER, then reauth shouldn't be needed... */ - as_AMI_IMS_register_Auth(pars, resync := false); + /* Wait for Asterisk to re-register and IMS_ConnHdlr to handle it... */ + f_sleep(int2float(pars.subscr.registrar_expires)); /* Trigger unregistration: */ f_AMI_IMS_unregister(pars); diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index 12f624c..39abc59 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -102,6 +102,7 @@ integer registrar_expires, SipUrl local_sip_url_ext, SipAddr local_sip_record, + WwwAuthenticate www_auth optional, Contact registered_contact optional, P_Associated_Uri p_associated_uri, IMS_CallPars cp optional @@ -241,6 +242,7 @@ ts_UserInfo(imsi)), local_sip_record := ts_SipAddr(ts_HostPort(domain), ts_UserInfo(imsi)), + www_auth := omit, registered_contact := omit, p_associated_uri := ts_P_Associated_Uri({}), cp := cp @@ -781,7 +783,6 @@ var CallidString sip_call_id; var template (value) From from_addr; var template (value) To to_addr; - var WwwAuthenticate wwwAuthenticate; var Security_server security_server; var template (value) Require require := ts_Require({"sec-agree"}); var template (value) Supported supported := ts_Supported({"sec-agree"}); @@ -835,7 +836,7 @@ } to_addr.toParams := f_sip_param_set(to_addr.toParams, "tag", f_sip_rand_tag()); - wwwAuthenticate := f_gen_WwwAuthenticate(); + g_pars.subscr.www_auth := f_gen_WwwAuthenticate(); security_server := f_gen_Security_server(); /* Tx 401 Unauthorized */ @@ -843,7 +844,7 @@ from_addr, to_addr, via, - wwwAuthenticate, + g_pars.subscr.www_auth, sip_seq_nr, "REGISTER", p_associated_uri := g_pars.subscr.p_associated_uri, @@ -857,7 +858,7 @@ /* Now we should receive a new non-protected REGISTER * with Authoritzation containing auts in base64: */ var template (present) Authorization authorization := - f_tr_Authorization_AKAv1MD5(wwwAuthenticate, + f_tr_Authorization_AKAv1MD5(g_pars.subscr.www_auth, g_pars.subscr.imsi & "@" & g_pars.realm, f_sip_SipUrl_to_str(g_pars.registrar_sip_req_uri)); exp_req := @@ -906,7 +907,7 @@ from_addr, to_addr, via, - wwwAuthenticate, + g_pars.subscr.www_auth, sip_seq_nr, "REGISTER", p_associated_uri := g_pars.subscr.p_associated_uri, @@ -918,7 +919,7 @@ } /* Now we should receive a new REGISTER over ipsec: */ - as_IMS_2nd_register(wwwAuthenticate, early_ret := early_ret); + as_IMS_2nd_register(early_ret := early_ret); } [fail_others] as_SIP_fail_resp(sip_expect_str); [fail_others] as_SIP_fail_req(sip_expect_str); @@ -926,12 +927,11 @@ } /* Peer is issuing 2nd register, accept it: */ -altstep as_IMS_2nd_register(WwwAuthenticate wwwAuthenticate, - IMS_register_early_return early_ret := IMS_REG_EARLY_RET_BEFORE_None, +altstep as_IMS_2nd_register(IMS_register_early_return early_ret := IMS_REG_EARLY_RET_BEFORE_None, boolean fail_others := true) runs on IMS_ConnHdlr { var template (present) Authorization authorization := - f_tr_Authorization_AKAv1MD5(wwwAuthenticate, + f_tr_Authorization_AKAv1MD5(g_pars.subscr.www_auth, g_pars.subscr.imsi & "@" & g_pars.realm, f_sip_SipUrl_to_str(g_pars.registrar_sip_req_uri)); var template (present) PDU_SIP_Request exp_req := -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38179?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d100dbba6cddfa5f31437c9cdc8c48f1bbd5701 Gerrit-Change-Number: 38179 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sccp[master]: coverity CID#216830

by laforge

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37995?usp=email ) Change subject: coverity CID#216830 ...................................................................... Abandoned continued in https://gerrit.osmocom.org/c/libosmo-sigtran/+/38178 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I3e6283154268f97a66b2b3f2ec8e3e9631424434 Gerrit-Change-Number: 37995 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: coverity CID#216830

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38178?usp=email ) Change subject: coverity CID#216830 ...................................................................... coverity CID#216830 sanity-check par->len received on the wire. Change-Id: I3e6283154268f97a66b2b3f2ec8e3e9631424434 --- M src/sua.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/78/38178/1 diff --git a/src/sua.c b/src/sua.c index 9e281e0..3d9d7ec 100644 --- a/src/sua.c +++ b/src/sua.c @@ -436,6 +436,10 @@ par = (struct xua_parameter_hdr *) &param->dat[pos]; par_tag = ntohs(par->tag); par_len = ntohs(par->len); + + /* sanity: check par->len received on the wire, make sure the subtraction does not wrap past zero. */ + if (par_len < sizeof(*par)) + goto subpar_fail; par_datalen = par_len - sizeof(*par); LOGP(DLSUA, LOGL_DEBUG, "SUA IEI 0x%04x pos %hu/%hu: subpart tag 0x%04x, len %hu\n", -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38178?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e6283154268f97a66b2b3f2ec8e3e9631424434 Gerrit-Change-Number: 38178 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024