September 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-gsm-tester[master]: contrib/jenkins-*: libosmo-sccp -> libosmo-sigtran

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/38176?usp=email ) Change subject: contrib/jenkins-*: libosmo-sccp -> libosmo-sigtran ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/38176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I9793c2bb7658d11318dd33c7bd6ad75a8e79bcbf Gerrit-Change-Number: 38176 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 12:00:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-gsm-tester[master]: contrib/jenkins-*: libosmo-sccp -> libosmo-sigtran

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/38176?usp=email ) Change subject: contrib/jenkins-*: libosmo-sccp -> libosmo-sigtran ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/38176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I9793c2bb7658d11318dd33c7bd6ad75a8e79bcbf Gerrit-Change-Number: 38176 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 12:00:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[M] Change in pysim[master]: pySim-prog: rework documentation

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38166?usp=email ) Change subject: pySim-prog: rework documentation ...................................................................... Patch Set 2: (1 comment) File docs/legacy.rst: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18592): https://gerrit.osmocom.org/c/pysim/+/38166/comment/921ddb6a_33092ae4?usp=em… : PS2, Line 27: This is the most common way to use ``pySim-prog``. The user will specify all relevent parameters directly via the 'relevent' may be misspelled - perhaps 'relevant'? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38166?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1d1a65154cea7fa77428b412fcf8c7b4cba629b1 Gerrit-Change-Number: 38166 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 16 Sep 2024 11:56:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 2 weeks

1
0
0 0

[M] Change in pysim[master]: pySim-prog: rework documentation

by dexter

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38166?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-prog: rework documentation ...................................................................... pySim-prog: rework documentation The documentation for the classic pySim-prog application is a bit sparse. Let's rework it so that it includes the most important information that is required to operate pySim-prog. Let's also add a section about how the batch mode and CSV files are used. Related: SYS#4120 Change-Id: I1d1a65154cea7fa77428b412fcf8c7b4cba629b1 --- M docs/legacy.rst 1 file changed, 169 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/66/38166/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38166?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1d1a65154cea7fa77428b412fcf8c7b4cba629b1 Gerrit-Change-Number: 38166 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[XS] Change in pysim[master]: pySim-prog: add FIXME note to tell that writing hlr.db files is broken

by dexter

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38162?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: pySim-prog: add FIXME note to tell that writing hlr.db files is broken ...................................................................... pySim-prog: add FIXME note to tell that writing hlr.db files is broken The writing to osmo-hlr SQLITE files is broken since the SQLITE format has evolved over time. Let's add a FIXME note to tell that this needs fixing. Related: SYS#4120 Change-Id: I2b23f8bb9f3c2adeb48b010834057f5b4fb1e626 --- M pySim-prog.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/62/38162/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38162?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2b23f8bb9f3c2adeb48b010834057f5b4fb1e626 Gerrit-Change-Number: 38162 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim-prog: generate Ki and OPc value using _digits() function

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38164?usp=email ) Change subject: pySim-prog: generate Ki and OPc value using _digits() function ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > the question is whether this wasn't intended as a security mechansim (keys should always be random)? When we use the the _digits function, then we have the advantage that we can identify the entire dataset via the num parameter. Otherweise the dataset basically lacks the key material. Each programming cycle will generate new keys. However, I also see that there may be security concerns. I can not say how easy it is to restore the secret random seed from let's say a few IMSIs, which were also generated with the same seed. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38164?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib53d9d04a2073dafcca7cd21b0324bee5a23c540 Gerrit-Change-Number: 38164 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 16 Sep 2024 11:55:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[M] Change in pysim[master]: pySim-prog: rework documentation

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38166?usp=email ) Change subject: pySim-prog: rework documentation ...................................................................... Patch Set 2: (3 comments) File docs/legacy.rst: https://gerrit.osmocom.org/c/pysim/+/38166/comment/690b09de_c821043e?usp=em… : PS1, Line 46: KI, OPc > depends on whether we merge the patch you just added to derive those from the 'secret'... Let's keep this one open until we made a decision. https://gerrit.osmocom.org/c/pysim/+/38166/comment/2c40e4be_2e7f0c14?usp=em… : PS1, Line 62: * supersim : * magicsim : * fakemagicsim : * grcardsim : * sysmosim-gr1 : * sysmoSIM-GR2 : * sysmoUSIM-SJS1 : * Fairwaves-SIM : * OpenCells-SIM : * Wavemobile-SIM : * sysmoISIM-SJA2 : * sysmoISIM-SJA5 : * gialersim > I guess those should be alphabetically sorted? Done https://gerrit.osmocom.org/c/pysim/+/38166/comment/f4682013_0dc218cf?usp=em… : PS1, Line 110: , > extra comma should probably be removed Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38166?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1d1a65154cea7fa77428b412fcf8c7b4cba629b1 Gerrit-Change-Number: 38166 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 16 Sep 2024 11:55:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-gsm-tester[master]: contrib/jenkins-*: libosmo-sccp -> libosmo-sigtran

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/38176?usp=email ) Change subject: contrib/jenkins-*: libosmo-sccp -> libosmo-sigtran ...................................................................... contrib/jenkins-*: libosmo-sccp -> libosmo-sigtran Change-Id: I9793c2bb7658d11318dd33c7bd6ad75a8e79bcbf --- M contrib/jenkins-build-osmo-bsc.sh M contrib/jenkins-build-osmo-hnbgw.sh M contrib/jenkins-build-osmo-msc.sh M contrib/jenkins-build-osmo-nitb.sh M contrib/jenkins-build-osmo-sgsn.sh M contrib/jenkins-build-osmo-stp.sh 6 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/76/38176/1 diff --git a/contrib/jenkins-build-osmo-bsc.sh b/contrib/jenkins-build-osmo-bsc.sh index 65c6158..8a1fd39 100755 --- a/contrib/jenkins-build-osmo-bsc.sh +++ b/contrib/jenkins-build-osmo-bsc.sh @@ -7,7 +7,7 @@ build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen --disable-uring build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi build_repo libosmo-netif ${SANITIZE_FLAGS} --disable-doxygen -build_repo libosmo-sccp ${SANITIZE_FLAGS} +build_repo libosmo-sigtran ${SANITIZE_FLAGS} build_repo osmo-mgw ${SANITIZE_FLAGS} build_repo osmo-bsc ${SANITIZE_FLAGS} diff --git a/contrib/jenkins-build-osmo-hnbgw.sh b/contrib/jenkins-build-osmo-hnbgw.sh index 7ca20b4..51ea833 100755 --- a/contrib/jenkins-build-osmo-hnbgw.sh +++ b/contrib/jenkins-build-osmo-hnbgw.sh @@ -7,7 +7,7 @@ build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen --disable-uring build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi build_repo libosmo-netif ${SANITIZE_FLAGS} --disable-doxygen -build_repo libosmo-sccp ${SANITIZE_FLAGS} +build_repo libosmo-sigtran ${SANITIZE_FLAGS} build_repo libasn1c ${SANITIZE_FLAGS} build_repo osmo-iuh ${SANITIZE_FLAGS} build_repo osmo-mgw ${SANITIZE_FLAGS} diff --git a/contrib/jenkins-build-osmo-msc.sh b/contrib/jenkins-build-osmo-msc.sh index bfe148e..2b72b6a 100755 --- a/contrib/jenkins-build-osmo-msc.sh +++ b/contrib/jenkins-build-osmo-msc.sh @@ -8,7 +8,7 @@ build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi build_repo libosmo-netif ${SANITIZE_FLAGS} --disable-doxygen build_repo libsmpp34 ${SANITIZE_FLAGS} -build_repo libosmo-sccp ${SANITIZE_FLAGS} +build_repo libosmo-sigtran ${SANITIZE_FLAGS} build_repo osmo-mgw ${SANITIZE_FLAGS} build_repo osmo-hlr ${SANITIZE_FLAGS} build_repo libasn1c ${SANITIZE_FLAGS} diff --git a/contrib/jenkins-build-osmo-nitb.sh b/contrib/jenkins-build-osmo-nitb.sh index 7eb446d..061e31c 100755 --- a/contrib/jenkins-build-osmo-nitb.sh +++ b/contrib/jenkins-build-osmo-nitb.sh @@ -9,7 +9,7 @@ build_repo libosmo-netif --disable-doxygen build_repo openggsn build_repo libsmpp34 -build_repo libosmo-sccp +build_repo libosmo-sigtran build_repo_dir openbsc openbsc --enable-smpp --enable-osmo-bsc --enable-nat create_bin_tgz "osmo-nitb osmo-bsc_mgcp" diff --git a/contrib/jenkins-build-osmo-sgsn.sh b/contrib/jenkins-build-osmo-sgsn.sh index d624f45..0e21747 100755 --- a/contrib/jenkins-build-osmo-sgsn.sh +++ b/contrib/jenkins-build-osmo-sgsn.sh @@ -7,7 +7,7 @@ build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen --disable-uring build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi build_repo libosmo-netif ${SANITIZE_FLAGS} --disable-doxygen -build_repo libosmo-sccp ${SANITIZE_FLAGS} +build_repo libosmo-sigtran ${SANITIZE_FLAGS} build_repo osmo-ggsn ${SANITIZE_FLAGS} build_repo osmo-hlr ${SANITIZE_FLAGS} build_repo libasn1c ${SANITIZE_FLAGS} diff --git a/contrib/jenkins-build-osmo-stp.sh b/contrib/jenkins-build-osmo-stp.sh index 5fd4abb..37d214f 100755 --- a/contrib/jenkins-build-osmo-stp.sh +++ b/contrib/jenkins-build-osmo-stp.sh @@ -7,6 +7,6 @@ build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen --disable-uring build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi build_repo libosmo-netif ${SANITIZE_FLAGS} --disable-doxygen -build_repo libosmo-sccp ${SANITIZE_FLAGS} +build_repo libosmo-sigtran ${SANITIZE_FLAGS} create_bin_tgz osmo-stp -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/38176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I9793c2bb7658d11318dd33c7bd6ad75a8e79bcbf Gerrit-Change-Number: 38176 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[M] Change in pysim[master]: pySim.profile: Further refactor card <-> profile matching

by laforge

Attention is currently required from: dexter, fixeria. Hello dexter, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38175?usp=email to look at the new patch set (#2). Change subject: pySim.profile: Further refactor card <-> profile matching ...................................................................... pySim.profile: Further refactor card <-> profile matching The new architecture avoids sim/ruim/uicc specific methods in pySim.profile and instead moves the profile-specific code into the profile; it also solves everything within the class hierarchy, no need for global methods. Change-Id: I3b6c44d2f5cce2513c3ec8a3ce939a242f3e4901 --- M pySim/cdma_ruim.py M pySim/profile.py M pySim/ts_102_221.py M pySim/ts_51_011.py 4 files changed, 51 insertions(+), 56 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/75/38175/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3b6c44d2f5cce2513c3ec8a3ce939a242f3e4901 Gerrit-Change-Number: 38175 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: docs: Bring osmo-smdpp documentation up to date with code

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38150?usp=email ) Change subject: docs: Bring osmo-smdpp documentation up to date with code ...................................................................... Patch Set 2: (1 comment) File docs/osmo-smdpp.rst: https://gerrit.osmocom.org/c/pysim/+/38150/comment/6a83a2dc_454446b9?usp=em… : PS1, Line 29: * doesn't perform any personalization, so the IMSI/ICCID etc. are always identical (the ones that are store in > are stored Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibaab1fadd5d35ecdb356bed1820074b1b0a1752e Gerrit-Change-Number: 38150 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 11:28:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024