September 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: vty: Add new "show cs7 instance <0-15> point-codes" command

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38181?usp=email ) Change subject: vty: Add new "show cs7 instance <0-15> point-codes" command ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Looks like the VTY transcript files need to be updated. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38181?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2908dc5d9f18610352b7ed7ec8ca814ae3736359 Gerrit-Change-Number: 38181 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 16 Sep 2024 16:26:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim-shell: Detect different eUICC types and print during start-up

by laforge

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38049?usp=email ) Change subject: pySim-shell: Detect different eUICC types and print during start-up ...................................................................... Patch Set 9: (4 comments) File pySim/euicc.py: https://gerrit.osmocom.org/c/pysim/+/38049/comment/74de49bf_93ad6da3?usp=em… : PS6, Line 580: -> bool: > Not addressed. Done https://gerrit.osmocom.org/c/pysim/+/38049/comment/59c21866_99cbc2b1?usp=em… : PS6, Line 598: -> bool: > Not addressed. Done https://gerrit.osmocom.org/c/pysim/+/38049/comment/28c1b08e_af8da91d?usp=em… : PS6, Line 616: -> bool: > Not addressed. Done File pySim/euicc.py: https://gerrit.osmocom.org/c/pysim/+/38049/comment/ba0aa4d4_cee8219f?usp=em… : PS8, Line 572: gc = > unused variable? Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38049?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I54ea4ce663693f3951040dcc8a16bf532bf99c02 Gerrit-Change-Number: 38049 Gerrit-PatchSet: 9 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 16:25:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: docs: remove traces of modules migrated to pyosmocom

by laforge

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, dexter, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38149?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: docs: remove traces of modules migrated to pyosmocom ...................................................................... docs: remove traces of modules migrated to pyosmocom Change-Id: I2ebb17f9781c90a81e9e554bddd7a851ef51c82a --- M docs/library.rst 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/49/38149/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2ebb17f9781c90a81e9e554bddd7a851ef51c82a Gerrit-Change-Number: 38149 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim-shell: Detect different eUICC types and print during start-up

by laforge

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, dexter, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38049?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pySim-shell: Detect different eUICC types and print during start-up ...................................................................... pySim-shell: Detect different eUICC types and print during start-up Change-Id: I54ea4ce663693f3951040dcc8a16bf532bf99c02 --- M pySim/cdma_ruim.py M pySim/euicc.py M pySim/ts_102_221.py M pySim/ts_51_011.py 4 files changed, 45 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/49/38049/9 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38049?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I54ea4ce663693f3951040dcc8a16bf532bf99c02 Gerrit-Change-Number: 38049 Gerrit-PatchSet: 9 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: SS7: Support secondary point codes

by fixeria

Attention is currently required from: laforge, neels, pespin. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38180?usp=email ) Change subject: SS7: Support secondary point codes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3c4c0d89d2a0ea36aa5df0887225d99a16b810f0 Gerrit-Change-Number: 38180 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 16:24:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: TC_ims_reregistration: Expect re-register using existing ip...

by laforge

Attention is currently required from: jolly, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38179?usp=email ) Change subject: asterisk: TC_ims_reregistration: Expect re-register using existing ipsec ctx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38179?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d100dbba6cddfa5f31437c9cdc8c48f1bbd5701 Gerrit-Change-Number: 38179 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Sep 2024 16:21:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: coverity CID#216830

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38178?usp=email ) Change subject: coverity CID#216830 ...................................................................... coverity CID#216830 sanity-check par->len received on the wire. Change-Id: I3e6283154268f97a66b2b3f2ec8e3e9631424434 --- M src/sua.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/sua.c b/src/sua.c index 9e281e0..3d9d7ec 100644 --- a/src/sua.c +++ b/src/sua.c @@ -436,6 +436,10 @@ par = (struct xua_parameter_hdr *) &param->dat[pos]; par_tag = ntohs(par->tag); par_len = ntohs(par->len); + + /* sanity: check par->len received on the wire, make sure the subtraction does not wrap past zero. */ + if (par_len < sizeof(*par)) + goto subpar_fail; par_datalen = par_len - sizeof(*par); LOGP(DLSUA, LOGL_DEBUG, "SUA IEI 0x%04x pos %hu/%hu: subpart tag 0x%04x, len %hu\n", -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38178?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e6283154268f97a66b2b3f2ec8e3e9631424434 Gerrit-Change-Number: 38178 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: coverity CID#216830

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38178?usp=email ) Change subject: coverity CID#216830 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38178?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e6283154268f97a66b2b3f2ec8e3e9631424434 Gerrit-Change-Number: 38178 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 16 Sep 2024 14:41:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: Reject M3UA with "M3UA Network Appearance"

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38177?usp=email ) Change subject: Reject M3UA with "M3UA Network Appearance" ...................................................................... Reject M3UA with "M3UA Network Appearance" The information element "Network Appearance" is not supported. In case it is included in a received message, an error is sent to the remote peer to indicate this. Additionally a message is sent on the log output. Related: OS#6240 Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f --- M src/m3ua.c M src/xua_rkm.c 2 files changed, 61 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/m3ua.c b/src/m3ua.c index fcbc759..af81da9 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -350,6 +350,11 @@ { struct xua_msg *xua = xua_msg_alloc(); + if (!xua) { + LOGP(DLM3UA, LOGL_NOTICE, "Failed to allocate M3UA MGMT error message.\n"); + return NULL; + } + xua->hdr = XUA_HDR(M3UA_MSGC_MGMT, M3UA_MGMT_ERR); xua->hdr.version = M3UA_VERSION; xua_msg_add_u32(xua, M3UA_IEI_ERR_CODE, err_code); @@ -359,15 +364,31 @@ static struct xua_msg *m3ua_gen_error_msg(uint32_t err_code, struct msgb *msg) { - struct xua_msg *xua = m3ua_gen_error(err_code); - unsigned int len_max_40 = msgb_length(msg); + struct xua_msg *err = m3ua_gen_error(err_code); + struct xua_msg *xua; + struct xua_msg_part *na_ie; + unsigned int len_max_40; - if (len_max_40 > 40) - len_max_40 = 40; + if (!err) + return NULL; - xua_msg_add_data(xua, M3UA_IEI_DIAG_INFO, len_max_40, msgb_data(msg)); + switch (err_code) { + case M3UA_ERR_INVAL_NET_APPEAR: + /* Include NA IE in Error message. */ + xua = xua_from_msg(M3UA_VERSION, msgb_length(msg), msgb_data(msg)); + na_ie = xua_msg_find_tag(xua, M3UA_IEI_NET_APPEAR); + xua_msg_add_data(err, M3UA_IEI_NET_APPEAR, na_ie->len, na_ie->dat); + xua_msg_free(xua); + break; + default: + len_max_40 = msgb_length(msg); + if (len_max_40 > 40) + len_max_40 = 40; - return xua; + xua_msg_add_data(err, M3UA_IEI_DIAG_INFO, len_max_40, msgb_data(msg)); + } + + return err; } /*********************************************************************** @@ -534,6 +555,7 @@ static int m3ua_rx_xfer(struct osmo_ss7_asp *asp, struct xua_msg *xua) { + struct xua_msg_part *na_ie = xua_msg_find_tag(xua, M3UA_IEI_NET_APPEAR); struct xua_msg_part *rctx_ie = xua_msg_find_tag(xua, M3UA_IEI_ROUTE_CTX); struct m3ua_data_hdr *dh; struct osmo_ss7_as *as; @@ -549,6 +571,18 @@ return M3UA_ERR_UNSUPP_MSG_TYPE; } + /* Reject unsupported Network Appearance IE. */ + if (na_ie) { + uint32_t na = xua_msg_part_get_u32(na_ie); + + LOGPASP(asp, DLM3UA, LOGL_NOTICE, + "Unsupported 'Network Appearance' IE '0x%08x' in message type '%s', sending 'Error'.\n", + na, get_value_string(m3ua_xfer_msgt_names, xua->hdr.msg_type)); + if (na_ie->len != 4) + return M3UA_ERR_PARAM_FIELD_ERR; + return M3UA_ERR_INVAL_NET_APPEAR; + } + rc = xua_find_as_for_asp(&as, asp, rctx_ie); if (rc) return rc; @@ -978,6 +1012,8 @@ static int m3ua_rx_snm(struct osmo_ss7_asp *asp, struct xua_msg *xua) { + struct xua_msg_part *na_ie = xua_msg_find_tag(xua, M3UA_IEI_NET_APPEAR); + /* SNM only permitted in ACTIVE state */ if (asp->fi->state != XUA_ASP_S_ACTIVE) { if (asp->fi->state == XUA_ASP_S_INACTIVE && @@ -991,6 +1027,18 @@ } } + /* Reject unsupported Network Appearance IE. */ + if (na_ie) { + uint32_t na = xua_msg_part_get_u32(na_ie); + + LOGPASP(asp, DLM3UA, LOGL_NOTICE, + "Unsupported 'Network Appearance' IE '0x%08x' in message type '%s', sending 'Error'.\n", + na, get_value_string(m3ua_xfer_msgt_names, xua->hdr.msg_type)); + if (na_ie->len != 4) + return M3UA_ERR_PARAM_FIELD_ERR; + return M3UA_ERR_INVAL_NET_APPEAR; + } + switch (asp->cfg.role) { case OSMO_SS7_ASP_ROLE_SG: return m3ua_rx_snm_sg(asp, xua); diff --git a/src/xua_rkm.c b/src/xua_rkm.c index 6abd17d..914cb01 100644 --- a/src/xua_rkm.c +++ b/src/xua_rkm.c @@ -176,11 +176,15 @@ /* We don't support routing keys with the following criteria, so * we have to reject those */ - /* TODO: network appearance (optional) */ + /* Network Appearance (optional) */ + if (xua_msg_find_tag(inner, M3UA_IEI_NET_APPEAR)) { + LOGPASP(asp, DLSS7, LOGL_NOTICE, "RKM: Unsupported 'Network Appearance' IE.\n"); + msgb_append_reg_res(resp, rk_id, M3UA_RKM_REG_ERR_INVAL_NET_APPEAR, 0); + return -1; + } /* TODO: service indicators (optional) */ /* TODO: originating point code list (optional) */ - if (xua_msg_find_tag(inner, M3UA_IEI_NET_APPEAR) || - xua_msg_find_tag(inner, M3UA_IEI_SVC_IND) || + if (xua_msg_find_tag(inner, M3UA_IEI_SVC_IND) || xua_msg_find_tag(inner, M3UA_IEI_ORIG_PC)) { LOGPASP(asp, DLSS7, LOGL_NOTICE, "RKM: Unsupported Routing Key\n"); msgb_append_reg_res(resp, rk_id, M3UA_RKM_REG_ERR_UNSUPP_RK_PARAM, 0); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38177?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f Gerrit-Change-Number: 38177 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu>

9 months, 2 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: Reject M3UA with "M3UA Network Appearance"

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38177?usp=email ) Change subject: Reject M3UA with "M3UA Network Appearance" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38177?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f Gerrit-Change-Number: 38177 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 16 Sep 2024 14:41:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024