September 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: testenv: support obtaining talloc reports

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38065?usp=email ) Change subject: testenv: support obtaining talloc reports ...................................................................... testenv: support obtaining talloc reports Allow setting vty_port= and vty_host= (default: 127.0.0.1) for SUT components in testenv.cfg. Pass the values as OSMO_SUT_PORT and OSMO_SUT_HOST to the testsuite, so ttcn3-tcpdump-stop.sh generates talloc reports after running test cases. The next patch will add vty_port/vty_host to existing testenv.cfg files. I have considered enabling the talloc report only conditionally (e.g. with a --talloc-report parameter). But previous behavior in docker-playground was also that we created them unconditionally where OSMO_SUT_PORT/HOST was set, and they are generated almost instantly so it did not seem necessary to make this conditionally. Related: OS#6552 Change-Id: I50a7035f072668ca2ab65de1bc1f194da8b18610 --- M _testenv/README.md M _testenv/testenv/testenv_cfg.py M _testenv/testenv/testsuite.py 3 files changed, 40 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/_testenv/README.md b/_testenv/README.md index 4886786..8562063 100644 --- a/_testenv/README.md +++ b/_testenv/README.md @@ -37,6 +37,7 @@ make=osmo-mgw package=osmo-mgw copy=osmo-mgw.cfg +vty_port=4243 ``` ### Keys @@ -90,6 +91,13 @@ below for `PATH`. A `TESTENV_CLEAN_REASON` env var is set to `prepare`, `crashed` or `finished` depending on when the script runs. +* `vty_port`: optionally set the VTY port for the SUT component to obtain a + talloc report after each test case has been executed. If this is not set, no + talloc reports will be obtained. + +* `vty_host`: optionally set the VTY host for the SUT component to be used when + obtaining a talloc report. If this is not set, `127.0.0.1` is used. + ### PATH Executables mentioned in `program=`, `prepare=`, `setup=` and `clean=` run diff --git a/_testenv/testenv/testenv_cfg.py b/_testenv/testenv/testenv_cfg.py index 64f2423..9642ae8 100644 --- a/_testenv/testenv/testenv_cfg.py +++ b/_testenv/testenv/testenv_cfg.py @@ -49,6 +49,27 @@ del cfg[section][key] +def get_vty_host_port(cfg, path=None): + host = "127.0.0.1" + port = None + + for section in cfg: + if "vty_port" in cfg[section]: + if port: + logging.error(f"Error in {path}, section {section}:") + logging.error(" Found vty_port in multiple sections. This is not supported.") + sys.exit(1) + port = cfg[section]["vty_port"] + if "vty_host" in cfg[section]: + if not port: + logging.error(f"Error in {path}, section {section}:") + logging.error(" Found vty_host in section without vty_port.") + sys.exit(1) + host = cfg[section]["vty_host"] + + return host, port + + def verify(cfg, path): keys_valid_testsuite = [ "clean", @@ -64,6 +85,8 @@ "prepare", "program", "setup", + "vty_host", + "vty_port", ] keys_invalid = { "configs": "config", @@ -108,6 +131,8 @@ logging.error("If this is on purpose, set make=no.") exit_error_readme() + get_vty_host_port(cfg, path) + def raise_error_config_arg(glob_result): valid = [] diff --git a/_testenv/testenv/testsuite.py b/_testenv/testenv/testsuite.py index a46d5a9..d14d36f 100644 --- a/_testenv/testenv/testsuite.py +++ b/_testenv/testenv/testsuite.py @@ -165,6 +165,13 @@ env = { "TTCN3_PCAP_PATH": os.path.join(testenv.testdir.testdir, "testsuite"), } + + # Let ttcn3-tcpdump-stop.sh retrieve talloc reports + host, port = testenv.testenv_cfg.get_vty_host_port(cfg) + if port: + env["OSMO_SUT_HOST"] = host + env["OSMO_SUT_PORT"] = port + env = testenv.cmd.generate_env(env, testenv.args.podman) cmd = [start_testsuite, suite, section_data["config"]] -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38065?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I50a7035f072668ca2ab65de1bc1f194da8b18610 Gerrit-Change-Number: 38065 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: Convert bts->depends_on from bitmask to llist

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38050?usp=email ) Change subject: Convert bts->depends_on from bitmask to llist ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I59e37d6baa020aeafdffc2c3538e988effd37620 Gerrit-Change-Number: 38050 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 12:34:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: */testenv.cfg: add vty_port, vty_host

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38066?usp=email ) Change subject: */testenv.cfg: add vty_port, vty_host ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5c0305c5d2ac6ac79dcf01bed8fb9d5beeeb99a6 Gerrit-Change-Number: 38066 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 12:32:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: support obtaining talloc reports

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38065?usp=email ) Change subject: testenv: support obtaining talloc reports ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38065?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I50a7035f072668ca2ab65de1bc1f194da8b18610 Gerrit-Change-Number: 38065 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 12:32:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: support obtaining talloc reports

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38065?usp=email ) Change subject: testenv: support obtaining talloc reports ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38065?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I50a7035f072668ca2ab65de1bc1f194da8b18610 Gerrit-Change-Number: 38065 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 12:27:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: */testenv.cfg: add vty_port, vty_host

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38066?usp=email ) Change subject: */testenv.cfg: add vty_port, vty_host ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5c0305c5d2ac6ac79dcf01bed8fb9d5beeeb99a6 Gerrit-Change-Number: 38066 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 12:27:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: */testenv.cfg: add vty_port, vty_host

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38066?usp=email ) Change subject: */testenv.cfg: add vty_port, vty_host ...................................................................... */testenv.cfg: add vty_port, vty_host Add these variables, so a talloc report can be obtained after running test cases. Closes: OS#6552 Change-Id: I5c0305c5d2ac6ac79dcf01bed8fb9d5beeeb99a6 --- M cbc/testenv.cfg M hlr/testenv.cfg M hnodeb/testenv.cfg M mgw/testenv.cfg M sgsn/testenv_generic.cfg M sgsn/testenv_sns.cfg M sip/testenv.cfg M smlc/testenv.cfg M upf/testenv.cfg 9 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/38066/1 diff --git a/cbc/testenv.cfg b/cbc/testenv.cfg index 1cae33c..b16babe 100644 --- a/cbc/testenv.cfg +++ b/cbc/testenv.cfg @@ -7,3 +7,5 @@ make=osmo-cbc package=osmo-cbc copy=osmo-cbc.cfg +vty_port=4264 +vty_host=127.0.0.20 diff --git a/hlr/testenv.cfg b/hlr/testenv.cfg index 0fe2f86..11d0309 100644 --- a/hlr/testenv.cfg +++ b/hlr/testenv.cfg @@ -7,3 +7,4 @@ make=osmo-hlr package=osmo-hlr copy=osmo-hlr.cfg +vty_port=4258 diff --git a/hnodeb/testenv.cfg b/hnodeb/testenv.cfg index 9505146..b2f29df 100644 --- a/hnodeb/testenv.cfg +++ b/hnodeb/testenv.cfg @@ -7,3 +7,5 @@ make=osmo-hnodeb package=osmo-hnodeb copy=osmo-hnodeb.cfg +vty_port=4273 +vty_host=127.0.0.20 diff --git a/mgw/testenv.cfg b/mgw/testenv.cfg index c69c422..7891477 100644 --- a/mgw/testenv.cfg +++ b/mgw/testenv.cfg @@ -7,3 +7,4 @@ make=osmo-mgw package=osmo-mgw copy=osmo-mgw.cfg +vty_port=4243 diff --git a/sgsn/testenv_generic.cfg b/sgsn/testenv_generic.cfg index 89181c6..d439c43 100644 --- a/sgsn/testenv_generic.cfg +++ b/sgsn/testenv_generic.cfg @@ -13,3 +13,5 @@ make=osmo-sgsn package=osmo-sgsn copy=osmo-sgsn.cfg +vty_port=4245 +vty_host=127.0.0.10 diff --git a/sgsn/testenv_sns.cfg b/sgsn/testenv_sns.cfg index e60e45e..7feb5d3 100644 --- a/sgsn/testenv_sns.cfg +++ b/sgsn/testenv_sns.cfg @@ -13,3 +13,5 @@ make=osmo-sgsn package=osmo-sgsn copy=osmo-sgsn.sns.cfg +vty_port=4245 +vty_host=127.0.0.10 diff --git a/sip/testenv.cfg b/sip/testenv.cfg index fc3a83e..59d628e 100644 --- a/sip/testenv.cfg +++ b/sip/testenv.cfg @@ -7,3 +7,4 @@ make=osmo-sip-connector package=osmo-sip-connector copy=osmo-sip-connector.cfg +vty_port=4256 diff --git a/smlc/testenv.cfg b/smlc/testenv.cfg index 127e4d7..a52cb12 100644 --- a/smlc/testenv.cfg +++ b/smlc/testenv.cfg @@ -13,3 +13,4 @@ make=osmo-smlc package=osmo-smlc copy=osmo-smlc.cfg +vty_port=4271 diff --git a/upf/testenv.cfg b/upf/testenv.cfg index f5ba0f0..7152e71 100644 --- a/upf/testenv.cfg +++ b/upf/testenv.cfg @@ -7,3 +7,4 @@ make=osmo-upf package=osmo-upf copy=osmo-upf.cfg +vty_port=4275 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5c0305c5d2ac6ac79dcf01bed8fb9d5beeeb99a6 Gerrit-Change-Number: 38066 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: support obtaining talloc reports

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38065?usp=email ) Change subject: testenv: support obtaining talloc reports ...................................................................... testenv: support obtaining talloc reports Allow setting vty_port= and vty_host= (default: 127.0.0.1) for SUT components in testenv.cfg. Pass the values as OSMO_SUT_PORT and OSMO_SUT_HOST to the testsuite, so ttcn3-tcpdump-stop.sh generates talloc reports after running test cases. The next patch will add vty_port/vty_host to existing testenv.cfg files. I have considered enabling the talloc report only conditionally (e.g. with a --talloc-report parameter). But previous behavior in docker-playground was also that we created them unconditionally where OSMO_SUT_PORT/HOST was set, and they are generated almost instantly so it did not seem necessary to make this conditionally. Related: OS#6552 Change-Id: I50a7035f072668ca2ab65de1bc1f194da8b18610 --- M _testenv/README.md M _testenv/testenv/testenv_cfg.py M _testenv/testenv/testsuite.py 3 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/38065/1 diff --git a/_testenv/README.md b/_testenv/README.md index 4886786..8562063 100644 --- a/_testenv/README.md +++ b/_testenv/README.md @@ -37,6 +37,7 @@ make=osmo-mgw package=osmo-mgw copy=osmo-mgw.cfg +vty_port=4243 ``` ### Keys @@ -90,6 +91,13 @@ below for `PATH`. A `TESTENV_CLEAN_REASON` env var is set to `prepare`, `crashed` or `finished` depending on when the script runs. +* `vty_port`: optionally set the VTY port for the SUT component to obtain a + talloc report after each test case has been executed. If this is not set, no + talloc reports will be obtained. + +* `vty_host`: optionally set the VTY host for the SUT component to be used when + obtaining a talloc report. If this is not set, `127.0.0.1` is used. + ### PATH Executables mentioned in `program=`, `prepare=`, `setup=` and `clean=` run diff --git a/_testenv/testenv/testenv_cfg.py b/_testenv/testenv/testenv_cfg.py index 64f2423..9642ae8 100644 --- a/_testenv/testenv/testenv_cfg.py +++ b/_testenv/testenv/testenv_cfg.py @@ -49,6 +49,27 @@ del cfg[section][key] +def get_vty_host_port(cfg, path=None): + host = "127.0.0.1" + port = None + + for section in cfg: + if "vty_port" in cfg[section]: + if port: + logging.error(f"Error in {path}, section {section}:") + logging.error(" Found vty_port in multiple sections. This is not supported.") + sys.exit(1) + port = cfg[section]["vty_port"] + if "vty_host" in cfg[section]: + if not port: + logging.error(f"Error in {path}, section {section}:") + logging.error(" Found vty_host in section without vty_port.") + sys.exit(1) + host = cfg[section]["vty_host"] + + return host, port + + def verify(cfg, path): keys_valid_testsuite = [ "clean", @@ -64,6 +85,8 @@ "prepare", "program", "setup", + "vty_host", + "vty_port", ] keys_invalid = { "configs": "config", @@ -108,6 +131,8 @@ logging.error("If this is on purpose, set make=no.") exit_error_readme() + get_vty_host_port(cfg, path) + def raise_error_config_arg(glob_result): valid = [] diff --git a/_testenv/testenv/testsuite.py b/_testenv/testenv/testsuite.py index a46d5a9..d14d36f 100644 --- a/_testenv/testenv/testsuite.py +++ b/_testenv/testenv/testsuite.py @@ -165,6 +165,13 @@ env = { "TTCN3_PCAP_PATH": os.path.join(testenv.testdir.testdir, "testsuite"), } + + # Let ttcn3-tcpdump-stop.sh retrieve talloc reports + host, port = testenv.testenv_cfg.get_vty_host_port(cfg) + if port: + env["OSMO_SUT_HOST"] = host + env["OSMO_SUT_PORT"] = port + env = testenv.cmd.generate_env(env, testenv.args.podman) cmd = [start_testsuite, suite, section_data["config"]] -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38065?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I50a7035f072668ca2ab65de1bc1f194da8b18610 Gerrit-Change-Number: 38065 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: Convert bts->depends_on from bitmask to llist

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38050?usp=email ) Change subject: Convert bts->depends_on from bitmask to llist ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/38050/comment/b4c479e0_c5f6a7ff?usp… : PS2, Line 876: entry = talloc_zero(bts, struct bts_depends_on_entry); > ack Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I59e37d6baa020aeafdffc2c3538e988effd37620 Gerrit-Change-Number: 38050 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 11:47:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: tests/vty: Validate allocating all possible BTS

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38064?usp=email ) Change subject: tests/vty: Validate allocating all possible BTS ...................................................................... tests/vty: Validate allocating all possible BTS Change-Id: I91603872de1287e8f69edd05a1f485e03909b3b4 --- M tests/vty_test_runner.py 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/64/38064/1 diff --git a/tests/vty_test_runner.py b/tests/vty_test_runner.py index 50bf6a0..ac9fad3 100755 --- a/tests/vty_test_runner.py +++ b/tests/vty_test_runner.py @@ -174,6 +174,26 @@ res = self.vty.command("show network") self.assertTrue(res.startswith('BSC is on Country Code') >= 0) + def testTonsOfBTS(self): + self.vty.enable() + self.assertTrue(self.vty.verify("configure terminal",[''])) + self.assertTrue(self.vty.verify("network",[''])) + num_of_bts = 255 + for i in range(num_of_bts): + self.assertTrue(self.vty.verify("bts " + str(i),[''])) + self.assertEqual(self.vty.node(), 'config-net-bts') + self.checkForEndAndExit() + self.assertTrue(self.vty.verify("trx 0",[''])) + self.assertEqual(self.vty.node(), 'config-net-bts-trx') + self.checkForEndAndExit() + self.assertTrue(self.vty.verify("exit",[''])) + self.assertEqual(self.vty.node(), 'config-net-bts') + self.assertTrue(self.vty.verify("exit",[''])) + self.assertEqual(self.vty.node(), 'config-net') + + self.assertTrue(self.vty.verify("bts " + str(num_of_bts+1),['% Unknown command.'])) + self.assertEqual(self.vty.node(), 'config-net') + def add_bsc_test(suite, workdir): if not os.path.isfile(os.path.join(workdir, "src/osmo-bsc/osmo-bsc")): -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I91603872de1287e8f69edd05a1f485e03909b3b4 Gerrit-Change-Number: 38064 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

11 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024