Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037?usp=email )
Change subject: s1gw: add TC_pfcp_heartbeat
......................................................................
Patch Set 3:
(2 comments)
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037/comment/1f816126_a15e… :
PS2, Line 330: rts := f_pfcp_get_recovery_timestamp();
> See my comment from last patch, you are also getting the value here, so you could have passed it to […]
Ack, I'll address this in the next patchset revision.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037/comment/cb350cc2_deb9… :
PS2, Line 336: f_ConnHdlr_pfcp_expect(tr_PFCP_Heartbeat_Resp);
> (this function should probably return the actually received value matching the template. […]
It already does.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iadb24c2c346a62aa8b59d24475e71f683fc3dfe6
Gerrit-Change-Number: 38037
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Sep 2024 09:37:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38031?usp=email )
Change subject: hnbgw: move vc_PFCP from ConnHdlr to test_CT
......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
Patchset:
PS2:
> as I see every so often: the commit log describes accurately what is done, but gives no rationale, w […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38031?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iaf7a54c674f2dc549572d918beb6f355f48ee700
Gerrit-Change-Number: 38031
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 09 Sep 2024 09:34:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38060?usp=email )
Change subject: upf: remove unused port PFCP from test_CT
......................................................................
upf: remove unused port PFCP from test_CT
Change-Id: Iba31a6aaa9a9ec854ba36956d1b853dcf66a804d
---
M upf/UPF_Tests.ttcn
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/38060/1
diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn
index 37af9b3..b92701f 100644
--- a/upf/UPF_Tests.ttcn
+++ b/upf/UPF_Tests.ttcn
@@ -52,8 +52,6 @@
}
type component test_CT extends CTRL_Adapter_CT {
- port PFCPEM_PT PFCP;
-
port TELNETasp_PT UPFVTY;
/* global test case guard timer (actual timeout value is set in f_init()) */
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38060?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iba31a6aaa9a9ec854ba36956d1b853dcf66a804d
Gerrit-Change-Number: 38060
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38033?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: library/PFCP_Emulation: fix routing of incoming PDUs
......................................................................
library/PFCP_Emulation: fix routing of incoming PDUs
Before this patch, the PFCP_Emulation component was unable to route
incoming PDUs properly. The problem is that the SeqNr and SEID were
neither stored nor updated whem sending outgoing PDUs, and thus
remained unbound all the time.
Change-Id: I8e62471915ab9a917ac960d3078e89669b5ac0ea
---
M library/PFCP_Emulation.ttcn
1 file changed, 8 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/38033/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38033?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8e62471915ab9a917ac960d3078e89669b5ac0ea
Gerrit-Change-Number: 38033
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38032?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: library/PFCP_Emulation: look up by SeqNr and SEID separately
......................................................................
library/PFCP_Emulation: look up by SeqNr and SEID separately
This allows routing of PFCP PDUs without SEID by SeqNr.
An example of such a PDU is the Heartbeat Request.
Change-Id: Ic7912d944e94852a587993708d51439ec90f08cd
---
M library/PFCP_Emulation.ttcn
1 file changed, 27 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/38032/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38032?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic7912d944e94852a587993708d51439ec90f08cd
Gerrit-Change-Number: 38032
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38035?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: library/PFCP_Emulation: allow retrieving the Recovery Time Stamp
......................................................................
library/PFCP_Emulation: allow retrieving the Recovery Time Stamp
The Recovery Time Stamp is a mandatory IE for some PDUs, such as:
* Heartbeat Request/Response
* PFCP Association Setup Request/Response
Allow the PFCP_ConnHdlr components to retrieve its value, so that
they can include it in outgoing (and expect in incoming) PDUs.
Change-Id: I23eb2b4e309460f93183df83cdd35e46a93fbb94
---
M library/PFCP_Emulation.ttcn
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/38035/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38035?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I23eb2b4e309460f93183df83cdd35e46a93fbb94
Gerrit-Change-Number: 38035
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>