September 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: Convert bts->depends_on from bitmask to llist

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38050?usp=email ) Change subject: Convert bts->depends_on from bitmask to llist ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I59e37d6baa020aeafdffc2c3538e988effd37620 Gerrit-Change-Number: 38050 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 08:30:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: Initial support for >256 BTS

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38052?usp=email ) Change subject: Initial support for >256 BTS ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/38052/comment/c9c11906_b3072abb?usp… : PS1, Line 14: The ipaccess OML bts_nr is still kept as uint8_t so nothing changes over : the wire. That's because in ipaccess OML, in general each BTS is : bt > Which other BTSs are we speaking about which are not ip.access connecting to osmo-bsc? Ericsson om2k? nokia foobar? Yes, these. Check `enum gsm_bts_type`. > I don't know tbh, One would needs to check if those have some sort of limitation ... At least a quick git-grep shows me that `bts->nr` is sent over the wire in the om2k, for instance: ``` src/osmo-bsc/abis_om2000.c:3189: om2k_mo_init(&trx->rbs2000.trxc.om2k_mo, OM2K_MO_CLS_TRXC, bts->nr, 255, trx->nr); src/osmo-bsc/abis_om2000.c:3192: om2k_mo_init(&trx->rbs2000.tx.om2k_mo, OM2K_MO_CLS_TX, bts->nr, 255, trx->nr); src/osmo-bsc/abis_om2000.c:3195: om2k_mo_init(&trx->rbs2000.rx.om2k_mo, OM2K_MO_CLS_RX, bts->nr, 255, trx->nr); src/osmo-bsc/abis_om2000.c:3200: om2k_mo_init(&ts->rbs2000.om2k_mo, OM2K_MO_CLS_TS, bts->nr, trx->nr, i); src/osmo-bsc/abis_om2000.c:3217: om2k_mo_init(&bts->rbs2000.cf.om2k_mo, OM2K_MO_CLS_CF, bts->nr, 0xFF, 0); src/osmo-bsc/abis_om2000.c:3220: om2k_mo_init(&bts->rbs2000.is.om2k_mo, OM2K_MO_CLS_IS, bts->nr, 0xFF, 0); src/osmo-bsc/abis_om2000.c:3223: om2k_mo_init(&bts->rbs2000.con.om2k_mo, OM2K_MO_CLS_CON, bts->nr, 0xFF, 0); src/osmo-bsc/abis_om2000.c:3226: om2k_mo_init(&bts->rbs2000.dp.om2k_mo, OM2K_MO_CLS_DP, bts->nr, 0xFF, 0); src/osmo-bsc/abis_om2000.c:3228: om2k_mo_init(&bts->rbs2000.tf.om2k_mo, OM2K_MO_CLS_TF, bts->nr, 0xFF, 0); src/osmo-bsc/abis_om2000.c:3231: om2k_mo_init(&bts->rbs2000.mctr.om2k_mo, OM2K_MO_CLS_MCTR, bts->nr, 0xFF, 0); ``` This looks like a problem to me, given the definition of `struct abis_om2k_mo`: ``` 551 /* Ericsson OM2000 Managed Object */ 552 struct abis_om2k_mo { 553 uint8_t class; 554 uint8_t bts; 555 uint8_t assoc_so; 556 uint8_t inst; 557 } __attribute__ ((packed)); ``` Harald definitely knows more about om2k, I am just raising a concern, which is specifically about non-ip.access BTS models osmo-bsc also supports. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I607a68efeb5f4a50cce107d11d3c5126b7d8f81a Gerrit-Change-Number: 38052 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 08:28:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[master]: configure.ac: Remove ibosmo-sccp dependency

by osmith

osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email ) Change subject: configure.ac: Remove ibosmo-sccp dependency ...................................................................... Patch Set 5: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ifcdad8684614c95982b6b471a5585dd42a7fb897 Gerrit-Change-Number: 38056 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 08:26:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SIP_Emulation: Allow forwarding ASP_SIP_close

by jolly

Attention is currently required from: Hoernchen, pespin. jolly has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38044?usp=email ) Change subject: SIP_Emulation: Allow forwarding ASP_SIP_close ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If5c6bb0c0d773e0ba18ec28062663bdec751c8c4 Gerrit-Change-Number: 38044 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 08:17:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[master]: configure.ac: Remove ibosmo-sccp dependency

by osmith

Attention is currently required from: laforge, osmith. osmith has uploaded a new patch set (#4) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email ) The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: configure.ac: Remove ibosmo-sccp dependency ...................................................................... configure.ac: Remove ibosmo-sccp dependency osmo-msc had probably forever contained a configure.ac dependency to libosmo-sccp (that's the old static library libsccp.a), which was only added to use a single header file (sccp_types.h). This file has recently been migrated to libosmo-sigtran, as libsccp.a has been removed. Change-Id: Ifcdad8684614c95982b6b471a5585dd42a7fb897 --- M TODO-RELEASE M configure.ac M debian/control M doc/manuals/chapters/overview.adoc M src/libmsc/Makefile.am M src/libmsc/neighbor_ident.c M src/libsmpputil/Makefile.am M src/libvlr/Makefile.am M src/osmo-msc/msc_main.c M src/utils/Makefile.am M tests/smpp/Makefile.am 11 files changed, 6 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/56/38056/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ifcdad8684614c95982b6b471a5585dd42a7fb897 Gerrit-Change-Number: 38056 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[master]: configure.ac: Remove ibosmo-sccp dependency

by laforge

Attention is currently required from: laforge, osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by osmith Change subject: configure.ac: Remove ibosmo-sccp dependency ...................................................................... configure.ac: Remove ibosmo-sccp dependency osmo-msc had probably forever contained a configure.ac dependency to libosmo-sccp (that's the old static library libsccp.a), which was only added to use a single header file (sccp_types.h). This file has recently been migrated to libosmo-sigtran, as libsccp.a has been removed. Change-Id: Ifcdad8684614c95982b6b471a5585dd42a7fb897 --- M TODO-RELEASE M configure.ac M debian/control M doc/manuals/chapters/overview.adoc M src/libmsc/Makefile.am M src/libmsc/neighbor_ident.c M src/libsmpputil/Makefile.am M src/libvlr/Makefile.am M src/osmo-msc/msc_main.c M src/utils/Makefile.am M tests/smpp/Makefile.am 11 files changed, 5 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/56/38056/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ifcdad8684614c95982b6b471a5585dd42a7fb897 Gerrit-Change-Number: 38056 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[master]: configure.ac: Remove ibosmo-sccp dependency

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email ) Change subject: configure.ac: Remove ibosmo-sccp dependency ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ifcdad8684614c95982b6b471a5585dd42a7fb897 Gerrit-Change-Number: 38056 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 09 Sep 2024 07:52:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[master]: configure.ac: Remove ibosmo-sccp dependency

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: configure.ac: Remove ibosmo-sccp dependency ...................................................................... configure.ac: Remove ibosmo-sccp dependency osmo-msc had probably forever contained a configure.ac dependency to libosmo-sccp (that's the old static library libsccp.a), which was only added to use a single header file (sccp_types.h). This file has recently been migrated to libosmo-sigtran, as libsccp.a has been removed. Change-Id: Ifcdad8684614c95982b6b471a5585dd42a7fb897 --- M TODO-RELEASE M configure.ac M debian/control M doc/manuals/chapters/overview.adoc M src/libmsc/Makefile.am M src/libmsc/neighbor_ident.c M src/libsmpputil/Makefile.am M src/libvlr/Makefile.am M src/osmo-msc/msc_main.c M src/utils/Makefile.am M tests/smpp/Makefile.am 11 files changed, 4 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/56/38056/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ifcdad8684614c95982b6b471a5585dd42a7fb897 Gerrit-Change-Number: 38056 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: Remove dependency on libosmo-sccp

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/38057?usp=email ) Change subject: Remove dependency on libosmo-sccp ...................................................................... Abandoned see https://gerrit.osmocom.org/c/osmo-msc/+/38056 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38057?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I46d8e48aabca69cd0d10896da4be8d35d3cedbd8 Gerrit-Change-Number: 38057 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: Remove dependency on libosmo-sccp

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/38057?usp=email ) Change subject: Remove dependency on libosmo-sccp ...................................................................... Patch Set 1: (1 comment) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/osmo-msc/+/38057/comment/5573167b_c3bde682?usp… : PS1, Line 46: osmo-build-dep.sh libosmo-sccp > this must not be removed. libosmo-sccp. […] ah right! -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38057?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I46d8e48aabca69cd0d10896da4be8d35d3cedbd8 Gerrit-Change-Number: 38057 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 09 Sep 2024 07:44:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024