Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38050?usp=email )
Change subject: Convert bts->depends_on from bitmask to llist
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/38050/comment/d764ec68_7662940d?usp… :
PS2, Line 876: entry = talloc_zero(bts, struct bts_depends_on_entry);
@laforge@gnumonks.org your comment was meant on this line? do you want me to early return if (!entry)?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38050?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I59e37d6baa020aeafdffc2c3538e988effd37620
Gerrit-Change-Number: 38050
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 09 Sep 2024 09:26:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: osmith, roh.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/37976?usp=email )
Change subject: jobs/{master,gerrit}: rpi4-raspbian11 -> raspbian
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
The general question is why do we want to run multiple rpi4 builders which are supposed to be identical but in reality they have different raspbian base versions, and different instruction set (32 vs 64bit).
The patch series here are just plastering around that issue, IMHO.
Either that one builder should be downgraded to be identical to the other ones, or all other ones should be upgraded.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37976?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I02dcf3098ffd3fa247c4f43c290d6e3fd809ad45
Gerrit-Change-Number: 37976
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: roh <jsteiger(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: roh <jsteiger(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Sep 2024 09:20:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: laforge.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/38058?usp=email
to look at the new patch set (#3).
Change subject: Stop building openbsc
......................................................................
Stop building openbsc
With recent changes in libosmo-sccp, openbsc does not build anymore.
The openbsc.git repo has been unmaintained/unsupported for 7 years, so
let's finally remove related build jobs instead of fixing this.
Related: libosmo-sccp I299a32a2f8f61477cf49c8126567fef2092d5407
Change-Id: Ie58f54c3f2a224fb1e3a0c95bd3ed85e7859fdc9
---
M jobs/gerrit-verifications.yml
M jobs/master-builds.yml
M jobs/osmo-gsm-tester-builder.yml
M scripts/osmocom-build-old-tags-against-master.sh
4 files changed, 5 insertions(+), 39 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/58/38058/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38058?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ie58f54c3f2a224fb1e3a0c95bd3ed85e7859fdc9
Gerrit-Change-Number: 38058
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: laforge.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38058?usp=email )
Change subject: Stop building openbsc
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ci/+/38058/comment/d44fb89e_586d1bde?usp=… :
PS1, Line 9: With recent changes in libosmo-sccp, openbsc does not build anymore.
: Harald suggested that we might want to stop building openbsc.git
: altogether now.
> I think the rationale should less be "Harald said ..." but more "the openbsc. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38058?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ie58f54c3f2a224fb1e3a0c95bd3ed85e7859fdc9
Gerrit-Change-Number: 38058
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 09 Sep 2024 09:19:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>