Attention is currently required from: osmith.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/38057?usp=email )
Change subject: Remove dependency on libosmo-sccp
......................................................................
Patch Set 1:
(1 comment)
File contrib/jenkins.sh:
https://gerrit.osmocom.org/c/osmo-msc/+/38057/comment/d359b120_493d1dcd?usp… :
PS1, Line 46: osmo-build-dep.sh libosmo-sccp
this must not be removed. libosmo-sccp.git must be built as it contains libosmo-sigtran!
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38057?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I46d8e48aabca69cd0d10896da4be8d35d3cedbd8
Gerrit-Change-Number: 38057
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Sep 2024 07:44:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38057?usp=email )
Change subject: Remove dependency on libosmo-sccp
......................................................................
Remove dependency on libosmo-sccp
OsmoMSC already depends on and uses libosmo-sigtran. Remove the
dependency on libosmo-sccp, which has been removed in the related
commit.
Fix for:
configure: error: Package requirements (libosmo-sccp >= 1.9.0) were not met:
Related: libosmo-sccp d258a59432364634d8cec1359ca821aae1950bcc
Change-Id: I46d8e48aabca69cd0d10896da4be8d35d3cedbd8
---
M configure.ac
M contrib/jenkins.sh
M debian/control
M doc/manuals/chapters/overview.adoc
M src/libmsc/neighbor_ident.c
M src/osmo-msc/msc_main.c
6 files changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/57/38057/1
diff --git a/configure.ac b/configure.ac
index c0ab55e..49afb7b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -44,7 +44,6 @@
PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.6.0)
PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.5.0)
PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.9.0)
-PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.9.0)
PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.13.0)
PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.8.0)
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index c5161ef..74f9ee9 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -43,7 +43,6 @@
osmo-build-dep.sh libosmo-abis
osmo-build-dep.sh libosmo-netif
-osmo-build-dep.sh libosmo-sccp
osmo-build-dep.sh libsmpp34
osmo-build-dep.sh osmo-mgw
osmo-build-dep.sh osmo-hlr
diff --git a/debian/control b/debian/control
index 76cfd7a..43a6334 100644
--- a/debian/control
+++ b/debian/control
@@ -15,7 +15,6 @@
libsmpp34-dev (>= 1.14.0),
libasn1c-dev (>= 0.9.30),
libosmocore-dev (>= 1.10.0),
- libosmo-sccp-dev (>= 1.9.0),
libosmo-sigtran-dev (>= 1.9.0),
libosmo-abis-dev (>= 1.6.0),
libosmo-mgcp-client-dev (>= 1.13.0),
diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc
index 0bb47d7..ab09022 100644
--- a/doc/manuals/chapters/overview.adoc
+++ b/doc/manuals/chapters/overview.adoc
@@ -42,7 +42,7 @@
had an SCCPlite based _A_ interface towards 3rd party MSC implementations.
OsmoMSC features a true SCCP/M3UA _A_ interface, which allows running OsmoBSC
against this Osmocom based MSC implementation. The new SCCP/M3UA SIGTRAN for
- the _A_ interface is implemented in libosmo-sccp, which is used by OsmoMSC
+ the _A_ interface is implemented in libosmo-sigtran, which is used by OsmoMSC
and OsmoBSC (and others), to establish a link via an STP (e.g. OsmoSTP).
- Addition of an _IuCS_ interface to allow operating 3G voice services, also
diff --git a/src/libmsc/neighbor_ident.c b/src/libmsc/neighbor_ident.c
index b3cdf17..e7d34fa 100644
--- a/src/libmsc/neighbor_ident.c
+++ b/src/libmsc/neighbor_ident.c
@@ -35,7 +35,7 @@
#include <osmocom/msc/sccp_ran.h>
#include <osmocom/msc/cell_id_list.h>
-/* XXX greater than or equal to IPA_STRING_MAX (libosmocore) and MAX_PC_STR_LEN (libosmo-sccp). */
+/* XXX greater than or equal to IPA_STRING_MAX (libosmocore) and MAX_PC_STR_LEN (libosmo-sigtran). */
#define NEIGHBOR_IDENT_ADDR_STRING_MAX 64
static struct gsm_network *gsmnet;
diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index 913bd21..a4b2ded 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -356,7 +356,7 @@
static int msc_vty_is_config_node(struct vty *vty, int node)
{
- /* Check if libosmo-sccp declares the node in
+ /* Check if libosmo-sigtran declares the node in
* question as config node */
if (osmo_ss7_is_config_node(vty, node))
return 1;
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38057?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I46d8e48aabca69cd0d10896da4be8d35d3cedbd8
Gerrit-Change-Number: 38057
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email )
Change subject: configure.ac: Remove ibosmo-sccp dependency
......................................................................
configure.ac: Remove ibosmo-sccp dependency
osmo-msc had probably forever contained a configure.ac dependency
to libosmo-sccp (that's the old static library libsccp.a), which was
only added to use a single header file (sccp_types.h). This file
has recently been migrated to libosmo-sigtran, as libsccp.a
has been removed.
Change-Id: Ifcdad8684614c95982b6b471a5585dd42a7fb897
---
M TODO-RELEASE
M configure.ac
2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/56/38056/1
diff --git a/TODO-RELEASE b/TODO-RELEASE
index 0ed7189..02843d4 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,3 +7,4 @@
# If any interfaces have been added since the last public release: c:r:a + 1.
# If any interfaces have been removed or changed since the last public release: c:r:0.
#library what description / commit summary line
+libosmo-sigtran bump dependency to > 1.9.0 / libosmo-sccp package removal
diff --git a/configure.ac b/configure.ac
index c0ab55e..49afb7b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -44,7 +44,6 @@
PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.6.0)
PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.5.0)
PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.9.0)
-PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.9.0)
PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.13.0)
PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.8.0)
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ifcdad8684614c95982b6b471a5585dd42a7fb897
Gerrit-Change-Number: 38056
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Attention is currently required from: fixeria, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38052?usp=email )
Change subject: Initial support for >256 BTS
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/38052/comment/ee0bce60_372bc236?usp… :
PS1, Line 14: The ipaccess OML bts_nr is still kept as uint8_t so nothing changes over
: the wire. That's because in ipaccess OML, in general each BTS is
: bt
> Which other BTSs are we speaking about which are not ip.access connecting to osmo-bsc? […]
we have to check how the bts->nr gets used in other abis dialects. In E1 based bts uaing 12.21 (like Siemens) you can for sure have multiple daisy-chained and then the OML header bts-nr can be non-zero. but it is unrealistic to have more than a handful at one link.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38052?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I607a68efeb5f4a50cce107d11d3c5126b7d8f81a
Gerrit-Change-Number: 38052
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Sep 2024 07:02:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38050?usp=email )
Change subject: Convert bts->depends_on from bitmask to llist
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
we usually Chek. for (of assert on) tallow returning NULL. in this case I think it's better to keep the BSC running and failing to add that one dependent record.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38050?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I59e37d6baa020aeafdffc2c3538e988effd37620
Gerrit-Change-Number: 38050
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Sep 2024 06:59:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, pespin.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37992?usp=email )
Change subject: coverity CID#216829
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
While writing this patch, I came across this possible bug:
https://osmocom.org/issues/6562
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37992?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I30beeac45ff2d8c08905986af9fabfda071ddc5b
Gerrit-Change-Number: 37992
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Sep 2024 00:43:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No