September 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-pfcp[master]: coverity CID#313611

by neels

Attention is currently required from: fixeria. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/37993?usp=email ) Change subject: coverity CID#313611 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/37993?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ic5c87e029fe761b24ef9dcf801376da7b5a8d290 Gerrit-Change-Number: 37993 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 Sep 2024 23:44:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months, 1 week

1
0
0 0

[M] Change in osmo-bsc[master]: Convert bts->depends_on from bitmask to llist

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/38050?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: Convert bts->depends_on from bitmask to llist ...................................................................... Convert bts->depends_on from bitmask to llist The amount of dependencies on each BTS is usually zero or a small number, hence the computation cost is mostly similar regardless of using a llist or a bitmask buffer. Right now, even if the dependency chains are (almost) empty, the iprevious code allocated (N * 256/8) bytes, where N is the amount of bts configured. Since we are now planning to increase the amount of bts (N) from uint8_t to uint16_t, that means with this change we will then avoid: * Increasing memory use to O(N * 65536/8). * Having to adapt code operating on bitmask (size) Related: SYS#7062 Change-Id: I59e37d6baa020aeafdffc2c3538e988effd37620 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c 3 files changed, 45 insertions(+), 45 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/38050/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I59e37d6baa020aeafdffc2c3538e988effd37620 Gerrit-Change-Number: 38050 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

11 months, 1 week

1
0
0 0

[M] Change in osmo-bsc[master]: Convert bts->depends_on from bitmask to llist

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38050?usp=email ) Change subject: Convert bts->depends_on from bitmask to llist ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/38050/comment/9d9871dd_c00fa6ae?usp… : PS1, Line 881: struct gsm_bts *bts > const? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I59e37d6baa020aeafdffc2c3538e988effd37620 Gerrit-Change-Number: 38050 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 Sep 2024 17:05:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

11 months, 1 week

1
0
0 0

[M] Change in osmo-bsc[master]: Initial support for >256 BTS

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38052?usp=email ) Change subject: Initial support for >256 BTS ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/38052/comment/365ddebe_b7e52d41?usp… : PS1, Line 14: The ipaccess OML bts_nr is still kept as uint8_t so nothing changes over : the wire. That's because in ipaccess OML, in general each BTS is : bt > Is my understanding correct that >256 BTS will only work with ip. […] Which other BTSs are we speaking about which are not ip.access connecting to osmo-bsc? Ericsson om2k? nokia foobar? I don't know tbh, One would needs to check if those have some sort of limitation regarding uint8_t like we have for ip.accesss/pcu_if. In fact, as mentioned the uint8_t id limitation for ip.access was not really a limitation, since in general the BTS there each use bts_nr=0 on its own OML link (except eg. when stacking up several nanoBTS, which in any case won't go over 256 stacked ones...). I think in here we are basically removing our own osmocom self-imposed limitation. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I607a68efeb5f4a50cce107d11d3c5126b7d8f81a Gerrit-Change-Number: 38052 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 Sep 2024 16:57:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

11 months, 1 week

1
0
0 0

[XS] Change in pysim[master]: pySim.euicc: Add 'get_data sgp02_eid' in ADF.ECASD of M2M eUICC

by fixeria

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38048?usp=email ) Change subject: pySim.euicc: Add 'get_data sgp02_eid' in ADF.ECASD of M2M eUICC ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6cca6f75d268229244c90b3f1f88e26c89a2b4e0 Gerrit-Change-Number: 38048 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 Sep 2024 16:05:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months, 1 week

1
0
0 0

[XS] Change in pysim[master]: pySim.commands: use _checksw during get_data() method

by fixeria

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38047?usp=email ) Change subject: pySim.commands: use _checksw during get_data() method ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic784bf0c30b22e5e83843aa6694e2706b4b2ac48 Gerrit-Change-Number: 38047 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 Sep 2024 16:04:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months, 1 week

1
0
0 0

[S] Change in pysim[master]: pySim.transport: Add support for generic stdout apdu tracer

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38054?usp=email ) Change subject: pySim.transport: Add support for generic stdout apdu tracer ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/38054/comment/c25b7152_be7c22b3?usp=em… : PS1, Line 258: 'apdu_tracer' in kwargs Wondering when this condition is true. Perhaps something for an upcoming patch? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4bc3d2e023ba360f07f024d7b661a93322f87530 Gerrit-Change-Number: 38054 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 08 Sep 2024 16:02:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

11 months, 1 week

1
0
0 0

[XS] Change in pysim[master]: pySim.app: Properly reset card state after reading EID

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38053?usp=email ) Change subject: pySim.app: Properly reset card state after reading EID ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib23d3d5b58b456a25157a622c1010c81cd8b2213 Gerrit-Change-Number: 38053 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 08 Sep 2024 16:00:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

11 months, 1 week

1
0
0 0

[S] Change in pysim[master]: pySim.transport: Add support for generic stdout apdu tracer

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38054?usp=email ) Change subject: pySim.transport: Add support for generic stdout apdu tracer ...................................................................... pySim.transport: Add support for generic stdout apdu tracer Any program using argparse_add_reader_args() will get a new long-opt '--apdu-trace' which enables a raw APDU trace to the console. Change-Id: I4bc3d2e023ba360f07f024d7b661a93322f87530 --- M pySim/transport/__init__.py 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/54/38054/1 diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py index 97022ce..856e86e 100644 --- a/pySim/transport/__init__.py +++ b/pySim/transport/__init__.py @@ -40,6 +40,12 @@ def trace_response(self, cmd, sw, resp): pass +class StdoutApduTracer(ApduTracer): + """Minimalistic APDU tracer, printing commands to stdout.""" + def trace_response(self, cmd, sw, resp): + print("-> %s %s" % (cmd[:10], cmd[10:])) + print("<- %s: %s" % (sw, resp)) + class ProactiveHandler(abc.ABC): """Abstract base class representing the interface of some code that handles the proactive commands, as returned by the card in responses to the FETCH @@ -239,6 +245,8 @@ PcscSimLink.argparse_add_reader_args(arg_parser) ModemATCommandLink.argparse_add_reader_args(arg_parser) CalypsoSimLink.argparse_add_reader_args(arg_parser) + arg_parser.add_argument('--apdu-trace', action='store_true', + help='Trace the command/response APDUs exchanged with the card') return arg_parser @@ -247,6 +255,9 @@ """ Init card reader driver """ + if opts.apdu_trace and not 'apdu_tracer' in kwargs: + kwargs['apdu_tracer'] = StdoutApduTracer() + if opts.pcsc_dev is not None or opts.pcsc_regex is not None: from pySim.transport.pcsc import PcscSimLink sl = PcscSimLink(opts, **kwargs) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4bc3d2e023ba360f07f024d7b661a93322f87530 Gerrit-Change-Number: 38054 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.transport: Also trace card reset events in ApduTracer

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38055?usp=email ) Change subject: pySim.transport: Also trace card reset events in ApduTracer ...................................................................... pySim.transport: Also trace card reset events in ApduTracer Change-Id: Ia46b65124520eb2b8015dfa3f0a135b497668b92 --- M pySim/transport/__init__.py M pySim/transport/calypso.py M pySim/transport/modem_atcmd.py M pySim/transport/pcsc.py M pySim/transport/serial.py 5 files changed, 19 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/55/38055/1 diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py index 856e86e..9482528 100644 --- a/pySim/transport/__init__.py +++ b/pySim/transport/__init__.py @@ -40,12 +40,18 @@ def trace_response(self, cmd, sw, resp): pass + def trace_reset(self): + pass + class StdoutApduTracer(ApduTracer): """Minimalistic APDU tracer, printing commands to stdout.""" def trace_response(self, cmd, sw, resp): print("-> %s %s" % (cmd[:10], cmd[10:])) print("<- %s: %s" % (sw, resp)) + def trace_reset(self): + print("-- RESET") + class ProactiveHandler(abc.ABC): """Abstract base class representing the interface of some code that handles the proactive commands, as returned by the card in responses to the FETCH @@ -117,9 +123,16 @@ """ @abc.abstractmethod + def _reset_card(self): + """Resets the card (power down/up) + """ + def reset_card(self): """Resets the card (power down/up) """ + if self.apdu_tracer: + self.apdu_tracer.trace_reset() + return self._reset_card() def send_apdu_raw(self, pdu: Hexstr) -> ResTuple: """Sends an APDU with minimal processing diff --git a/pySim/transport/calypso.py b/pySim/transport/calypso.py index d8e5b89..9462939 100644 --- a/pySim/transport/calypso.py +++ b/pySim/transport/calypso.py @@ -109,7 +109,7 @@ rsp = self.sock.recv(exp_len) return rsp - def reset_card(self): + def _reset_card(self): # Request FULL reset req_msg = L1CTLMessageReset() self.sock.send(req_msg.gen_msg()) diff --git a/pySim/transport/modem_atcmd.py b/pySim/transport/modem_atcmd.py index 882cb65..8970f7d 100644 --- a/pySim/transport/modem_atcmd.py +++ b/pySim/transport/modem_atcmd.py @@ -125,7 +125,7 @@ return raise ReaderError('Interface \'%s\' does not respond to \'AT\' command' % self._device) - def reset_card(self): + def _reset_card(self): # Reset the modem, just to be sure if self.send_at_cmd('ATZ') != [b'OK']: raise ReaderError('Failed to reset the modem') diff --git a/pySim/transport/pcsc.py b/pySim/transport/pcsc.py index 7843f7f..207cf6c 100644 --- a/pySim/transport/pcsc.py +++ b/pySim/transport/pcsc.py @@ -97,7 +97,7 @@ def disconnect(self): self._con.disconnect() - def reset_card(self): + def _reset_card(self): self.disconnect() self.connect() return 1 diff --git a/pySim/transport/serial.py b/pySim/transport/serial.py index e155226..04b4ab7 100644 --- a/pySim/transport/serial.py +++ b/pySim/transport/serial.py @@ -101,15 +101,15 @@ def disconnect(self): pass # Nothing to do really ... - def reset_card(self): - rv = self._reset_card() + def _reset_card(self): + rv = self.__reset_card() if rv == 0: raise NoCardError() if rv < 0: raise ProtocolError() return rv - def _reset_card(self): + def __reset_card(self): self._atr = None rst_meth_map = { 'rts': self._sl.setRTS, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia46b65124520eb2b8015dfa3f0a135b497668b92 Gerrit-Change-Number: 38055 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

11 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024