September 2024 - gerrit-log - lists.osmocom.org

[L] Change in osmo-ttcn3-hacks[master]: Introduce PCRF_Tests testsuite

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38028?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Introduce PCRF_Tests testsuite ...................................................................... Introduce PCRF_Tests testsuite Change-Id: I381577111ccadaefe42f6abe3cd9bb30cc8ceb56 --- M Makefile M library/DIAMETER_Templates.ttcn M library/DIAMETER_ts29_212_Templates.ttcn A pcrf/PCRF_Tests.cfg A pcrf/PCRF_Tests.default A pcrf/PCRF_Tests.ttcn A pcrf/create_test_subscribers.sh A pcrf/expected-results.xml A pcrf/freediameter.conf A pcrf/gen_links.sh A pcrf/mongod.conf A pcrf/open5gs-pcrf.yaml A pcrf/regen_makefile.sh A pcrf/testenv.cfg 14 files changed, 796 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/28/38028/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38028?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I381577111ccadaefe42f6abe3cd9bb30cc8ceb56 Gerrit-Change-Number: 38028 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

9 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: Rename s/g_pars/g__pars

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38018?usp=email ) Change subject: HTTP_Adapter: Rename s/g_pars/g__pars ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Fine with it, I'll do the change as requested. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38018?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia07cf8717593073a71632e247d7fe0775e66eb13 Gerrit-Change-Number: 38018 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 05 Sep 2024 13:39:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Does that imply your patches get higher preference than mine? because it has been clarified that testing is not a real reason comapring to your patches. I am really not liking this tone and direction of the conversation. I never said or implied that. After all, you were the one who gave CR+2 on the whole patchset, so I merged it a few days after getting the necessary CR+3. Testing coverage was WIP at that time. It's not like I was playing a race trying to get those patches merged earlier than yours. It has also been about a week ago when I wrote this comment: > Let's keep this patch in review until we have functional or at least unit tests. which was not acted/commented upon, and you're now blaming me for keeping your patches trapped. > You could have merged mine and worked on top of mine, like I usually do with yours, because I consider this helps everybody. I don't remember this being discussed and negotiated in advance. I am also surprised to hear this, because I didn't touch the proxy module (only the `pfcp_peer`), so how could have this created conflicts with this patch? It might have created conflicts for the metrics patch, which was submitted exactly in the same day I submitted my patches adding the heartbear procedure... I am puzzled. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 05 Sep 2024 13:37:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-sip-connector[master]: sip.c: permit early media with both 183 and 180

by pespin

Attention is currently required from: fixeria, laforge, lynxis lazus, neels. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email ) Change subject: sip.c: permit early media with both 183 and 180 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79 Gerrit-Change-Number: 38039 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 05 Sep 2024 13:35:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-sip-connector[master]: sip.c: permit early media with both 183 and 180

by jolly

Attention is currently required from: fixeria, laforge, lynxis lazus, neels, pespin. jolly has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email ) Change subject: sip.c: permit early media with both 183 and 180 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79 Gerrit-Change-Number: 38039 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 05 Sep 2024 13:35:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-sip-connector[master]: sip.c: permit early media with both 183 and 180

by laforge

Attention is currently required from: fixeria, jolly, lynxis lazus, neels, pespin. Hello Jenkins Builder, fixeria, jolly, lynxis lazus, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sip.c: permit early media with both 183 and 180 ...................................................................... sip.c: permit early media with both 183 and 180 So far we only attempted to extract SDP (and hence enable early media) when receiving a status code 183. However, SDP can also be provided with 180, see for example https://developer.signalwire.com/freeswitch/FreeSWITCH-Explained/Codecs-and… Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79 Closes: OS#6559 --- M src/sip.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/39/38039/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79 Gerrit-Change-Number: 38039 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-sip-connector[master]: sip.c: permit early media with both 183 and 180

by laforge

Attention is currently required from: fixeria, jolly, lynxis lazus, neels, pespin. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email ) Change subject: sip.c: permit early media with both 183 and 180 ...................................................................... Patch Set 1: (1 comment) File src/sip.c: https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039/comment/b1f8b684_0f… : PS1, Line 85: if (status == 183 || status == 180) > What if "180 Ringing" result does not contain SDP? sdp_extract_sdp() would print error log message, […] nice catch. I've pushed an updated version that only calls sdp_extract_sdp if there's `sip->sip_payload->pl_data` -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79 Gerrit-Change-Number: 38039 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 05 Sep 2024 13:30:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-sip-connector[master]: sip.c: permit early media with both 183 and 180

by laforge

Attention is currently required from: fixeria, laforge, lynxis lazus, neels, pespin. Hello Jenkins Builder, fixeria, jolly, lynxis lazus, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: sip.c: permit early media with both 183 and 180 ...................................................................... sip.c: permit early media with both 183 and 180 So far we only attempted to extract SDP (and hence enable early media) when receiving a status code 183. However, SDP can also be provided with 180, see for example https://developer.signalwire.com/freeswitch/FreeSWITCH-Explained/Codecs-and… Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79 Closes: OS#6559 --- M src/sip.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/39/38039/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79 Gerrit-Change-Number: 38039 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

9 months, 3 weeks

1
0
0 0

[XL] Change in libosmo-sccp[master]: remove old static libsccp.a, libmtp.a, libxua.a

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/38041?usp=email ) Change subject: remove old static libsccp.a, libmtp.a, libxua.a ...................................................................... Patch Set 5: (1 comment) Patchset: PS2: > I just tested it locally. […] AFAICT, our master-builds and `osmocom-build-old-tags-against-master.sh` jenkins jobs should still pass even after this change. "of course" I have no way of testing that locally outside of jenkins... -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/38041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I299a32a2f8f61477cf49c8126567fef2092d5407 Gerrit-Change-Number: 38041 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Sep 2024 13:26:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[XL] Change in libosmo-sccp[master]: remove old static libsccp.a, libmtp.a, libxua.a

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/38041?usp=email ) Change subject: remove old static libsccp.a, libmtp.a, libxua.a ...................................................................... Patch Set 5: (1 comment) Patchset: PS2: > it should only break if you do --enable-nat or --enable-osmo-bsc. I just tested it locally. Indeed, only if either of those two are used you get a `configure: error: Package requirements (libosmo-sccp >= 1.0.0) were not met` error at the configure step. the default build succeeds. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/38041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I299a32a2f8f61477cf49c8126567fef2092d5407 Gerrit-Change-Number: 38041 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Sep 2024 13:22:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024