September 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: Stop building openbsc

by osmith

Attention is currently required from: laforge, osmith. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/38058?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge Change subject: Stop building openbsc ...................................................................... Stop building openbsc With recent changes in libosmo-sccp, openbsc does not build anymore. The openbsc.git repo has been unmaintained/unsupported for 7 years, so let's finally remove it instead of fixing this. Related: libosmo-sccp I299a32a2f8f61477cf49c8126567fef2092d5407 Change-Id: Ie58f54c3f2a224fb1e3a0c95bd3ed85e7859fdc9 --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml M jobs/osmo-gsm-tester-builder.yml M scripts/osmocom-build-old-tags-against-master.sh 4 files changed, 5 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/58/38058/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38058?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie58f54c3f2a224fb1e3a0c95bd3ed85e7859fdc9 Gerrit-Change-Number: 38058 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: jobs/{gerrit,master,update-osmo-ci}: add aarch64 case

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/37975?usp=email ) Change subject: jobs/{gerrit,master,update-osmo-ci}: add aarch64 case ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaf987d05870d842cd297f5f14c8542bf75835414 Gerrit-Change-Number: 37975 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 09:17:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: Stop building openbsc

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38058?usp=email ) Change subject: Stop building openbsc ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/38058/comment/b0435510_f6f96cb5?usp=… : PS1, Line 9: With recent changes in libosmo-sccp, openbsc does not build anymore. : Harald suggested that we might want to stop building openbsc.git : altogether now. I think the rationale should less be "Harald said ..." but more "the openbsc.git repo has been unmaintained/unsupported for 7 years", and that at some point enough is enough. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38058?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie58f54c3f2a224fb1e3a0c95bd3ed85e7859fdc9 Gerrit-Change-Number: 38058 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 09:16:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: Stop building openbsc

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38058?usp=email ) Change subject: Stop building openbsc ...................................................................... Stop building openbsc With recent changes in libosmo-sccp, openbsc does not build anymore. Harald suggested that we might want to stop building openbsc.git altogether now. Related: libosmo-sccp I299a32a2f8f61477cf49c8126567fef2092d5407 Change-Id: Ie58f54c3f2a224fb1e3a0c95bd3ed85e7859fdc9 --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml M jobs/osmo-gsm-tester-builder.yml M scripts/osmocom-build-old-tags-against-master.sh 4 files changed, 5 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/58/38058/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index abeb383..f68102b 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -130,21 +130,6 @@ - libusrp - - openbsc: - a1_name: SMPP - a1: !!python/tuple [--enable-smpp] - a2_name: MGCP - a2: !!python/tuple [--enable-mgcp-transcoding, --disable-mgcp-transcoding] - a3_name: IU - a3: !!python/tuple [--disable-iu] - cmd: | - {docker_run_ccache} \ - -e IU="$IU" \ - -e SMPP="$SMPP" \ - -e MGCP="$MGCP" \ - {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - pipeline_binpkgs: "" - - openggsn: a1_name: GTP a1: !!python/tuple [--enable-gtp-linux,--disable-gtp-linux] diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index a3711f0..3b5f254 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -99,7 +99,7 @@ # Full triggers would be: # trigger: > # master-libosmo-netif, master-osmo-bsc, master-osmo-bts, master-osmo-hlr, - # master-osmo-msc, master-osmo-sgsn, master-openbsc + # master-osmo-msc, master-osmo-sgsn # Optimized: # (see comment at libosmocore) trigger: > @@ -129,7 +129,7 @@ - libosmo-netif: # Full triggers would be: # trigger: > - # master-libosmo-sccp, master-openbsc, mastere-osmo-hlr, master-osmo-iuh, + # master-libosmo-sccp, mastere-osmo-hlr, master-osmo-iuh, # master-osmo-mgw, master-osmo-msc, master-osmo-sgsn, master-osmo-hnodeb, # master-osmo-hnbgw # Optimized: @@ -153,12 +153,11 @@ - libosmo-sccp: # Full triggers would be: # trigger: > - # master-openbsc, master-osmo-bsc, master-osmo-iuh, master-osmo-msc, + # master-osmo-bsc, master-osmo-iuh, master-osmo-msc, # master-osmo-sgsn, master-osmo-hnodeb, master-osmo-hnbgw # Optimized: # (see comment at libosmocore) trigger: > - master-openbsc, master-osmo-bsc, master-osmo-bsc-nat, master-osmo-iuh, @@ -173,7 +172,7 @@ cmd: '{docker_run_ccache} {docker_img} {timeout_cmd} /build/contrib/jenkins_arch.sh "$arch"' # Full triggers would be: # trigger: > - # master-libosmo-abis, master-libosmo-netif, master-libosmo-sccp, master-openbsc, + # master-libosmo-abis, master-libosmo-netif, master-libosmo-sccp, # master-osmo-bsc, master-osmo-bts, master-osmo-ggsn, master-osmo-gmr, master-osmo-hlr, # master-osmo-iuh, master-osmo-mgw, master-osmo-msc, master-osmo-pcap, master-osmo-pcu, # master-osmo-sgsn, master-osmo-sip-connector, master-osmo-tetra, master-osmo-hnodeb @@ -183,7 +182,6 @@ # -> master-libosmo-abis # -> master-libosmo-netif # -> master-libosmo-sccp - # -> master-openbsc # -> master-osmo-bsc # -> master-osmo-bsc-nat # -> master-osmo-iuh @@ -219,26 +217,12 @@ master-xgoldmon - libsmpp34: - trigger: master-osmo-msc, master-openbsc + trigger: master-osmo-msc - libtelnet - libusrp: trigger: master-osmo-trx - - openbsc: - a1_name: SMPP - a1: !!python/tuple [--enable-smpp] - a2_name: MGCP - a2: !!python/tuple [--enable-mgcp-transcoding, --disable-mgcp-transcoding] - a3_name: IU - a3: !!python/tuple [--disable-iu] - cmd: | - {docker_run_ccache} \ - -e IU="$IU" \ - -e SMPP="$SMPP" \ - -e MGCP="$MGCP" \ - {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - - osmo-bsc - osmo-bsc-nat diff --git a/jobs/osmo-gsm-tester-builder.yml b/jobs/osmo-gsm-tester-builder.yml index cd50cb8..262663f 100644 --- a/jobs/osmo-gsm-tester-builder.yml +++ b/jobs/osmo-gsm-tester-builder.yml @@ -17,8 +17,6 @@ - osmo-sgsn - osmo-trx - osmocom-bb - - osmo-nitb: - triggered-by: master-openbsc - osmo-stp: triggered-by: master-libosmo-sccp - osmo-bts-sysmo: diff --git a/scripts/osmocom-build-old-tags-against-master.sh b/scripts/osmocom-build-old-tags-against-master.sh index 5f0d04d..53d97a9 100755 --- a/scripts/osmocom-build-old-tags-against-master.sh +++ b/scripts/osmocom-build-old-tags-against-master.sh @@ -30,7 +30,6 @@ libosmocore libosmo-netif libosmo-sccp - openbsc osmo-bsc osmo-bts osmo-ggsn -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38058?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie58f54c3f2a224fb1e3a0c95bd3ed85e7859fdc9 Gerrit-Change-Number: 38058 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in docker-playground[master]: debian-bookworm-build-arm: FROM: add arm32v7

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/37973?usp=email ) Change subject: debian-bookworm-build-arm: FROM: add arm32v7 ...................................................................... Patch Set 1: (1 comment) File debian-bookworm-build-arm/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/37973/comment/695a2cfa_5b7… : PS1, Line 6: FROM ${REGISTRY}/arm32v7/${UPSTREAM_DISTRO} > we may want to change this file name to mention it's arm32? or it's already implicit vs arm64? IMHO not worth changing, if we add arm64 too we could name it -arm64 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I93986569a9f492237da28fbc534ac5ccd176f120 Gerrit-Change-Number: 37973 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 09:04:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: ansible: update rpi4-raspbian12build-ansible-1

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37974?usp=email ) Change subject: ansible: update rpi4-raspbian12build-ansible-1 ...................................................................... ansible: update rpi4-raspbian12build-ansible-1 Update the SSH key and name of this jenkins node, after it was reinstalled. Related: OS#6549 Change-Id: I36cc7d1e832be790a20192a9e619ef1736886097 --- M ansible/hosts M ansible/util/known_hosts 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/ansible/hosts b/ansible/hosts index 7f846ec..7878dfe 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -11,7 +11,7 @@ build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13 osmocom_jenkins_slave_fstrim=True docker_max_image_space="80 GB" build4-deb12build-ansible ansible_host=2a01:4f8:121:200a::1:3 osmocom_jenkins_slave_fstrim=True docker_max_image_space="80 GB" host2-deb11build-ansible ansible_host=2a01:4f8:120:8470::1:4 osmocom_jenkins_slave_fstrim=True docker_max_image_space="80 GB" -rpi4-raspbian11build-ansible-1 ansible_host=10.9.25.50 docker_max_image_space="20 GB" +rpi4-raspbian12build-ansible-1 ansible_host=10.9.25.50 docker_max_image_space="20 GB" rpi4-raspbian11build-ansible-2 ansible_host=10.9.25.60 docker_max_image_space="20 GB" rpi4-raspbian11build-ansible-3 ansible_host=10.9.25.70 docker_max_image_space="20 GB" lx2-raspbian11build-ansible ansible_host=10.9.25.28 docker_max_image_space="20 GB" jenkins_tmpfs=True diff --git a/ansible/util/known_hosts b/ansible/util/known_hosts index 88bb700..8b7fd8e 100644 --- a/ansible/util/known_hosts +++ b/ansible/util/known_hosts @@ -2,7 +2,7 @@ 2a01:4f8:10b:2ad9::1:13 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIEfg7NNBKjVJGoL3oUDrJCccI2D8podsSPKnRn1aTUge 2a01:4f8:212:3762::1:3 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAICl7tuOgN64+iYuYCtfCKaUbN9IWzKycpKVRgzsjVCPY 2a01:4f8:120:8470::1:4 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIIPKRz2Eg+h6RTREn52n/ip3pzUjRu9pw1XdjWUrvvi/ -10.9.25.50 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIPowg8lZeIGJ6LCLA8U4eSHnnPX90FaVgInDuRi5U9Zq +10.9.25.50 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIKn5hZBA8i3kcCuTORaQtLXf/NqpXxhkoldj9i60GOLo 10.9.25.60 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIOAK6SQXmifMamE1VHL/1GmPkk6KhplzT20jSOwb8PyZ 10.9.25.70 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAILioWTUt6CyZTceSKqy09mtlNUif+ETKTF6whnWuIROx 2a01:4f8:121:200a::1:3 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIGafw2VdeZo4YNvbu8VEBjDrsCFL+ZSbHtvhspNIQ9PR -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37974?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I36cc7d1e832be790a20192a9e619ef1736886097 Gerrit-Change-Number: 37974 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: jobs/{gerrit,master,update-osmo-ci}: add aarch64 case

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/37975?usp=email ) Change subject: jobs/{gerrit,master,update-osmo-ci}: add aarch64 case ...................................................................... Patch Set 1: (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/37975/comment/fd064ada_a267ae2f?usp=… : PS1, Line 181: arm*|aarch64) DOCKER_IMG="$DOCKER_IMG-arm" ;; > didn't you just change this docker image in the previous commit to always pull an arm32? Yes. But the code here runs on the host, it will not use the -arm image if "$(arch)" on the host says "aarch64" without this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaf987d05870d842cd297f5f14c8542bf75835414 Gerrit-Change-Number: 37975 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 09:02:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[master]: configure.ac: Remove ibosmo-sccp dependency

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email ) Change subject: configure.ac: Remove ibosmo-sccp dependency ...................................................................... configure.ac: Remove ibosmo-sccp dependency osmo-msc had probably forever contained a configure.ac dependency to libosmo-sccp (that's the old static library libsccp.a), which was only added to use a single header file (sccp_types.h). This file has recently been migrated to libosmo-sigtran, as libsccp.a has been removed. Change-Id: Ifcdad8684614c95982b6b471a5585dd42a7fb897 --- M TODO-RELEASE M configure.ac M debian/control M doc/manuals/chapters/overview.adoc M src/libmsc/Makefile.am M src/libmsc/neighbor_ident.c M src/libsmpputil/Makefile.am M src/libvlr/Makefile.am M src/osmo-msc/msc_main.c M src/utils/Makefile.am M tests/smpp/Makefile.am 11 files changed, 8 insertions(+), 11 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..02843d4 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-sigtran bump dependency to > 1.9.0 / libosmo-sccp package removal diff --git a/configure.ac b/configure.ac index c0ab55e..49afb7b 100644 --- a/configure.ac +++ b/configure.ac @@ -44,7 +44,6 @@ PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.6.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.9.0) -PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.9.0) PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.13.0) PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.8.0) diff --git a/debian/control b/debian/control index 76cfd7a..43a6334 100644 --- a/debian/control +++ b/debian/control @@ -15,7 +15,6 @@ libsmpp34-dev (>= 1.14.0), libasn1c-dev (>= 0.9.30), libosmocore-dev (>= 1.10.0), - libosmo-sccp-dev (>= 1.9.0), libosmo-sigtran-dev (>= 1.9.0), libosmo-abis-dev (>= 1.6.0), libosmo-mgcp-client-dev (>= 1.13.0), diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc index 0bb47d7..ab09022 100644 --- a/doc/manuals/chapters/overview.adoc +++ b/doc/manuals/chapters/overview.adoc @@ -42,7 +42,7 @@ had an SCCPlite based _A_ interface towards 3rd party MSC implementations. OsmoMSC features a true SCCP/M3UA _A_ interface, which allows running OsmoBSC against this Osmocom based MSC implementation. The new SCCP/M3UA SIGTRAN for - the _A_ interface is implemented in libosmo-sccp, which is used by OsmoMSC + the _A_ interface is implemented in libosmo-sigtran, which is used by OsmoMSC and OsmoBSC (and others), to establish a link via an STP (e.g. OsmoSTP). - Addition of an _IuCS_ interface to allow operating 3G voice services, also diff --git a/src/libmsc/Makefile.am b/src/libmsc/Makefile.am index dff4b2d..3cda322 100644 --- a/src/libmsc/Makefile.am +++ b/src/libmsc/Makefile.am @@ -13,7 +13,6 @@ $(LIBSMPP34_CFLAGS) \ $(LIBASN1C_CFLAGS) \ $(LIBOSMOSIGTRAN_CFLAGS) \ - $(LIBOSMOSCCP_CFLAGS) \ $(LIBOSMOMGCPCLIENT_CFLAGS) \ $(LIBOSMOGSUPCLIENT_CFLAGS) \ $(LIBOSMORANAP_CFLAGS) \ diff --git a/src/libmsc/neighbor_ident.c b/src/libmsc/neighbor_ident.c index b3cdf17..e7d34fa 100644 --- a/src/libmsc/neighbor_ident.c +++ b/src/libmsc/neighbor_ident.c @@ -35,7 +35,7 @@ #include <osmocom/msc/sccp_ran.h> #include <osmocom/msc/cell_id_list.h> -/* XXX greater than or equal to IPA_STRING_MAX (libosmocore) and MAX_PC_STR_LEN (libosmo-sccp). */ +/* XXX greater than or equal to IPA_STRING_MAX (libosmocore) and MAX_PC_STR_LEN (libosmo-sigtran). */ #define NEIGHBOR_IDENT_ADDR_STRING_MAX 64 static struct gsm_network *gsmnet; diff --git a/src/libsmpputil/Makefile.am b/src/libsmpputil/Makefile.am index b180ddf..ee1b790 100644 --- a/src/libsmpputil/Makefile.am +++ b/src/libsmpputil/Makefile.am @@ -3,7 +3,7 @@ -Wall \ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOVTY_CFLAGS) \ - $(LIBOSMOSCCP_CFLAGS) \ + $(LIBOSMOSIGTRAN_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMONETIF_CFLAGS) \ $(LIBOSMOMGCPCLIENT_CFLAGS) \ diff --git a/src/libvlr/Makefile.am b/src/libvlr/Makefile.am index 14cd302..49bf573 100644 --- a/src/libvlr/Makefile.am +++ b/src/libvlr/Makefile.am @@ -3,7 +3,7 @@ -Wall \ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOVTY_CFLAGS) \ - $(LIBOSMOSCCP_CFLAGS) \ + $(LIBOSMOSIGTRAN_CFLAGS) \ $(LIBOSMOMGCPCLIENT_CFLAGS) \ $(LIBOSMOGSUPCLIENT_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c index 913bd21..a4b2ded 100644 --- a/src/osmo-msc/msc_main.c +++ b/src/osmo-msc/msc_main.c @@ -356,7 +356,7 @@ static int msc_vty_is_config_node(struct vty *vty, int node) { - /* Check if libosmo-sccp declares the node in + /* Check if libosmo-sigtran declares the node in * question as config node */ if (osmo_ss7_is_config_node(vty, node)) return 1; diff --git a/src/utils/Makefile.am b/src/utils/Makefile.am index 6069672..335c950 100644 --- a/src/utils/Makefile.am +++ b/src/utils/Makefile.am @@ -34,7 +34,7 @@ smpp_mirror_CFLAGS = \ $(LIBOSMOCORE_CFLAGS) \ - $(LIBOSMOSCCP_CFLAGS) \ + $(LIBOSMOSIGTRAN_CFLAGS) \ $(LIBOSMOMGCPCLIENT_CFLAGS) \ $(LIBSMPP34_CFLAGS) \ $(NULL) diff --git a/tests/smpp/Makefile.am b/tests/smpp/Makefile.am index ff19d3d..8ad5967 100644 --- a/tests/smpp/Makefile.am +++ b/tests/smpp/Makefile.am @@ -9,9 +9,8 @@ -ggdb3 \ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOGSM_CFLAGS) \ - $(LIBOSMOSCCP_CFLAGS) \ + $(LIBOSMOSIGTRAN_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ - $(LIBOSMOSCCP_CFLAGS) \ $(LIBOSMOMGCPCLIENT_CFLAGS) \ $(COVERAGE_CFLAGS) \ $(LIBSMPP34_CFLAGS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ifcdad8684614c95982b6b471a5585dd42a7fb897 Gerrit-Change-Number: 38056 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[master]: configure.ac: Remove ibosmo-sccp dependency

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email ) Change subject: configure.ac: Remove ibosmo-sccp dependency ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: merging now to unbreak osmo-msc-master -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ifcdad8684614c95982b6b471a5585dd42a7fb897 Gerrit-Change-Number: 38056 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 09 Sep 2024 08:32:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-sccp[master]: coverity CID#216830

by fixeria

Attention is currently required from: neels, pespin. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37995?usp=email ) Change subject: coverity CID#216830 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I3e6283154268f97a66b2b3f2ec8e3e9631424434 Gerrit-Change-Number: 37995 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 08:31:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024