September 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bsc[master]: bs11: Mark global private variables as static

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38068?usp=email ) Change subject: bs11: Mark global private variables as static ...................................................................... bs11: Mark global private variables as static Change-Id: I3e1378c0132d8b73c7a3b98c1cbf215235688494 --- M src/osmo-bsc/bts_siemens_bs11.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/bts_siemens_bs11.c b/src/osmo-bsc/bts_siemens_bs11.c index 9e4f091..8ff0b37 100644 --- a/src/osmo-bsc/bts_siemens_bs11.c +++ b/src/osmo-bsc/bts_siemens_bs11.c @@ -95,7 +95,7 @@ emergencyTimer2: 0 minutes */ -unsigned char msg_1[] = +static unsigned char msg_1[] = { NM_MT_BS11_SET_ATTR, NM_OC_SITE_MANAGER, 0xFF, 0xFF, 0xFF, NM_ATT_BS11_ABIS_EXT_TIME, 0x07, @@ -230,7 +230,7 @@ timerHORequest: 3 ,unit 2 SACCH multiframes */ -unsigned char msg_3[] = +static unsigned char msg_3[] = { NM_MT_BS11_SET_ATTR, NM_OC_BS11_HANDOVER, 0x00, 0xFF, 0xFF, 0xD0, 0x00, /* enableDelayPowerBudgetHO */ @@ -301,7 +301,7 @@ enableBSPowerControl: 00h = disabled */ -unsigned char msg_4[] = +static unsigned char msg_4[] = { NM_MT_BS11_SET_ATTR, NM_OC_BS11_PWR_CTRL, 0x00, 0xFF, 0xFF, NM_ATT_BS11_ENA_MS_PWR_CTRL, 0x00, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3e1378c0132d8b73c7a3b98c1cbf215235688494 Gerrit-Change-Number: 38068 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: bs11: Move model struct further down in the file

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38069?usp=email ) Change subject: bs11: Move model struct further down in the file ...................................................................... bs11: Move model struct further down in the file This is where one would usually expect it, so that private model functions can be declared static easily, and next to the function registering it with the core. Change-Id: I4006d4a0df4c7e477a6c731fc55badc782448866 --- M src/osmo-bsc/bts_siemens_bs11.c 1 file changed, 38 insertions(+), 39 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_siemens_bs11.c b/src/osmo-bsc/bts_siemens_bs11.c index 8ff0b37..fe0ef39 100644 --- a/src/osmo-bsc/bts_siemens_bs11.c +++ b/src/osmo-bsc/bts_siemens_bs11.c @@ -32,51 +32,12 @@ #include <osmocom/bsc/timeslot_fsm.h> #include <osmocom/bsc/bts.h> -static int bts_model_bs11_start(struct gsm_network *net); static void bts_model_bs11_e1line_bind_ops(struct e1inp_line *line) { e1inp_line_bind_ops(line, &bts_isdn_e1inp_line_ops); } -static struct gsm_bts_model model_bs11 = { - .type = GSM_BTS_TYPE_BS11, - .name = "bs11", - .start = bts_model_bs11_start, - .oml_rcvmsg = &abis_nm_rcvmsg, - .e1line_bind_ops = bts_model_bs11_e1line_bind_ops, - .nm_att_tlvdef = { - .def = { - [NM_ATT_AVAIL_STATUS] = { TLV_TYPE_TLV }, - /* BS11 specifics */ - [NM_ATT_BS11_ESN_FW_CODE_NO] = { TLV_TYPE_TLV }, - [NM_ATT_BS11_ESN_HW_CODE_NO] = { TLV_TYPE_TLV }, - [NM_ATT_BS11_ESN_PCB_SERIAL] = { TLV_TYPE_TLV }, - [NM_ATT_BS11_BOOT_SW_VERS] = { TLV_TYPE_TLV }, - [0xd5] = { TLV_TYPE_TLV }, - [0xa8] = { TLV_TYPE_TLV }, - [NM_ATT_BS11_PASSWORD] = { TLV_TYPE_TLV }, - [NM_ATT_BS11_TXPWR] = { TLV_TYPE_TLV }, - [NM_ATT_BS11_RSSI_OFFS] = { TLV_TYPE_TLV }, - [NM_ATT_BS11_LINE_CFG] = { TLV_TYPE_TV }, - [NM_ATT_BS11_L1_PROT_TYPE] = { TLV_TYPE_TV }, - [NM_ATT_BS11_BIT_ERR_THESH] = { TLV_TYPE_FIXED, 2 }, - [NM_ATT_BS11_DIVERSITY] = { TLV_TYPE_TLV }, - [NM_ATT_BS11_LMT_LOGON_SESSION]={ TLV_TYPE_TLV }, - [NM_ATT_BS11_LMT_LOGIN_TIME] = { TLV_TYPE_TLV }, - [NM_ATT_BS11_LMT_USER_ACC_LEV] ={ TLV_TYPE_TLV }, - [NM_ATT_BS11_LMT_USER_NAME] = { TLV_TYPE_TLV }, - [NM_ATT_BS11_BTS_STATE] = { TLV_TYPE_TLV }, - [NM_ATT_BS11_E1_STATE] = { TLV_TYPE_TLV }, - [NM_ATT_BS11_PLL_MODE] = { TLV_TYPE_TLV }, - [NM_ATT_BS11_PLL] = { TLV_TYPE_TLV }, - [NM_ATT_BS11_CCLK_ACCURACY] = { TLV_TYPE_TV }, - [NM_ATT_BS11_CCLK_TYPE] = { TLV_TYPE_TV }, - [0x95] = { TLV_TYPE_FIXED, 2 }, - }, - }, -}; - /* The following definitions are for OM and NM packets that we cannot yet * generate by code but we just pass on */ @@ -582,6 +543,44 @@ return 0; } +static struct gsm_bts_model model_bs11 = { + .type = GSM_BTS_TYPE_BS11, + .name = "bs11", + .start = bts_model_bs11_start, + .oml_rcvmsg = &abis_nm_rcvmsg, + .e1line_bind_ops = bts_model_bs11_e1line_bind_ops, + .nm_att_tlvdef = { + .def = { + [NM_ATT_AVAIL_STATUS] = { TLV_TYPE_TLV }, + /* BS11 specifics */ + [NM_ATT_BS11_ESN_FW_CODE_NO] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_ESN_HW_CODE_NO] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_ESN_PCB_SERIAL] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_BOOT_SW_VERS] = { TLV_TYPE_TLV }, + [0xd5] = { TLV_TYPE_TLV }, + [0xa8] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_PASSWORD] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_TXPWR] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_RSSI_OFFS] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_LINE_CFG] = { TLV_TYPE_TV }, + [NM_ATT_BS11_L1_PROT_TYPE] = { TLV_TYPE_TV }, + [NM_ATT_BS11_BIT_ERR_THESH] = { TLV_TYPE_FIXED, 2 }, + [NM_ATT_BS11_DIVERSITY] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_LMT_LOGON_SESSION] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_LMT_LOGIN_TIME] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_LMT_USER_ACC_LEV] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_LMT_USER_NAME] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_BTS_STATE] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_E1_STATE] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_PLL_MODE] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_PLL] = { TLV_TYPE_TLV }, + [NM_ATT_BS11_CCLK_ACCURACY] = { TLV_TYPE_TV }, + [NM_ATT_BS11_CCLK_TYPE] = { TLV_TYPE_TV }, + [0x95] = { TLV_TYPE_FIXED, 2 }, + }, + }, +}; + int bts_model_bs11_init(void) { model_bs11.features.data = &model_bs11._features_data[0]; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38069?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4006d4a0df4c7e477a6c731fc55badc782448866 Gerrit-Change-Number: 38069 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: bs11: Move model struct further down in the file

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38069?usp=email ) Change subject: bs11: Move model struct further down in the file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38069?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4006d4a0df4c7e477a6c731fc55badc782448866 Gerrit-Change-Number: 38069 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 15:59:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: bs11: Mark global private variables as static

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38068?usp=email ) Change subject: bs11: Mark global private variables as static ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3e1378c0132d8b73c7a3b98c1cbf215235688494 Gerrit-Change-Number: 38068 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 15:59:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in libosmo-netif[master]: coverity CID#216829

by pespin

Attention is currently required from: fixeria, neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37992?usp=email ) Change subject: coverity CID#216829 ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: I updated the patch myself since I was anyway fixing the issue you reported as a follow-up patch. Please @nhofmeyr@sysmocom.de review and if you agree let's merge both. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37992?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I30beeac45ff2d8c08905986af9fabfda071ddc5b Gerrit-Change-Number: 37992 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 15:26:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 2 weeks

1
0
0 0

[XL] Change in pysim[master]: Add testsuite for pySim-shell with real cards

by dexter

Attention is currently required from: dexter, fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email to look at the new patch set (#19). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add testsuite for pySim-shell with real cards ...................................................................... Add testsuite for pySim-shell with real cards This patch adds a comprehensive testsuite for pySim-shell. The testsuite is based on python's unittest framework in combination with pySim-shell scripts. Related: OS#6531 Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de --- M contrib/jenkins.sh A tests/pySim-shell_test/README.txt A tests/pySim-shell_test/__init__.py A tests/pySim-shell_test/ara_m/__init__.py A tests/pySim-shell_test/ara_m/adf_ara-m.cfg.ok A tests/pySim-shell_test/ara_m/adf_ara-m.script.ok A tests/pySim-shell_test/ara_m/adf_ara-m_empty.cfg.ok A tests/pySim-shell_test/ara_m/test.py A tests/pySim-shell_test/ara_m/test.script A tests/pySim-shell_test/authenticate/__init__.py A tests/pySim-shell_test/authenticate/auth_result.ok A tests/pySim-shell_test/authenticate/test.py A tests/pySim-shell_test/authenticate/test.script A tests/pySim-shell_test/card_data.csv A tests/pySim-shell_test/cardinfo/__init__.py A tests/pySim-shell_test/cardinfo/sysmoEUICC1-C2T-cardinfo.ok A tests/pySim-shell_test/cardinfo/sysmoISIM-SJA2-cardinfo.ok A tests/pySim-shell_test/cardinfo/sysmoISIM-SJA5-S17-cardinfo.ok A tests/pySim-shell_test/cardinfo/sysmoSIM-GR1-cardinfo.ok A tests/pySim-shell_test/cardinfo/test.py A tests/pySim-shell_test/cardinfo/test.template A tests/pySim-shell_test/chv/__init__.py A tests/pySim-shell_test/chv/test.py A tests/pySim-shell_test/chv/test_manage_csv.ok A tests/pySim-shell_test/chv/test_manage_csv.template A tests/pySim-shell_test/chv/test_manage_direct.ok A tests/pySim-shell_test/chv/test_manage_direct.template A tests/pySim-shell_test/chv/test_unblock_csv.ok A tests/pySim-shell_test/chv/test_unblock_csv.script A tests/pySim-shell_test/chv/test_unblock_direct.ok A tests/pySim-shell_test/chv/test_unblock_direct.template A tests/pySim-shell_test/config.yaml A tests/pySim-shell_test/euicc/__init__.py A tests/pySim-shell_test/euicc/enable_disable_profile.ok A tests/pySim-shell_test/euicc/euicc_info1.ok A tests/pySim-shell_test/euicc/euicc_info2.ok A tests/pySim-shell_test/euicc/get_eid.ok A tests/pySim-shell_test/euicc/get_profiles_info.ok A tests/pySim-shell_test/euicc/notifications.ok A tests/pySim-shell_test/euicc/set_nickname.ok A tests/pySim-shell_test/euicc/test.py A tests/pySim-shell_test/euicc/test_enable_disable_profile.script A tests/pySim-shell_test/euicc/test_gen_notif.script A tests/pySim-shell_test/euicc/test_get_eid.script A tests/pySim-shell_test/euicc/test_get_euicc_info.script A tests/pySim-shell_test/euicc/test_get_profiles_info.script A tests/pySim-shell_test/euicc/test_list_notif.script A tests/pySim-shell_test/euicc/test_rm_notif.template A tests/pySim-shell_test/euicc/test_set_nickname.script A tests/pySim-shell_test/export/__init__.py A tests/pySim-shell_test/export/export.script.ok A tests/pySim-shell_test/export/test.py A tests/pySim-shell_test/export/test.script A tests/pySim-shell_test/file_admin/__init__.py A tests/pySim-shell_test/file_admin/activate_deactivate_file.ok A tests/pySim-shell_test/file_admin/test.py A tests/pySim-shell_test/file_admin/test_activate_deactivate_file.script A tests/pySim-shell_test/file_admin/test_create_delete_df.script A tests/pySim-shell_test/file_admin/test_create_resize_delete_linear_fixed_ef.script A tests/pySim-shell_test/file_admin/test_create_resize_delete_transparent_ef.script A tests/pySim-shell_test/file_content/__init__.py A tests/pySim-shell_test/file_content/test.py A tests/pySim-shell_test/file_content/test_ber_tlv_uicc.ok A tests/pySim-shell_test/file_content/test_ber_tlv_uicc.script A tests/pySim-shell_test/file_content/test_binary_sim.ok A tests/pySim-shell_test/file_content/test_binary_sim.script A tests/pySim-shell_test/file_content/test_binary_uicc.ok A tests/pySim-shell_test/file_content/test_binary_uicc.script A tests/pySim-shell_test/file_content/test_record_sim.ok A tests/pySim-shell_test/file_content/test_record_sim.script A tests/pySim-shell_test/file_content/test_record_uicc.ok A tests/pySim-shell_test/file_content/test_record_uicc.script A tests/pySim-shell_test/file_specific/__init__.py A tests/pySim-shell_test/file_specific/ef_imsi.ok A tests/pySim-shell_test/file_specific/test.py A tests/pySim-shell_test/file_specific/test_ef_ist.ok A tests/pySim-shell_test/file_specific/test_ef_ist.script A tests/pySim-shell_test/file_specific/test_ef_ust.ok A tests/pySim-shell_test/file_specific/test_ef_ust.script A tests/pySim-shell_test/file_specific/test_update_imsi_plmn.script A tests/pySim-shell_test/fsdump/__init__.py A tests/pySim-shell_test/fsdump/fsdump.json.ok A tests/pySim-shell_test/fsdump/test.py A tests/pySim-shell_test/fsdump/test.script A tests/pySim-shell_test/get_identity/__init__.py A tests/pySim-shell_test/get_identity/test.py A tests/pySim-shell_test/get_identity/test.script A tests/pySim-shell_test/gp/__init__.py A tests/pySim-shell_test/gp/get_status_isd.ok A tests/pySim-shell_test/gp/key_information.ok A tests/pySim-shell_test/gp/test.py A tests/pySim-shell_test/gp/test_est_scp02_csv.script A tests/pySim-shell_test/gp/test_est_scp02_direct.template A tests/pySim-shell_test/gp/test_est_scp03_csv.script A tests/pySim-shell_test/gp/test_est_scp03_direct.template A tests/pySim-shell_test/gp/test_get_status.script A tests/pySim-shell_test/gp/test_put_delete_key.script A tests/pySim-shell_test/lchan/__init__.py A tests/pySim-shell_test/lchan/test.ok A tests/pySim-shell_test/lchan/test.py A tests/pySim-shell_test/lchan/test.script A tests/pySim-shell_test/navigate_fs/__init__.py A tests/pySim-shell_test/navigate_fs/checkpoints_sim.ok A tests/pySim-shell_test/navigate_fs/checkpoints_uicc.ok A tests/pySim-shell_test/navigate_fs/test.py A tests/pySim-shell_test/navigate_fs/test_sim.script A tests/pySim-shell_test/navigate_fs/test_uicc.script A tests/pySim-shell_test/utils.py A tests/pySim-shell_test/verify_adm/__init__.py A tests/pySim-shell_test/verify_adm/test.py A tests/pySim-shell_test/verify_adm/test_cmdline.script A tests/pySim-shell_test/verify_adm/test_csv.script A tests/pySim-shell_test/verify_adm/test_direct.template 113 files changed, 22,411 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/19/37819/19 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de Gerrit-Change-Number: 37819 Gerrit-PatchSet: 19 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: Introduce PCRF_Tests testsuite

by pespin

Attention is currently required from: osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38028?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Introduce PCRF_Tests testsuite ...................................................................... Introduce PCRF_Tests testsuite Change-Id: I381577111ccadaefe42f6abe3cd9bb30cc8ceb56 --- M Makefile M library/DIAMETER_Templates.ttcn M library/DIAMETER_ts29_212_Templates.ttcn A pcrf/PCRF_Tests.cfg A pcrf/PCRF_Tests.default A pcrf/PCRF_Tests.ttcn A pcrf/create_test_subscribers.sh A pcrf/expected-results.xml A pcrf/freediameter.conf A pcrf/gen_links.sh A pcrf/mongod.conf A pcrf/open5gs-pcrf.yaml A pcrf/regen_makefile.sh A pcrf/testenv.cfg 14 files changed, 796 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/28/38028/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38028?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I381577111ccadaefe42f6abe3cd9bb30cc8ceb56 Gerrit-Change-Number: 38028 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: cosmetic: Fix same typo in comment in several files

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38070?usp=email ) Change subject: cosmetic: Fix same typo in comment in several files ...................................................................... cosmetic: Fix same typo in comment in several files Change-Id: Id59e09b0ac89251175ecee23e7f9d1a058644aa8 --- M ggsn_tests/GGSN_Tests.ttcn M hss/HSS_Tests.ttcn M pgw/PGW_Tests.ttcn 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/70/38070/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 70bb1c3..c151346 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -274,7 +274,7 @@ f_diameter_wait_capability(Gx_UNIT); f_diameter_wait_capability(Gy_UNIT); - /* Give some time for our emulation to get out of SUSPECT list of SUT (3 watchdong ping-pongs): + /* Give some time for our emulation to get out of SUSPECT list of SUT (3 watchdog ping-pongs): * RFC6733 sec 5.1 * RFC3539 sec 3.4.1 [5] * https://github.com/freeDiameter/freeDiameter/blob/master/libfdcore/p_psm.c#… diff --git a/hss/HSS_Tests.ttcn b/hss/HSS_Tests.ttcn index 5c4f765..1838619 100644 --- a/hss/HSS_Tests.ttcn +++ b/hss/HSS_Tests.ttcn @@ -143,7 +143,7 @@ vc_S6a.start(DIAMETER_Emulation.main(ops, pars, id)); f_diameter_wait_capability(S6a_UNIT); - /* Give some time for our emulation to get out of SUSPECT list of SUT (3 watchdong ping-pongs): + /* Give some time for our emulation to get out of SUSPECT list of SUT (3 watchdog ping-pongs): * RFC6733 sec 5.1 * RFC3539 sec 3.4.1 [5] * https://github.com/freeDiameter/freeDiameter/blob/master/libfdcore/p_psm.c#… diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index 08cd1a0..4a4f77f 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -272,7 +272,7 @@ f_diameter_wait_capability(Gx_UNIT); f_diameter_wait_capability(Gy_UNIT); f_diameter_wait_capability(S6b_UNIT); - /* Give some time for our emulation to get out of SUSPECT list of SUT (3 watchdong ping-pongs): + /* Give some time for our emulation to get out of SUSPECT list of SUT (3 watchdog ping-pongs): * RFC6733 sec 5.1 * RFC3539 sec 3.4.1 [5] * https://github.com/freeDiameter/freeDiameter/blob/master/libfdcore/p_psm.c#… -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38070?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id59e09b0ac89251175ecee23e7f9d1a058644aa8 Gerrit-Change-Number: 38070 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: Introduce PCRF_Tests testsuite

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38028?usp=email ) Change subject: Introduce PCRF_Tests testsuite ...................................................................... Patch Set 2: (1 comment) File pcrf/PCRF_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38028/comment/51c715d0_6814… : PS2, Line 148: watchdong > watchdog? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38028?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I381577111ccadaefe42f6abe3cd9bb30cc8ceb56 Gerrit-Change-Number: 38028 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 15:13:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: lapdm: remove

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38067?usp=email ) Change subject: lapdm: remove ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38067?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6aae060a5b252d3ab36378da8c721154b3186466 Gerrit-Change-Number: 38067 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Sep 2024 15:12:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024