September 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: gerrit-verifications,master-builds: Add pyosmocom

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ci/+/38024?usp=email ) Change subject: gerrit-verifications,master-builds: Add pyosmocom ...................................................................... Patch Set 4: (1 comment) File jobs/master-builds.yml: https://gerrit.osmocom.org/c/osmo-ci/+/38024/comment/b105067a_189adb48?usp=… : PS4, Line 425: a1: !!python/tuple ["test", "pylint", "docs"] this is different from gerrit-verifications. should be the same? otherwise LGTM -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9ec289f8d3116bbc8291298146c58d0209684439 Gerrit-Change-Number: 38024 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Sep 2024 12:35:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: gerrit-verifications,master-builds: Add pyosmocom

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ci/+/38024?usp=email ) Change subject: gerrit-verifications,master-builds: Add pyosmocom ...................................................................... Patch Set 4: (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/38024/comment/7d72757f_fe2231e6?usp=… : PS1, Line 319: #pipeline_binpkgs: "debian:10 debian:12" > This comment can be dropped? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9ec289f8d3116bbc8291298146c58d0209684439 Gerrit-Change-Number: 38024 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Sep 2024 12:33:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: gerrit-verifications,master-builds: Add pyosmocom

by laforge

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/38024?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gerrit-verifications,master-builds: Add pyosmocom ...................................................................... gerrit-verifications,master-builds: Add pyosmocom Change-Id: I9ec289f8d3116bbc8291298146c58d0209684439 --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/24/38024/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9ec289f8d3116bbc8291298146c58d0209684439 Gerrit-Change-Number: 38024 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in ...pyosmocom[master]: contrib/jenkins.sh: Fix unittest discovery

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38096?usp=email ) Change subject: contrib/jenkins.sh: Fix unittest discovery ...................................................................... contrib/jenkins.sh: Fix unittest discovery With the 'src-layout', we cannot rely on unittst finding the code to test, as it's in a sub-directory. Let's change to the 'src' directory before calling unittest. Change-Id: I9c6025d50d8e4c290660805890146881d49d1f38 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index cbe2f39..afd66eb 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -19,7 +19,7 @@ pip install -r requirements.txt # Execute automatically discovered unit tests - python -m unittest discover -v -s tests/ + (cd src && python -m unittest discover -v -s ../tests/) ;; "distcheck") -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I9c6025d50d8e4c290660805890146881d49d1f38 Gerrit-Change-Number: 38096 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[XS] Change in ...pyosmocom[master]: contrib/jenkins.sh: Fix unittest discovery

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38096?usp=email ) Change subject: contrib/jenkins.sh: Fix unittest discovery ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I9c6025d50d8e4c290660805890146881d49d1f38 Gerrit-Change-Number: 38096 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 11 Sep 2024 12:32:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: gerrit-verifications,master-builds: Add pyosmocom

by laforge

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/38024?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: gerrit-verifications,master-builds: Add pyosmocom ...................................................................... gerrit-verifications,master-builds: Add pyosmocom Change-Id: I9ec289f8d3116bbc8291298146c58d0209684439 --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/24/38024/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9ec289f8d3116bbc8291298146c58d0209684439 Gerrit-Change-Number: 38024 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: …gerrit/comment generate: make error more helpful

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38097?usp=email ) Change subject: …gerrit/comment_generate: make error more helpful ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iec5f4cde53b763bb6c814934abcc83e39518566f Gerrit-Change-Number: 38097 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Sep 2024 12:23:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: …gerrit/comment generate: make error more helpful

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38097?usp=email ) Change subject: …gerrit/comment_generate: make error more helpful ...................................................................... …gerrit/comment_generate: make error more helpful The start of a stage may also not be found if the related -build job was not deployed. This was not obvious before, add a hint to the error message. Change-Id: Iec5f4cde53b763bb6c814934abcc83e39518566f --- M scripts/jenkins-gerrit/comment_generate.py 1 file changed, 12 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/97/38097/1 diff --git a/scripts/jenkins-gerrit/comment_generate.py b/scripts/jenkins-gerrit/comment_generate.py index e127c4c..a2aec0e 100755 --- a/scripts/jenkins-gerrit/comment_generate.py +++ b/scripts/jenkins-gerrit/comment_generate.py @@ -6,6 +6,7 @@ import json import re import urllib.request +import sys jenkins_url = "https://jenkins.osmocom.org" re_start_build = re.compile("Starting building: gerrit-[a-zA-Z-_0-9]* #[0-9]*") @@ -94,11 +95,17 @@ if stage.startswith("comment_"): # Jobs that run this script, not relevant for summary continue - assert stage in ret, f"found result for stage {stage}, but" \ - " didn't find where it was started. The" \ - " re_start_build regex probably needs to be adjusted" \ - " to match the related gerrit-*-build job.\n\n" \ - f"ret: {ret}" + if stage not in ret: + print(f"URL: {url}") + print() + print(f"ERROR: found result for stage {stage}, but didn't" + " find where it was started. Possible reasons:") + print("* The re_stat_build regex needs to be adjusted" + " to match the related gerrit-*-build job") + print("* The gerrit-*-build job has not been deployed," + " and therefore could not be started by the" + " gerrit-* job.") + sys.exit(1) ret[stage]["passed"] = (match.group(2) == "SUCCESS") return ret -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iec5f4cde53b763bb6c814934abcc83e39518566f Gerrit-Change-Number: 38097 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in ...pyosmocom[master]: contrib/jenkins.sh: Fix unittest discovery

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38096?usp=email ) Change subject: contrib/jenkins.sh: Fix unittest discovery ...................................................................... contrib/jenkins.sh: Fix unittest discovery With the 'src-layout', we cannot rely on unittst finding the code to test, as it's in a sub-directory. Let's change to the 'src' directory before calling unittest. Change-Id: I9c6025d50d8e4c290660805890146881d49d1f38 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/96/38096/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index cbe2f39..afd66eb 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -19,7 +19,7 @@ pip install -r requirements.txt # Execute automatically discovered unit tests - python -m unittest discover -v -s tests/ + (cd src && python -m unittest discover -v -s ../tests/) ;; "distcheck") -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I9c6025d50d8e4c290660805890146881d49d1f38 Gerrit-Change-Number: 38096 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: scripts/build-old-tags: build libosmo-sccp-legacy

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38095?usp=email ) Change subject: scripts/build-old-tags: build libosmo-sccp-legacy ...................................................................... scripts/build-old-tags: build libosmo-sccp-legacy Fix building old osmo-msc versions, after libosmo-sccp has been deprecated. Related: OS#6239 Change-Id: I2601d747b4258146b485cdc65aa1fc7ecc58e268 --- M scripts/common.sh M scripts/osmocom-build-old-tags-against-master.sh 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/scripts/common.sh b/scripts/common.sh index 48ce3a8..b4ab685 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -145,7 +145,7 @@ strongswan-epdg) echo "$OSMO_GIT_URL_GITEA"/ims-volte-vowifi/strongswan ;; - pyosmocom) + pyosmocom|libosmo-sccp-legacy) echo "$OSMO_GIT_URL_GITEA"/osmocom/"$1" ;; osmo_dia2gsup|osmo-epdg|osmo-s1gw) diff --git a/scripts/osmocom-build-old-tags-against-master.sh b/scripts/osmocom-build-old-tags-against-master.sh index 53d97a9..6d20591 100755 --- a/scripts/osmocom-build-old-tags-against-master.sh +++ b/scripts/osmocom-build-old-tags-against-master.sh @@ -17,6 +17,7 @@ libosmo-abis libosmo-netif libosmo-sccp + libosmo-sccp-legacy libsmpp34 libasn1c osmo-ggsn -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2601d747b4258146b485cdc65aa1fc7ecc58e268 Gerrit-Change-Number: 38095 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024