September 2024 - gerrit-log - lists.osmocom.org

[XS] Change in docker-playground[master]: debian-bookworm-build-arm: FROM: add arm32v7

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/37973?usp=email ) Change subject: debian-bookworm-build-arm: FROM: add arm32v7 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: merging this trivial patch too, since the rest of https://gerrit.osmocom.org/q/topic:%22rpi4-1%22 has been merged -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I93986569a9f492237da28fbc534ac5ccd176f120 Gerrit-Change-Number: 37973 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Sep 2024 08:18:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: scripts/manuals: ignore pyosmocom 0.0.1, 0.0.2

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38089?usp=email ) Change subject: scripts/manuals: ignore pyosmocom 0.0.1, 0.0.2 ...................................................................... scripts/manuals: ignore pyosmocom 0.0.1, 0.0.2 These tags don't have scripts to generate and publish manuals yet. Change-Id: I1dc9eec3fff836c507686e61657ca1b69d43c845 --- M scripts/manuals/publish-manuals-for-tags.sh 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/89/38089/1 diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh index 3e3baf3..8ca34a6 100755 --- a/scripts/manuals/publish-manuals-for-tags.sh +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -200,6 +200,9 @@ osmo-trx:0.4.0, pysim:1.0, + + pyosmocom:0.0.1, + pyosmocom:0.0.2, " mkdir -p \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38089?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1dc9eec3fff836c507686e61657ca1b69d43c845 Gerrit-Change-Number: 38089 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmo-gsm-tester-build: fix Missing parameter

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38088?usp=email ) Change subject: jobs/osmo-gsm-tester-build: fix Missing parameter ...................................................................... jobs/osmo-gsm-tester-build: fix Missing parameter Use OSMO_GSM_TESTER_BRANCH as shell variable ('$...'), not as jenkins job builder parameter (${...}). This is how we do it in other jobs as well, e.g. jobs/osmocom-obs.yml. Apparently the workaround in the file happened to work earlier, but it does not work anymore with Jenkins Job Builder version 6.3.0. Remove it. Fix for: osmo-gsm-tester-builder.yml:119:15: While formatting string '${OSMO_GSM_TESTER_BRANCH}': Missing parameter: 'OSMO_GSM_TESTER_BRANCH' - ${OSMO_GSM_TESTER_BRANCH} ^ Change-Id: I3b6b16964a4d8a51fd3ecc0d670805182a8c6586 --- M jobs/osmo-gsm-tester-builder.yml 1 file changed, 1 insertion(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/88/38088/1 diff --git a/jobs/osmo-gsm-tester-builder.yml b/jobs/osmo-gsm-tester-builder.yml index 262663f..ba925d0 100644 --- a/jobs/osmo-gsm-tester-builder.yml +++ b/jobs/osmo-gsm-tester-builder.yml @@ -106,17 +106,10 @@ - add_param_build_branch: name: OSMO_GSM_TESTER_BUILD_srslte scm: - - osmo-gsm-tester-repo - -# The repo must be used seperate to workaround the bug "Can not expand OSMO_GSM_TESTER_BRANCH". -# The safe-guard check to not use un-defined variables seems to be broken. -- scm: - name: osmo-gsm-tester-repo - scm: - git: url: https://gerrit.osmocom.org/osmo-gsm-tester branches: - - ${OSMO_GSM_TESTER_BRANCH} + - '$OSMO_GSM_TESTER_BRANCH' wipe-workspace: false skip-tag: true basedir: osmo-gsm-tester -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3b6b16964a4d8a51fd3ecc0d670805182a8c6586 Gerrit-Change-Number: 38088 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: Introduce hashtable to lookup bts by LAC

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38087?usp=email ) Change subject: Introduce hashtable to lookup bts by LAC ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/neighbor_ident.c: https://gerrit.osmocom.org/c/osmo-bsc/+/38087/comment/b0bae32c_2cc7dfd3?usp… : PS2, Line 381: f (bts_tmp->location_area_code != lac) : continue; > Not really. […] ah, nevermind. Of course, I knew that... Not sure what I was thinking. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38087?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id523027b49e0f58cd2c8c9b4dee619de415dbd15 Gerrit-Change-Number: 38087 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Sep 2024 06:06:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in pysim[master]: pySim.euicc: Add 'get_data sgp02_eid' in ADF.ECASD of M2M eUICC

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38048?usp=email ) Change subject: pySim.euicc: Add 'get_data sgp02_eid' in ADF.ECASD of M2M eUICC ...................................................................... pySim.euicc: Add 'get_data sgp02_eid' in ADF.ECASD of M2M eUICC The M2M eUICC are completely different from the consumer/IoT eUICC. Obtaining the EID works via GET DATA in the ECASD. Let's add support for that. Change-Id: I6cca6f75d268229244c90b3f1f88e26c89a2b4e0 --- M pySim/euicc.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/euicc.py b/pySim/euicc.py index 1ad0f22..c7b59d9 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -35,6 +35,13 @@ from pySim.commands import SimCardCommands import pySim.global_platform +# SGP.02 Section 2.2.2 +class Sgp02Eid(BER_TLV_IE, tag=0x5a): + _construct = BcdAdapter(GreedyBytes) + +# patch this into global_platform, to allow 'get_data sgp02_eid' in EF.ECASD +pySim.global_platform.DataCollection.possible_nested.append(Sgp02Eid) + def compute_eid_checksum(eid) -> str: """Compute and add/replace check digits of an EID value according to GSMA SGP.29 Section 10.""" if isinstance(eid, str): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6cca6f75d268229244c90b3f1f88e26c89a2b4e0 Gerrit-Change-Number: 38048 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[XS] Change in pysim[master]: pySim.commands: use _checksw during get_data() method

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38047?usp=email ) Change subject: pySim.commands: use _checksw during get_data() method ...................................................................... pySim.commands: use _checksw during get_data() method All other methods use send_apdu_checksw, just get_data() was missing the _checksw part. Change-Id: Ic784bf0c30b22e5e83843aa6694e2706b4b2ac48 --- M pySim/commands.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/commands.py b/pySim/commands.py index f13e18b..5c5933a 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -794,8 +794,9 @@ data, sw = self.send_apdu_checksw('8076010008' + token, apply_lchan = False) return (data, sw) + # GPC_SPE_034 11.3 def get_data(self, tag: int, cla: int = 0x00): - data, sw = self.send_apdu('%02xca%04x00' % (cla, tag)) + data, sw = self.send_apdu_checksw('%02xca%04x00' % (cla, tag)) return (data, sw) # TS 31.102 Section 7.5.2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic784bf0c30b22e5e83843aa6694e2706b4b2ac48 Gerrit-Change-Number: 38047 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: Introduce hashtable to lookup bts by LAC

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38087?usp=email ) Change subject: Introduce hashtable to lookup bts by LAC ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/neighbor_ident.c: https://gerrit.osmocom.org/c/osmo-bsc/+/38087/comment/e0dd77a6_e2d31952?usp… : PS2, Line 381: f (bts_tmp->location_area_code != lac) : continue; > shouldn't this be now an error message in all of those iterations (not just this function)? After a […] Not really. AFAIU different LACs can end up in the same hashtable bucket/llist due to hashing function, it's totally fine and expected... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38087?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id523027b49e0f58cd2c8c9b4dee619de415dbd15 Gerrit-Change-Number: 38087 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 Sep 2024 23:05:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: gsm_bts_num(): use hashtable to lookup bts

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38085?usp=email ) Change subject: gsm_bts_num(): use hashtable to lookup bts ...................................................................... Patch Set 1: (1 comment) File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/38085/comment/a30acea1_83d1b034?usp… : PS1, Line 990: 6 > why only 6? In very small lab type setups, a few more hash buckets will not matter performance-wise. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38085?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7312da7d9aa80c6d0f2e92e9c7d20d32ce453ad1 Gerrit-Change-Number: 38085 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 Sep 2024 23:01:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: bts: Remove from net->bts_list during talloc destructor

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38083?usp=email ) Change subject: bts: Remove from net->bts_list during talloc destructor ...................................................................... bts: Remove from net->bts_list during talloc destructor This went unnoticed because so far there's not clear way to free a BTS, eg. through VTY. Change-Id: I2bb1d51541c79e417c0359830e9f095be4669867 --- M src/osmo-bsc/bts.c M src/osmo-bsc/gsm_data.c M tests/acc/acc_test.c M tests/gsm0408/gsm0408_test.c M tests/paging/paging_test.c 5 files changed, 5 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 0d33427..50a8579 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -158,6 +158,8 @@ { /* Entries in bts->loc_list are freed by talloc recursively, no need to free them here. */ + llist_del(&bts->list); + paging_destructor(bts); bts_setup_ramp_remove(bts); @@ -193,6 +195,9 @@ talloc_set_destructor(bts, gsm_bts_talloc_destructor); + llist_add_tail(&bts->list, &net->bts_list); + net->num_bts++; + bts->nr = bts_num; bts->num_trx = 0; INIT_LLIST_HEAD(&bts->trx_list); diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 87e3893..d5c74ad 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -96,14 +96,10 @@ return NULL; bts = bts_sm->bts[0]; - net->num_bts++; - bts->type = type; gsm_set_bts_model(bts, model); bts->bsic = bsic; - llist_add_tail(&bts->list, &net->bts_list); - return bts; } diff --git a/tests/acc/acc_test.c b/tests/acc/acc_test.c index 887e891..3dcdc1b 100644 --- a/tests/acc/acc_test.c +++ b/tests/acc/acc_test.c @@ -60,7 +60,6 @@ { osmo_timer_del(&bts->acc_mgr.rotate_timer); osmo_timer_del(&bts->acc_ramp.step_timer); - /* no need to llist_del(&bts->list), we never registered the bts there. */ talloc_free(bts->site_mgr); fprintf(stderr, "BTS deallocated OK in %s()\n", msg); } diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c index a39f8c2..b35df60 100644 --- a/tests/gsm0408/gsm0408_test.c +++ b/tests/gsm0408/gsm0408_test.c @@ -138,7 +138,6 @@ static inline void _bts_del(struct gsm_bts *bts, const char *msg) { osmo_timer_del(&bts->acc_mgr.rotate_timer); - /* no need to llist_del(&bts->list), we never registered the bts there. */ talloc_free(bts->site_mgr); printf("BTS deallocated OK in %s()\n", msg); } diff --git a/tests/paging/paging_test.c b/tests/paging/paging_test.c index 80aaee1..dae3499 100644 --- a/tests/paging/paging_test.c +++ b/tests/paging/paging_test.c @@ -97,7 +97,6 @@ #define bts_del(bts) _bts_del(bts, __func__) static inline void _bts_del(struct gsm_bts *bts, const char *msg) { - /* no need to llist_del(&bts->list), we never registered the bts there. */ talloc_free(bts->site_mgr); fprintf(stderr, "BTS deallocated OK in %s()\n", msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38083?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2bb1d51541c79e417c0359830e9f095be4669867 Gerrit-Change-Number: 38083 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: bts: Remove acc timers during talloc destructor

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38084?usp=email ) Change subject: bts: Remove acc timers during talloc destructor ...................................................................... bts: Remove acc timers during talloc destructor This went unnoticed because so far there's not clear way to free a BTS, eg. through VTY. Change-Id: I0f94d8fc775953ee98eebc4d80f825404c4f92b2 --- M include/osmocom/bsc/acc.h M src/osmo-bsc/acc.c M src/osmo-bsc/bts.c M tests/acc/acc_test.c M tests/gsm0408/gsm0408_test.c 5 files changed, 21 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/include/osmocom/bsc/acc.h b/include/osmocom/bsc/acc.h index 531a69a..5674825 100644 --- a/include/osmocom/bsc/acc.h +++ b/include/osmocom/bsc/acc.h @@ -53,6 +53,7 @@ }; void acc_mgr_init(struct acc_mgr *acc_mgr, struct gsm_bts *bts); +void acc_mgr_deinit(struct acc_mgr *acc_mgr); uint8_t acc_mgr_get_len_allowed_adm(struct acc_mgr *acc_mgr); uint8_t acc_mgr_get_len_allowed_ramp(struct acc_mgr *acc_mgr); void acc_mgr_set_len_allowed_adm(struct acc_mgr *acc_mgr, uint8_t len_allowed_adm); @@ -164,6 +165,7 @@ void acc_ramp_global_init(void); void acc_ramp_init(struct acc_ramp *acc_ramp, struct gsm_bts *bts); +void acc_ramp_deinit(struct acc_ramp *acc_ramp); int acc_ramp_set_step_size(struct acc_ramp *acc_ramp, unsigned int step_size); int acc_ramp_set_step_interval(struct acc_ramp *acc_ramp, unsigned int step_interval); int acc_ramp_set_chan_load_thresholds(struct acc_ramp *acc_ramp, unsigned int low_threshold, unsigned int up_threshold); diff --git a/src/osmo-bsc/acc.c b/src/osmo-bsc/acc.c index 80a3576..4b5aba0 100644 --- a/src/osmo-bsc/acc.c +++ b/src/osmo-bsc/acc.c @@ -296,6 +296,11 @@ acc_mgr_gen_subset(acc_mgr, false); } +void acc_mgr_deinit(struct acc_mgr *acc_mgr) +{ + osmo_timer_del(&acc_mgr->rotate_timer); +} + uint8_t acc_mgr_get_len_allowed_adm(struct acc_mgr *acc_mgr) { return acc_mgr->len_allowed_adm; @@ -475,6 +480,17 @@ } /*! + * Deinitialize an acc_ramp data structure. + * Called when the user is going to free the structure. + * + * \param[in] acc_ramp Pointer to acc_ramp structure to be deinitialized. + */ +void acc_ramp_deinit(struct acc_ramp *acc_ramp) +{ + osmo_timer_del(&acc_ramp->step_timer); +} + +/*! * Change the ramping step size which controls how many ACCs will be allowed per ramping step. * Returns negative on error (step_size out of range), else zero. * \param[in] acc_ramp Pointer to acc_ramp structure. diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 50a8579..790a8d4 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -163,6 +163,9 @@ paging_destructor(bts); bts_setup_ramp_remove(bts); + acc_ramp_deinit(&bts->acc_ramp); + acc_mgr_deinit(&bts->acc_mgr); + osmo_timer_del(&bts->cbch_timer); bts->site_mgr->bts[0] = NULL; diff --git a/tests/acc/acc_test.c b/tests/acc/acc_test.c index 3dcdc1b..84a63b0 100644 --- a/tests/acc/acc_test.c +++ b/tests/acc/acc_test.c @@ -58,8 +58,6 @@ #define bts_del(bts) _bts_del(bts, __func__) static inline void _bts_del(struct gsm_bts *bts, const char *msg) { - osmo_timer_del(&bts->acc_mgr.rotate_timer); - osmo_timer_del(&bts->acc_ramp.step_timer); talloc_free(bts->site_mgr); fprintf(stderr, "BTS deallocated OK in %s()\n", msg); } diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c index b35df60..4f4b4d4 100644 --- a/tests/gsm0408/gsm0408_test.c +++ b/tests/gsm0408/gsm0408_test.c @@ -137,7 +137,6 @@ #define bts_del(bts) _bts_del(bts, __func__) static inline void _bts_del(struct gsm_bts *bts, const char *msg) { - osmo_timer_del(&bts->acc_mgr.rotate_timer); talloc_free(bts->site_mgr); printf("BTS deallocated OK in %s()\n", msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f94d8fc775953ee98eebc4d80f825404c4f92b2 Gerrit-Change-Number: 38084 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024