Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040?usp=email )
Change subject: s1gw: send the actual Recovery Time Stamp
......................................................................
Patch Set 3:
(1 comment)
File s1gw/S1GW_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040/comment/e70ed715_07d9… :
PS1, Line 242: f_pfcp_get_recovery_timestamp()));
> It probably makes more sense to pass this value as a param of f_pfcp_handle_assoc_setup_req(), so th […]
Done, see https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38098. I don't think it's a big problem that each `ConnHdlr` requests the recovery timestamp after spawning, since it's basically just fetching a value.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I350d28289526d8264ef9b70e796ef76ee7fcbb4b
Gerrit-Change-Number: 38040
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Sep 2024 17:52:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38099?usp=email )
Change subject: s1gw: move t_ConnHdlrPars back to S1GW_Tests
......................................................................
s1gw: move t_ConnHdlrPars back to S1GW_Tests
This is a partial revert of 956bf05e7, which moved the t_ConnHdlrPars
from module S1GW_Tests to S1GW_ConnHdlr and added f_new_ConnHdlrPars().
The problem is that we want to assign module parameter values to
some fields of the ConnHdlrPars record, but TTCN-3 does not allow
to access module parameters of one module from another. Having to
add more and more parameters to the proxy function
f_new_ConnHdlrPars() is highly inconvenient.
Change-Id: Ibc34d0219a616a239c0595e61a783f18fbc91b36
Related: 956bf05e7 "s1gw: Initial StatsD support"
---
M s1gw/S1GW_ConnHdlr.ttcn
M s1gw/S1GW_Tests.ttcn
2 files changed, 11 insertions(+), 15 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/38099/1
diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn
index bb502be..d90609d 100644
--- a/s1gw/S1GW_ConnHdlr.ttcn
+++ b/s1gw/S1GW_ConnHdlr.ttcn
@@ -64,13 +64,6 @@
iE_Extensions := omit
}
-template (value) ConnHdlrPars
-t_ConnHdlrPars(integer idx := 0, charstring statsd_prefix := "") := {
- idx := idx,
- genb_id := ts_Global_ENB_ID(idx),
- statsd_prefix := statsd_prefix
-}
-
type function void_fn(charstring id) runs on ConnHdlr;
function f_ConnHdlr_init(void_fn fn, charstring id, ConnHdlrPars pars)
diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn
index 06e4877..fd6a0ee 100644
--- a/s1gw/S1GW_Tests.ttcn
+++ b/s1gw/S1GW_Tests.ttcn
@@ -109,9 +109,12 @@
vc_PFCP.start(PFCP_Emulation.main(pfcp_cfg));
}
-function f_new_ConnHdlrPars(integer idx := 0) return ConnHdlrPars {
- var ConnHdlrPars pars := valueof(t_ConnHdlrPars(idx, mp_statsd_prefix));
- return pars;
+template (value) ConnHdlrPars
+t_ConnHdlrPars(integer idx := 0,
+ charstring statsd_prefix := mp_statsd_prefix) := {
+ idx := idx,
+ genb_id := ts_Global_ENB_ID(idx),
+ statsd_prefix := statsd_prefix
}
function f_ConnHdlr_spawn(void_fn fn, ConnHdlrPars pars)
@@ -162,7 +165,7 @@
f_ConnHdlr_s1ap_unregister(g_pars.genb_id);
}
testcase TC_setup() runs on test_CT {
- var ConnHdlrPars pars := f_new_ConnHdlrPars();
+ var ConnHdlrPars pars := valueof(t_ConnHdlrPars);
var ConnHdlr vc_conn;
f_init();
@@ -189,7 +192,7 @@
f_init();
for (var integer i := 0; i < 42; i := i + 1) {
- var ConnHdlrPars pars := f_new_ConnHdlrPars(i);
+ var ConnHdlrPars pars := valueof(t_ConnHdlrPars(i));
var ConnHdlr vc_conn := f_ConnHdlr_spawn(refers(f_TC_setup_multi), pars);
vc_conns := vc_conns & { vc_conn };
}
@@ -217,7 +220,7 @@
f_ConnHdlr_s1ap_unregister(g_pars.genb_id);
}
testcase TC_conn_term_by_mme() runs on test_CT {
- var ConnHdlrPars pars := f_new_ConnHdlrPars();
+ var ConnHdlrPars pars := valueof(t_ConnHdlrPars);
var ConnHdlr vc_conn;
f_init();
@@ -237,7 +240,7 @@
setverdict(pass);
}
testcase TC_conn_term_mme_unavail() runs on test_CT {
- var ConnHdlrPars pars := f_new_ConnHdlrPars();
+ var ConnHdlrPars pars := valueof(t_ConnHdlrPars);
var ConnHdlr vc_conn;
f_init(s1apsrv_start := false);
@@ -312,7 +315,7 @@
f_ConnHdlr_s1ap_unregister(g_pars.genb_id);
}
testcase TC_e_rab_setup() runs on test_CT {
- var ConnHdlrPars pars := f_new_ConnHdlrPars();
+ var ConnHdlrPars pars := valueof(t_ConnHdlrPars);
var ConnHdlr vc_conn;
f_init();
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38099?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibc34d0219a616a239c0595e61a783f18fbc91b36
Gerrit-Change-Number: 38099
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: s1gw: send the actual Recovery Time Stamp
......................................................................
s1gw: send the actual Recovery Time Stamp
Change-Id: I350d28289526d8264ef9b70e796ef76ee7fcbb4b
---
M s1gw/S1GW_ConnHdlr.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/38040/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I350d28289526d8264ef9b70e796ef76ee7fcbb4b
Gerrit-Change-Number: 38040
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, laforge.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38062?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: s1gw: derive functions from f_TC_e_rab_setup()
......................................................................
s1gw: derive functions from f_TC_e_rab_setup()
... to avoid code duplication when adding more E-RAB related TCs.
While at it, allow establishing multiple E-RABs.
Change-Id: I1bff371da6337ecd7710219d1c86f0fff82ad17f
---
M s1gw/S1GW_ConnHdlr.ttcn
M s1gw/S1GW_Tests.ttcn
2 files changed, 111 insertions(+), 50 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/38062/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38062?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1bff371da6337ecd7710219d1c86f0fff82ad17f
Gerrit-Change-Number: 38062
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: s1gw: add TC_pfcp_heartbeat
......................................................................
s1gw: add TC_pfcp_heartbeat
Change-Id: Iadb24c2c346a62aa8b59d24475e71f683fc3dfe6
---
M s1gw/S1GW_Tests.ttcn
M s1gw/expected-results.xml
2 files changed, 27 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/38037/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iadb24c2c346a62aa8b59d24475e71f683fc3dfe6
Gerrit-Change-Number: 38037
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>