August 2024 - gerrit-log - lists.osmocom.org

[M] Change in ...osmo-s1gw[master]: erab_fsm: fix message flow misconceptions

by neels

Attention is currently required from: fixeria. neels has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37803?usp=email ) Change subject: erab_fsm: fix message flow misconceptions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37803?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie6f65516fd5621acf002de97eeeb2b9b0b4fae4a Gerrit-Change-Number: 37803 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Aug 2024 00:31:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: add paging a whole routing area with multiple cells

by lynxis lazus

Attention is currently required from: fixeria, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37796?usp=email ) Change subject: SGSN_Tests: add paging a whole routing area with multiple cells ...................................................................... Patch Set 2: (1 comment) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37796/comment/4911ae28_4d93… : PS1, Line 2575: var default d; > same here Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I88dc95669d57278a96e05ec84f934ebf70b319e5 Gerrit-Change-Number: 37796 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Aug 2024 18:57:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 year

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: remove unused variable d

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37811?usp=email ) Change subject: SGSN_Tests: remove unused variable d ...................................................................... SGSN_Tests: remove unused variable d Change-Id: I611e4444dfc9443584397e5523e7612ee5b00af4 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/11/37811/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 1d38d65..cbf50dd 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -2572,7 +2572,6 @@ /* wait for T3314 expiration and check that PS PAGING is created on DL PDU */ private function f_TC_paging_ps(charstring id) runs on BSSGP_ConnHdlr { var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip)); - var default d; /* first perform regular attach */ f_TC_attach(id); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I611e4444dfc9443584397e5523e7612ee5b00af4 Gerrit-Change-Number: 37811 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 year

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests_NS: NS related tests: use the shutdown helper

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37812?usp=email ) Change subject: SGSN_Tests_NS: NS related tests: use the shutdown helper ...................................................................... SGSN_Tests_NS: NS related tests: use the shutdown helper Currently the test case TC_SNS_config_sgsn() is failing because of a dynamic test error after succeeding. Use the Misc_Helpers.f_shutdown() to prevent this. Change-Id: I08eee0d11ae04276ca1ad8fd58ebb93dd6d0066f --- M sgsn/SGSN_Tests_NS.ttcn 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/12/37812/1 diff --git a/sgsn/SGSN_Tests_NS.ttcn b/sgsn/SGSN_Tests_NS.ttcn index e5d012f..ed21d5f 100644 --- a/sgsn/SGSN_Tests_NS.ttcn +++ b/sgsn/SGSN_Tests_NS.ttcn @@ -13,6 +13,7 @@ import from Osmocom_Types all; import from Osmocom_Gb_Types all; import from Osmocom_VTY_Functions all; +import from Misc_Helpers all; import from NS_Types all; import from RAW_NS all; import from SGSN_Tests all; @@ -29,6 +30,7 @@ f_sleep(1.0); f_clean_ns_codec(); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } testcase TC_NS_connect_alive() runs on RAW_Test_CT { @@ -45,6 +47,7 @@ f_sleep(1.0); f_clean_ns_codec(); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } /* perform outgoing SNS-SIZE procedure */ @@ -55,6 +58,7 @@ f_outgoing_sns_size(); setverdict(pass); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } /* outgoing SNS-SIZE procedure with more BSS side IPs than SGSN can handle */ @@ -65,6 +69,7 @@ f_outgoing_sns_size(cause := NS_CAUSE_INVALID_NR_OF_NSVCS, num_ip := 100); setverdict(pass); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } /* perform outgoing SNS-CONFIG procedure (for BSS) */ @@ -76,6 +81,7 @@ f_outgoing_sns_size(); f_outgoing_sns_config(); setverdict(pass); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } /* perform incoming SNS-CONFIG procedure (for SGSN) */ @@ -88,6 +94,7 @@ f_outgoing_sns_config(); f_incoming_sns_config(); setverdict(pass); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } /* perform full SNS handshake and then outbound NS-ALIVE */ @@ -101,6 +108,7 @@ f_incoming_sns_config(); f_outgoing_ns_alive(); setverdict(pass); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } control { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08eee0d11ae04276ca1ad8fd58ebb93dd6d0066f Gerrit-Change-Number: 37812 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 year

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests_NS: TC_NS_connect_alive: set missing verdict

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37813?usp=email ) Change subject: SGSN_Tests_NS: TC_NS_connect_alive: set missing verdict ...................................................................... SGSN_Tests_NS: TC_NS_connect_alive: set missing verdict Change-Id: I03574bc17a10d9098dcd25d73007ec5525c42c18 --- M sgsn/SGSN_Tests_NS.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/13/37813/1 diff --git a/sgsn/SGSN_Tests_NS.ttcn b/sgsn/SGSN_Tests_NS.ttcn index ed21d5f..e1bc4a7 100644 --- a/sgsn/SGSN_Tests_NS.ttcn +++ b/sgsn/SGSN_Tests_NS.ttcn @@ -47,6 +47,7 @@ f_sleep(1.0); f_clean_ns_codec(); + setverdict(pass); Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I03574bc17a10d9098dcd25d73007ec5525c42c18 Gerrit-Change-Number: 37813 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 year

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: add paging a whole routing area with multiple cells

by lynxis lazus

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37796?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: SGSN_Tests: add paging a whole routing area with multiple cells ...................................................................... SGSN_Tests: add paging a whole routing area with multiple cells 1. Attach + PDP Request 2. Wait for UE to be in Standby 3. Transmit to GTP Userdata 4. See the Paging on 2 BVCIs within the Routing Area Change-Id: I88dc95669d57278a96e05ec84f934ebf70b319e5 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 50 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/37796/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I88dc95669d57278a96e05ec84f934ebf70b319e5 Gerrit-Change-Number: 37796 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 year

1
0
0 0

[XS] Change in osmo-sgsn[master]: build: do not link against libosmo-abis

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37793?usp=email ) Change subject: build: do not link against libosmo-abis ...................................................................... build: do not link against libosmo-abis We use 'struct ipa_client_conn' from libosmo-abis: src/sgsn/sgsn_vty.c:56:#include <osmocom/abis/ipa.h> but do not call any of its API directly, so linking against it is not necessary. Remove it from $LDADD, but keep in $CFLAGS. Change-Id: I11168a7b25942d6c70566441fb0a1d26c3ae5c43 Related: OS#6535 --- M src/sgsn/Makefile.am M tests/sgsn/Makefile.am M tests/sndcp_xid/Makefile.am M tests/xid/Makefile.am 4 files changed, 0 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/sgsn/Makefile.am b/src/sgsn/Makefile.am index 93b9fa0..487dead 100644 --- a/src/sgsn/Makefile.am +++ b/src/sgsn/Makefile.am @@ -79,7 +79,6 @@ $(top_builddir)/src/gprs/gprs_utils.o \ $(top_builddir)/src/gprs/sgsn_ares.o \ $(OSMO_LIBS) \ - $(LIBOSMOABIS_LIBS) \ $(LIBOSMOGSUPCLIENT_LIBS) \ $(LIBCARES_LIBS) \ $(LIBGTP_LIBS) \ diff --git a/tests/sgsn/Makefile.am b/tests/sgsn/Makefile.am index c6c1f4a..9cffdfd 100644 --- a/tests/sgsn/Makefile.am +++ b/tests/sgsn/Makefile.am @@ -84,7 +84,6 @@ $(top_builddir)/src/gprs/gprs_llc_parse.o \ $(top_builddir)/src/gprs/crc24.o \ $(top_builddir)/src/gprs/sgsn_ares.o \ - $(LIBOSMOABIS_LIBS) \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMOGSM_LIBS) \ diff --git a/tests/sndcp_xid/Makefile.am b/tests/sndcp_xid/Makefile.am index c4702b8..08bd27f 100644 --- a/tests/sndcp_xid/Makefile.am +++ b/tests/sndcp_xid/Makefile.am @@ -10,7 +10,6 @@ sndcp_xid_test_LDADD = \ $(top_builddir)/src/sgsn/gprs_sndcp_xid.o \ - $(LIBOSMOABIS_LIBS) \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOGB_LIBS) \ diff --git a/tests/xid/Makefile.am b/tests/xid/Makefile.am index d3a260b..284e392 100644 --- a/tests/xid/Makefile.am +++ b/tests/xid/Makefile.am @@ -27,7 +27,6 @@ xid_test_LDADD = \ $(top_builddir)/src/sgsn/gprs_llc_xid.o \ - $(LIBOSMOABIS_LIBS) \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOGB_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I11168a7b25942d6c70566441fb0a1d26c3ae5c43 Gerrit-Change-Number: 37793 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 year

1
0
0 0

[XS] Change in osmo-sgsn[master]: build: remove indirect libosmo-netif dependency

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37792?usp=email ) Change subject: build: remove indirect libosmo-netif dependency ...................................................................... build: remove indirect libosmo-netif dependency Neither we include its headers nor call any of its functions. It's actually a dependency of libosmo-sccp, which is required for '--enable-iu', so keep it in contrib/jenkins.sh. Change-Id: Ia3395fd335d3a693c314b29b8e92968eef55da9a Related: OS#6535 --- M configure.ac M contrib/jenkins.sh M debian/control 3 files changed, 1 insertion(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/configure.ac b/configure.ac index 7e318aa..5286d2e 100644 --- a/configure.ac +++ b/configure.ac @@ -44,7 +44,6 @@ PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.10.0) PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.10.0) PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.6.0) -PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOGSUPCLIENT, libosmo-gsup-client >= 1.8.0) PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.12.0) diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 321beef..8db3a70 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -33,11 +33,11 @@ export PATH="$inst/bin:$PATH" osmo-build-dep.sh libosmo-abis -osmo-build-dep.sh libosmo-netif osmo-build-dep.sh osmo-ggsn osmo-build-dep.sh osmo-hlr if [ "x$IU" = "x--enable-iu" ]; then + osmo-build-dep.sh libosmo-netif osmo-build-dep.sh libosmo-sccp osmo-build-dep.sh libasn1c #osmo-build-dep.sh asn1c aper-prefix # only needed for make regen in osmo-iuh diff --git a/debian/control b/debian/control index c9c224b..a5c0c6e 100644 --- a/debian/control +++ b/debian/control @@ -14,7 +14,6 @@ libgtp-dev (>= 1.12.0), libosmocore-dev (>= 1.10.0), libosmo-abis-dev (>= 1.6.0), - libosmo-netif-dev (>= 1.5.0), libosmo-gsup-client-dev (>= 1.8.0), libasn1c-dev (>= 0.9.30), libosmo-ranap-dev (>= 1.6.0), -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia3395fd335d3a693c314b29b8e92968eef55da9a Gerrit-Change-Number: 37792 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 year

1
0
0 0

[XS] Change in osmo-sgsn[master]: build: remove indirect libosmo-netif dependency

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37792?usp=email ) Change subject: build: remove indirect libosmo-netif dependency ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia3395fd335d3a693c314b29b8e92968eef55da9a Gerrit-Change-Number: 37792 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Aug 2024 15:19:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[XS] Change in osmo-sgsn[master]: build: do not link against libosmo-abis

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37793?usp=email ) Change subject: build: do not link against libosmo-abis ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I11168a7b25942d6c70566441fb0a1d26c3ae5c43 Gerrit-Change-Number: 37793 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Aug 2024 15:19:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024