August 2024 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: tests: move unittests into sub directory

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37821?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: tests: move unittests into sub directory ...................................................................... tests: move unittests into sub directory We currently mix the unit-tests with the shell script based integration tests. Let's put them into a dedicated sub directory. Related: OS#6531 Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 --- M contrib/jenkins.sh R tests/unittests/test_apdu.py R tests/unittests/test_construct.py R tests/unittests/test_esim.py R tests/unittests/test_esim_bsp.py R tests/unittests/test_esim_saip.py R tests/unittests/test_euicc.py R tests/unittests/test_files.py R tests/unittests/test_globalplatform.py R tests/unittests/test_ota.py R tests/unittests/test_sms.py R tests/unittests/test_tlv.py R tests/unittests/test_tlvs.py R tests/unittests/test_utils.py 14 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/21/37821/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 Gerrit-Change-Number: 37821 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 year

1
0
0 0

[XS] Change in pysim[master]: tests: move unittests into sub directory

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37821?usp=email ) Change subject: tests: move unittests into sub directory ...................................................................... tests: move unittests into sub directory We currently mix the unit-tests with the shell script based integration tests. Let's put them into a dedicated sub directory. Related: OS#6531 Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 --- M contrib/jenkins.sh R tests/unittests/test_apdu.py R tests/unittests/test_construct.py R tests/unittests/test_esim.py R tests/unittests/test_esim_bsp.py R tests/unittests/test_esim_saip.py R tests/unittests/test_euicc.py R tests/unittests/test_files.py R tests/unittests/test_globalplatform.py R tests/unittests/test_ota.py R tests/unittests/test_sms.py R tests/unittests/test_tlv.py R tests/unittests/test_tlvs.py R tests/unittests/test_utils.py 14 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/21/37821/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index a35241d..c42d3fe 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -25,7 +25,7 @@ pip install pyshark # Execute automatically discovered unit tests first - python -m unittest discover -v -s tests/ + python -m unittest discover -v -s tests/unittests # Run the test with physical cards cd pysim-testdata diff --git a/tests/test_apdu.py b/tests/unittests/test_apdu.py similarity index 100% rename from tests/test_apdu.py rename to tests/unittests/test_apdu.py diff --git a/tests/test_construct.py b/tests/unittests/test_construct.py similarity index 100% rename from tests/test_construct.py rename to tests/unittests/test_construct.py diff --git a/tests/test_esim.py b/tests/unittests/test_esim.py similarity index 100% rename from tests/test_esim.py rename to tests/unittests/test_esim.py diff --git a/tests/test_esim_bsp.py b/tests/unittests/test_esim_bsp.py similarity index 100% rename from tests/test_esim_bsp.py rename to tests/unittests/test_esim_bsp.py diff --git a/tests/test_esim_saip.py b/tests/unittests/test_esim_saip.py similarity index 100% rename from tests/test_esim_saip.py rename to tests/unittests/test_esim_saip.py diff --git a/tests/test_euicc.py b/tests/unittests/test_euicc.py similarity index 100% rename from tests/test_euicc.py rename to tests/unittests/test_euicc.py diff --git a/tests/test_files.py b/tests/unittests/test_files.py similarity index 100% rename from tests/test_files.py rename to tests/unittests/test_files.py diff --git a/tests/test_globalplatform.py b/tests/unittests/test_globalplatform.py similarity index 100% rename from tests/test_globalplatform.py rename to tests/unittests/test_globalplatform.py diff --git a/tests/test_ota.py b/tests/unittests/test_ota.py similarity index 100% rename from tests/test_ota.py rename to tests/unittests/test_ota.py diff --git a/tests/test_sms.py b/tests/unittests/test_sms.py similarity index 100% rename from tests/test_sms.py rename to tests/unittests/test_sms.py diff --git a/tests/test_tlv.py b/tests/unittests/test_tlv.py similarity index 100% rename from tests/test_tlv.py rename to tests/unittests/test_tlv.py diff --git a/tests/test_tlvs.py b/tests/unittests/test_tlvs.py similarity index 100% rename from tests/test_tlvs.py rename to tests/unittests/test_tlvs.py diff --git a/tests/test_utils.py b/tests/unittests/test_utils.py similarity index 100% rename from tests/test_utils.py rename to tests/unittests/test_utils.py -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 Gerrit-Change-Number: 37821 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 year

1
0
0 0

[XS] Change in libosmo-netif[master]: stream_test: don't check if uint8_t is negative

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37820?usp=email ) Change subject: stream_test: don't check if uint8_t is negative ...................................................................... stream_test: don't check if uint8_t is negative Change-Id: Ic4fac424dcd06c3e235e7bd64c934eb446edb906 Closes: CID#323030 --- M tests/stream/stream_test.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/20/37820/1 diff --git a/tests/stream/stream_test.c b/tests/stream/stream_test.c index 67f7429..f2f1d4f 100644 --- a/tests/stream/stream_test.c +++ b/tests/stream/stream_test.c @@ -516,7 +516,7 @@ } LOGCLI(osc, "Received message from stream (payload len = %" PRIu16 ")\n", msgb_length(msg)); - if (ipac_msg_type < 0 || 5 < ipac_msg_type) { + if (5 < ipac_msg_type) { fprintf(stderr, "Received unexpected IPAC message type %"PRIu8"\n", ipac_msg_type); msgb_free(msg); return -ENOMSG; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic4fac424dcd06c3e235e7bd64c934eb446edb906 Gerrit-Change-Number: 37820 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 year

1
0
0 0

[XL] Change in pysim[master]: WIP: Testsuite for pySim-shell with real cards

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37819?usp=email ) Change subject: WIP: Testsuite for pySim-shell with real cards ...................................................................... Patch Set 1: (4 comments) File tests/pySim-shell_test/config.toml: https://gerrit.osmocom.org/c/pysim/+/37819/comment/f89777ec_447b4a11?usp=em… : PS1, Line 2: {name = "sysmoISIM-SJA5", atr = "3B9F96801F878031E073FE211B674A357530350259C4", adm = "46369345"}, > I am not happy with the adm in config.toml and card_cata.csv. […] card_data.csv is looked up by ICCID. So if you have ICCID + ADM in the CSV, pySim-shell can resolve it by the ICCID of the card. File tests/pySim-shell_test/export_adf_ara_m/test.script: https://gerrit.osmocom.org/c/pysim/+/37819/comment/273f8698_2efa1c8a?usp=em… : PS1, Line 26: sysmoUSIM it is unsupported in bertrand martel's ARA-M applet. As the sysmoEUICC1 is not using that applet, but a built-in one of the CardOS, that constrant doesn't apply there. File tests/pySim-shell_test/export_fs/export.script.ok: https://gerrit.osmocom.org/c/pysim/+/37819/comment/f43ff457_2b898c5a?usp=em… : PS1, Line 7: # there's a non-zero chance that the comment section here will change over time, especially even including the decoded FCP template. For the test, the only thing that matters is the actual non-comment commands generated by the export. Maybe we should pipe the output through a grep that drops all comment lines starting with '#'? This way any future change to the comment section would not require lots of modification to the .ok file. File tests/pySim-shell_test/export_fs/test.py: https://gerrit.osmocom.org/c/pysim/+/37819/comment/ca3c4841_45acf5b8?usp=em… : PS1, Line 35: aram_store_ref_ar_do ah, ok. you already have ignore-regexes. MAybe simply ignore all comments here? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de Gerrit-Change-Number: 37819 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Aug 2024 08:54:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 year

1
0
0 0

[XL] Change in pysim[master]: WIP: Testsuite for pySim-shell with real cards

by dexter

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37819?usp=email ) Change subject: WIP: Testsuite for pySim-shell with real cards ...................................................................... Patch Set 1: (1 comment) File tests/pySim-shell_test/config.toml: https://gerrit.osmocom.org/c/pysim/+/37819/comment/5824ffc2_5f4cf926?usp=em… : PS1, Line 2: {name = "sysmoISIM-SJA5", atr = "3B9F96801F878031E073FE211B674A357530350259C4", adm = "46369345"}, I am not happy with the adm in config.toml and card_cata.csv. Maybe we should parse the ADM from card_data.csv? But then we have to put some key here to connect the entries. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de Gerrit-Change-Number: 37819 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 15 Aug 2024 08:08:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 year

1
0
0 0

[XL] Change in pysim[master]: WIP: Testsuite for pySim-shell with real cards

by dexter

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37819?usp=email ) Change subject: WIP: Testsuite for pySim-shell with real cards ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I am currently working on a testsuite for pySim-shell in python. This is currently work in progress but comments and suggestions are welcome already. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de Gerrit-Change-Number: 37819 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 15 Aug 2024 07:59:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 year

1
0
0 0

[XL] Change in pysim[master]: WIP: Testsuite for pySim-shell with real cards

by Jenkins Builder

Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37819?usp=email ) Change subject: WIP: Testsuite for pySim-shell with real cards ...................................................................... Patch Set 1: (2 comments) File tests/pySim-shell_test/README.txt: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17725): https://gerrit.osmocom.org/c/pysim/+/37819/comment/2535b2d8_ad1b9141?usp=em… : PS1, Line 6: Run a specfic test (e.g. export_fs) with: 'specfic' may be misspelled - perhaps 'specific'? File tests/pySim-shell_test/utils.py: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17725): https://gerrit.osmocom.org/c/pysim/+/37819/comment/00f66755_76c39d7c?usp=em… : PS1, Line 71: the executed testcase and ensures that the requred card are present. The API user should call this method at 'requred' may be misspelled - perhaps 'required'? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de Gerrit-Change-Number: 37819 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 15 Aug 2024 07:57:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 year

1
0
0 0

[XL] Change in pysim[master]: WIP: Testsuite for pySim-shell with real cards

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37819?usp=email ) Change subject: WIP: Testsuite for pySim-shell with real cards ...................................................................... WIP: Testsuite for pySim-shell with real cards Related: OS#6531 Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de --- A tests/pySim-shell_test/README.txt A tests/pySim-shell_test/__init__.py A tests/pySim-shell_test/card_data.csv A tests/pySim-shell_test/config.toml A tests/pySim-shell_test/export_adf_ara_m/__init__.py A tests/pySim-shell_test/export_adf_ara_m/adf_ara-m.cfg.ok A tests/pySim-shell_test/export_adf_ara_m/adf_ara-m.script.ok A tests/pySim-shell_test/export_adf_ara_m/adf_ara-m_empty.cfg.ok A tests/pySim-shell_test/export_adf_ara_m/test.py A tests/pySim-shell_test/export_adf_ara_m/test.script A tests/pySim-shell_test/export_fs/__init__.py A tests/pySim-shell_test/export_fs/export.script.ok A tests/pySim-shell_test/export_fs/test.py A tests/pySim-shell_test/export_fs/test.script A tests/pySim-shell_test/fsdump/__init__.py A tests/pySim-shell_test/fsdump/export.script.ok A tests/pySim-shell_test/fsdump/fsdump.json.ok A tests/pySim-shell_test/fsdump/test.py A tests/pySim-shell_test/fsdump/test.script A tests/pySim-shell_test/navigate_fs/__init__.py A tests/pySim-shell_test/navigate_fs/checkpoints.ok A tests/pySim-shell_test/navigate_fs/test.py A tests/pySim-shell_test/navigate_fs/test.script A tests/pySim-shell_test/utils.py A tests/pySim-shell_test/verify_adm/__init__.py A tests/pySim-shell_test/verify_adm/ef_sim_auth_key.ok A tests/pySim-shell_test/verify_adm/test.py A tests/pySim-shell_test/verify_adm/test_cmdline.script A tests/pySim-shell_test/verify_adm/test_csv.script A tests/pySim-shell_test/verify_adm/test_direct.script.template 30 files changed, 25,106 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/19/37819/1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de Gerrit-Change-Number: 37819 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 year

1
0
0 0

[XS] Change in libosmocore[master]: core/socket.c: Provide more context when printing error message

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/37818?usp=email ) Change subject: core/socket.c: Provide more context when printing error message ...................................................................... core/socket.c: Provide more context when printing error message Let's include the AF, SOCKTYPE and PROTO numbers when logging an error like "unable to create socket: Address family not supported by protocol" Change-Id: I91b05d0520b5432ca301cf6fd34468c2f4ac9b72 Related: SYS#7047 --- M src/core/socket.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/18/37818/1 diff --git a/src/core/socket.c b/src/core/socket.c index 80a9d0e..97708a7 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -172,8 +172,8 @@ sfd = socket(rp->ai_family, rp->ai_socktype, rp->ai_protocol); if (sfd == -1) { - LOGP(DLGLOBAL, LOGL_ERROR, - "unable to create socket: %s\n", strerror(errno)); + LOGP(DLGLOBAL, LOGL_ERROR, "unable to create socket(%d, %d, %d): %s\n", + rp->ai_family, rp->ai_socktype, rp->ai_protocol, strerror(errno)); return sfd; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37818?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I91b05d0520b5432ca301cf6fd34468c2f4ac9b72 Gerrit-Change-Number: 37818 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 year

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: handle E-RAB RELEASE COMMAND/RESPONSE

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37805?usp=email ) Change subject: s1ap_proxy: handle E-RAB RELEASE COMMAND/RESPONSE ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I9c5f279886b548c539211e1e709ae0c6e1cd2788 Gerrit-Change-Number: 37805 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Aug 2024 11:29:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024