August 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-upf[master]: contrib/pfcp-tool-scripts: adjust tunend_session_est.vty and upf cfg ...

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/37827?usp=email ) Change subject: contrib/pfcp-tool-scripts: adjust tunend_session_est.vty and upf cfg to match up ...................................................................... contrib/pfcp-tool-scripts: adjust tunend_session_est.vty and upf cfg to match up Change-Id: I3d6a26b45f084c281887bee541cf01b690c9d1de --- M contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg M contrib/osmo-pfcp-tool-scripts/tunend_session_est.vty 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/27/37827/1 diff --git a/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg b/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg index b639e96..4577a94 100644 --- a/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg +++ b/contrib/osmo-pfcp-tool-scripts/osmo-upf-12.cfg @@ -23,3 +23,7 @@ local-addr 127.0.0.12 tunmap table-name osmo-upf-12 + +# gtp-dev only for GTP-U Echo service +tunend + dev create gtp-echo-12 127.0.0.12 diff --git a/contrib/osmo-pfcp-tool-scripts/tunend_session_est.vty b/contrib/osmo-pfcp-tool-scripts/tunend_session_est.vty index 89a4629..2cefc09 100644 --- a/contrib/osmo-pfcp-tool-scripts/tunend_session_est.vty +++ b/contrib/osmo-pfcp-tool-scripts/tunend_session_est.vty @@ -1,5 +1,5 @@ timer pfcp x23 0 -pfcp-peer 127.0.0.1 +pfcp-peer 127.0.0.11 tx assoc-setup-req sleep 1 session tunend -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3d6a26b45f084c281887bee541cf01b690c9d1de Gerrit-Change-Number: 37827 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 year

1
0
0 0

[L] Change in osmo-upf[master]: add VTY 'gtp-echo' command

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/37830?usp=email ) Change subject: add VTY 'gtp-echo' command ...................................................................... add VTY 'gtp-echo' command Allow sending GTPv1-U Echo Requests to GTP peers via new VTY command gtp-echo tx to 1.2.3.4 [from (dev|ip) (apn0|5.6.7.8)] (pseudocode) Related: OS#6541 Change-Id: I970dccd7a27b098eea9e660822e24e2c4b059fc6 --- M include/osmocom/upf/upf.h M include/osmocom/upf/upf_gtpu_echo.h M src/osmo-upf/upf_gtpu_echo.c M src/osmo-upf/upf_vty.c A tests/gtp-echo.vty 5 files changed, 295 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/30/37830/1 diff --git a/include/osmocom/upf/upf.h b/include/osmocom/upf/upf.h index db73c1f..abd881e 100644 --- a/include/osmocom/upf/upf.h +++ b/include/osmocom/upf/upf.h @@ -117,6 +117,7 @@ struct { uint32_t next_local_teid_state; + uint16_t next_echo_seq_nr; } gtp; struct llist_head netinst; diff --git a/include/osmocom/upf/upf_gtpu_echo.h b/include/osmocom/upf/upf_gtpu_echo.h index 2575424..2bb7c31 100644 --- a/include/osmocom/upf/upf_gtpu_echo.h +++ b/include/osmocom/upf/upf_gtpu_echo.h @@ -2,3 +2,4 @@ #pragma once int upf_gtpu_echo_setup(struct upf_gtp_dev *dev); +int upf_gtpu_echo_req_tx(struct upf_gtp_dev *dev, const struct osmo_sockaddr *remote, uint16_t seq_nr); diff --git a/src/osmo-upf/upf_gtpu_echo.c b/src/osmo-upf/upf_gtpu_echo.c index b234065..8d8db0c 100644 --- a/src/osmo-upf/upf_gtpu_echo.c +++ b/src/osmo-upf/upf_gtpu_echo.c @@ -122,6 +122,45 @@ return rc; } +int upf_gtpu_echo_req_tx(struct upf_gtp_dev *dev, const struct osmo_sockaddr *remote, uint16_t seq_nr) +{ + struct gtp1u_hdr *tx_h; + int rc; + +#define GTP_ECHO_REQ_SIZE ((size_t)(sizeof(struct gtp1u_hdr) + 2)) + uint8_t msgbuf[GTP_ECHO_REQ_SIZE]; + + tx_h = (void *)msgbuf; + *tx_h = (struct gtp1u_hdr){ + /* 3GPP TS 29.281 5.1 defines that the ECHO REQ & RESP shall contain a sequence nr */ + .s = 1, + .pt = 1, + .version = 1, + .msg_type = GTP1U_MSGTYPE_ECHO_REQ, + .ext = { + .seq_nr = seq_nr, + }, + }; + + /* ECHO REQUEST shall contain a recovery counter */ + tx_h->data2[0] = GTP1U_IEI_RECOVERY; + tx_h->data2[1] = g_upf->tunend.recovery_count; + + osmo_store16be(GTP_ECHO_REQ_SIZE - offsetof(struct gtp1u_hdr, data1), &tx_h->length); + + rc = sendto(dev->gtpv1.ofd.fd, msgbuf, GTP_ECHO_REQ_SIZE, 0, &remote->u.sa, sizeof(*remote)); + if (rc < 0) { + rc = -errno; + LOG_GTP_DEV(dev, LOGL_ERROR, "GTP1-U sendto(len=%zu, to=%s): %s\n", GTP_ECHO_REQ_SIZE, + osmo_sockaddr_to_str(remote), strerror(-rc)); + } else { + rc = 0; + } + LOG_GTP_DEV(dev, LOGL_INFO, "<- %s: tx GTP1-U Echo Request: seq_nr=%u recovery_count=%u\n", + osmo_sockaddr_to_str(remote), seq_nr, g_upf->tunend.recovery_count); + return rc; +} + int upf_gtpu_echo_read_cb(struct osmo_fd *ofd, unsigned int what) { struct upf_gtp_dev *dev = ofd->data; diff --git a/src/osmo-upf/upf_vty.c b/src/osmo-upf/upf_vty.c index 44d14db..76d18ea 100644 --- a/src/osmo-upf/upf_vty.c +++ b/src/osmo-upf/upf_vty.c @@ -38,6 +38,7 @@ #include <osmocom/upf/up_session.h> #include <osmocom/upf/up_gtp_action.h> #include <osmocom/upf/netinst.h> +#include <osmocom/upf/upf_gtpu_echo.h> enum upf_vty_node { PFCP_NODE = _LAST_OSMOVTY_NODE + 1, @@ -486,6 +487,80 @@ return CMD_SUCCESS; } +DEFUN(gtp_echo_tx, gtp_echo_tx_cmd, + "gtp-echo tx to IP_ADDR [from] [(ip|dev)] [LOCAL_ADDR_OR_DEV_NAME]", + "GTP1-U Echo probing\n" + "Send a GTP1-U Echo Request to a remote peer\n" + "Send to remote peer's GTP address\n" "IP address like 1.2.3.4 or 1:2:3::4\n" + "Choose local GTP device to send from; when omitted, choose first GTP device.\n" + "Choose local GTP device by IP address\n" + "Choose local GTP device by configured name\n" + "A local IP address bound by a GTP device | a GTP device name as in cfg\n") +{ + struct osmo_sockaddr_str addr; + struct osmo_sockaddr osa_remote; + struct osmo_sockaddr osa_local; + struct upf_gtp_dev *gtp_dev = NULL; + const char *remote_str = argv[0]; + const char *local_type = NULL; + const char *local_str = NULL; + if (argc > 1 && argc <= 3) { + vty_out(vty, "%% Error: missing argument after '%s'%s", argv[argc - 1], VTY_NEWLINE); + return CMD_WARNING; + } + if (argc > 2) + local_type = argv[2]; + if (argc > 3) + local_str = argv[3]; + + /* GTP can be received on port 2152 only, i.e. the remote port must be 2152. (The sending port is allowed to + * differ). */ + if (osmo_sockaddr_str_from_str(&addr, remote_str, 2152) + || osmo_sockaddr_str_to_osa(&addr, &osa_remote)) { + vty_out(vty, "%% Error: invalid IP address: %s%s", osmo_quote_str(remote_str, -1), VTY_NEWLINE); + return CMD_WARNING; + } + + if (local_type) { + if (!strcmp(local_type, "ip")) { + if (osmo_sockaddr_str_from_str(&addr, local_str, 2152) + || osmo_sockaddr_str_to_osa(&addr, &osa_local)) { + vty_out(vty, "%% Error: invalid IP address: %s%s", osmo_quote_str(local_str, -1), VTY_NEWLINE); + return CMD_WARNING; + } + gtp_dev = upf_gtp_dev_find_by_local_addr(&osa_local); + if (!gtp_dev) { + vty_out(vty, "%% Error: this does not seem to be a locally bound GTP address: %s%s", + osmo_sockaddr_to_str_c(OTC_SELECT, &osa_local), VTY_NEWLINE); + return CMD_WARNING; + } + } else { + gtp_dev = upf_gtp_dev_find_by_name(local_str); + if (!gtp_dev) { + vty_out(vty, "%% Error: there is no GTP device by the name of '%s'%s", + local_str, VTY_NEWLINE); + return CMD_WARNING; + } + } + } else { + gtp_dev = llist_first_entry_or_null(&g_upf->tunend.devs, struct upf_gtp_dev, entry); + if (!gtp_dev) { + vty_out(vty, "%% Error: there is no GTP device to send Echo from%s", + VTY_NEWLINE); + return CMD_WARNING; + } + } + OSMO_ASSERT(gtp_dev); + + if (upf_gtpu_echo_req_tx(gtp_dev, &osa_remote, g_upf->gtp.next_echo_seq_nr++)) { + vty_out(vty, "%%Error: Failed to transmit Echo Request (see DGTP logging)%s", VTY_NEWLINE); + return CMD_WARNING; + } + vty_out(vty, "%s -> %s tx Echo Request; for responses, see DGTP logging level INFO%s", + gtp_dev->name, osmo_sockaddr_to_str_c(OTC_SELECT, &osa_remote), VTY_NEWLINE); + return CMD_SUCCESS; +} + void upf_vty_init() { OSMO_ASSERT(g_upf != NULL); @@ -495,6 +570,7 @@ install_element_ve(&show_session_cmd); install_element_ve(&show_netinst_cmd); install_element_ve(&show_nft_rule_append_cmd); + install_element_ve(&gtp_echo_tx_cmd); install_node(&cfg_pfcp_node, config_write_pfcp); install_element(CONFIG_NODE, &cfg_pfcp_cmd); diff --git a/tests/gtp-echo.vty b/tests/gtp-echo.vty new file mode 100644 index 0000000..620d36c --- /dev/null +++ b/tests/gtp-echo.vty @@ -0,0 +1,178 @@ +OsmoUPF> list + show pid + show uptime + show version + show online-help + list [with-flags] + exit + help + show vty-attributes + show vty-attributes (application|library|global) + enable [expert-mode] + terminal length <0-512> + terminal no length + who + show history + logging enable + logging disable + logging filter all (0|1) + logging color (0|1) + logging timestamp (0|1) + logging print extended-timestamp (0|1) + logging print thread-id (0|1) + logging print category (0|1) + logging print category-hex (0|1) + logging print level (0|1) + logging print file (0|1|basename) [last] + logging set-log-mask MASK + logging level (ref|peer|session|gtp|nft|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp|lcsn1|lio) (debug|info|notice|error|fatal) + logging level set-all (debug|info|notice|error|fatal) + logging level force-all (debug|info|notice|error|fatal) + no logging level force-all + logp (ref|peer|session|gtp|nft|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp|lcsn1|lio) (debug|info|notice|error|fatal) .LOGMESSAGE + show logging vty + show alarms + show talloc-context (application|global|all) (full|brief|DEPTH) + show talloc-context (application|global|all) (full|brief|DEPTH) tree ADDRESS + show talloc-context (application|global|all) (full|brief|DEPTH) filter REGEXP + show cpu-sched threads + show pdr + show gtp + show session + show netinst [NAME] + gtp-echo tx to IP_ADDR [from] [(ip|dev)] [LOCAL_ADDR_OR_DEV_NAME] + show timer [(pfcp)] [TNNNN] +OsmoUPF> enable +OsmoUPF# list + help + list [with-flags] + show vty-attributes + show vty-attributes (application|library|global) + write terminal + write file [PATH] + write memory + write + show running-config + exit + disable + configure [terminal] + copy running-config startup-config + shutdown + show startup-config + show version + show online-help + terminal length <0-512> + terminal no length + who + show history + terminal monitor + terminal no monitor + logging enable + logging disable + logging filter all (0|1) + logging color (0|1) + logging timestamp (0|1) + logging print extended-timestamp (0|1) + logging print thread-id (0|1) + logging print category (0|1) + logging print category-hex (0|1) + logging print level (0|1) + logging print file (0|1|basename) [last] + logging set-log-mask MASK + logging level (ref|peer|session|gtp|nft|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp|lcsn1|lio) (debug|info|notice|error|fatal) + logging level set-all (debug|info|notice|error|fatal) + logging level force-all (debug|info|notice|error|fatal) + no logging level force-all + logp (ref|peer|session|gtp|nft|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp|lcsn1|lio) (debug|info|notice|error|fatal) .LOGMESSAGE + show logging vty + show alarms + show talloc-context (application|global|all) (full|brief|DEPTH) + show talloc-context (application|global|all) (full|brief|DEPTH) tree ADDRESS + show talloc-context (application|global|all) (full|brief|DEPTH) filter REGEXP + show cpu-sched threads + show pdr + show gtp + show session + show netinst [NAME] + gtp-echo tx to IP_ADDR [from] [(ip|dev)] [LOCAL_ADDR_OR_DEV_NAME] + show timer [(pfcp)] [TNNNN] +OsmoUPF# configure terminal +OsmoUPF(config)# list + help + list [with-flags] + show vty-attributes + show vty-attributes (application|library|global) + write terminal + write file [PATH] + write memory + write + show running-config + exit + end + hostname WORD + no hostname [HOSTNAME] + password (8|) WORD + password LINE + enable password (8|) WORD + enable password LINE + no enable password + banner motd default + banner motd file [FILE] + no banner motd + service terminal-length <0-512> + no service terminal-length [<0-512>] + line vty + service advanced-vty + no service advanced-vty + show history + ctrl + log stderr [blocking-io] + no log stderr + log file FILENAME [blocking-io] + no log file FILENAME + log alarms <2-32700> + no log alarms + log syslog (authpriv|cron|daemon|ftp|lpr|mail|news|user|uucp) + log syslog local <0-7> + no log syslog + log systemd-journal [raw] + no log systemd-journal + log gsmtap [HOSTNAME] + no log gsmtap [HOSTNAME] + cpu-sched + pfcp + tunend + tunmap + netinst + timer [(pfcp)] [TNNNN] [(<0-2147483647>|default)] +OsmoUPF(config)# end + +OsmoUPF# gtp-echo? + gtp-echo GTP1-U Echo probing +OsmoUPF# gtp-echo ? + tx Send a GTP1-U Echo Request to a remote peer +OsmoUPF# gtp-echo tx ? + to Send to remote peer's GTP address +OsmoUPF# gtp-echo tx to ? + IP_ADDR IP address like 1.2.3.4 or 1:2:3::4 +OsmoUPF# gtp-echo tx to 1.2.3.4 ? + [from] Choose local GTP device to send from; when omitted, choose first GTP device. +OsmoUPF# gtp-echo tx to 1.2.3.4 from ? + [ip] Choose local GTP device by IP address + [dev] Choose local GTP device by configured name +OsmoUPF# gtp-echo tx to 1.2.3.4 from ip ? + [LOCAL_ADDR_OR_DEV_NAME] A local IP address bound by a GTP device | a GTP device name as in cfg +OsmoUPF# gtp-echo tx to 1.2.3.4 from dev ? + [LOCAL_ADDR_OR_DEV_NAME] A local IP address bound by a GTP device | a GTP device name as in cfg +OsmoUPF# gtp-echo tx to 1.2.3.4 +% Error: there is no GTP device to send Echo from +OsmoUPF# gtp-echo tx to 1.2.3.4 from +% Error: missing argument after 'from' +OsmoUPF# gtp-echo tx to 1.2.3.4 from ip +% Error: missing argument after 'ip' +OsmoUPF# gtp-echo tx to 1.2.3.4 from dev +% Error: missing argument after 'dev' +OsmoUPF# gtp-echo tx to 1.2.3.4 from ip 1.2.3.4 +% Error: this does not seem to be a locally bound GTP address: 1.2.3.4:2152 +OsmoUPF# gtp-echo tx to 1.2.3.4 from dev apn0 +% Error: there is no GTP device by the name of 'apn0' -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I970dccd7a27b098eea9e660822e24e2c4b059fc6 Gerrit-Change-Number: 37830 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 year

1
0
0 0

[XS] Change in osmo-upf[master]: fix msgb memleak on GTP echo response

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/37824?usp=email ) Change subject: fix msgb memleak on GTP echo response ...................................................................... fix msgb memleak on GTP echo response Change-Id: I2bd2e9c57bf392074eed9628a69eb710d4e459a6 --- M src/osmo-upf/upf_gtpu_echo.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/24/37824/1 diff --git a/src/osmo-upf/upf_gtpu_echo.c b/src/osmo-upf/upf_gtpu_echo.c index b251a94..0d93299 100644 --- a/src/osmo-upf/upf_gtpu_echo.c +++ b/src/osmo-upf/upf_gtpu_echo.c @@ -94,6 +94,7 @@ LOG_GTP_DEV(dev, LOGL_ERROR, "GTP1-U sendto(len=%d, to=%s): %s\n", msgb_length(msg), osmo_sockaddr_to_str(remote), strerror(err)); } + msgb_free(msg); return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I2bd2e9c57bf392074eed9628a69eb710d4e459a6 Gerrit-Change-Number: 37824 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 year

1
0
0 0

[XS] Change in osmo-upf[master]: fix EXTRA_DIST for vty test scripts

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/37825?usp=email ) Change subject: fix EXTRA_DIST for vty test scripts ...................................................................... fix EXTRA_DIST for vty test scripts Like e.g. in osmo-msc.git, osmo-bsc.git, use wildcard $(srcdir)/*.vty to make sure we never forget to distribute committed VTY test scripts. Change-Id: If4dca81ce287ce1b1af32057634af912a8b89665 --- M tests/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/25/37825/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 5e1d517..ef55b97 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -21,7 +21,7 @@ } >'$(srcdir)/package.m4' EXTRA_DIST = \ - upf.vty \ + $(srcdir)/*.vty \ testsuite.at \ $(srcdir)/package.m4 \ $(TESTSUITE) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: If4dca81ce287ce1b1af32057634af912a8b89665 Gerrit-Change-Number: 37825 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 year

1
0
0 0

[XS] Change in osmo-upf[master]: drop unreachable statement

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/37826?usp=email ) Change subject: drop unreachable statement ...................................................................... drop unreachable statement Change-Id: I0710fd0e38a5ce26ac532ab7150e285f171accfb --- M src/osmo-upf/upf_gtpu_echo.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/26/37826/1 diff --git a/src/osmo-upf/upf_gtpu_echo.c b/src/osmo-upf/upf_gtpu_echo.c index 0d93299..cbf804b 100644 --- a/src/osmo-upf/upf_gtpu_echo.c +++ b/src/osmo-upf/upf_gtpu_echo.c @@ -146,8 +146,6 @@ LOG_GTP_DEV(dev, LOGL_ERROR, "rx: GTPv1-U message type %u not supported\n", h->msg_type); return -1; } - - return 0; } int upf_gtpu_echo_setup(struct upf_gtp_dev *dev) -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I0710fd0e38a5ce26ac532ab7150e285f171accfb Gerrit-Change-Number: 37826 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 year

1
0
0 0

[M] Change in pysim[master]: pySim.esim.saip.templates: Introduce dependency/hierarchy information

by laforge

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37814?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pySim.esim.saip.templates: Introduce dependency/hierarchy information ...................................................................... pySim.esim.saip.templates: Introduce dependency/hierarchy information The SAIP specification is very weird in a way that it treats the DF and EF descriptions as some kind of flat structure without describing the hierarchy. So when creating a DF, sometimes it should be created below the current DF, and sometimes it should be adjacent next to the current DF. Let's introduce * a 'ppath' property of FileTemplate to indicate if a file is anything but a direct sibling of the 'base DF' of the PE * an 'extends' property of ProfileTemplate to indicate that a given template does not have its own 'base DF', but that its contents merely extends that of another ProfileTemplate * a 'parent' property of ProfileTemplate to indicate a parent ProfileTemplate below whose 'base DF' our files should be placed. Change-Id: Ieab4835cd21008b289713784c0eb7170af2ccfb9 --- M pySim/esim/saip/templates.py 1 file changed, 99 insertions(+), 50 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/14/37814/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37814?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieab4835cd21008b289713784c0eb7170af2ccfb9 Gerrit-Change-Number: 37814 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder

1 year

1
0
0 0

[S] Change in pysim[master]: tests: move pySim-prog test and its data into a sub directory

by dexter

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37823?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: tests: move pySim-prog test and its data into a sub directory ...................................................................... tests: move pySim-prog test and its data into a sub directory We currently have the shell script that performs the test in the tests directory and the related data in pysim-testdata directory. This is confusing, let's have evrything in a dedicated sub directory Change-Id: Ic995a7f600d164fc0be3c2eb8255dbe043429bea Related: OS#6531 --- M contrib/jenkins.sh R tests/pySim-prog_test/Fairwaves-SIM.data R tests/pySim-prog_test/Fairwaves-SIM.ok R tests/pySim-prog_test/Wavemobile-SIM.data R tests/pySim-prog_test/Wavemobile-SIM.ok R tests/pySim-prog_test/fakemagicsim.data R tests/pySim-prog_test/fakemagicsim.ok R tests/pySim-prog_test/pySim-prog_test.sh R tests/pySim-prog_test/sysmoISIM-SJA2.data R tests/pySim-prog_test/sysmoISIM-SJA2.ok R tests/pySim-prog_test/sysmoUSIM-SJS1.data R tests/pySim-prog_test/sysmoUSIM-SJS1.ok R tests/pySim-prog_test/sysmosim-gr1.data R tests/pySim-prog_test/sysmosim-gr1.ok 14 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/23/37823/7 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic995a7f600d164fc0be3c2eb8255dbe043429bea Gerrit-Change-Number: 37823 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 year

1
0
0 0

[S] Change in pysim[master]: tests: move pySim-prog test and its data into a sub directory

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37823?usp=email ) Change subject: tests: move pySim-prog test and its data into a sub directory ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic995a7f600d164fc0be3c2eb8255dbe043429bea Gerrit-Change-Number: 37823 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Aug 2024 15:17:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[XS] Change in pysim[master]: tests: move pySim-trace test and its data into a sub directory

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37822?usp=email ) Change subject: tests: move pySim-trace test and its data into a sub directory ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I565b4268a05c1a1334b5e7d3fbcd9ef2ef0f0c4c Gerrit-Change-Number: 37822 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Aug 2024 15:17:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[XS] Change in pysim[master]: tests: move unittests into a sub directory

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37821?usp=email ) Change subject: tests: move unittests into a sub directory ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24 Gerrit-Change-Number: 37821 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Aug 2024 15:16:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024