fixeria has submitted this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/37799?usp=email )
Change subject: osmotestconfig: fix return value of write_config()
......................................................................
osmotestconfig: fix return value of write_config()
This patch fixes the following exception, if the received string does
not match. The calling function just expects an integer.
----
TypeError: '>' not supported between instances of 'tuple' and 'int'
----
Change-Id: I24adfd344937bab1ab641327e59a25bf76e18591
---
M scripts/osmotestconfig.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
diff --git a/scripts/osmotestconfig.py b/scripts/osmotestconfig.py
index aa926f1..c56849d 100755
--- a/scripts/osmotestconfig.py
+++ b/scripts/osmotestconfig.py
@@ -86,7 +86,7 @@
new_config = vty.enabled_command("write")
if not new_config.startswith("Configuration saved to "):
print(new_config)
- return 1, [new_config]
+ return 1
return 0
--
To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/37799?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: I24adfd344937bab1ab641327e59a25bf76e18591
Gerrit-Change-Number: 37799
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Attention is currently required from: neels.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/37764?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: osmo-pfcp-tool: add GTP flooding using io_uring
......................................................................
osmo-pfcp-tool: add GTP flooding using io_uring
Freely copying from gtp-load-gen.c, implement GTP flooding in
osmo-pfcp-tool scripts.
Add dependency liburing. It can be disabled with
configure --disable-uring
in which case the new 'gtp flood' command only logs an error.
This verbosely commented example script serves as a good explanation:
contrib/osmo-pfcp-tool-scripts/gtp_flood.vty
Related: SYS#6590
Change-Id: I332aa0e2efd55f6e357cde4752a3d8b584db531b
---
M TODO-RELEASE
M configure.ac
A contrib/osmo-pfcp-tool-scripts/gtp_flood.vty
M debian/control
M include/osmocom/pfcptool/Makefile.am
A include/osmocom/pfcptool/checksum.h
A include/osmocom/pfcptool/gtp_flood.h
M include/osmocom/pfcptool/pfcp_tool.h
A include/osmocom/pfcptool/range.h
M src/osmo-pfcp-tool/Makefile.am
A src/osmo-pfcp-tool/checksum.c
A src/osmo-pfcp-tool/gtp_flood.c
M src/osmo-pfcp-tool/osmo_pfcp_tool_main.c
M src/osmo-pfcp-tool/pfcp_tool.c
M src/osmo-pfcp-tool/pfcp_tool_vty.c
A src/osmo-pfcp-tool/range.c
16 files changed, 1,298 insertions(+), 27 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/64/37764/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37764?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I332aa0e2efd55f6e357cde4752a3d8b584db531b
Gerrit-Change-Number: 37764
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Attention is currently required from: laforge.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807?usp=email )
Change subject: on RUA Connect failure, respond with RUA Disconnect
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS1:
> I was first a bit puzzled and would have expected some kind of unsuccessful result for the RUA Conne […]
RUA is very weird in that way, connection-oriented with a single-message, single-direction disconnect procedure.
Patchset:
PS2:
re-adding +1 after trivial compilation fix
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Iafb30c31a4c5db53ecdda99a0e0b5937b71e362c
Gerrit-Change-Number: 37807
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 13 Aug 2024 06:00:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: neels.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/37808?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: on RUA DT for unknown context, respond with RUA Disconnect
......................................................................
on RUA DT for unknown context, respond with RUA Disconnect
If we receive a DirectTransfer for an unknown RUA context, respond with
a RUA Disconnect to make sure the peer knows there is no such context.
(Do not respond to RUA Disconnect though.)
Related: OS#6283
Change-Id: If0b9a999649c9822f55b42b0cae8408af668e1b8
---
M src/osmo-hnbgw/hnbgw_rua.c
1 file changed, 9 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/08/37808/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37808?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: If0b9a999649c9822f55b42b0cae8408af668e1b8
Gerrit-Change-Number: 37808
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Attention is currently required from: laforge, neels.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified-1 by Jenkins Builder
Change subject: on RUA Connect failure, respond with RUA Disconnect
......................................................................
on RUA Connect failure, respond with RUA Disconnect
Related: OS#6283
Related: osmo-ttcn3-hacks I2b5c024a395e736538c0c37db40d34f3b8d99991
Change-Id: Iafb30c31a4c5db53ecdda99a0e0b5937b71e362c
---
M src/osmo-hnbgw/hnbgw_rua.c
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/07/37807/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Iafb30c31a4c5db53ecdda99a0e0b5937b71e362c
Gerrit-Change-Number: 37807
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: laforge.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37756?usp=email )
Change subject: pfcp-tool: always use specific PDR ids for access and core
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
again
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37756?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic343494001c70a84f3402ce5749d08e729551b26
Gerrit-Change-Number: 37756
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 13 Aug 2024 05:53:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: neels.
Jenkins Builder has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37764?usp=email )
Change subject: osmo-pfcp-tool: add GTP flooding using io_uring
......................................................................
Patch Set 5:
(1 comment)
File src/osmo-pfcp-tool/pfcp_tool_vty.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17697):
https://gerrit.osmocom.org/c/osmo-upf/+/37764/comment/29be6185_6c91b837?usp… :
PS5, Line 179: )
please, no spaces at the start of a line
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37764?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I332aa0e2efd55f6e357cde4752a3d8b584db531b
Gerrit-Change-Number: 37764
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Aug 2024 05:53:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: laforge.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37757?usp=email )
Change subject: pfcp-tool: n-sessions [1/4]: add generators for TEID and UE IP
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> commit log message should state it's about the pfcp-tool, not osmo-upf. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37757?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Iec164a222782d382aefe8d0342f398ebba1eac05
Gerrit-Change-Number: 37757
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 13 Aug 2024 05:52:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: neels.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/37758?usp=email
to look at the new patch set (#3).
Change subject: pfcp-tool: n-sessions [2/4]: generalize function args
......................................................................
pfcp-tool: n-sessions [2/4]: generalize function args
Change some VTY DEFUN into generally callable functions. Prepare for N
sessions commands.
Related: SYS#6590
Change-Id: I112206049e704b7adad7072b1f7953f7ee4f18ca
---
M src/osmo-pfcp-tool/pfcp_tool.c
M src/osmo-pfcp-tool/pfcp_tool_vty.c
2 files changed, 51 insertions(+), 35 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/58/37758/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37758?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I112206049e704b7adad7072b1f7953f7ee4f18ca
Gerrit-Change-Number: 37758
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
