August 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: on RUA Connect failure, respond with RUA Disconnect

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807?usp=email ) Change subject: on RUA Connect failure, respond with RUA Disconnect ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I was first a bit puzzled and would have expected some kind of unsuccessful result for the RUA Connect. But it turns out that there is no way to communicate an unsuccessful resposne to connect, so this approach is correct. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iafb30c31a4c5db53ecdda99a0e0b5937b71e362c Gerrit-Change-Number: 37807 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Aug 2024 05:45:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[L] Change in osmo-upf[master]: n-sessions [4/4]: implement 'n <0-2147483647> session create'

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-upf/+/37760?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: n-sessions [4/4]: implement 'n <0-2147483647> session create' ...................................................................... n-sessions [4/4]: implement 'n <0-2147483647> session create' Related: SYS#6590 Change-Id: I74a21cc31296ab89a2acda1da8ae9693c1992e66 --- M src/osmo-pfcp-tool/pfcp_tool_vty.c 1 file changed, 294 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/60/37760/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I74a21cc31296ab89a2acda1da8ae9693c1992e66 Gerrit-Change-Number: 37760 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

1 year

1
0
0 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: include Network Instance IE in PDRs and FARs

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37795?usp=email ) Change subject: erab_fsm: include Network Instance IE in PDRs and FARs ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: AFAICT, those IEs are completely optional. So some configurations of UPF will need them, while others don't. The current code doesn't look like it anticipate such situtations? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I4dbe8e0b1d14eed5fdb3f9f3f2543c44fd543d22 Gerrit-Change-Number: 37795 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Aug 2024 05:43:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 year

1
0
0 0

[M] Change in ...osmo-s1gw[master]: erab_fsm: fix message flow misconceptions

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37803?usp=email ) Change subject: erab_fsm: fix message flow misconceptions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37803?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie6f65516fd5621acf002de97eeeb2b9b0b4fae4a Gerrit-Change-Number: 37803 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Aug 2024 05:41:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: fix misconceptions about E-RAB establishment

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37801?usp=email ) Change subject: fix misconceptions about E-RAB establishment ...................................................................... fix misconceptions about E-RAB establishment Change-Id: I8d777699cf71cb5ba2609ab5f3587e4cc88ceaea --- M test/s1ap_proxy_test.erl 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/test/s1ap_proxy_test.erl b/test/s1ap_proxy_test.erl index 9830af8..cb0a4ca 100644 --- a/test/s1ap_proxy_test.erl +++ b/test/s1ap_proxy_test.erl @@ -60,7 +60,7 @@ [?_assertEqual({OrigData, S}, s1ap_proxy:handle_pdu(OrigData, S))]. -%% [eNB -> MME] E-RAB SETUP REQUEST +%% [eNB <- MME] E-RAB SETUP REQUEST e_rab_setup_req_pdu(TLA, TEID) when is_binary(TLA), is_binary(TEID) -> << 16#00, 16#05, 16#00, 16#80, 16#9b, 16#00, 16#00, 16#03, @@ -100,7 +100,7 @@ [?_assertMatch({ExpData, _}, s1ap_proxy:handle_pdu(OrigData, S))]. -%% [MME -> eNB] E-RAB SETUP RESPONSE +%% [eNB -> MME] E-RAB SETUP RESPONSE e_rab_setup_rsp_pdu(TLA, TEID) when is_binary(TLA), is_binary(TEID) -> << 16#20, 16#05, 16#00, 16#22, 16#00, 16#00, 16#03, 16#00, @@ -148,7 +148,7 @@ [?_assertMatch({ExpData, _}, s1ap_proxy:handle_pdu(OrigData, S))]. -%% [eNB -> MME] INITIAL CONTEXT SETUP REQUEST +%% [eNB <- MME] INITIAL CONTEXT SETUP REQUEST initial_context_setup_req_pdu(TLA, TEID) when is_binary(TLA), is_binary(TEID) -> << 16#00, 16#09, 16#00, 16#81, 16#10, 16#00, 16#00, 16#07, @@ -203,7 +203,7 @@ [?_assertMatch({ExpData, _}, s1ap_proxy:handle_pdu(OrigData, S))]. -%% [MME -> eNB] INITIAL CONTEXT SETUP RESPONSE +%% [eNB -> MME] INITIAL CONTEXT SETUP RESPONSE initial_context_setup_rsp_pdu(TLA, TEID) when is_binary(TLA), is_binary(TEID) -> << 16#20, 16#09, 16#00, 16#22, 16#00, 16#00, 16#03, 16#00, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37801?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8d777699cf71cb5ba2609ab5f3587e4cc88ceaea Gerrit-Change-Number: 37801 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 year

1
0
0 0

[S] Change in ...osmo-s1gw[master]: config: rename upf_{loc,rem}_addr to pfcp_{loc,rem}_addr

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37800?usp=email ) Change subject: config: rename upf_{loc,rem}_addr to pfcp_{loc,rem}_addr ...................................................................... config: rename upf_{loc,rem}_addr to pfcp_{loc,rem}_addr Clarify that the existing parameters are related to PFCP. Change-Id: I8447bac3a0a61537f9327121f28266a8e5af7f9c --- M config/sys.config M src/osmo_s1gw_sup.erl 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/config/sys.config b/config/sys.config index 99930cc..993176b 100644 --- a/config/sys.config +++ b/config/sys.config @@ -14,8 +14,8 @@ [{s1gw_bind_addr, "127.0.1.1"}, %% S1GW bind address for incoming eNB connections {mme_loc_addr, "127.0.2.1"}, %% local address for outgoing connections to the MME {mme_rem_addr, "127.0.2.10"}, %% remote address for outgoing connections to the MME - {upf_loc_addr, "127.0.1.1"}, %% local address for outgoing connections to the UPF - {upf_rem_addr, "127.0.1.2"} %% remote address for outgoing connections to the UPF + {pfcp_loc_addr, "127.0.1.1"}, %% local address for incoming PFCP PDUs from UPF + {pfcp_rem_addr, "127.0.1.2"} %% remote address for outgoing PFCP PDUs to UPF ]}, %% ================================================================================ %% kernel config diff --git a/src/osmo_s1gw_sup.erl b/src/osmo_s1gw_sup.erl index 7bfd53f..c6adb55 100644 --- a/src/osmo_s1gw_sup.erl +++ b/src/osmo_s1gw_sup.erl @@ -47,8 +47,8 @@ -define(ENV_DEFAULT_MME_LOC_ADDR, "127.0.2.1"). -define(ENV_DEFAULT_MME_REM_ADDR, "127.0.2.10"). -define(ENV_DEFAULT_MME_REM_PORT, ?S1AP_PORT). --define(ENV_DEFAULT_UPF_LOC_ADDR, "127.0.1.1"). --define(ENV_DEFAULT_UPF_REM_ADDR, "127.0.1.2"). +-define(ENV_DEFAULT_PFCP_LOC_ADDR, "127.0.1.1"). +-define(ENV_DEFAULT_PFCP_REM_ADDR, "127.0.1.2"). %% ------------------------------------------------------------------ %% supervisor API @@ -64,8 +64,8 @@ MmeLocAddr = get_env(mme_loc_addr, ?ENV_DEFAULT_MME_LOC_ADDR), MmeRemAddr = get_env(mme_rem_addr, ?ENV_DEFAULT_MME_REM_ADDR), MmeRemPort = get_env(mme_rem_port, ?ENV_DEFAULT_MME_REM_PORT), - UpfLocAddr = get_env(upf_loc_addr, ?ENV_DEFAULT_UPF_LOC_ADDR), - UpfRemAddr = get_env(upf_rem_addr, ?ENV_DEFAULT_UPF_REM_ADDR), + PfcpLocAddr = get_env(pfcp_loc_addr, ?ENV_DEFAULT_PFCP_LOC_ADDR), + PfcpRemAddr = get_env(pfcp_rem_addr, ?ENV_DEFAULT_PFCP_REM_ADDR), SctpServer = {sctp_server, {sctp_server, start_link, [S1GWBindAddr, S1GWBindPort, @@ -75,7 +75,7 @@ worker, [sctp_server]}, PfcpPeer = {pfcp_peer, {pfcp_peer, start_link, - [UpfLocAddr, UpfRemAddr]}, + [PfcpLocAddr, PfcpRemAddr]}, permanent, 5000, worker, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8447bac3a0a61537f9327121f28266a8e5af7f9c Gerrit-Change-Number: 37800 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 year

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: erab_fsm: fix API docs: UID was moved to start_link()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37802?usp=email ) Change subject: erab_fsm: fix API docs: UID was moved to start_link() ...................................................................... erab_fsm: fix API docs: UID was moved to start_link() Change-Id: I4987baac8f2da30a6d285275eaba2cac0528ac93 --- M src/erab_fsm.erl 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl index 5635086..8a9d0ec 100644 --- a/src/erab_fsm.erl +++ b/src/erab_fsm.erl @@ -80,6 +80,10 @@ %% public API %% ------------------------------------------------------------------ +%% @doc Allocate and start an E-RAB FSM process +%% @param UID *unique* E-RAB identifier. +%% @returns process ID on success; an error otherwise. +%% @end -spec start_link(term()) -> gen_statem:start_ret(). start_link(UID) -> gen_statem:start_link(?MODULE, [UID], []). @@ -87,7 +91,6 @@ %% @doc Indicate reception of E-RAB setup request (from the eNB). %% @param Pid PID of an erab_fsm. -%% @param UID *unique* E-RAB identifier. %% @param TEID TEID chosen by the eNB. %% @returns TEID to be sent to the core; an error otherwise. %% @end -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37802?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I4987baac8f2da30a6d285275eaba2cac0528ac93 Gerrit-Change-Number: 37802 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 year

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: erab_fsm: fix API docs: UID was moved to start_link()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37802?usp=email ) Change subject: erab_fsm: fix API docs: UID was moved to start_link() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37802?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I4987baac8f2da30a6d285275eaba2cac0528ac93 Gerrit-Change-Number: 37802 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Aug 2024 05:40:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: fix misconceptions about E-RAB establishment

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37801?usp=email ) Change subject: fix misconceptions about E-RAB establishment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37801?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8d777699cf71cb5ba2609ab5f3587e4cc88ceaea Gerrit-Change-Number: 37801 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Aug 2024 05:40:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[S] Change in ...osmo-s1gw[master]: config: rename upf_{loc,rem}_addr to pfcp_{loc,rem}_addr

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37800?usp=email ) Change subject: config: rename upf_{loc,rem}_addr to pfcp_{loc,rem}_addr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8447bac3a0a61537f9327121f28266a8e5af7f9c Gerrit-Change-Number: 37800 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Aug 2024 05:40:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024