Attention is currently required from: laforge.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37532?usp=email )
Change subject: pySim.apdu: Fix APDU CLA matching
......................................................................
Patch Set 1: Verified+1 Code-Review+2
(1 comment)
Patchset:
PS1:
As far as I can see this is correct.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37532?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I890bc385d6209e6cfe9b0c38bd9deee7ae50e5f5
Gerrit-Change-Number: 37532
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 23 Jul 2024 13:51:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37535?usp=email )
Change subject: pySim.apdu: Get rid of HexAdapter
......................................................................
Patch Set 2: Verified+1 Code-Review+1
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/37535/comment/4e5b1253_73b1a9c5
PS2, Line 14: We should do a similar migrtaion all over pySim (pySim-shell,
Tyop: migrtaion -> migration
Patchset:
PS2:
This looks correct to me, also I didn't experience any problems when I gave it a try.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37535?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0cde40b2db08b4db9c10c1ece9ca6fdd42aa9154
Gerrit-Change-Number: 37535
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 23 Jul 2024 13:34:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37541?usp=email )
Change subject: saip-tool: Fix TAR display for implicit TAR
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
To me this looks correct. (As far as I understand, the last three bytes of the AID make up the TAR in case implicit TAR is used.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37541?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I76133b0e02996a138257f3fba5ceb0d2fc6fad80
Gerrit-Change-Number: 37541
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 23 Jul 2024 13:23:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: falconia.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/37550?usp=email )
Change subject: fix E1 TS output when used with osmo-e1d
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Please have a look, this is the same fix you did for osmo-mgw applied to osmo-pcu, which inherited a lot of E1 code from osmo-mgw.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37550?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia2e0fa27195fc1ae75e441038eb4adeb4cf1d6cf
Gerrit-Change-Number: 37550
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: falconia <falcon(a)freecalypso.org>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Tue, 23 Jul 2024 13:02:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: falconia.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37311?usp=email )
Change subject: fix E1 TS output when used with osmo-e1d
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
The same problem also exists in osmo-pcu. I have fixed it there as well and submitted a patch here: https://gerrit.osmocom.org/c/osmo-pcu/+/37550
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37311?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6ce9a1dea6834632faf75059e85ca9a0c25d57c2
Gerrit-Change-Number: 37311
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Tue, 23 Jul 2024 13:00:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/37550?usp=email )
Change subject: fix E1 TS output when used with osmo-e1d
......................................................................
fix E1 TS output when used with osmo-e1d
The original code did E1 raw TS output by posting directly to
&ts->raw.tx_queue instead of calling e1inp_ts_send_raw();
doing so bypasses the call to driver->want_write performed in
e1inp layer. This approach worked for DAHDI where no
select-for-write is used; however, e1inp interface to osmo-e1d
does use select-for-write, hence applications like osmo-mgw
do need to use e1inp_ts_send_raw() API in order to work
correctly.
Change-Id: Ia2e0fa27195fc1ae75e441038eb4adeb4cf1d6cf
---
M src/ericsson-rbs/er_ccu_if.c
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/50/37550/1
diff --git a/src/ericsson-rbs/er_ccu_if.c b/src/ericsson-rbs/er_ccu_if.c
index 98abbf7..ad7f353 100644
--- a/src/ericsson-rbs/er_ccu_if.c
+++ b/src/ericsson-rbs/er_ccu_if.c
@@ -126,7 +126,7 @@
DEBUG_BYTES_MAX ? DEBUG_BYTES_MAX : msgb_length(msg)));
/* Hand data over to the E1 stack */
- msgb_enqueue(&ts->raw.tx_queue, msg);
+ e1inp_ts_send_raw(ts, msg);
}
/* Callback function to handle incoming E1 traffic */
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37550?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia2e0fa27195fc1ae75e441038eb4adeb4cf1d6cf
Gerrit-Change-Number: 37550
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: falconia <falcon(a)freecalypso.org>
Gerrit-MessageType: newchange
Attention is currently required from: falconia.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37311?usp=email )
Change subject: fix E1 TS output when used with osmo-e1d
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Patchset:
PS1:
From what I can see, this patch is correct.
File src/libosmo-mgcp/mgcp_e1.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/37311/comment/1be0499c_43e88d39
PS1, Line 327: e1inp_ts_send_raw(ts, msg);
I believe that this API was not around in 2020 when I did the implementation. Or I simply overlooked it. In any case, I believe this is correct.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37311?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6ce9a1dea6834632faf75059e85ca9a0c25d57c2
Gerrit-Change-Number: 37311
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Tue, 23 Jul 2024 12:47:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
