July 2024 - gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: pySim-shell: add "fsdump" command

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37543?usp=email ) Change subject: pySim-shell: add "fsdump" command ...................................................................... Patch Set 1: Verified+1 (2 comments) Patchset: PS1: I have tested it and it appears to work fine, expect for the small bug (see comment) when --filename is used. File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37543/comment/5df1d7c4_309ad16e PS1, Line 852: self.export_ef(opts.filename, context, **kwargs_export) Did you mean fsdump_ef here? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib179f57bc04d394efe11003ba191dca6098192d3 Gerrit-Change-Number: 37543 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 23 Jul 2024 12:41:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[S] Change in osmo-pcu[master]: pcuif_sock: do not retry when sending PCU version

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/37548?usp=email ) Change subject: pcuif_sock: do not retry when sending PCU version ...................................................................... pcuif_sock: do not retry when sending PCU version When some client connects to the PCU socket, the PCU sends a TXT indication with its version number in it. There is a retry mechanism in place that checks if the BTS got active. In case the BTS is not active yet, the TXT indication with the version number is repeated. This mechanism is unnecessary. It even can cause annoyance in cas the BTS on the other end does not send an info indication because it does not use GPRS/EGPRS at all. The TXT indication is sent after the PCU socket connection is made. We use a normal unix domain socket, which can not lose messages. It is guaranteed that the TXT indication reaches the client (BTS or BSC). Related: OS#6270 Change-Id: Iddd3eed113ed288e629b6029f9a56de427de8126 --- M src/pcuif_sock.c 1 file changed, 22 insertions(+), 22 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/src/pcuif_sock.c b/src/pcuif_sock.c index f8c0ecc..15b65ab 100644 --- a/src/pcuif_sock.c +++ b/src/pcuif_sock.c @@ -53,24 +53,6 @@ pcu_l1if_open(); } -static void pcu_tx_txt_retry(void *_priv) -{ - struct gprs_rlcmac_bts *bts; - bool retry = llist_empty(&the_pcu->bts_list); - - llist_for_each_entry(bts, &the_pcu->bts_list, list) { - if (bts->active) - continue; - retry = true; - pcu_tx_txt_ind(PCU_VERSION, "%s", PACKAGE_VERSION); - break; - } - - /* If no BTS (or not all) yet active, retry */ - if (retry) - osmo_timer_schedule(&pcu_sock_state.timer, 5, 0); -} - int pcu_sock_send(struct msgb *msg) { struct osmo_fd *conn_bfd; @@ -240,10 +222,6 @@ pcu_tx_txt_ind(PCU_VERSION, "%s", PACKAGE_VERSION); - /* Schedule a timer so we keep trying until the BTS becomes active. */ - osmo_timer_setup(&pcu_sock_state.timer, pcu_tx_txt_retry, NULL); - osmo_timer_schedule(&pcu_sock_state.timer, 5, 0); - return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iddd3eed113ed288e629b6029f9a56de427de8126 Gerrit-Change-Number: 37548 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 1 week

1
0
0 0

[S] Change in osmo-pcu[master]: pcuif_sock: do not retry when sending PCU version

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/37548?usp=email ) Change subject: pcuif_sock: do not retry when sending PCU version ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iddd3eed113ed288e629b6029f9a56de427de8126 Gerrit-Change-Number: 37548 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jul 2024 10:19:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[S] Change in osmo-pcu[master]: pcuif_sock: do not retry when sending PCU version

by fixeria

Attention is currently required from: dexter, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/37548?usp=email ) Change subject: pcuif_sock: do not retry when sending PCU version ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iddd3eed113ed288e629b6029f9a56de427de8126 Gerrit-Change-Number: 37548 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jul 2024 10:15:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[S] Change in osmo-pcu[master]: pcuif_sock: do not retry when sending PCU version

by fixeria

Attention is currently required from: dexter, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/37548?usp=email ) Change subject: pcuif_sock: do not retry when sending PCU version ...................................................................... Patch Set 2: (1 comment) File src/pcuif_sock.c: https://gerrit.osmocom.org/c/osmo-pcu/+/37548/comment/e5cca76d_debe5baf PS2, Line 245: osmo_timer_schedule(&pcu_sock_state.timer, 5, 0); > And I guess you also need to remove the timer from the struct now that it's not used anymore? @pespin@sysmocom.de it's also used for re-connection, check code carefully. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iddd3eed113ed288e629b6029f9a56de427de8126 Gerrit-Change-Number: 37548 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jul 2024 10:14:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: enable EVS-only codec on IMS side

by pespin

Attention is currently required from: Hoernchen, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37546?usp=email ) Change subject: asterisk: IMS: enable EVS-only codec on IMS side ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Before merging this patch, the ewild/codec_rebased branch needs to be merged into the jolly/work branch, which the ttcn3 testsuite is using so far. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37546?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1d1542f23ef7c6b2cd18afd90a169633d0d73a3f Gerrit-Change-Number: 37546 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 23 Jul 2024 10:00:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[M] Change in osmo-ci[master]: jobs/update-osmo-…: only trigger container rebuild

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37549?usp=email ) Change subject: jobs/update-osmo-…: only trigger container rebuild ...................................................................... jobs/update-osmo-…: only trigger container rebuild Installing osmo-python-tests to the jenkins nodes should not be needed anymore, as builds of almost all jenkins jobs are done in docker where we install osmo-python-tests inside the containers where it is needed. We already removed the initial deployment to jenkins nodes via ansible in I7c87bd516d1bcdbcc21f65909dabbd3ccc38eede ("ansible: osmocom_build_deps: remove"), let's adjust the job that updates osmo-python-tests too. Instead of deploying it directly, only trigger a rebuild of containers. I'm doing this now because the jenkins job started failing after I42ba71e2fd0ceb8466758ea46e9ae33e3d4fcb91 ("contrib/jenkins.sh: use virtualenv and pip") on some nodes where virtualenv is not available. The contrib/jenkins.sh script was used for both CI verification and to actually deploy this python package to the jenkins nodes, which was not really obvious and also as noted above isn't needed anymore. Change-Id: I3b06a2fc2c7182d0b0a4d13b82f67a9db1be2fd0 --- A jobs/update-containers-osmo-python-tests.yml D jobs/update-osmo-python-on-slaves.yml 2 files changed, 50 insertions(+), 47 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/jobs/update-containers-osmo-python-tests.yml b/jobs/update-containers-osmo-python-tests.yml new file mode 100644 index 0000000..63b2929 --- /dev/null +++ b/jobs/update-containers-osmo-python-tests.yml @@ -0,0 +1,25 @@ +- job: + name: update-containers-osmo-python-tests + description: | + Trigger rebuild of containers after osmo-python-tests.git has changed. + properties: + - build-discarder: + days-to-keep: 30 + num-to-keep: 120 + scm: + - git: + url: https://gerrit.osmocom.org/python/osmo-python-tests + branches: + - 'origin/master' + skip-tag: true + wipe-workspace: true + triggers: + - pollscm: + cron: "H/5 * * * *" + ignore-post-commit-hooks: false + publishers: + - trigger: + project: update-osmo-ci-on-slaves + threshold: FAILURE + - email: + recipients: jenkins-notifications(a)lists.osmocom.org diff --git a/jobs/update-osmo-python-on-slaves.yml b/jobs/update-osmo-python-on-slaves.yml deleted file mode 100644 index df01409..0000000 --- a/jobs/update-osmo-python-on-slaves.yml +++ /dev/null @@ -1,47 +0,0 @@ -- job: - name: update-osmo-python-on-slaves - project-type: matrix - axes: - - axis: - type: slave - name: label - values: - - build2-deb10build-ansible - - build2-deb11build-ansible - - build4-deb12build-ansible - - host2-deb11build-ansible - - lx2-raspbian11build-ansible - - rpi4-raspbian11build-ansible-1 - - rpi4-raspbian11build-ansible-2 - - rpi4-raspbian11build-ansible-3 - properties: - - build-discarder: - days-to-keep: 30 - num-to-keep: 120 - scm: - - git: - url: https://gerrit.osmocom.org/python/osmo-python-tests - branches: - - 'origin/master' - skip-tag: true - wipe-workspace: true - - triggers: - - pollscm: - cron: "H/5 * * * *" - ignore-post-commit-hooks: false - - builders: - - shell: './contrib/jenkins.sh' - description: | - <b>Auto-generated using Jenkins Job Builder. DO NOT EDIT MANUALLY!</b> - - # make sure to update the osmo-python in docker images, rebuilt from osmo-ci/contrib/jenkins.sh - publishers: - - trigger: - project: update-osmo-ci-on-slaves - threshold: FAILURE - - email: - recipients: jenkins-notifications(a)lists.osmocom.org - -# vim: expandtab tabstop=2 shiftwidth=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37549?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3b06a2fc2c7182d0b0a4d13b82f67a9db1be2fd0 Gerrit-Change-Number: 37549 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 1 week

1
0
0 0

[M] Change in osmo-ci[master]: jobs/update-osmo-…: only trigger container rebuild

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37549?usp=email ) Change subject: jobs/update-osmo-…: only trigger container rebuild ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37549?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3b06a2fc2c7182d0b0a4d13b82f67a9db1be2fd0 Gerrit-Change-Number: 37549 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jul 2024 09:58:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[S] Change in osmo-pcu[master]: pcuif_sock: do not retry when sending PCU version

by pespin

Attention is currently required from: dexter, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/37548?usp=email ) Change subject: pcuif_sock: do not retry when sending PCU version ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File src/pcuif_sock.c: https://gerrit.osmocom.org/c/osmo-pcu/+/37548/comment/7e3fee9a_b5c1f001 PS2, Line 245: osmo_timer_schedule(&pcu_sock_state.timer, 5, 0); And I guess you also need to remove the timer from the struct now that it's not used anymore? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iddd3eed113ed288e629b6029f9a56de427de8126 Gerrit-Change-Number: 37548 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jul 2024 09:57:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[M] Change in osmo-ci[master]: jobs/update-osmo-…: only trigger container rebuild

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37549?usp=email ) Change subject: jobs/update-osmo-…: only trigger container rebuild ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37549?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3b06a2fc2c7182d0b0a4d13b82f67a9db1be2fd0 Gerrit-Change-Number: 37549 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jul 2024 09:33:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024