July 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: enable EVS-only codec on IMS side

by laforge

Attention is currently required from: Hoernchen, jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37546?usp=email ) Change subject: asterisk: IMS: enable EVS-only codec on IMS side ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37546?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1d1542f23ef7c6b2cd18afd90a169633d0d73a3f Gerrit-Change-Number: 37546 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jul 2024 19:59:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[S] Change in docker-playground[master]: asterisk: Enable use of EVS codec

by laforge

Attention is currently required from: Hoernchen, jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37547?usp=email ) Change subject: asterisk: Enable use of EVS codec ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8bf781cbb0ae40a2bc67ede1110d50721d1f6025 Gerrit-Change-Number: 37547 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jul 2024 19:59:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[XL] Change in osmo-ttcn3-hacks[master]: sgsn: Move BSSGP_ConnHdlr code to its own file

by laforge

Attention is currently required from: daniel, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37545?usp=email ) Change subject: sgsn: Move BSSGP_ConnHdlr code to its own file ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37545?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0591cab8cca5195b8648920d5f79acc536a4efac Gerrit-Change-Number: 37545 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jul 2024 19:58:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: kpi_ranap: Avoid null pointer de-ref during HNB shutdown

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37530?usp=email ) Change subject: kpi_ranap: Avoid null pointer de-ref during HNB shutdown ...................................................................... kpi_ranap: Avoid null pointer de-ref during HNB shutdown In the downlink path, we cannot assume map->hnb_ctx is always non-NULL. If the HNB has just disconnected, it might be NULL, while we're still processing downlink messages from the CN which were sent by it before it realized that HNB was gone. Closes: SYS#7010 Change-Id: I9a304b9e0cbc18dbf7b699f4aae6b91ca0c16173 --- M src/osmo-hnbgw/kpi_ranap.c 1 file changed, 25 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/kpi_ranap.c b/src/osmo-hnbgw/kpi_ranap.c index 59631cf..d731c5f 100644 --- a/src/osmo-hnbgw/kpi_ranap.c +++ b/src/osmo-hnbgw/kpi_ranap.c @@ -179,6 +179,13 @@ void kpi_ranap_process_dl(struct hnbgw_context_map *map, ranap_message *ranap) { + if (map->hnb_ctx == NULL) { + /* This can happen if the HNB has disconnected and we are processing downlink messages + * from the CN which were already in flight before the CN side has realized the HNB + * is gone. */ + return; + } + switch (ranap->procedureCode) { case RANAP_ProcedureCode_id_RAB_Assignment: /* RAB ASSIGNMENT REQ (8.2) */ kpi_ranap_process_dl_rab_ass_req(map, ranap); @@ -405,6 +412,9 @@ void kpi_ranap_process_ul(struct hnbgw_context_map *map, ranap_message *ranap) { + /* we should never be processing uplink messages from a non-existant HNB */ + OSMO_ASSERT(map->hnb_ctx); + switch (ranap->procedureCode) { case RANAP_ProcedureCode_id_RAB_Assignment: /* RAB ASSIGNMENT REQ (8.2) */ kpi_ranap_process_ul_rab_ass_resp(map, ranap); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37530?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9a304b9e0cbc18dbf7b699f4aae6b91ca0c16173 Gerrit-Change-Number: 37530 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: kpi_ranap: Avoid null pointer de-ref during HNB shutdown

by fixeria

Attention is currently required from: iedemam, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37530?usp=email ) Change subject: kpi_ranap: Avoid null pointer de-ref during HNB shutdown ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37530?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9a304b9e0cbc18dbf7b699f4aae6b91ca0c16173 Gerrit-Change-Number: 37530 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Jul 2024 19:27:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: expected-results.xml: Add missing TC_sgsn_context_req_{in,out}

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37544?usp=email ) Change subject: sgsn: expected-results.xml: Add missing TC_sgsn_context_req_{in,out} ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: We do not expect those to pass yet (patches not merged). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37544?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2579958bbf8c28b72e58174e60634ca77c71dfee Gerrit-Change-Number: 37544 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jul 2024 19:23:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[XL] Change in osmo-ttcn3-hacks[master]: sgsn: Move BSSGP_ConnHdlr code to its own file

by fixeria

Attention is currently required from: daniel, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37545?usp=email ) Change subject: sgsn: Move BSSGP_ConnHdlr code to its own file ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37545/comment/5d88ac4e_0aaf… PS1, Line 902: } "No newline at end of right file." -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37545?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0591cab8cca5195b8648920d5f79acc536a4efac Gerrit-Change-Number: 37545 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jul 2024 19:22:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[M] Change in pysim[master]: pySim-shell: add "fsdump" command

by fixeria

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37543?usp=email ) Change subject: pySim-shell: add "fsdump" command ...................................................................... Patch Set 1: Code-Review+1 (3 comments) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37543/comment/d78d413d_69d5eb82 PS1, Line 731: # the EF we want to export. To maintain consistency we will then tabs vs spaces https://gerrit.osmocom.org/c/pysim/+/37543/comment/cf7c3f6e_de14d3ad PS1, Line 784: result[0]) don't you need to do `str()` like above? https://gerrit.osmocom.org/c/pysim/+/37543/comment/17ebafdc_3dab3e56 PS1, Line 790: else cosmetic: `else` is not needed after `break` or `return` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib179f57bc04d394efe11003ba191dca6098192d3 Gerrit-Change-Number: 37543 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jul 2024 19:19:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[S] Change in pysim[master]: pySim.global_platform.ota: Support KVN 0x70 for SCP02

by fixeria

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37542?usp=email ) Change subject: pySim.global_platform.ota: Support KVN 0x70 for SCP02 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37542?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I00d52f7629aae190ee487ea3453f42b5f94cf42f Gerrit-Change-Number: 37542 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jul 2024 18:48:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

[S] Change in pysim[master]: saip-tool: Fix TAR display for implicit TAR

by fixeria

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37541?usp=email ) Change subject: saip-tool: Fix TAR display for implicit TAR ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37541?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I76133b0e02996a138257f3fba5ceb0d2fc6fad80 Gerrit-Change-Number: 37541 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jul 2024 18:47:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024