lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

July 2024

  • 1 participants
  • 1379 discussions
[S] Change in osmo-ttcn3-hacks[master]: deps: Update titan.ProtocolEmulations.M3UA to current master
by pespin 25 Jul '24

25 Jul '24
Attention is currently required from: laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37605?usp=email ) Change subject: deps: Update titan.ProtocolEmulations.M3UA to current master ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: https://gitlab.eclipse.org/eclipse/titan/titan.ProtocolEmulations.M3UA/-/co… -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37605?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4037fdd6ada765b2e041426393fcc506dd7885ff Gerrit-Change-Number: 37605 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 25 Jul 2024 09:01:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: msc: Use template ts_RAB_SMdL
by pespin 25 Jul '24

25 Jul '24
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37552?usp=email ) Change subject: msc: Use template ts_RAB_SMdL ...................................................................... msc: Use template ts_RAB_SMdL Change-Id: I768aad762c4fa6c0d3a6d0effd7a7a1aabb3488f --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 17 insertions(+), 39 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index c82d36a..467f387 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -1298,27 +1298,11 @@ [] BSSAP.receive(tr_RANAP_RabAssReq(?)) -> value ranap { log("f_mt_call_complete 6.iu"); var RAB_ID rab_id := f_ranap_rab_ass_req_extract_rab_id(ranap); - var RAB_SetupOrModifiedList l := { - { - { - id := id_RAB_SetupOrModifiedItem, - criticality := ignore, - value_ := { - rAB_SetupOrModifiedItem := { - rAB_ID := rab_id, - transportLayerAddress := hex2bit( '350001c0a8021500000000000000000000000000'H), - iuTransportAssociation := { - bindingID := '040c0000'O - }, - dl_dataVolumes := omit, - iE_Extensions := omit - } - } - } - } - }; + var template (value) RAB_SetupOrModifiedList l := + ts_RAB_SMdL(rab_id, + hex2bit('350001c0a8021500000000000000000000000000'H), + '040c0000'O); BSSAP.send(ts_RANAP_RabAssResp(l)); - BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_CC_CONNECT(cpars.transaction_id))); } @@ -1780,25 +1764,10 @@ [] BSSAP.receive(tr_RANAP_RabAssReq(*)) -> value ranap { log("f_mo_call_establish 4.iu: rx RANAP RAB Assignment Request"); var RAB_ID rab_id := f_ranap_rab_ass_req_extract_rab_id(ranap); - var RAB_SetupOrModifiedList l := { - { - { - id := id_RAB_SetupOrModifiedItem, - criticality := ignore, - value_ := { - rAB_SetupOrModifiedItem := { - rAB_ID := rab_id, - transportLayerAddress := hex2bit( '350001c0a8021500000000000000000000000000'H), - iuTransportAssociation := { - bindingID := '040c0000'O - }, - dl_dataVolumes := omit, - iE_Extensions := omit - } - } - } - } - }; + var template (value) RAB_SetupOrModifiedList l := + ts_RAB_SMdL(rab_id, + hex2bit('350001c0a8021500000000000000000000000000'H), + '040c0000'O); BSSAP.send(ts_RANAP_RabAssResp(l)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I768aad762c4fa6c0d3a6d0effd7a7a1aabb3488f Gerrit-Change-Number: 37552 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: msc: Use RAB_ID obtained from RAB-AssReq
by pespin 25 Jul '24

25 Jul '24
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37551?usp=email ) Change subject: msc: Use RAB_ID obtained from RAB-AssReq ...................................................................... msc: Use RAB_ID obtained from RAB-AssReq The helper function will be used too by follow-up patches. Change-Id: If532c41304803d223591ce8e0c10dda4a562dfb8 --- M library/ranap/RANAP_Templates.ttcn M msc/BSC_ConnectionHandler.ttcn 2 files changed, 24 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/library/ranap/RANAP_Templates.ttcn b/library/ranap/RANAP_Templates.ttcn index 8e6c8f3..7fb374d 100644 --- a/library/ranap/RANAP_Templates.ttcn +++ b/library/ranap/RANAP_Templates.ttcn @@ -1870,5 +1870,12 @@ return omit; } +function f_ranap_rab_ass_req_extract_rab_id(RANAP_PDU ranap) return RAB_ID +{ + var RAB_AssignmentRequest.protocolIEs ies := ranap.initiatingMessage.value_.rAB_AssignmentRequest.protocolIEs; + var RAB_ID rab_id := ies[0].value_.rAB_SetupOrModifyList[0][0].firstValue.rAB_SetupOrModifyItemFirst.rAB_ID; + return rab_id; +} + } diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 16309ed..c82d36a 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -1122,6 +1122,7 @@ var template MgcpResponse mgcp_resp; var MgcpOsmuxCID osmux_cid; var PDU_BSSAP bssap; + var RANAP_PDU ranap; f_ran_register_imsi(g_pars.imsi, g_pars.tmsi); @@ -1294,8 +1295,9 @@ log("f_mt_call_complete 5.iu"); } - [] BSSAP.receive(tr_RANAP_RabAssReq(?)) { + [] BSSAP.receive(tr_RANAP_RabAssReq(?)) -> value ranap { log("f_mt_call_complete 6.iu"); + var RAB_ID rab_id := f_ranap_rab_ass_req_extract_rab_id(ranap); var RAB_SetupOrModifiedList l := { { { @@ -1303,7 +1305,7 @@ criticality := ignore, value_ := { rAB_SetupOrModifiedItem := { - rAB_ID := int2bit(23, 8), + rAB_ID := rab_id, transportLayerAddress := hex2bit( '350001c0a8021500000000000000000000000000'H), iuTransportAssociation := { bindingID := '040c0000'O @@ -1777,6 +1779,7 @@ } [] BSSAP.receive(tr_RANAP_RabAssReq(*)) -> value ranap { log("f_mo_call_establish 4.iu: rx RANAP RAB Assignment Request"); + var RAB_ID rab_id := f_ranap_rab_ass_req_extract_rab_id(ranap); var RAB_SetupOrModifiedList l := { { { @@ -1784,7 +1787,7 @@ criticality := ignore, value_ := { rAB_SetupOrModifiedItem := { - rAB_ID := int2bit(23, 8), + rAB_ID := rab_id, transportLayerAddress := hex2bit( '350001c0a8021500000000000000000000000000'H), iuTransportAssociation := { bindingID := '040c0000'O -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If532c41304803d223591ce8e0c10dda4a562dfb8 Gerrit-Change-Number: 37551 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: library/GTP_Emulation: Check IMSI presence before returning if Condit...
by pespin 25 Jul '24

25 Jul '24
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37553?usp=email ) Change subject: library/GTP_Emulation: Check IMSI presence before returning if Conditional or Optional ...................................................................... library/GTP_Emulation: Check IMSI presence before returning if Conditional or Optional Change-Id: I73c683e62191a06212933391d424d608a14f8c1e --- M library/GTP_Emulation.ttcn 1 file changed, 60 insertions(+), 11 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/library/GTP_Emulation.ttcn b/library/GTP_Emulation.ttcn index f7c54a1..afe4217 100644 --- a/library/GTP_Emulation.ttcn +++ b/library/GTP_Emulation.ttcn @@ -118,11 +118,23 @@ if (ischosen(gtp.gtpc_pdu.createPDPContextRequest)) { return gtp.gtpc_pdu.createPDPContextRequest.imsi.digits; } else if (ischosen(gtp.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestSGSN)) { - return gtp.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestSGSN.imsi.digits; + if (ispresent(gtp.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestSGSN.imsi.digits)) { + return gtp.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestSGSN.imsi.digits; + } else { + return omit; + } } else if (ischosen(gtp.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestGGSN)) { - return gtp.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestGGSN.imsi.digits; + if (ispresent(gtp.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestGGSN.imsi.digits)) { + return gtp.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestGGSN.imsi.digits; + } else { + return omit; + } } else if (ischosen(gtp.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestCGW)) { - return gtp.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestCGW.imsi.digits; + if (ispresent(gtp.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestCGW.imsi.digits)) { + return gtp.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestCGW.imsi.digits; + } else { + return omit; + } } else if (ischosen(gtp.gtpc_pdu.pdu_NotificationRequest)) { return gtp.gtpc_pdu.pdu_NotificationRequest.imsi.digits; } else if (ischosen(gtp.gtpc_pdu.sendRouteingInformationForGPRSRequest)) { @@ -133,8 +145,12 @@ return gtp.gtpc_pdu.failureReportRequest.imsi.digits; } else if (ischosen(gtp.gtpc_pdu.noteMS_GPRSPresentRequest)) { return gtp.gtpc_pdu.noteMS_GPRSPresentRequest.imsi.digits; - } else if (ischosen(gtp.gtpc_pdu.identificationResponse) ){ - return gtp.gtpc_pdu.identificationResponse.imsi.digits; + } else if (ischosen(gtp.gtpc_pdu.identificationResponse) ) { + if (ispresent(gtp.gtpc_pdu.identificationResponse.imsi.digits)) { + return gtp.gtpc_pdu.identificationResponse.imsi.digits; + } else { + return omit; + } } else if (ischosen(gtp.gtpc_pdu.sgsn_ContextRequest)) { if (ispresent(gtp.gtpc_pdu.sgsn_ContextRequest.imsi.digits)) { return gtp.gtpc_pdu.sgsn_ContextRequest.imsi.digits; @@ -148,9 +164,17 @@ return omit; } } else if (ischosen(gtp.gtpc_pdu.forwardRelocationRequest)) { - return gtp.gtpc_pdu.forwardRelocationRequest.imsi.digits; + if (ispresent(gtp.gtpc_pdu.forwardRelocationRequest.imsi.digits)) { + return gtp.gtpc_pdu.forwardRelocationRequest.imsi.digits; + } else { + return omit; + } } else if (ischosen(gtp.gtpc_pdu.relocationCancelRequest)) { - return gtp.gtpc_pdu.relocationCancelRequest.imsi.digits; + if (ispresent(gtp.gtpc_pdu.relocationCancelRequest.imsi.digits)) { + return gtp.gtpc_pdu.relocationCancelRequest.imsi.digits; + } else { + return omit; + } } else if (ischosen(gtp.gtpc_pdu.uERegistrationQueryRequest)) { return gtp.gtpc_pdu.uERegistrationQueryRequest.imsi.digits; } else if (ischosen(gtp.gtpc_pdu.uERegistrationQueryResponse)) { @@ -158,13 +182,29 @@ } else if (ischosen(gtp.gtpc_pdu.mBMSNotificationRequest)) { return gtp.gtpc_pdu.mBMSNotificationRequest.imsi.digits; } else if (ischosen(gtp.gtpc_pdu.createMBMSContextRequest)) { - return gtp.gtpc_pdu.createMBMSContextRequest.imsi.digits; + if (ispresent(gtp.gtpc_pdu.createMBMSContextRequest.imsi.digits)) { + return gtp.gtpc_pdu.createMBMSContextRequest.imsi.digits; + } else { + return omit; + } } else if (ischosen(gtp.gtpc_pdu.deleteMBMSContextRequest)) { - return gtp.gtpc_pdu.deleteMBMSContextRequest.imsi.digits; + if (ispresent(gtp.gtpc_pdu.deleteMBMSContextRequest.imsi.digits)) { + return gtp.gtpc_pdu.deleteMBMSContextRequest.imsi.digits; + } else { + return omit; + } } else if (ischosen(gtp.gtpc_pdu.mS_InfoChangeNotificationRequest)) { - return gtp.gtpc_pdu.mS_InfoChangeNotificationRequest.imsi.digits; + if (ispresent(gtp.gtpc_pdu.mS_InfoChangeNotificationRequest.imsi.digits)) { + return gtp.gtpc_pdu.mS_InfoChangeNotificationRequest.imsi.digits; + } else { + return omit; + } } else if (ischosen(gtp.gtpc_pdu.mS_InfoChangeNotificationResponse)) { - return gtp.gtpc_pdu.mS_InfoChangeNotificationResponse.imsi.digits; + if (ispresent(gtp.gtpc_pdu.mS_InfoChangeNotificationResponse.imsi.digits)) { + return gtp.gtpc_pdu.mS_InfoChangeNotificationResponse.imsi.digits; + } else { + return omit; + } } else { return omit; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I73c683e62191a06212933391d424d608a14f8c1e Gerrit-Change-Number: 37553 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: library/GTPv1C_Templates: Introduce template ts_GTPC_UpdatePdpRespGGSN
by pespin 25 Jul '24

25 Jul '24
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37554?usp=email ) Change subject: library/GTPv1C_Templates: Introduce template ts_GTPC_UpdatePdpRespGGSN ...................................................................... library/GTPv1C_Templates: Introduce template ts_GTPC_UpdatePdpRespGGSN Will be used by SGSN_Tests in a follow-up patch. Change-Id: I91afc14eecfadb3e00ccb9b74794079a82ef884b --- M library/GTPv1C_Templates.ttcn 1 file changed, 66 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn index 2eb1d7e..fe0db2b 100644 --- a/library/GTPv1C_Templates.ttcn +++ b/library/GTPv1C_Templates.ttcn @@ -994,6 +994,61 @@ eua, recovery, pco)), seq) } + template (value) GTPC_PDUs ts_UpdatePdpRespGGSNPDU(OCT1 cause, OCT4 teid_data, OCT4 teid_ctrl, + octetstring ggsn_ip_sign, octetstring ggsn_ip_data, + OCT4 chg_id, template (omit) EndUserAddress eua := omit, + template (omit) Recovery_gtpc recovery := omit, + template (omit) ProtConfigOptions pco := omit) := { + updatePDPContextResponse := { + updatePDPContextResponseGGSN := { + + cause := { '00'O, cause }, + recovery := recovery, + teidDataI := { + type_gtpc := '00'O, + teidDataI := teid_data + }, + teidControlPlane := { + type_gtpc := '00'O, + teidControlPlane := teid_ctrl + }, + chargingID := { + type_gtpc := '7F'O, + chargingID := chg_id + }, + protConfigOptions := pco, + ggsn_addr_controlPlane := ts_GsnAddr(ggsn_ip_sign), + ggsn_addr_traffic := ts_GsnAddr(ggsn_ip_data), + alt_ggsn_addr_controlPane := omit, + alt_ggsn_addr_traffic := omit, + qualityOfServiceProfile := ts_QosDefault, + commonFlags := omit, + aPN_Restriction := omit, + mS_InfoChangeReportingAction := omit, + bearerControlMode := omit, + evolvedAllocationRetentionPriorityI := omit, + csg_information_reporting_action := omit, + aPN_AMBR := omit, + private_extension_gtpc := omit + } + } + } + + template (value) Gtp1cUnitdata ts_GTPC_UpdatePdpRespGGSN(Gtp1cPeer peer, uint16_t seq, OCT4 teid, + OCT1 cause, + OCT4 teid_ctrl, OCT4 teid_data, + octetstring ggsn_ip_sign, + octetstring ggsn_ip_data, OCT4 chg_id, + template (omit) EndUserAddress eua := omit, + template (omit) Recovery_gtpc recovery := omit, + template (omit) ProtConfigOptions pco := omit) := { + peer := peer, + gtpc := ts_GTP1C_PDU(updatePDPContextResponse, teid, + valueof(ts_UpdatePdpRespGGSNPDU(cause, teid_data, teid_ctrl, + ggsn_ip_sign, ggsn_ip_data, chg_id, + eua, recovery, pco)), seq) + } + /* PCO send base template */ template (value) ProtConfigOptions ts_PCO := { type_gtpc := '84'O, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I91afc14eecfadb3e00ccb9b74794079a82ef884b Gerrit-Change-Number: 37554 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: library/GTPv1C_Templates: Introduce template ts_GTPC_UpdatePdpRespGGSN
by pespin 25 Jul '24

25 Jul '24
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37554?usp=email ) Change subject: library/GTPv1C_Templates: Introduce template ts_GTPC_UpdatePdpRespGGSN ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I91afc14eecfadb3e00ccb9b74794079a82ef884b Gerrit-Change-Number: 37554 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Jul 2024 09:00:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: library/GTP_Emulation: Check IMSI presence before returning if Condit...
by pespin 25 Jul '24

25 Jul '24
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37553?usp=email ) Change subject: library/GTP_Emulation: Check IMSI presence before returning if Conditional or Optional ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I73c683e62191a06212933391d424d608a14f8c1e Gerrit-Change-Number: 37553 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Jul 2024 09:00:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: library/GTPv1C_Templates: Introduce template ts_GTPC_UpdatePdpRespGGSN
by pespin 25 Jul '24

25 Jul '24
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37554?usp=email ) Change subject: library/GTPv1C_Templates: Introduce template ts_GTPC_UpdatePdpRespGGSN ...................................................................... Patch Set 2: (1 comment) File library/GTPv1C_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37554/comment/663151eb_9270… PS2, Line 1047: ts_UpdatePdpRespGGSNPDU > why not just letting the caller pass a template param with all these params? It's done the same way for all the templates in this file, so not changing this here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I91afc14eecfadb3e00ccb9b74794079a82ef884b Gerrit-Change-Number: 37554 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Jul 2024 08:59:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-sip-connector[master]: Bump version: 1.6.3.12-6725 → 1.7.0
by pespin 25 Jul '24

25 Jul '24
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/37604?usp=email ) Change subject: Bump version: 1.6.3.12-6725 → 1.7.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/37604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ia741d0a574828da121693fa73f54f517ad9d2be2 Gerrit-Change-Number: 37604 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Jul 2024 08:57:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-hnodeb[master]: Bump version: 0.1.2.15-cb5e → 0.2.0
by pespin 25 Jul '24

25 Jul '24
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/37603?usp=email ) Change subject: Bump version: 0.1.2.15-cb5e → 0.2.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/37603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I2d4a8d92d697f28844380f6ef64d858f00ceffe7 Gerrit-Change-Number: 37603 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Jul 2024 08:56:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 38
  • 39
  • 40
  • 41
  • 42
  • 43
  • 44
  • ...
  • 138
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.