July 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-mgw[master]: Bump version: 1.12.1.58-95e50-dirty → 1.13.0

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37579?usp=email ) Change subject: Bump version: 1.12.1.58-95e50-dirty → 1.13.0 ...................................................................... Bump version: 1.12.1.58-95e50-dirty → 1.13.0 Change-Id: I46cabfda147bf700fb29a0b8eecf54560a1d378d --- M TODO-RELEASE M configure.ac M debian/changelog M debian/control R debian/libosmo-mgcp-client14.install M src/libosmo-mgcp-client/Makefile.am 6 files changed, 112 insertions(+), 55 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 59da45b..bdb3915 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -1,43 +1,11 @@ -# When cleaning up this file upon a release: -# -# - Note that the release version number is entirely unrelated to the API -# versions. A release version 5.2.3 may happily have an API version of 42:7:5. -# -# - Bump API version in src/lib*/Makefile.am files according to chapter -# "Library interface versions" of the libtool documentation. -# https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info… -# -# - Iff the 'current' API version has changed, rename debian/lib*.install -# -# API version bumping for the impatient: -# LIBVERSION=c:r:a (current:revision_of_current:backwards_compat_age) -# 5:2:4 means that -# - this implements version 5 of the API; -# - this is the 2nd (compatible) revision of API version 5; -# - this is backwards compatible to all APIs since 4 versions ago, -# i.e. callers that need API versions from 1 to 5 can use this. -# -# Bumping API versions recipe: -# If the library source code has changed at all since the last update, r++; -# If any interfaces have been added, removed, or changed since the last update, c++, r=0; -# If any interfaces have been added since the last public release, a++; -# If any interfaces have been removed or changed since the last public release, a=0. -# -#library what description / commit summary line -libosmo-mgcp-client remove public API These public API items have not been called by any of our osmo-programs - for many years. Any sane caller of libosmo-mgcp-client should use the - higher level osmo_mgcpc_* API instead. Move these to a private header: - struct mgcp_response_head - struct mgcp_response - struct mgcp_msg - mgcp_response_parse_params() - mgcp_client_tx() - mgcp_client_cancel() - mgcp_msg_gen() - mgcp_msg_trans_id() -libosmo-mgcp-client deprecate public API New code should no longer use codecs[], instead use ptmap[].codec. There - is backwards compat code that moves codecs[] entries, if any, over to - ptmap[], so callers may migrate at own leisure. -osmo-mgw remove cfg Remove VTY config item 'sdp audio fmtp-extra' (see OS#6313) +# When cleaning up this file: bump API version in corresponding Makefile.am and rename corresponding debian/lib*.install +# according to https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release +# In short: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info… +# LIBVERSION=c:r:a +# If the library source code has changed at all since the last update, then increment revision: c:r + 1:a. +# If any interfaces have been added, removed, or changed since the last update: c + 1:0:a. +# If any interfaces have been added since the last public release: c:r:a + 1. +# If any interfaces have been removed or changed since the last public release: c:r:0. +#library what description / commit summary line libosmocore bump_dep; workaround Bump libosmocore version dependency after I68328adb952ca8833ba047cb3b49ccc6f8a1f1b5 has been merged to libosmocore.git; then remove my_msgb_copy_c wrapper function. diff --git a/configure.ac b/configure.ac index 2c4974b..294df05 100644 --- a/configure.ac +++ b/configure.ac @@ -44,13 +44,13 @@ AC_SUBST(LIBRARY_DLSYM) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.9.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.9.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.9.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.9.0) -PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.4.0) -PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.5.0) -PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.10.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.10.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.10.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.10.0) +PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 1.6.0) CFLAGS="$CFLAGS -DBUILDING_LIBOSMOMGCPCLIENT -pthread" CPPFLAGS="$CPPFLAGS -DBUILDING_LIBOSMOMGCPCLIENT -pthread" diff --git a/debian/changelog b/debian/changelog index 1e23bc2..f173ac1 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,83 @@ +osmo-mgw (1.13.0) unstable; urgency=medium + + [ Neels Hofmeyr ] + * add mgcp_conn_rtp_type_names[] + * mgcp_parse_audio_port_pt(): fix buffer overflow + * client: replace two assertions with graceful error handling + * systemd,manual: set LimitNOFILE=65536 + * IuUP: allow Initialization from any address if not yet set + * check_rtp_origin: drop special case for legacy IuUP hack + * mgcp_client_test: fix function name + * fix possible NULL deref on early media + * client: move some items to internal header + * client: safely handle dealloc on event dispatch + * build: move mgcp/*.h to noinst_HEADERS, drop RPM libosmo-mgcp-devel + * client: deprecate legacy API + * client: collapse codecs[] and ptmap[]; allow codec variants + * client: allow MGCP_MAX_CODECS entries + * client SDP: more verbose error logging + * mgcp_client_test: add test_parse_response() + * drop (now) unused code + * tests/mgcp: add update_exp target + * drop get_net_downlink_format_cb + * drop cfg 'sdp audio fmtp-extra' + * mgcp_codec_decide: remove redundant lookup + * tweak DEBUG log + * mgcp_test: fix false negatives in test output + * mgw: do not fail MGCP on codec mismatch + * mgcp-client: always send 'm=audio' line + * mgcp_test.c: verify osmo-mgw accepts m=audio 0 + * mgcp_test.c: fix various missing '\r' and '\n' + * mgcp_test: test a=ptime:20, not 40 + * mgcp_test: add CRCX for IUFP in sendrecv + * do not FAIL on CRCX in sendrecv mode + + [ Keith Whyte ] + * vty and log: also show local port for RTP conns + + [ Andreas Eversberg ] + * Use uniform log format for default config files + + [ Pau Espin Pedrol ] + * mgcp_network: Improve err logging when rtp pkt from unexpected origin comes in + * cosmetic: Fix line indentation + * IuUP: Allow Initialization with set rem IP address and unset rem port + * mgcp-client: Transmit remote IP addr in CRCX if known and port=0 + * Fix IuUP RTP hdr seqnr field not incremented + * iuup: Increment RTP hdr seqnr even if Tx over UDP fails + + [ Vadim Yanitskiy ] + * mgcp: simplify getting msgb tail in mgcp_msg_terminate_nul() + * mgcp: reserve once byte for '\0' in mgcp_do_read() + * mgcp: correctly put NUL character in mgcp_msg_terminate_nul() + * build: include README into the release tarball + + [ neels ] + * Revert "drop (now) unused code" + + [ Harald Welte ] + * Convert README to README.md and expand like in other projects + * migrate mgcp_client from osmo_wqueue to osmo_io + * mgw: Add our usual SIGABRT, SIGUSR1 signal handlers + * don't log useless "transcoding disabled" message + * remove strange loop for non-existant transcoding support + * simplify unused transcoding/processing call-back + * remove osmo_fd from mgcp_create_bind() + * Change msgb ownership in processing of received msgb + * cosmetic: make linter happy + * Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io + + [ Oliver Smith ] + * contrib: remove rpm spec file + * contrib/systemd: run as osmocom user + * doc: example configs: fix deprecation warnings + + [ Mychaela N. Falconia ] + * E1: support HRv1 codec on both 16k and 8k subslots + * fix E1 TS output when used with osmo-e1d + + -- Oliver Smith <osmith(a)sysmocom.de> Wed, 24 Jul 2024 15:44:47 +0200 + osmo-mgw (1.12.1) unstable; urgency=medium [ Pau Espin Pedrol ] diff --git a/debian/control b/debian/control index f894f97..05245a8 100644 --- a/debian/control +++ b/debian/control @@ -6,10 +6,10 @@ dh-autoreconf, pkg-config, autotools-dev, - libosmocore-dev (>= 1.9.0), - libosmo-netif-dev (>= 1.4.0), - libosmo-abis-dev (>= 1.5.0), - osmo-gsm-manuals-dev (>= 1.5.0) + libosmocore-dev (>= 1.10.0), + libosmo-netif-dev (>= 1.5.0), + libosmo-abis-dev (>= 1.6.0), + osmo-gsm-manuals-dev (>= 1.6.0) Standards-Version: 3.9.8 Vcs-Git: https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw Vcs-Browser: https://gitea.osmocom.org/cellular-infrastructure/osmo-mgw @@ -21,7 +21,7 @@ Depends: ${misc:Depends}, ${shlibs:Depends} Description: OsmoMGW: Osmocom's Media Gateway for 2G and 3G circuit-switched mobile networks -Package: libosmo-mgcp-client12 +Package: libosmo-mgcp-client14 Section: libs Architecture: any Multi-Arch: same @@ -33,7 +33,7 @@ Section: libdevel Architecture: any Multi-Arch: same -Depends: libosmo-mgcp-client12 (= ${binary:Version}), ${misc:Depends} +Depends: libosmo-mgcp-client14 (= ${binary:Version}), ${misc:Depends} Description: libosmo-mgcp-client: Osmocom's Media Gateway Control Protocol client utilities Package: osmo-mgw-doc diff --git a/debian/libosmo-mgcp-client12.install b/debian/libosmo-mgcp-client14.install similarity index 100% rename from debian/libosmo-mgcp-client12.install rename to debian/libosmo-mgcp-client14.install diff --git a/src/libosmo-mgcp-client/Makefile.am b/src/libosmo-mgcp-client/Makefile.am index b2bed9a..83e3c97 100644 --- a/src/libosmo-mgcp-client/Makefile.am +++ b/src/libosmo-mgcp-client/Makefile.am @@ -19,7 +19,7 @@ # This is not at all related to the release version, but a range of supported # API versions. Read TODO_RELEASE in the source tree's root! -MGCP_CLIENT_LIBVERSION=13:0:1 +MGCP_CLIENT_LIBVERSION=14:0:0 lib_LTLIBRARIES = \ libosmo-mgcp-client.la \ -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I46cabfda147bf700fb29a0b8eecf54560a1d378d Gerrit-Change-Number: 37579 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/L3_Templates: Fix discriminator field in ts_GMM_DET_ACCEPT_MO

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37556?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: library/L3_Templates: Fix discriminator field in ts_GMM_DET_ACCEPT_MO ...................................................................... library/L3_Templates: Fix discriminator field in ts_GMM_DET_ACCEPT_MO It says it's overwritten, so in practice it may not be important, but it's confusing for readers when figuring out which values are expected, eg when adding a new tr_ template which needs that field set right (not overwritten there). Change-Id: If9741953f98b7dd29749d335a5bd937fdfb62bc6 --- M library/L3_Templates.ttcn 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index 77d949b..4c9a2f6 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -3061,7 +3061,7 @@ } template PDU_L3_MS_SGSN ts_GMM_DET_ACCEPT_MO := { - discriminator := '0000'B, /* overwritten */ + discriminator := '1000'B, /* overwritten */ tiOrSkip := { skipIndicator := '0000'B }, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If9741953f98b7dd29749d335a5bd937fdfb62bc6 Gerrit-Change-Number: 37556 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/L3_Templates: Introduce templates for GMM Service Req/Acc/Rej

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37555?usp=email ) Change subject: library/L3_Templates: Introduce templates for GMM Service Req/Acc/Rej ...................................................................... library/L3_Templates: Introduce templates for GMM Service Req/Acc/Rej Those will be used by a follow-up patch in SGSN_Tests. Change-Id: Ia948a27e39cf11f1421396d15da32bd82ea9513c --- M library/L3_Templates.ttcn 1 file changed, 100 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index 710b0ea..77d949b 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -44,6 +44,15 @@ CM_ID_TYPE_PTMSI_RAI_PTMSI_SIG ('101'B) } +/* TS 24.008 10.5.5.20 Service type */ +type enumerated ServiceType { + SERVICE_TYPE_Signalling ('001'B), + SERVICE_TYPE_Data ('010'B), + SERVICE_TYPE_Paging_Response ('011'B), + SERVICE_TYPE_MBMS_Multicast_Service_Reception ('100'B), + SERVICE_TYPE_MBMS_Broadcast_Service_Reception ('101'B) +} + template ML3_Cause_TLV ts_ML3_Cause(BIT7 cause, BIT4 loc := '0001'B, BIT2 std := '11'B) := { elementIdentifier := '08'O, lengthIndicator := 0, /* overwritten */ @@ -148,7 +157,7 @@ /* send template for Mobile Identity (TMSI) */ -template MobileIdentityLV ts_MI_TMSI_LV(OCT4 tmsi) := { +template MobileIdentityLV ts_MI_TMSI_LV(template (value) OCT4 tmsi) := { lengthIndicator := 0, /* overwritten */ mobileIdentityV := { typeOfIdentity := '000'B, /* overwritten */ @@ -315,6 +324,14 @@ fop := '0'B }; +/* TS 24.008 10.5.7.1 PDPContextStatus */ +template (value) PDPContextStatusTLV ts_PDPContextStatusTLV(template (value) OCT2 status := '0000'O /* all inactive */) := { + elementIdentifier := '32'O, + lengthIndicator := 0, /* overwritten */ + valueField := status +}; + + /* Send template for LOCATION UPDATING REQUEST */ template (value) PDU_ML3_MS_NW ts_LU_REQ(template (value) LocationUpdatingType lu_type, template (value) MobileIdentityLV mi_lv, @@ -431,8 +448,8 @@ } } -template (value) CipheringKeySequenceNumberV ts_CKSN(integer key_seq) := { - keySequence := int2bit(key_seq, 3), +template (value) CipheringKeySequenceNumberV ts_CKSN(template (value) integer key_seq) := { + keySequence := int2bit(valueof(key_seq), 3), spare := '0'B } @@ -2974,6 +2991,75 @@ } } +template (value) ServiceTypeV ts_ServiceTypeV(template (value) ServiceType serviceType) := { + serviceType := int2bit(enum2int(valueof(serviceType)), 3), + spare := '0'B +} +template (present) ServiceTypeV tr_ServiceTypeV(template (present) BIT3 serviceType := ?) := { + serviceType := serviceType, + spare := '0'B +} + +/* 3GPP TS 24.008 9.4.20 Service Request (Iu mode only) */ +template (value) PDU_L3_MS_SGSN ts_GMM_SERVICE_REQ(template (value) ServiceType service_type, + template (value) OCT4 p_tmsi, + template (value) integer cksn := 0, + template (value) OCT2 pdp_status := '0000'O) := { + discriminator := '1000'B, /* overwritten */ + tiOrSkip := { + skipIndicator := '0000'B + }, + msgs := { + gprs_mm := { + serviceRequest := { + messageType := '00001100'B, /* overwritten */ + cipheringKeySeqNum := ts_CKSN(cksn), + serviceType := ts_ServiceTypeV(service_type), + ptmsi := ts_MI_TMSI_LV(p_tmsi), + pdpContextStatus := ts_PDPContextStatusTLV(pdp_status), + mBMS_ContextStatus := omit, + uplinkDataStatus := omit, + deviceProperties := omit + } + } + } +} + +/* 3GPP TS 24.008 9.4.21 Service Accept (Iu mode only) */ +template (present) PDU_L3_SGSN_MS tr_GMM_SERVICE_ACC(template PDPContextStatusTLV pdp_status := *) := { + discriminator := '1000'B, /* overwritten */ + tiOrSkip := { + skipIndicator := '0000'B + }, + msgs := { + gprs_mm := { + serviceAccept := { + messageType := '00001101'B, /* overwritten */ + pdpContextStatus := pdp_status, + mBMS_ContextStatus := * + } + } + } +} + +/* 3GPP TS 24.008 9.4.22 Service Reject (Iu mode only) */ +template (present) PDU_L3_SGSN_MS tr_GMM_SERVICE_REJ(template (present) GMM_CauseV gmmCause := ?, + template GPRSTimer2TLV t3346 := *) := { + discriminator := '1000'B, /* overwritten */ + tiOrSkip := { + skipIndicator := '0000'B + }, + msgs := { + gprs_mm := { + serviceReject := { + messageType := '00001110'B, /* overwritten */ + gmmCause := gmmCause, + t3346 := t3346 + } + } + } +} + template PDU_L3_MS_SGSN ts_GMM_DET_ACCEPT_MO := { discriminator := '0000'B, /* overwritten */ tiOrSkip := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia948a27e39cf11f1421396d15da32bd82ea9513c Gerrit-Change-Number: 37555 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/L3_Templates: Introduce templates for GMM Service Req/Acc/Rej

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37555?usp=email ) Change subject: library/L3_Templates: Introduce templates for GMM Service Req/Acc/Rej ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia948a27e39cf11f1421396d15da32bd82ea9513c Gerrit-Change-Number: 37555 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Jul 2024 09:11:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/L3_Templates: Introduce templates for GMM Service Req/Acc/Rej

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37555?usp=email ) Change subject: library/L3_Templates: Introduce templates for GMM Service Req/Acc/Rej ...................................................................... Patch Set 3: (1 comment) File library/L3_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37555/comment/0fb72918_0830… PS2, Line 329: elementIdentifier := '32'O, > why spaces here Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia948a27e39cf11f1421396d15da32bd82ea9513c Gerrit-Change-Number: 37555 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Jul 2024 09:11:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

11 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/L3_Templates: Introduce templates for GMM Service Req/Acc/Rej

by pespin

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37555?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: library/L3_Templates: Introduce templates for GMM Service Req/Acc/Rej ...................................................................... library/L3_Templates: Introduce templates for GMM Service Req/Acc/Rej Those will be used by a follow-up patch in SGSN_Tests. Change-Id: Ia948a27e39cf11f1421396d15da32bd82ea9513c --- M library/L3_Templates.ttcn 1 file changed, 100 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/37555/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia948a27e39cf11f1421396d15da32bd82ea9513c Gerrit-Change-Number: 37555 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/L3_Templates: Fix discriminator field in ts_GMM_DET_ACCEPT_MO

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37556?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: library/L3_Templates: Fix discriminator field in ts_GMM_DET_ACCEPT_MO ...................................................................... library/L3_Templates: Fix discriminator field in ts_GMM_DET_ACCEPT_MO It says it's overwritten, so in practice it may not be important, but it's confusing for readers when figuring out which values are expected, eg when adding a new tr_ template which needs that field set right (not overwritten there). Change-Id: If9741953f98b7dd29749d335a5bd937fdfb62bc6 --- M library/L3_Templates.ttcn 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/37556/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If9741953f98b7dd29749d335a5bd937fdfb62bc6 Gerrit-Change-Number: 37556 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

11 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_pdp_act_user

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: sgsn: Introduce test TC_attach_pdp_act_user ...................................................................... sgsn: Introduce test TC_attach_pdp_act_user Related: SYS#5435 Change-Id: I5f0cb51457395d95bde22732b032786211cb7b61 --- M sgsn/BSSGP_ConnHdlr.ttcn M sgsn/SGSN_Tests_Iu.ttcn 2 files changed, 246 insertions(+), 53 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/37593/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5f0cb51457395d95bde22732b032786211cb7b61 Gerrit-Change-Number: 37593 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: Validate Direct Tunnel Flags DTI=1 is set during UpdatePDPConte...

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37598?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: sgsn: Validate Direct Tunnel Flags DTI=1 is set during UpdatePDPContextReq ...................................................................... sgsn: Validate Direct Tunnel Flags DTI=1 is set during UpdatePDPContextReq Related: SYS#5435 Change-Id: Iadd30318d02fbc304f65840f2299e5ec8b5b08e9 --- M sgsn/BSSGP_ConnHdlr.ttcn 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/37598/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iadd30318d02fbc304f65840f2299e5ec8b5b08e9 Gerrit-Change-Number: 37598 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

11 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_pdp_act_user

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593?usp=email ) Change subject: sgsn: Introduce test TC_attach_pdp_act_user ...................................................................... Patch Set 2: (4 comments) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/ccebc042_04cd… PS2, Line 614: Iu only > put `_iu_` in the name if this is Iu only? Service Request is always Iu only, I see no need to add it everytime in the name, since it's usually going with [is_iu(ran_index)] clauses. I'm just adding it here as a comment for readers looking at this exact point. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/0da882be_b2e1… PS2, Line 635: f_service_request > Likewise, name it `f_iu_... […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/8795391d_25aa… PS2, Line 651: [is_gb(ran_index)] > This is never true since you ensure the Iu mode above. […] Ack, this can be dropped, I'll do so. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593/comment/a0f43883_2dac… PS2, Line 806: completing the PDP ACT > "... […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5f0cb51457395d95bde22732b032786211cb7b61 Gerrit-Change-Number: 37593 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Jul 2024 09:08:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024