July 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: library/L3_Templates: Introduce templates for GMM Service Req/Acc/Rej

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37555?usp=email ) Change subject: library/L3_Templates: Introduce templates for GMM Service Req/Acc/Rej ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File library/L3_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37555/comment/b2d6e414_5ad7… PS2, Line 329: elementIdentifier := '32'O, why spaces here -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia948a27e39cf11f1421396d15da32bd82ea9513c Gerrit-Change-Number: 37555 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 Jul 2024 21:16:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/GTPv1C_Templates: Introduce template ts_GTPC_UpdatePdpRespGGSN

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37554?usp=email ) Change subject: library/GTPv1C_Templates: Introduce template ts_GTPC_UpdatePdpRespGGSN ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File library/GTPv1C_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37554/comment/5d5c440e_3151… PS2, Line 1047: ts_UpdatePdpRespGGSNPDU why not just letting the caller pass a template param with all these params? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I91afc14eecfadb3e00ccb9b74794079a82ef884b Gerrit-Change-Number: 37554 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 Jul 2024 21:11:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/GTP_Emulation: Check IMSI presence before returning if Condit...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37553?usp=email ) Change subject: library/GTP_Emulation: Check IMSI presence before returning if Conditional or Optional ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File library/GTP_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37553/comment/8b377c87_7633… PS2, Line 121: imsi.digits Is it the `imsi` field that is `optional` and thus can be omitted, or the inner `digits` field? Or maybe both? If it's only the `imsi` field, then I would not check `digits` to avoid confusion. Not critical, but may raise questions. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I73c683e62191a06212933391d424d608a14f8c1e Gerrit-Change-Number: 37553 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 Jul 2024 21:10:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: Use template ts_RAB_SMdL

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37552?usp=email ) Change subject: msc: Use template ts_RAB_SMdL ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I768aad762c4fa6c0d3a6d0effd7a7a1aabb3488f Gerrit-Change-Number: 37552 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 Jul 2024 20:13:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: Use RAB_ID obtained from RAB-AssReq

by fixeria

Attention is currently required from: daniel, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37551?usp=email ) Change subject: msc: Use RAB_ID obtained from RAB-AssReq ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If532c41304803d223591ce8e0c10dda4a562dfb8 Gerrit-Change-Number: 37551 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 Jul 2024 20:12:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: Validate Direct Tunnel Flags DTI=1 is set during UpdatePDPConte...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37598?usp=email ) Change subject: sgsn: Validate Direct Tunnel Flags DTI=1 is set during UpdatePDPContextReq ...................................................................... sgsn: Validate Direct Tunnel Flags DTI=1 is set during UpdatePDPContextReq Related: SYS#5435 Change-Id: Iadd30318d02fbc304f65840f2299e5ec8b5b08e9 --- M sgsn/BSSGP_ConnHdlr.ttcn 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/37598/1 diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn index 29b8f38..5dd719e 100644 --- a/sgsn/BSSGP_ConnHdlr.ttcn +++ b/sgsn/BSSGP_ConnHdlr.ttcn @@ -697,6 +697,13 @@ function f_process_gtp_ctx_upd_req(inout PdpActPars apars, PDU_GTPC gtpc, integer ran_index := 0) runs on BSSGP_ConnHdlr { var UpdatePDPContextRequestSGSN upd := gtpc.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestSGSN; + + if (not ispresent(upd.directTunnelFlags) or upd.directTunnelFlags.dTI != '1'B) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Rx UpdatePDPCtxReq with Direct Tunnel Flags ", + upd.directTunnelFlags, " vs exp DTI=1")); + } + if (ispresent(upd.teidControlPlane.teidControlPlane)) { apars.sgsn_tei_c := upd.teidControlPlane.teidControlPlane; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iadd30318d02fbc304f65840f2299e5ec8b5b08e9 Gerrit-Change-Number: 37598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months

1
0
0 0

[S] Change in osmo-ggsn[master]: WIP: gtp: Allow setting callback to receive update_context_ind

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37597?usp=email ) Change subject: WIP: gtp: Allow setting callback to receive update_context_ind ...................................................................... WIP: gtp: Allow setting callback to receive update_context_ind This will be used: SGSN: Get to know that RNC has gonne down according to GGSN (re-attempt Direct Tunnel or go back to tun SGSN<->GGSN). GGSN: Maybe find out that Direct Flags are used (should be handled internally directly in the rx path probably) Change-Id: Ic80a9a928c55b6ff85be96014920bb42793cb943 --- M gtp/gsn.c M gtp/gtp.c M include/osmocom/gtp/gsn.h 3 files changed, 37 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/97/37597/1 diff --git a/gtp/gsn.c b/gtp/gsn.c index c23fb2a..612baf2 100644 --- a/gtp/gsn.c +++ b/gtp/gsn.c @@ -497,6 +497,7 @@ /* Initialise call back functions */ (*gsn)->cb_create_context_ind = 0; + (*gsn)->cb_update_context_ind = 0; (*gsn)->cb_delete_context = 0; (*gsn)->cb_unsup_ind = 0; (*gsn)->cb_conf = 0; @@ -563,6 +564,13 @@ return 0; } +int gtp_set_cb_update_context_ind(struct gsn_t *gsn, + int (*cb_update_context_ind)(struct pdp_t *pdp)) +{ + gsn->cb_update_context_ind = cb_update_context_ind; + return 0; +} + int gtp_retrans(struct gsn_t *gsn) { /* dummy API, deprecated. */ diff --git a/gtp/gtp.c b/gtp/gtp.c index 8736cad..662eea9 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -1772,6 +1772,7 @@ struct pdp_t pdp_backup; union gtpie_member *ie[GTPIE_SIZE]; uint8_t recovery; + int rc; uint16_t seq = get_seq(pack); int hlen = get_hlen(pack); @@ -1991,9 +1992,17 @@ } } + /* Callback function to validate login */ + if (gsn->cb_update_context_ind != 0) + rc = gsn->cb_update_context_ind(pdp); + else { + /* Confirm to peer that things were "successful" */ + rc = gtp_update_pdp_resp(gsn, version, peer, fd, pack, len, pdp, + GTPCAUSE_ACC_REQ); + } + /* Confirm to peer that things were "successful" */ - return gtp_update_pdp_resp(gsn, version, peer, fd, pack, len, pdp, - GTPCAUSE_ACC_REQ); + return rc; } /* Handle Update PDP Context Response */ diff --git a/include/osmocom/gtp/gsn.h b/include/osmocom/gtp/gsn.h index 936db9b..006fdfd 100644 --- a/include/osmocom/gtp/gsn.h +++ b/include/osmocom/gtp/gsn.h @@ -99,6 +99,7 @@ /* Call back functions */ int (*cb_delete_context) (struct pdp_t *); int (*cb_create_context_ind) (struct pdp_t *); + int (*cb_update_context_ind)(struct pdp_t *pdp); int (*cb_unsup_ind) (struct sockaddr_in * peer); int (*cb_extheader_ind) (struct sockaddr_in * peer); int (*cb_ran_info_relay_ind) (struct sockaddr_in *peer, union gtpie_member **ie); @@ -134,6 +135,8 @@ int (*cb_create_context_ind) (struct pdp_t * pdp)); +extern int gtp_set_cb_update_context_ind(struct gsn_t *gsn, + int (*cb_update_context_ind)(struct pdp_t *pdp)); extern int gtp_set_cb_data_ind(struct gsn_t *gsn, int (*cb_data_ind) (struct pdp_t * pdp, void *pack, unsigned len)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ic80a9a928c55b6ff85be96014920bb42793cb943 Gerrit-Change-Number: 37597 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months

1
0
0 0

[S] Change in osmo-sgsn[master]: gtp: Set Direct Tunnel Flags DTI during UpdatePDPCtx

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37596?usp=email ) Change subject: gtp: Set Direct Tunnel Flags DTI during UpdatePDPCtx ...................................................................... gtp: Set Direct Tunnel Flags DTI during UpdatePDPCtx This is required as per TS 28.060 to tell the GGSN that the remote Address/TEID it is receiving it's the one of the RNC. Upon receiving a GTPU Error Indication, the GGSN knowing it's using DirectTunnel, can then update the SGSN with UpdatePDPContextReq with Direct Tunnel Flags DTI=1 EI=1 and then the SGSN can decide whether reconfigure the Direct Tunnel or switch to 2-leg tunnel until the connection with RNC/UE can be reestablished. Depends: osmo-ggsn.git Change-Id Ia3e360a35d30858eab1e438dc2508fd756c2e22e Related: SYS#5435 Change-Id: Iefe73eeea41df0c55db673194c9e9547504cbf0d --- M src/sgsn/gprs_ranap.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/96/37596/1 diff --git a/src/sgsn/gprs_ranap.c b/src/sgsn/gprs_ranap.c index 5e0d8ed..51954ce 100644 --- a/src/sgsn/gprs_ranap.c +++ b/src/sgsn/gprs_ranap.c @@ -103,6 +103,8 @@ LOGP(DRANAP, LOGL_DEBUG, "Updating TEID on RNC side from 0x%08x to 0x%08x\n", pdp->lib->teid_own, tei); pdp->lib->teid_own = tei; + pdp->lib->dir_tun_flags.l = 1; + pdp->lib->dir_tun_flags.v[0] = 0x01; /* Set DTI flag in Direct Tunnel Flags */ require_pdp_update = true; } -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37596?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iefe73eeea41df0c55db673194c9e9547504cbf0d Gerrit-Change-Number: 37596 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: Store rx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp}

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37595?usp=email ) Change subject: gtp: Store rx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp} ...................................................................... gtp: Store rx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp} In Update PDP Ctx Response, only SGSN is expected to transmit Direct Tunnel Flags in the message. Related: SYS#5435 Change-Id: Ia3e360a35d30858eab1e438dc2508fd756c2e22e --- M gtp/gtp.c 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/95/37595/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index 62cad60..8736cad 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -1984,6 +1984,11 @@ } /* OMC identity */ + + /* Direct Tunnel Flags */ + if (gtpie_gettlv(ie, GTPIE_DIR_TUN_FLAGS, 0, &pdp->dir_tun_flags.l, + &pdp->dir_tun_flags.v, sizeof(pdp->dir_tun_flags.v))) { + } } /* Confirm to peer that things were "successful" */ @@ -2093,6 +2098,12 @@ &pdp->qos_neg.v, sizeof(pdp->qos_neg.v))) { goto err_missing; } + + /* Direct Tunnel Flags */ + if (gsn->mode == GTP_MODE_GGSN && + gtpie_gettlv(ie, GTPIE_DIR_TUN_FLAGS, 0, &pdp->dir_tun_flags.l, + &pdp->dir_tun_flags.v, sizeof(pdp->dir_tun_flags.v))) { + } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37595?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ia3e360a35d30858eab1e438dc2508fd756c2e22e Gerrit-Change-Number: 37595 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: Allow tx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp}

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37594?usp=email ) Change subject: gtp: Allow tx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp} ...................................................................... gtp: Allow tx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp} In Update PDP Ctx Response, only SGSN is expected to transmit Direct Tunnel Flags in the message. Related: SYS#5435 Change-Id: I36d93619e2fe9cafd3092515df18b82d29099d2d --- M gtp/gtp.c M include/osmocom/gtp/pdp.h 2 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/94/37594/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index 245927b..62cad60 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -1686,6 +1686,11 @@ gtpie_tlv(&packet, &length, GTP_MAX, GTPIE_OMC_ID, pdp->omcid.l, pdp->omcid.v); + /* Direct Tunnel Flags */ + if ((pdp->version == 1) && pdp->dir_tun_flags.l) + gtpie_tlv(&packet, &length, GTP_MAX, GTPIE_DIR_TUN_FLAGS, + pdp->dir_tun_flags.l, pdp->dir_tun_flags.v); + gtp_req(gsn, pdp->version, pdp, &packet, length, inetaddr, cbp); return 0; @@ -1747,6 +1752,11 @@ pdp->qos_neg.l, pdp->qos_neg.v); /* TODO: Charging gateway address */ + + /* Direct Tunnel Flags */ + if ((gsn->mode == GTP_MODE_SGSN) && (version == 1) && pdp->dir_tun_flags.l) + gtpie_tlv(&packet, &length, GTP_MAX, GTPIE_DIR_TUN_FLAGS, + pdp->dir_tun_flags.l, pdp->dir_tun_flags.v); } return gtp_resp(version, gsn, pdp, &packet, length, peer, diff --git a/include/osmocom/gtp/pdp.h b/include/osmocom/gtp/pdp.h index 4dcdde4..da4a382 100644 --- a/include/osmocom/gtp/pdp.h +++ b/include/osmocom/gtp/pdp.h @@ -46,6 +46,11 @@ unsigned char *v; }; +struct ul1_t { + unsigned int l; + unsigned char v[1]; +}; + struct ul16_t { unsigned int l; unsigned char v[16]; @@ -244,6 +249,8 @@ bool tx_gpdu_seq; /* Transmit (true) or suppress G-PDU sequence numbers */ struct llist_head qmsg_list_req; /* list of req qmsg_t in retrans queue belonging this pdp ctx */ + + struct ul1_t dir_tun_flags; /* Direct Tunnel Flags, TS 29.060 7.7.81 */ }; /* functions related to pdp_t management */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I36d93619e2fe9cafd3092515df18b82d29099d2d Gerrit-Change-Number: 37594 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024