Attention is currently required from: falconia.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email )
Change subject: TRAU->RTP: add support for TW-TS-001 & TW-TS-002
......................................................................
Patch Set 1:
(2 comments)
File include/osmocom/trau/trau_rtp.h:
https://gerrit.osmocom.org/c/libosmo-abis/+/37156/comment/17519538_61bdbcc8
PS1, Line 27: uint8_t rtp_extensions;
missing entry in TODO-RELEASE file stating ABI change.
File src/trau/trau_rtp_conv.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/37156/comment/19318042_d4cb1143
PS1, Line 291: crc_bfi = true;
why is all the code path logic changing here? now if it's considered a bgi, then all the computation below is still done.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I7a6d13d406484c01210594bb6d2f0aff7c1341ab
Gerrit-Change-Number: 37156
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Mon, 10 Jun 2024 09:31:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: falconia.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37150?usp=email )
Change subject: rtp2trau_hr16: set D bits correctly
......................................................................
Patch Set 1:
(1 comment)
File src/trau/trau_rtp_conv.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/37150/comment/fc93374e_9ef34113
PS1, Line 428: osmo_pbit2ubit(tf->d_bits, data, 112);
where does this 112 come from?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37150?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Icb6a21a12fe82f6637f327d45bd843686a90a458
Gerrit-Change-Number: 37150
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Mon, 10 Jun 2024 09:15:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment