June 2024 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: pySim.tlv.COMPR_TLV_IE: Patch comprehension bit if derived class miss...
by osmith 10 Jun '24

10 Jun '24

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37145?usp=email ) Change subject: pySim.tlv.COMPR_TLV_IE: Patch comprehension bit if derived class misses it ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37145?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I299cd65f32dffda9040d18c17a374e8dc9ebe7da Gerrit-Change-Number: 37145 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 10 Jun 2024 08:16:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in pysim[master]: pySim.cat: Make sure to always set comprehension bit in COMPR_TLV_IE
by osmith 10 Jun '24

10 Jun '24

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37144?usp=email ) Change subject: pySim.cat: Make sure to always set comprehension bit in COMPR_TLV_IE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6e5f2a69c960c03015c3f233f8fbc2a7a802f07e Gerrit-Change-Number: 37144 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 10 Jun 2024 08:15:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim.tlv: Correctly parse COMPREHENSION-TLV without comprehension bit
by osmith 10 Jun '24

10 Jun '24

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37137?usp=email ) Change subject: pySim.tlv: Correctly parse COMPREHENSION-TLV without comprehension bit ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37137?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I58d04ec13be0c12d9fb8cb3d5a0480d0defb6c95 Gerrit-Change-Number: 37137 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 10 Jun 2024 08:13:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in pysim[master]: esim.saip: Add ProfileElementSequence.remove_naas_of_type
by osmith 10 Jun '24

10 Jun '24

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37010?usp=email ) Change subject: esim.saip: Add ProfileElementSequence.remove_naas_of_type ...................................................................... Patch Set 4: Code-Review+1 (2 comments) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/37010/comment/351326ab_1337481d PS3, Line 562: def remove_naas_of_type(self, naa: Naa) -> None: > I don't like printing by library functions in general, this kind of code might very well be executed […] a list of items that were removed could be returned... but it's not that important, marking as resolved. https://gerrit.osmocom.org/c/pysim/+/37010/comment/b915c31c_68dc1e43 PS3, Line 573: if template in hdr.decoded['eUICC-Mandatory-GFSTEList']: : hdr.decoded['eUICC-Mandatory-GFSTEList'] = [x for x in hdr.decoded['eUICC-Mandatory-GFSTEList'] if not template.prefix_match(x)] > I'm not following you here, sorry. I thought if this could possibly miss entries, if `template.prefix_match(x)` is True, but for some reason `template in hdr.decoded[...]` is False. But probably not, nvm. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37010?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I64438bf0be58bad7a561c3744b7e9b1338a7857c Gerrit-Change-Number: 37010 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 10 Jun 2024 08:11:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: prevent use-after-free after FSM instance termination
by fixeria 10 Jun '24

10 Jun '24

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37147?usp=email ) Change subject: prevent use-after-free after FSM instance termination ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37147?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib41e1a996aaa03221e73643636140947ac8f99e2 Gerrit-Change-Number: 37147 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Jun 2024 07:59:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim.ota.OtaDialectSms: Move SMS header construct up to class level
by laforge 10 Jun '24

10 Jun '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37140?usp=email to look at the new patch set (#7). Change subject: pySim.ota.OtaDialectSms: Move SMS header construct up to class level ...................................................................... pySim.ota.OtaDialectSms: Move SMS header construct up to class level this way we can use it in other [future] methods. Change-Id: If296f823c18864fddcfb9cb1b82a087bac8875d4 --- M pySim/ota.py 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/40/37140/7 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If296f823c18864fddcfb9cb1b82a087bac8875d4 Gerrit-Change-Number: 37140 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: unber.py: work-around pylint reporting (possibly-used-before-assignment)
by laforge 10 Jun '24

10 Jun '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37154?usp=email ) Change subject: unber.py: work-around pylint reporting (possibly-used-before-assignment) ...................................................................... unber.py: work-around pylint reporting (possibly-used-before-assignment) contrib/unber.py:39:22: E0606: Possibly using variable 'content' before assignment (possibly-used-before-assignment) Change-Id: I725cd5e05e3121c853669eb4bbfe5ba51b79eb75 --- M contrib/unber.py 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/54/37154/1 diff --git a/contrib/unber.py b/contrib/unber.py index 65262e1..6b488b7 100755 --- a/contrib/unber.py +++ b/contrib/unber.py @@ -35,5 +35,8 @@ content = f.read() elif opts.hex: content = h2b(opts.hex) + else: + # avoid pylint "(possibly-used-before-assignment)" below + sys.exit(2) process_one_level(content, 0) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I725cd5e05e3121c853669eb4bbfe5ba51b79eb75 Gerrit-Change-Number: 37154 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: contrib/jenkins.sh: Execute pylint also on all contrib python scripts
by laforge 10 Jun '24

10 Jun '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37155?usp=email ) Change subject: contrib/jenkins.sh: Execute pylint also on all contrib python scripts ...................................................................... contrib/jenkins.sh: Execute pylint also on all contrib python scripts This way we get linting coverage for sim-rest-{server,client}, eidtool, unber and others. Change-Id: I2d6271d493d0f6765e6a184f8ae32f8325317be2 --- M contrib/jenkins.sh 1 file changed, 13 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/55/37155/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7d3defb..a35241d 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -57,9 +57,7 @@ --disable E0401 \ --enable W0301 \ pySim tests/*.py *.py \ - contrib/es2p_client.py \ - contrib/es9p_client.py \ - contrib/saip-tool.py + contrib/*.py ;; "docs") rm -rf docs/_build -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2d6271d493d0f6765e6a184f8ae32f8325317be2 Gerrit-Change-Number: 37155 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[M] Change in libosmo-abis[master]: RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads
by falconia 10 Jun '24

10 Jun '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37153?usp=email ) Change subject: RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads ...................................................................... RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads TW-TS-001 is an enhanced RTP transport format for FR and EFR codecs that replicates the functionality and semantics of GSM 08.60 TRAU-UL frames. Given that libosmotrau functions support converting from RTP to either TRAU-UL or TRAU-DL, the option of TW-TS-001 fits in naturally. It needs to be noted, however, that the fully correct path in OsmoMGW from RTP input to E1 output will need to include one more critical step _before_ the call to osmo_rtp2trau(): it will be a stateful preening engine that implements the rules of TS 28.062 section C.3.2.1.1, a codec-dependent stateful transform that can be fairly complex. The necessary engines will most likely be implemented in Themyscira codec libraries, and OsmoMGW will need to be outfitted with an _optional_ dependency on those libs. The "native" support for TW-TS-001 input in osmo_rtp2trau() for TRAU-DL (as opposed to TRAU-UL) output is a fallback in the case of OsmoMGW built without any Themyscira codec libraries. Related: OS#6448 Change-Id: I3b2a33c1fcc5a7dafe06736dce5fa5b7b1138e54 --- M src/trau/trau_rtp_conv.c 1 file changed, 77 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/53/37153/1 diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index 069baab..e4aa885 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -269,13 +269,29 @@ { int i, j, k, l, o; enum osmo_gsm631_sid_class sidc; + bool bfi = false, taf = false, dtxd = false; - /* data_len == 0 for BFI frame */ - if (data_len < GSM_FR_BYTES && data_len != 0) - return -EINVAL; + /* accept TW-TS-001 input */ + if (data_len > 0 && (data[0] & 0xF0) == 0xE0) { + dtxd = (data[0] & 0x08) != 0; + bfi = (data[0] & 0x02) != 0; + taf = (data[0] & 0x01) != 0; + data++; + data_len--; + } - if (data_len && data[0] >> 4 != 0xd) + /* now we must have either standard FR or no-data input */ + switch (data_len) { + case GSM_FR_BYTES: + if ((data[0] & 0xF0) != 0xD0) + return -EINVAL; + break; + case 0: + bfi = true; + break; + default: return -EINVAL; + } tf->type = OSMO_TRAU16_FT_FR; @@ -308,20 +324,19 @@ } memset(&tf->c_bits[5], 0, 6); /* C6 .. C11: Time Alignment */ if (tf->dir == OSMO_TRAU_DIR_UL) { + tf->c_bits[11] = bfi; /* C12: BFI */ if (data_len == 0) { - tf->c_bits[11] = 1; /* C12: BFI */ tf->c_bits[12] = 0; /* C13: SID=0 */ tf->c_bits[13] = 0; /* C14: SID=0 */ } else { - tf->c_bits[11] = 0; /* C12: BFI */ /* SID classification per GSM 06.31 section 6.1.1 */ sidc = osmo_fr_sid_classify(data); tf->c_bits[12] = (sidc >> 1) & 1; /* C13: msb */ tf->c_bits[13] = (sidc >> 0) & 1; /* C14: lsb */ } - tf->c_bits[14] = 0; /* C15: TAF (SACCH or not) */ - tf->c_bits[15] = 1; /* C16: spare */ - tf->c_bits[16] = 0; /* C17: DTXd not applied */ + tf->c_bits[14] = taf; /* C15: TAF (SACCH or not) */ + tf->c_bits[15] = 1; /* C16: spare */ + tf->c_bits[16] = dtxd; /* C17: DTXd applied or not */ } else { memset(&tf->c_bits[11], 1, 4); /* C12 .. C15: spare */ if (data_len && osmo_fr_check_sid(data, data_len)) @@ -461,13 +476,29 @@ int i, j; ubit_t check_bits[26]; enum osmo_gsm631_sid_class sidc; + bool bfi = false, taf = false, dtxd = false; - /* data_len == 0 for BFI frame */ - if (data_len < GSM_EFR_BYTES && data_len != 0) - return -EINVAL; + /* accept TW-TS-001 input */ + if (data_len > 0 && (data[0] & 0xF0) == 0xE0) { + dtxd = (data[0] & 0x08) != 0; + bfi = (data[0] & 0x02) != 0; + taf = (data[0] & 0x01) != 0; + data++; + data_len--; + } - if (data_len && data[0] >> 4 != 0xc) + /* now we must have either standard EFR or no-data input */ + switch (data_len) { + case GSM_EFR_BYTES: + if ((data[0] & 0xF0) != 0xC0) + return -EINVAL; + break; + case 0: + bfi = true; + break; + default: return -EINVAL; + } tf->type = OSMO_TRAU16_FT_EFR; @@ -492,20 +523,19 @@ memset(&tf->c_bits[5], 0, 6); /* C6 .. C11: Time Alignment */ if (tf->dir == OSMO_TRAU_DIR_UL) { + tf->c_bits[11] = bfi; /* C12: BFI */ if (data_len == 0) { - tf->c_bits[11] = 1; /* C12: BFI */ tf->c_bits[12] = 0; /* C13: SID=0 */ tf->c_bits[13] = 0; /* C14: SID=0 */ } else { - tf->c_bits[11] = 0; /* C12: BFI */ /* SID classification per GSM 06.81 section 6.1.1 */ sidc = osmo_efr_sid_classify(data); tf->c_bits[12] = (sidc >> 1) & 1; /* C13: msb */ tf->c_bits[13] = (sidc >> 0) & 1; /* C14: lsb */ } - tf->c_bits[14] = 0; /* C15: TAF (SACCH) */ - tf->c_bits[15] = 1; /* C16: spare */ - tf->c_bits[16] = 0; /* C17: DTXd applied */ + tf->c_bits[14] = taf; /* C15: TAF (SACCH or not) */ + tf->c_bits[15] = 1; /* C16: spare */ + tf->c_bits[16] = dtxd; /* C17: DTXd applied or not */ } else { tf->c_bits[11] = 1; /* C12: UFE (good uplink) */ memset(&tf->c_bits[12], 1, 3); /* C13 .. C15: spare */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3b2a33c1fcc5a7dafe06736dce5fa5b7b1138e54 Gerrit-Change-Number: 37153 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 0

[M] Change in pysim[master]: pySim.ota.OtaDialectSms: Implement command decoding
by laforge 10 Jun '24

10 Jun '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37141?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim.ota.OtaDialectSms: Implement command decoding ...................................................................... pySim.ota.OtaDialectSms: Implement command decoding So far we only implemented command encoding and response decoding. Let's also add command decoding, which is useful for example when decoding protocol traces. Change-Id: Id666cea8a91a854209f3c19c1f09b512bb493c85 --- M pySim/ota.py M tests/test_ota.py 2 files changed, 79 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/41/37141/6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id666cea8a91a854209f3c19c1f09b512bb493c85 Gerrit-Change-Number: 37141 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

2025

2024

2023

2022

gerrit-log June 2024