June 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: rtp2trau_hr16: accept both TS 101 318 and RFC 5993 payload formats

by laforge

Attention is currently required from: dexter, falconia. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37151?usp=email ) Change subject: rtp2trau_hr16: accept both TS 101 318 and RFC 5993 payload formats ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37151?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I125d57d3451b030e35a7b2b95a45e38b4581626c Gerrit-Change-Number: 37151 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Jun 2024 11:48:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in libosmo-abis[master]: TRAU<->RTP HRv1: fix SID frame definition

by laforge

Attention is currently required from: falconia. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37149?usp=email ) Change subject: TRAU<->RTP HRv1: fix SID frame definition ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I4554a70f05bee428e0fb304868e25ee61ff375a1 Gerrit-Change-Number: 37149 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 10 Jun 2024 11:48:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in libosmo-abis[master]: rtp2trau_hr16: fix UFE bit setting

by laforge

Attention is currently required from: falconia, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37148?usp=email ) Change subject: rtp2trau_hr16: fix UFE bit setting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37148?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ibeb8db332f2e20806bebb077844a509064b2d89d Gerrit-Change-Number: 37148 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Jun 2024 11:47:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in pysim[master]: es9p_client: Use a plausible TAC (copy from lpac)

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37166?usp=email ) Change subject: es9p_client: Use a plausible TAC (copy from lpac) ...................................................................... es9p_client: Use a plausible TAC (copy from lpac) Some SM-DP+ (notably Idemia) fail if the TAC is not valid. Change-Id: I48890c4a56147410d0cd5c4e47647b8eb5ad9998 --- M contrib/es9p_client.py 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/66/37166/1 diff --git a/contrib/es9p_client.py b/contrib/es9p_client.py index a221035..987b85e 100755 --- a/contrib/es9p_client.py +++ b/contrib/es9p_client.py @@ -147,7 +147,7 @@ ('ctxParamsForCommonAuthentication', { 'matchingId': opts.matchingId, 'deviceInfo': { - 'tac': b'\x00'*8, + 'tac': b'\x35\x23\x01\x45', # same as lpac 'deviceCapabilities': {}, #imei: } -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37166?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I48890c4a56147410d0cd5c4e47647b8eb5ad9998 Gerrit-Change-Number: 37166 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year

1
0
0 0

[M] Change in pysim[master]: saip-tool: Add new 'info' action to print general information

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37168?usp=email ) Change subject: saip-tool: Add new 'info' action to print general information ...................................................................... saip-tool: Add new 'info' action to print general information It will print something like this: SAIP Profile Version: 2.1 Profile Type: 'GSMA Generic eUICC Test Profile' ICCID: 8949449999999990023f Mandatory Services: usim, isim, csim, javacard, usim-test-algorithm NAAs: mf[1], usim[1], csim[1], isim[1] NAA mf NAA usim (a0000000871002ff49ff0589) IMSI: 001010123456063 NAA csim NAA isim (a0000000871004ff49ff0589) Number of applications: 0 Change-Id: I107d457c3313a766229b569453c18a8d69134bec --- M contrib/saip-tool.py M pySim/esim/saip/__init__.py 2 files changed, 91 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/68/37168/1 diff --git a/contrib/saip-tool.py b/contrib/saip-tool.py index 9bbaddf..68072fa 100755 --- a/contrib/saip-tool.py +++ b/contrib/saip-tool.py @@ -54,6 +54,7 @@ parser_rn.add_argument('--naa-type', required=True, choices=NAAs.keys(), help='Network Access Application type to remove') # TODO: add an --naa-index or the like, so only one given instance can be removed +parser_info = subparsers.add_parser('info', help='Display information about the profile') def do_split(pes: ProfileElementSequence, opts): i = 0 @@ -136,6 +137,45 @@ with open(opts.output_file, 'wb') as f: f.write(pes.to_der()) +def do_info(pes: ProfileElementSequence, opts): + def get_naa_count(pes: ProfileElementSequence) -> dict: + """return a dict with naa-type (usim, isim) as key and the count of NAA instances as value.""" + ret = {} + for naa_type in pes.pes_by_naa: + ret[naa_type] = len(pes.pes_by_naa[naa_type]) + return ret + + pe_hdr_dec = pes.pe_by_type['header'][0].decoded + print() + print("SAIP Profile Version: %u.%u" % (pe_hdr_dec['major-version'], pe_hdr_dec['minor-version'])) + print("Profile Type: '%s'" % pe_hdr_dec['profileType']) + print("ICCID: %s" % b2h(pe_hdr_dec['iccid'])) + print("Mandatory Services: %s" % ', '.join(pe_hdr_dec['eUICC-Mandatory-services'].keys())) + print() + naa_strs = ["%s[%u]" % (k, v) for k, v in get_naa_count(pes).items()] + print("NAAs: %s" % ', '.join(naa_strs)) + for naa_type in pes.pes_by_naa: + for naa_inst in pes.pes_by_naa[naa_type]: + first_pe = naa_inst[0] + adf_name = '' + if hasattr(first_pe, 'adf_name'): + adf_name = '(' + first_pe.adf_name + ')' + print("NAA %s %s" % (first_pe.type, adf_name)) + if hasattr(first_pe, 'imsi'): + print("\tIMSI: %s" % first_pe.imsi) + + # applications + print() + apps = pes.pe_by_type.get('application', []) + print("Number of applications: %u" % len(apps)) + for app_pe in apps: + print("App Load Package AID: %s" % b2h(app_pe.decoded['loadBlock']['loadPackageAID'])) + print("\tMandated: %s" % ('mandated' in app_pe.decoded['app-Header'])) + print("\tLoad Block Size: %s" % len(app_pe.decoded['loadBlock']['loadBlockObject'])) + for inst in app_pe.decoded.get('instanceList', []): + print("\tInstance AID: %s" % b2h(inst['instanceAID'])) + pass + if __name__ == '__main__': opts = parser.parse_args() @@ -155,3 +195,5 @@ do_remove_pe(pes, opts) elif opts.command == 'remove-naa': do_remove_naa(pes, opts) + elif opts.command == 'info': + do_info(pes, opts) diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index ee2538c..278b5cf 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -22,7 +22,7 @@ import asn1tools -from pySim.utils import bertlv_parse_tag, bertlv_parse_len, b2h, h2b +from pySim.utils import bertlv_parse_tag, bertlv_parse_len, b2h, h2b, dec_imsi from pySim.ts_102_221 import FileDescriptor from pySim.construct import build_construct from pySim.esim import compile_asn1_subdir @@ -263,10 +263,15 @@ @classmethod def from_der(cls, der: bytes) -> 'ProfileElement': + class4petype = { + 'securityDomain': ProfileElementSD, + 'usim': ProfileElementUSIM, + 'isim': ProfileElementISIM, + } """Construct an instance from given raw, DER encoded bytes.""" pe_type, decoded = asn1.decode('ProfileElement', der) - if pe_type == 'securityDomain': - inst = ProfileElementSD(decoded) + if pe_type in class4petype: + inst = class4petype[pe_type](decoded) else: inst = ProfileElement(decoded) inst.type = pe_type @@ -437,6 +442,22 @@ 'uiccToolkitApplicationSpecificParametersField': h2b('01000001000000020112036C756500'), } +class ProfileElementUSIM(ProfileElement): + type = 'usim' + @property + def adf_name(self) -> str: + return b2h(self.decoded['adf-usim'][0][1]['dfName']) + @property + def imsi(self) -> Optional[str]: + f = File('ef-imsi', self.decoded['ef-imsi']) + return dec_imsi(b2h(f.stream.getvalue())) + +class ProfileElementISIM(ProfileElement): + type = 'isim' + @property + def adf_name(self) -> str: + return b2h(self.decoded['adf-isim'][0][1]['dfName']) + def bertlv_first_segment(binary: bytes) -> Tuple[bytes, bytes]: """obtain the first segment of a binary concatenation of BER-TLV objects. Returns: tuple of first TLV and remainder.""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37168?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I107d457c3313a766229b569453c18a8d69134bec Gerrit-Change-Number: 37168 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in pysim[master]: esim.saip: Remove debug print()

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37167?usp=email ) Change subject: esim.saip: Remove debug print() ...................................................................... esim.saip: Remove debug print() Change-Id: I8dfe29302225d951e656d1321bbd249bfe242602 --- M pySim/esim/saip/__init__.py 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/67/37167/1 diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 3742c96..ee2538c 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -95,7 +95,6 @@ # apply some defaults from profile if self.template: self.from_template(self.template) - print("after template: %s" % repr(self)) if l: self.from_tuples(l) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37167?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8dfe29302225d951e656d1321bbd249bfe242602 Gerrit-Change-Number: 37167 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year

1
0
0 0

[M] Change in pysim[master]: pySim.ota.OtaDialectSms: Implement command decoding

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37141?usp=email ) Change subject: pySim.ota.OtaDialectSms: Implement command decoding ...................................................................... pySim.ota.OtaDialectSms: Implement command decoding So far we only implemented command encoding and response decoding. Let's also add command decoding, which is useful for example when decoding protocol traces. Change-Id: Id666cea8a91a854209f3c19c1f09b512bb493c85 --- M pySim/ota.py M tests/test_ota.py 2 files changed, 79 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/ota.py b/pySim/ota.py index d77a64e..c3a7512 100644 --- a/pySim/ota.py +++ b/pySim/ota.py @@ -18,7 +18,7 @@ import zlib import abc import struct -from typing import Optional +from typing import Optional, Tuple from construct import Enum, Int8ub, Int16ub, Struct, Bytes, GreedyBytes, BitsInteger, BitStruct from construct import Flag, Padding, Switch, this @@ -388,6 +388,49 @@ return envelope_data + def decode_cmd(self, otak: OtaKeyset, encoded: bytes) -> Tuple[bytes, dict, bytes]: + """Decode an encoded (encrypted, signed) OTA SMS Command-APDU.""" + if True: # TODO: how to decide? + cpl = int.from_bytes(encoded[:2], 'big') + part_head = encoded[2:2+8] + ciph = encoded[2+8:] + envelope_data = otak.crypt.decrypt(ciph) + else: + part_head = encoded[:8] + envelope_data = encoded[8:] + + hdr_dec = self.hdr_construct.parse(part_head) + + # strip counter part from front of envelope_data + part_cnt = envelope_data[:6] + cntr = int.from_bytes(part_cnt[:5], 'big') + pad_cnt = int.from_bytes(part_cnt[5:], 'big') + envelope_data = envelope_data[6:] + + spi = hdr_dec['spi'] + if spi['rc_cc_ds'] == 'cc': + # split cc from front of APDU + cc = envelope_data[:8] + apdu = envelope_data[8:] + # verify CC + temp_data = cpl.to_bytes(2, 'big') + part_head + part_cnt + apdu + otak.auth.check_sig(temp_data, cc) + elif spi['rc_cc_ds'] == 'rc': + # CRC32 + crc32_rx = int.from_bytes(envelope_data[:4], 'big') + # FIXME: crc32_computed = zlip.crc32( + # FIXME: verify RC + raise NotImplementedError + apdu = envelope_data[4:] + elif spi['rc_cc_ds'] == 'no_rc_cc_ds': + apdu = envelope_data + else: + raise ValueError("Invalid rc_cc_ds: %s" % spi['rc_cc_ds']) + + apdu = apdu[:len(apdu)-pad_cnt] + return hdr_dec['tar'], spi, apdu + + def decode_resp(self, otak: OtaKeyset, spi: dict, data: bytes) -> ("OtaDialectSms.SmsResponsePacket", Optional["CompactRemoteResp"]): if isinstance(data, str): data = h2b(data) diff --git a/tests/test_ota.py b/tests/test_ota.py index ce10a7d..c4598a3 100644 --- a/tests/test_ota.py +++ b/tests/test_ota.py @@ -65,14 +65,19 @@ def test_cmd_aes128_ciphered(self): spi = self.spi_base - r = self.dialect.encode_cmd(self.od, self.tar, spi, h2b('00a40004023f00')) + apdu = h2b('00a40004023f00') + r = self.dialect.encode_cmd(self.od, self.tar, spi, apdu) self.assertEqual(b2h(r), '00281506192222b00011e87cceebb2d93083011ce294f93fc4d8de80da1abae8c37ca3e72ec4432e5058') - - + # also test decoder + dec_tar, dec_spi, dec_apdu = self.dialect.decode_cmd(self.od, r) + self.assertEqual(b2h(apdu), b2h(dec_apdu)) + self.assertEqual(b2h(dec_tar), b2h(self.tar)) + self.assertEqual(dec_spi, spi) class Test_SMS_3DES(unittest.TestCase): tar = h2b('b00000') + apdu = h2b('00a40000023f00') """Test the OtaDialectSms for 3DES algorithms.""" def __init__(self, foo, **kwargs): super().__init__(foo, **kwargs) @@ -134,21 +139,26 @@ spi = self.spi_base spi['ciphering'] = True spi['rc_cc_ds'] = 'no_rc_cc_ds' - r = self.dialect.encode_cmd(self.od, self.tar, spi, h2b('00a40000023f00')) + r = self.dialect.encode_cmd(self.od, self.tar, spi, self.apdu) self.assertEqual(b2h(r), '00180d04193535b00000e3ec80a849b554421276af3883927c20') + # also test decoder + dec_tar, dec_spi, dec_apdu = self.dialect.decode_cmd(self.od, r) + self.assertEqual(b2h(self.apdu), b2h(dec_apdu)) + self.assertEqual(b2h(dec_tar), b2h(self.tar)) + self.assertEqual(dec_spi, spi) def test_cmd_3des_signed(self): spi = self.spi_base spi['ciphering'] = False spi['rc_cc_ds'] = 'cc' - r = self.dialect.encode_cmd(self.od, self.tar, spi, h2b('00a40000023f00')) + r = self.dialect.encode_cmd(self.od, self.tar, spi, self.apdu) self.assertEqual(b2h(r), '1502193535b00000000000000000072ea17bdb72060e00a40000023f00') def test_cmd_3des_none(self): spi = self.spi_base spi['ciphering'] = False spi['rc_cc_ds'] = 'no_rc_cc_ds' - r = self.dialect.encode_cmd(self.od, self.tar, spi, h2b('00a40000023f00')) + r = self.dialect.encode_cmd(self.od, self.tar, spi, self.apdu) self.assertEqual(b2h(r), '0d00193535b0000000000000000000a40000023f00') @@ -273,6 +283,12 @@ #print("tpdu: %s" % b2h(tpdu.to_bytes())) self.assertEqual(b2h(tpdu.to_bytes()), t['request']['encoded_tpdu']) + # also test decoder + dec_tar, dec_spi, dec_apdu = self.dialect.decode_cmd(kset, outp) + self.assertEqual(b2h(t['request']['apdu']), b2h(dec_apdu)) + self.assertEqual(b2h(dec_tar), b2h(self.tar)) + self.assertEqual(dec_spi, t['spi']) + def test_decode_resp(self): for t in SmsOtaTestCase.testdatasets: with self.subTest(name=t['name']): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id666cea8a91a854209f3c19c1f09b512bb493c85 Gerrit-Change-Number: 37141 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[S] Change in pysim[master]: tests/ota_test.py: Allow stand-alone execution

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37142?usp=email ) Change subject: tests/ota_test.py: Allow stand-alone execution ...................................................................... tests/ota_test.py: Allow stand-alone execution Let's add a __main__ section to allow stand-alone execution via python3 ./tests/test_ota.py Change-Id: Ic3940ac23c7ddc1013e21f41eae6076a11dfd4f4 --- M tests/test_ota.py 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/test_ota.py b/tests/test_ota.py index c4598a3..f75ba8d 100644 --- a/tests/test_ota.py +++ b/tests/test_ota.py @@ -299,3 +299,6 @@ self.assertEqual(d.number_of_commands, t['response']['number_of_commands']) self.assertEqual(d.last_status_word, t['response']['last_status_word']) self.assertEqual(d.last_response_data, t['response']['last_response_data']) + +if __name__ == "__main__": + unittest.main() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic3940ac23c7ddc1013e21f41eae6076a11dfd4f4 Gerrit-Change-Number: 37142 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[S] Change in pysim[master]: osmo-smdpp: use NIST-P256 by default

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37143?usp=email ) Change subject: osmo-smdpp: use NIST-P256 by default ...................................................................... osmo-smdpp: use NIST-P256 by default The eSIM specs allow for both brainpool and nist; in reality the deployments use the NIST P256 curve. osmo-smdpp currently only supports a single certificate; let's use the NIST one by default. Change-Id: Idc7809f320505279c8a75e9b667be0a2af802f6b --- M osmo-smdpp.py 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/osmo-smdpp.py b/osmo-smdpp.py index 9551396..6c275ac 100755 --- a/osmo-smdpp.py +++ b/osmo-smdpp.py @@ -559,7 +559,7 @@ args = parser.parse_args() - hs = SmDppHttpServer(HOSTNAME, os.path.join(DATA_DIR, 'certs', 'CertificateIssuer'), use_brainpool=True) + hs = SmDppHttpServer(HOSTNAME, os.path.join(DATA_DIR, 'certs', 'CertificateIssuer'), use_brainpool=False) #hs.app.run(endpoint_description="ssl:port=8000:dhParameters=dh_param_2048.pem") hs.app.run("localhost", 8000) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37143?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idc7809f320505279c8a75e9b667be0a2af802f6b Gerrit-Change-Number: 37143 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[S] Change in pysim[master]: unber.py: work-around pylint reporting (possibly-used-before-assignment)

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37154?usp=email ) Change subject: unber.py: work-around pylint reporting (possibly-used-before-assignment) ...................................................................... unber.py: work-around pylint reporting (possibly-used-before-assignment) contrib/unber.py:39:22: E0606: Possibly using variable 'content' before assignment (possibly-used-before-assignment) Change-Id: I725cd5e05e3121c853669eb4bbfe5ba51b79eb75 --- M contrib/unber.py 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/unber.py b/contrib/unber.py index 65262e1..6b488b7 100755 --- a/contrib/unber.py +++ b/contrib/unber.py @@ -35,5 +35,8 @@ content = f.read() elif opts.hex: content = h2b(opts.hex) + else: + # avoid pylint "(possibly-used-before-assignment)" below + sys.exit(2) process_one_level(content, 0) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I725cd5e05e3121c853669eb4bbfe5ba51b79eb75 Gerrit-Change-Number: 37154 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024