June 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/37237?usp=email ) Change subject: smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN ...................................................................... smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN Change-Id: I3f8d9a8e3739679995ddb037a8f3d58a627d36bc --- M include/osmocom/smpp/smpp.h 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/37/37237/1 diff --git a/include/osmocom/smpp/smpp.h b/include/osmocom/smpp/smpp.h index a2832d3..d48cd79 100644 --- a/include/osmocom/smpp/smpp.h +++ b/include/osmocom/smpp/smpp.h @@ -2,7 +2,7 @@ #include <osmocom/msc/gsm_data.h> -/* Length limits according to SMPP 3.4 spec including NUL-byte: */ +/* Length limits according to SMPP 3.4 spec excluding NUL-byte: */ #define SMPP_SYS_ID_LEN 15 #define SMPP_PASSWD_LEN 8 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3f8d9a8e3739679995ddb037a8f3d58a627d36bc Gerrit-Change-Number: 37237 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in osmo-msc[master]: utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/37239?usp=email ) Change subject: utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow ...................................................................... utils/smpp_mirror: use OSMO_STRLCPY_ARRAY, fix -Wstringop-overflow This patch fixes a warning printed by gcc 14.1.1: CC smpp_mirror-smpp_mirror.o CCLD smpp_mirror In function 'snprintf', inlined from 'bind_transceiver' at smpp_mirror.c:121:2, inlined from 'smpp_esme_init' at smpp_mirror.c:258:9, inlined from 'main' at smpp_mirror.c:299:7: /usr/include/bits/stdio2.h:54:10: warning: '__builtin___snprintf_chk' specified bound 16 exceeds destination size 9 [-Wstringop-overflow=] 54 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, | ^ Take a chance to replace all snprintf() calls with OSMO_STRLCPY_ARRAY. Change-Id: If1df370fbfbca0953abf83ea1840d8bf8a0118be --- M src/utils/smpp_mirror.c 1 file changed, 30 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/39/37239/1 diff --git a/src/utils/smpp_mirror.c b/src/utils/smpp_mirror.c index 3356468..340e94f 100644 --- a/src/utils/smpp_mirror.c +++ b/src/utils/smpp_mirror.c @@ -117,9 +117,9 @@ memset(&bind, 0, sizeof(bind)); bind.command_id = BIND_TRANSCEIVER; bind.sequence_number = esme_inc_seq_nr(esme); - snprintf((char *)bind.system_id, SMPP_SYS_ID_LEN + 1, "%s", esme->system_id); - snprintf((char *)bind.password, SMPP_SYS_ID_LEN + 1, "%s", esme->password); - snprintf((char *)bind.system_type, sizeof(bind.system_type), "mirror"); + OSMO_STRLCPY_ARRAY(bind.system_id, esme->system_id); + OSMO_STRLCPY_ARRAY(bind.password, esme->password); + OSMO_STRLCPY_ARRAY(bind.system_type, "mirror"); bind.interface_version = esme->smpp_version; return PACK_AND_SEND(esme, &bind); @@ -287,8 +287,8 @@ if (!esme) exit(2); - snprintf((char *) esme->system_id, sizeof(esme->system_id), "mirror"); - snprintf((char *) esme->password, sizeof(esme->password), "mirror"); + OSMO_STRLCPY_ARRAY(esme->system_id, "mirror"); + OSMO_STRLCPY_ARRAY(esme->password, "mirror"); esme->smpp_version = 0x34; if (argc >= 2) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If1df370fbfbca0953abf83ea1840d8bf8a0118be Gerrit-Change-Number: 37239 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in osmo-msc[master]: smpp: fix password[] length in struct esme

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email ) Change subject: smpp: fix password[] length in struct esme ...................................................................... smpp: fix password[] length in struct esme Change-Id: I07e7193460580a3c972a24700e75c925d1e50411 --- M include/osmocom/smpp/smpp.h 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/38/37238/1 diff --git a/include/osmocom/smpp/smpp.h b/include/osmocom/smpp/smpp.h index d48cd79..0d34345 100644 --- a/include/osmocom/smpp/smpp.h +++ b/include/osmocom/smpp/smpp.h @@ -23,7 +23,7 @@ uint8_t smpp_version; char system_id[SMPP_SYS_ID_LEN + 1]; - char password[SMPP_SYS_ID_LEN + 1]; + char password[SMPP_PASSWD_LEN + 1]; }; #define LOGPESME(ESME, LEVEL, FMT, ARGS...) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I07e7193460580a3c972a24700e75c925d1e50411 Gerrit-Change-Number: 37238 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in osmo-msc[master]: debian/copyright: remove include/openbsc/slhc.h (no such file)

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email ) Change subject: debian/copyright: remove include/openbsc/slhc.h (no such file) ...................................................................... debian/copyright: remove include/openbsc/slhc.h (no such file) Change-Id: Ib1f2395798010381d67d79c46778bb0caef17046 --- M debian/copyright 1 file changed, 9 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/36/37236/1 diff --git a/debian/copyright b/debian/copyright index ac8ed52..1bde2c2 100644 --- a/debian/copyright +++ b/debian/copyright @@ -146,28 +146,3 @@ . On Debian systems, the complete text of the GNU General Public License Version 3 can be found in `/usr/share/common-licenses/GPL-3'. - -Files: include/openbsc/slhc.h -Copyright: 1989 Regents of the University of California. -License: __UNKNOWN__ - Redistribution and use in source and binary forms are permitted - provided that the above copyright notice and this paragraph are - duplicated in all such forms and that any documentation, - advertising materials, and other materials related to such - distribution and use acknowledge that the software was developed - by the University of California, Berkeley. The name of the - University may not be used to endorse or promote products derived - from this software without specific prior written permission. - THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR - IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED - WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. - . - Van Jacobson (van(a)helios.ee.lbl.gov), Dec 31, 1989: - - Initial distribution. - . - modified for KA9Q Internet Software Package by - Katie Stevens (dkstevens(a)ucdavis.edu) - University of California, Davis - Computing Services - - 01-31-90 initial adaptation - -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib1f2395798010381d67d79c46778bb0caef17046 Gerrit-Change-Number: 37236 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Osmocom_CTRL: counters: return -1 for absent objects

by fixeria

Attention is currently required from: neels, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37189?usp=email ) Change subject: Osmocom_CTRL: counters: return -1 for absent objects ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS1: > the reason why I like the implicit -1 is exactly because it is so simple and elegantly "docking" to […] The proposed approach looks acceptable to me, so CR+1 from me. I see analogy with `kw.get(field, default)` in Python. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id00bbfe721d453e5f551e6d47e1b1d03d219700b Gerrit-Change-Number: 37189 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Jun 2024 21:01:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in ...osmo-s1gw[master]: osmo_s1gw.app.src: add logger_color_formatter

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37228?usp=email ) Change subject: osmo_s1gw.app.src: add logger_color_formatter ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37228?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I6f10b22af406ef640bc2eaa2dddca34b009f7e6a Gerrit-Change-Number: 37228 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Jun 2024 20:46:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1ap: add {enc,dec}_S1AP_Global_ENB_ID() API

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37226?usp=email ) Change subject: s1ap: add {enc,dec}_S1AP_Global_ENB_ID() API ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I856fd426b92046dcae72149f46737da3e1b65219 Gerrit-Change-Number: 37226 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Jun 2024 20:46:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-qcdiag[master]: Makefile: print files removed when running 'clean'

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/37224?usp=email ) Change subject: Makefile: print files removed when running 'clean' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/37224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: Ic93a43a8ee771f5d8eb5f36cc0c90aedea72a51c Gerrit-Change-Number: 37224 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Jun 2024 20:45:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-qcdiag[master]: Makefile: fix CFLAGS != CPPFLAGS, allow overriding them

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-qcdiag/+/37223?usp=email ) Change subject: Makefile: fix CFLAGS != CPPFLAGS, allow overriding them ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-qcdiag/+/37223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-qcdiag Gerrit-Branch: master Gerrit-Change-Id: Id31923856915a3d2c3a03201ef8922c2129bc635 Gerrit-Change-Number: 37223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Jun 2024 20:45:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-ci[master]: jobs/ttcn3: add ttcn3-s1gw-test

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/37235?usp=email ) Change subject: jobs/ttcn3: add ttcn3-s1gw-test ...................................................................... jobs/ttcn3: add ttcn3-s1gw-test Change-Id: I659b5c4144900260622a8c878a1567d275c0ba04 Depends: docker-playground.git I95000d7a9d778df1da830cd5059e5b6899391fbe Related: SYS#6772 --- M jobs/ttcn3-testsuites.yml 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/35/37235/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index cd74823..66a8385 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -158,6 +158,10 @@ timer: H 07 * * * # osmo-epdg requires OTP and kernel >= debian12: node: build4-deb12build-ansible + - ttcn3-s1gw-test: + timer: H 07 * * * + # osmo-s1gw requires OTP and kernel >= debian12: + node: build4-deb12build-ansible - ttcn3-asterisk-ims-ue-test: timer: H 07 * * * -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37235?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I659b5c4144900260622a8c878a1567d275c0ba04 Gerrit-Change-Number: 37235 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024