fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/37213?usp=email )
Change subject: mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep()
......................................................................
mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep()
This is very unlikely to happen, because we set strongest to 127,
but anyway we don't want to see those warnings:
gsm48_rr.c: In function ‘gsm48_rr_tx_meas_rep.isra’:
gsm48_rr.c:3714:74: warning: ‘strongest_i’ may be used uninitialized [-Wmaybe-uninitialized]
3714 | if (rrmeas->nc_rxlev_dbm[i] == strongest && i <= strongest_i)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
gsm48_rr.c:3696:31: note: ‘strongest_i’ was declared here
3696 | int i, index, strongest_i;
| ^~~~~~~~~~~
Change-Id: I111438633ed48e16f7c43fc1b7a23ae6753a404d
---
M src/host/layer23/src/mobile/gsm48_rr.c
1 file changed, 21 insertions(+), 0 deletions(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c
index 83287c1..1750c57 100644
--- a/src/host/layer23/src/mobile/gsm48_rr.c
+++ b/src/host/layer23/src/mobile/gsm48_rr.c
@@ -3703,6 +3703,7 @@
/* get 6 strongest measurements */
strongest = 127; /* infinite */
+ strongest_i = -1; /* make gcc happy */
for (n = 0; n < 6; n++) {
current = -128; /* -infinite */
index = 0;
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/37213?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I111438633ed48e16f7c43fc1b7a23ae6753a404d
Gerrit-Change-Number: 37213
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: msc: test re-assignment to match codec with MT
......................................................................
msc: test re-assignment to match codec with MT
Related: osmo-msc I8760feaa8598047369ef8c3ab2673013bac8ac8a
Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53
---
M msc/BSC_ConnectionHandler.ttcn
M msc/MSC_Tests.ttcn
2 files changed, 84 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/35053/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53
Gerrit-Change-Number: 35053
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email )
Change subject: msc: test re-assignment to match codec with MT
......................................................................
Patch Set 2:
(3 comments)
File msc/BSC_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/3f87abb7_e977…
PS2, Line 986: /* What to Codec (Chosen) to send back in Assignment Complete */
> "What to Codec to" doesn't make sense to me? […]
thx
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/c7e7b22a_e3a1…
PS2, Line 993: BSSMAP_FIELD_CodecElements re_ass_req_codecs,
> Sounds like "optional" is missing in this field.
it is always {FR} by default, so it is never actually absent.
Should it still be marked optional?
There is no practical benefit of 'optional', because there already is the expect_re_assignment flag -- that bool indicates usage for both re_ass_req_codecs and re_ass_compl_chosen_codec, so adding more optionality makes checks for presence more complex; point being that there is no caller ever using the optional part.
The same is true for the already existing transaction_id: it is marked optional, yet it is always initialized. So maybe I am wrong here?
But why add more possible states == more complexity??
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053/comment/664a4c15_0aaa…
PS2, Line 995: re_ass_compl_chosen_codec
> Sounds like "optional" is missing in this field.
(s.a.)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35053?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I402ed0523a2a87b83f29c5577b2c828102005d53
Gerrit-Change-Number: 35053
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 15 Jun 2024 03:06:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273?usp=email )
Change subject: add static SS7 routing example to cs7-config.adoc
......................................................................
Patch Set 7:
(2 comments)
Patchset:
PS6:
> seems we're not getting this good enough, should we abandon this?
Done
File common/chapters/cs7-config.adoc:
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/692f798f_a547…
PS5, Line 375: For static routing, the M3UA port numbers must be fixed, i.e. there must be no `0` for a client's local port as in
: `asp foo 2905 0 m3ua`. Instead, you may use `asp foo 2905 2905 m3ua`.
> With current state of things in libosmo-sccp (I think better management of IP addresses during socke […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I44afddf7004f5bf37eec706ca3da12c04f83f8fa
Gerrit-Change-Number: 32273
Gerrit-PatchSet: 7
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 15 Jun 2024 02:54:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273?usp=email )
Change subject: add static SS7 routing example to cs7-config.adoc
......................................................................
add static SS7 routing example to cs7-config.adoc
I put the cfg files I used for testing this here:
https://people.osmocom.org/neels/zoch4ahX/g32273.tgz
To test, just start up and verify successful BSSAP RESET ACK.
Related: SYS#6422
Change-Id: I44afddf7004f5bf37eec706ca3da12c04f83f8fa
---
M common/chapters/cs7-config.adoc
1 file changed, 164 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
neels: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/common/chapters/cs7-config.adoc b/common/chapters/cs7-config.adoc
index 09b526c..6f212b2 100644
--- a/common/chapters/cs7-config.adoc
+++ b/common/chapters/cs7-config.adoc
@@ -351,3 +351,153 @@
So you only have the following options:
* Using M3UA with routing context (1..N)
* Using M3UA without routing context (0)
+
+==== Example: Static Routing
+
+Osmocom SS7 supports dynamic routing key registration via M3UA Routing Key Management (RKM), allowing minimal SS7
+configuration. If all of your components support dynamic RKM, you should probably use it: see
+`accept-asp-connections dynamic-permitted` in osmo-stp.cfg.
+
+This chapter explains how to configure osmo-stp if dynamic RKM is not an option.
+
+In this example, let's connect osmo-bsc via osmo-stp to osmo-msc using only static SS7 routing.
+
+----
+ BSC <--RK-1--> STP <--RK-3--> MSC
+ IP 1.1.1.1 IP 2.2.2.2 IP 3.3.3.3
+ M3UA 2905 M3UA 2905 M3UA 2905
+ PC 1.1.1 PC 3.3.3
+----
+
+Every one static route fanning out from STP gets assigned a distinct Routing Key -- a simple integer number. Above, the
+BSC's link has RK 1, the MSC's link has RK 3.
+
+For static routing, the M3UA port numbers must be fixed, i.e. there must be no `0` for a client's local port as in
+`asp foo 2905 0 m3ua`. Instead, you may use `asp foo 2905 2905 m3ua`.
+
+The BSC needs to configure:
+
+- its own point-code -- has to match the PC configured for the BSC in osmo-stp.cfg
+- the routing key -- has to match the RK assigned to BSC's PC in osmo-stp.cfg
+- the MSC's point-code -- has to match the PC in osmo-stp.cfg and osmo-msc.cfg
+- local and remote IP:ports for M3UA -- have to match the IP:ports in osmo-stp.cfg
+
+The MSC needs to configure:
+
+- its own point-code -- has to match the PC configured for the MSC in osmo-stp.cfg
+- the routing key -- has to match the RK assigned to MSC's PC in osmo-stp.cfg
+- local and remote IP:ports for M3UA -- have to match the IP:ports in osmo-stp.cfg
+
+The STP needs to configure:
+
+- all point-codes -- they have to match the PCs in osmo-bsc.cfg and osmo-msc.cfg
+- all routing keys -- they have to match the RKs used in osmo-bsc.cfg and osmo-msc.cfg
+- local and remote IP:ports for M3UA -- have to match the IP:ports in osmo-bsc.cfg and osmo-msc.cfg
+
+.osmo-bsc.cfg
+----
+cs7 instance 0
+ point-code 1.1.1
+
+ asp mybsc-0 2905 2905 m3ua
+ remote-ip 2.2.2.2
+ local-ip 1.1.1.1
+ sctp-role client
+ as mybsc0 m3ua
+ asp mybsc0-0
+ routing-key 1 1.1.1
+
+ sccp-address mymsc
+ routing-indicator PC
+ point-code 3.3.3
+
+msc 0
+ msc-addr mymsc
+----
+
+.osmo-stp.cfg
+----
+cs7 instance 0
+ xua rkm routing-key-allocation static-only
+ listen m3ua 2905
+ accept-asp-connections pre-configured
+ local-ip 2.2.2.2
+
+ # asp <name> <remote-port> <local-port|0> m3ua
+ asp mybsc-0 2905 2905 m3ua
+ remote-ip 1.1.1.1
+ local-ip 2.2.2.2
+ as mybsc m3ua
+ asp bsc-0
+ routing-key 1 1.1.1
+
+ asp mymsc-0 2905 2905 m3ua
+ remote-ip 3.3.3.3
+ local-ip 2.2.2.2
+ as mymsc m3ua
+ asp mymsc-0
+ routing-key 3 3.3.3
+
+ route-table system
+ update route 1.1.1 7.255.7 linkset mybsc
+ update route 3.3.3 7.255.7 linkset mymsc
+----
+
+.osmo-msc.cfg
+----
+cs7 instance 0
+ point-code 3.3.3
+
+ asp mymsc-0 2905 2905 m3ua
+ remote-ip 2.2.2.2
+ local-ip 3.3.3.3
+ sctp-role client
+ as mymsc0 m3ua
+ asp mymsc0-0
+ routing-key 3 3.3.3
+----
+
+For comparison, the same setup with dynamic routing key management is a lot shorter, especially at osmo-stp.cfg, and
+there is no need to manually configure point-codes and routing keys between STP and \{BSC,MSC}:
+
+.osmo-bsc.cfg
+----
+cs7 instance 0
+ point-code 1.1.1
+
+ asp mybsc-0 2905 0 m3ua
+ remote-ip 2.2.2.2
+ local-ip 1.1.1.1
+ sctp-role client
+ as mybsc0 m3ua
+ asp mybsc0-0
+
+ sccp-address mymsc
+ routing-indicator PC
+ point-code 3.3.3
+
+msc 0
+ msc-addr mymsc
+----
+
+.osmo-stp.cfg
+----
+cs7 instance 0
+ xua rkm routing-key-allocation dynamic-permitted
+ listen m3ua 2905
+ accept-asp-connections dynamic-permitted
+ local-ip 2.2.2.2
+----
+
+.osmo-msc.cfg
+----
+cs7 instance 0
+ point-code 3.3.3
+
+ asp mymsc-0 2905 0 m3ua
+ remote-ip 2.2.2.2
+ local-ip 3.3.3.3
+ sctp-role client
+ as mymsc0 m3ua
+ asp mymsc0-0
+----
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I44afddf7004f5bf37eec706ca3da12c04f83f8fa
Gerrit-Change-Number: 32273
Gerrit-PatchSet: 7
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: merged
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37186?usp=email )
Change subject: dbg log: nft kpi: clarify nr of rate ctrs vs nr of hnbp
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37186?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I84346d3151f3040967f39a3a6e6db2e29bc1e2ec
Gerrit-Change-Number: 37186
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 15 Jun 2024 02:53:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
