Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email )
Change subject: asterisk: Test auth resync procedure
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
This patch is huge. Can't say that I can quickly review this in full, but it's the test suite, right, and seems to work...
File asterisk/Asterisk_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191/comment/50bf3e4a_d732…
PS1, Line 367: private function f_AMI_IMS_start_register(IMS_ConnHdlrPars pars) runs on test_CT
f_AMI_IMS_register_start()
matching below
f_AMI_IMS_register_auth()
File asterisk/IMS_ConnectionHandler.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191/comment/2443a3e1_60b5…
PS1, Line 529: g_pars.subscr.auth.autn)))
(indent off?)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37191?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2c654c270aa908859ec0bbb4d1da30d58de99be4
Gerrit-Change-Number: 37191
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Jun 2024 01:57:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: lynxis lazus.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36983?usp=email )
Change subject: remsim_client: add support to set sim presence pin polarity
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
(not really important: i think naming wise, it's more elegant to stick to one variant of the name, not mixing "_pres_" and "_presence_")
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36983?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Iaa61967d2e8cd5c2269b73f4e65b42072e0ec513
Gerrit-Change-Number: 36983
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 17 Jun 2024 01:45:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: lynxis lazus.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email )
Change subject: firmware: allow to change the sim presence pin polarity
......................................................................
Patch Set 6: Code-Review+1
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/8761dd5c_d1434f16
PS6, Line 12: n
"Even though" ?
Patchset:
PS6:
rather fix the "prensence" typo in the symbol name before merging (see in-line comment).
otherwise looks sane, though I don't know this code.
File firmware/libcommon/include/simtrace.h:
https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/b99831f2_2b2a50c4
PS6, Line 128: prensence
typo in the name, should be "_presence_"
(same below)
File firmware/libcommon/include/simtrace_prot.h:
https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/872ccfcf_c571d209
PS6, Line 274: is valid bit
maybe "is a validity bit" or "indicates validity"?
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I77118114ba873fdf0778137402888b40f2442456
Gerrit-Change-Number: 36981
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 17 Jun 2024 01:34:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email )
Change subject: debian/copyright: remove include/openbsc/slhc.h (no such file)
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
(FTR, slhc.h lives in osmo-sgsn.git now, and that debian/copyright does include the same note accurately)
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ib1f2395798010381d67d79c46778bb0caef17046
Gerrit-Change-Number: 37236
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Jun 2024 01:20:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email )
Change subject: debian/copyright: remove include/openbsc/slhc.h (no such file)
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37236?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ib1f2395798010381d67d79c46778bb0caef17046
Gerrit-Change-Number: 37236
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Jun 2024 01:18:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37237?usp=email )
Change subject: smpp: fix typo in comment for SMPP_{SYS_ID,PASSWD}_LEN
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37237?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3f8d9a8e3739679995ddb037a8f3d58a627d36bc
Gerrit-Change-Number: 37237
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Jun 2024 01:17:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
