June 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-s1gw[master]: Makefile,contrib/jenkins: import from osmo-epdg

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37054?usp=email ) Change subject: Makefile,contrib/jenkins: import from osmo-epdg ...................................................................... Makefile,contrib/jenkins: import from osmo-epdg Add Makefile and contrib/jenkins.sh from osmo-epdg. Add "rebar3 asn compile" to the "build" target, as mentioned in README.md. Change-Id: Id8d6652c9007f4d565e2e0ca318e3a7b2113ea67 Tweaked-By: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> --- A Makefile A contrib/jenkins.sh 2 files changed, 49 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/Makefile b/Makefile new file mode 100644 index 0000000..6d3ded2 --- /dev/null +++ b/Makefile @@ -0,0 +1,31 @@ +all: build + +GEN_FILES = include/S1AP-*.hrl src/S1AP-*.erl + +src/S1AP-%.erl include/S1AP-%.hrl: asn1/S1AP-%.asn + rebar3 asn compile + +build: $(GEN_FILES) + rebar3 compile + rebar3 escriptize + +run: build + ERL_FLAGS='-config config/sys.config' _build/default/bin/osmo-s1gw + +shell: build + rebar3 shell --config ./config/sys.config + +check: $(GEN_FILES) + rebar3 eunit + +clean: +# Avoid running rebar3 clean if _build doesn't exist, since it would try +# to fetch deps from the Internet and that may not be avaialble when in +# OBS build. +ifneq ("$(wildcard _build/.*)", "") + rebar3 asn clean + rebar3 clean + rm -rf _build/ +else + rm -f $(GEN_FILES) +endif diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh new file mode 100755 index 0000000..df99a89 --- /dev/null +++ b/contrib/jenkins.sh @@ -0,0 +1,5 @@ +#!/bin/sh -ex + +make clean +make +make check -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id8d6652c9007f4d565e2e0ca318e3a7b2113ea67 Gerrit-Change-Number: 37054 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[S] Change in osmo-s1gw[master]: README: use shorter 'make' commands

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37056?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: README: use shorter 'make' commands ...................................................................... README: use shorter 'make' commands Change-Id: If650c04c676f98d5f936f478a0e44a6e1713c3d2 --- M README.md 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/README.md b/README.md index c5d30b2..b85bbbc 100644 --- a/README.md +++ b/README.md @@ -80,9 +80,7 @@ to compile it from source in some distros). ``` -$ rebar3 asn compile -$ rebar3 compile -$ rebar3 escriptize +$ make ``` @@ -92,7 +90,7 @@ Unit tests can be run this way: ``` -$ rebar3 eunit +$ make check ``` @@ -102,7 +100,7 @@ Once `osmo_s1gw` is built, you can start it this way: ``` -$ rebar3 shell --config config/sys.config +$ make run ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If650c04c676f98d5f936f478a0e44a6e1713c3d2 Gerrit-Change-Number: 37056 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[S] Change in osmo-s1gw[master]: Makefile,contrib/jenkins: import from osmo-epdg

by osmith

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37054?usp=email ) Change subject: Makefile,contrib/jenkins: import from osmo-epdg ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: great team work :) -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id8d6652c9007f4d565e2e0ca318e3a7b2113ea67 Gerrit-Change-Number: 37054 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Jun 2024 07:51:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in docker-playground[master]: asterisk: extensions.conf: Route non-local extensions towards IMS side

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37014?usp=email ) Change subject: asterisk: extensions.conf: Route non-local extensions towards IMS side ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37014?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icce5e55ab75c0c9fdacc4d8504e6714b99d385b4 Gerrit-Change-Number: 37014 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Jun 2024 06:44:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in docker-playground[master]: asterisk: pjsip.conf: Set default p_access_network_info

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37013?usp=email ) Change subject: asterisk: pjsip.conf: Set default p_access_network_info ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37013?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2bb0b89ec36137bbae613962ff5f5aad56721f34 Gerrit-Change-Number: 37013 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Jun 2024 06:44:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in osmo-hnbgw[master]: hnb_persistent: introduce disconnected timeout

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: hnb_persistent: introduce disconnected timeout ...................................................................... hnb_persistent: introduce disconnected timeout Add timer hnbgw X35: Clean up all hNodeB persistent state after this time of the hNodeB being disconnected. Set to zero to never clear hNodeB persistent state. (default is 60*60*24*27 = a week). The idea is to bound memory usage at sites where hNodeB do not stay on one fixed cell id, but use a different cell id after each Iuh reconnection. Related: SYS#6773 Related: osmo-ttcn3-hacks Ibec009203d38f65714561b7c28edbdbd8b34e704 Change-Id: Ic819d7cbc03fb39e98c204b70d016c5170dc6307 --- M include/osmocom/hnbgw/hnbgw.h M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/tdefs.c 3 files changed, 58 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/94/36894/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic819d7cbc03fb39e98c204b70d016c5170dc6307 Gerrit-Change-Number: 36894 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year

1
0
0 0

[S] Change in osmo-hnbgw[master]: warn earlier for missing nftables support

by neels

neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37076?usp=email ) Change subject: warn earlier for missing nftables support ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib19a3f671b096c349c13ed650837c621ac7ecd20 Gerrit-Change-Number: 37076 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 year

1
0
0 0

[M] Change in osmo-hnbgw[master]: hnb_persistent: introduce disconnected timeout

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894?usp=email ) Change subject: hnb_persistent: introduce disconnected timeout ...................................................................... Patch Set 2: (3 comments) File src/osmo-hnbgw/hnbgw.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16535): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894/comment/d0ad3a28_06b06c50 PS2, Line 572: if (period_s < 1) { suspect code indent for conditional statements (7, 15) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16535): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894/comment/f76795fc_04bf9091 PS2, Line 575: return; Statements should start on a tabstop Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16535): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894/comment/33e4f8b1_5ca88255 PS2, Line 576: } please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic819d7cbc03fb39e98c204b70d016c5170dc6307 Gerrit-Change-Number: 36894 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jun 2024 05:23:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: TC_hnb_disconnected_timeout; Osmocom_CTRL_Functions

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37077?usp=email ) Change subject: hnbgw: TC_hnb_disconnected_timeout; Osmocom_CTRL_Functions ...................................................................... hnbgw: TC_hnb_disconnected_timeout; Osmocom_CTRL_Functions Test the new timer hnbgw X35: discard all hnb_persistent state after a given timeout. While a hnb_persistent is present, its rate_ctrs and stat_items remain present. When it is discarded, these vanish again. Use this to verify that discarding and re-registering a hnb_persistent works. Teach the CTRL functions that retrieve rate counters to return counters of -1 when a requested object is not present, instead of erroring and stopping the test. Like this we can expect absence of an object. Set X35 to five seconds, drop the Iuh link, wait and verify that the rate counter group for the hnb_persistent is gone. Then reconnect and disconnect again, to provoke errors like use-after-free. Depends: osmo-hnbgw Ic819d7cbc03fb39e98c204b70d016c5170dc6307 Related: SYS#6773 Change-Id: Ibec009203d38f65714561b7c28edbdbd8b34e704 --- M hnbgw/HNBGW_Tests.ttcn M library/Osmocom_CTRL_Functions.ttcn 2 files changed, 198 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/37077/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 88b8c1e..d49d632 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -357,6 +357,7 @@ var charstring g_ctr_cn_node_name; /* Counter state */ var CounterNameValsList g_ctr_cn; + var CounterNameValsList g_ctr_hnb; } /* global altstep for global guard timer; */ @@ -433,6 +434,15 @@ vc_RUA[hnb_idx].start(RUA_Emulation.main(rua_ops, id & "-RUA")); } +function f_drop_hnodeb(integer hnb_idx) runs on test_CT +{ + + vc_Iuh[hnb_idx].stop; + vc_RUA[hnb_idx].stop; + disconnect(self:HNBAP[hnb_idx], vc_Iuh[hnb_idx]:HNBAP); + disconnect(vc_RUA[hnb_idx]:RUA, vc_Iuh[hnb_idx]:RUA); +} + private type record of boolean BooleanList; private function f_vty_cnlink_allow_attach(TELNETasp_PT pt, boolean ps_domain, BooleanList allow_attach_list) @@ -1016,6 +1026,114 @@ f_shutdown_helper(); } +/* Default list of counters for a 'hnb' entity */ +const CounterNameVals counternames_hnb := { + { "iuh:established", 0 } +}; + +private function f_ctrs_hnb_init(integer hnb_start := 0, integer hnb_count := 1, + CounterNameVals counternames := counternames_hnb) runs on test_CT { + g_ctr_hnb := f_counter_name_vals_get_n(IPA_CTRL, "hnb", hnb_count, counternames, start_idx := hnb_start); + log("initial hnb rate counters: ", g_ctr_hnb); +} + +/* f_ctrs_hnb_init(); + * f_do_thing(on_hnb := 0); + * f_do_thing(on_hnb := 0); + * f_do_other(on_hnb := 1); + * f_ctrs_hnb_add(0, "thing", 2); + * f_ctrs_hnb_add(1, "other"); + * f_ctrs_hnb_verify(); + */ +private function f_ctrs_hnb_verify() runs on test_CT { + log("verifying hnb rate counters: ", g_ctr_hnb); + f_counter_name_vals_expect_n(IPA_CTRL, "hnb", g_ctr_hnb); +} + +/* convenience: f_ctrs_hnb_add() and f_ctrs_hnb_verify() in one call. + * f_ctrs_hnb_init(); + * f_do_thing(on_hnb := 0); + * f_do_thing(on_hnb := 0); + * f_do_thing(on_hnb := 0); + * f_ctrs_hnb_expect(0, "thing", 3); + */ +private function f_ctrs_hnb_expect(integer hnb_nr, charstring countername, integer val := 1) runs on test_CT { + f_ctrs_hnb_add(hnb_nr, countername, val); + f_ctrs_hnb_verify(); +} + +private function f_ctrs_hnb_add(integer hnb_nr, charstring countername, integer val := 1) runs on test_CT { + f_counter_name_vals_list_add(g_ctr_hnb, hnb_nr, countername, val); +} + +/* Set all counters for this hnb instance to a specific value. Useful to expect a disconnected and discarded hnb, + * because -1 is returned by f_counter_name_vals_get_n() when the hnb is not present on the CTRL interface. */ +private function f_ctrs_hnb_set_all(integer hnb_nr, integer val) runs on test_CT { + for (var integer i := 0; i < lengthof(counternames_hnb); i := i + 1) { + f_counter_name_vals_list_set(g_ctr_hnb, hnb_nr, counternames_hnb[i].name, val); + } +} + +private function f_vty_run_hnbgw(TELNETasp_PT pt, charstring cmd) +{ + f_vty_enter_config(pt); + f_vty_transceive(pt, "hnbgw"); + f_vty_transceive(pt, cmd); + f_vty_transceive(pt, "end"); +} + +testcase TC_hnb_disconnected_timeout() runs on test_CT { + g_num_hnbs := 1; + f_init(start_hnb := true); + + f_vty_run_hnbgw(HNBGWVTY, "timer hnbgw X35 5"); + + /* Init the counters when the hnb already exists. There should be a nonzero iuh:established count now. */ + f_ctrs_hnb_init(); + + /* Drop the Iuh link */ + f_drop_hnodeb(0); + f_sleep(1.0); + + /* The hNodeB persistent state should still be around, because X35 has not yet elapsed. */ + f_ctrs_hnb_verify(); + + f_sleep(5.0); + /* We get -1 counters when the CTRL interface returned an error for the requested counter, meaning that the + * hnb_persistent no longer exists. Verify that it is gone: */ + f_ctrs_hnb_set_all(0, -1); + f_ctrs_hnb_verify(); + + f_sleep(1.0); + + /* Connect again. */ + var RuaOps rua_ops := { + create_cb := refers(IuhRanapCreateCallback), + unitdata_cb := refers(IuhRanapUnitdataCallback) + }; + f_init_hnodeb(testcasename(), 0, rua_ops); + + /* still disconnected until actually registered on HNBAP */ + f_ctrs_hnb_verify(); + + f_hnbap_register(0); + /* The hNodeB has come back to existence, so expect 0, not -1 anymore: */ + f_ctrs_hnb_set_all(0, 0); + /* Also we've registered once. */ + f_ctrs_hnb_add(0, "iuh:established", 1); + f_ctrs_hnb_verify(); + f_sleep(1.0); + + /* Again drop the Iuh link, wait for X35 and see that it's gone again. */ + f_drop_hnodeb(0); + f_ctrs_hnb_verify(); + f_sleep(6.0); + f_ctrs_hnb_set_all(0, -1); + f_ctrs_hnb_verify(); + + f_shutdown_helper(); +} + /* regular UE registration */ testcase TC_ue_register() runs on test_CT { var UE_Identity ue_id := { iMSI := imsi_hex2oct(f_gen_imsi(1)) }; @@ -2882,6 +3000,7 @@ execute(TC_hnb_register()); execute(TC_hnb_register_duplicate()); execute(TC_hnb_register_duplicate_reuse_sctp_assoc()); + execute(TC_hnb_disconnected_timeout()); execute(TC_ue_register()); execute(TC_ue_register_tmsi_lai()); execute(TC_ue_register_before_hnb_register()); diff --git a/library/Osmocom_CTRL_Functions.ttcn b/library/Osmocom_CTRL_Functions.ttcn index 75f8646..24b8880 100644 --- a/library/Osmocom_CTRL_Functions.ttcn +++ b/library/Osmocom_CTRL_Functions.ttcn @@ -30,7 +30,7 @@ } /* perform a given GET Operation */ - function f_ctrl_get(IPA_CTRL_PT pt, CtrlVariable variable) return CtrlValue { + function f_ctrl_get(IPA_CTRL_PT pt, CtrlVariable variable, template (omit) charstring on_err := omit) return CtrlValue { timer T := 2.0; var CtrlMessage rx; var CtrlId id := f_gen_rand_id(); @@ -41,8 +41,12 @@ } [] pt.receive(tr_CtrlMsgTrap) { repeat; } [] pt.receive(tr_CtrlMsgError) -> value rx { - setverdict(fail, "Error in CTRL GET ", variable, ": ", rx.err.reason); - mtc.stop; + if (ispresent(on_err)) { + rx.resp.val := valueof(on_err); + } else { + setverdict(fail, "Error in CTRL GET ", variable, ": ", rx.err.reason); + mtc.stop; + } } [] T.timeout { setverdict(fail, "Timeout waiting for CTRL GET REPLY ", variable); @@ -155,7 +159,7 @@ function f_ctrl_get_ratectr_abs(IPA_CTRL_PT pt, CtrlVariable grp, integer instance, CtrlVariable name) return integer { - return str2int(f_ctrl_get(pt, valueof(ts_ctrl_ratectr(grp, instance, name)))); + return str2int(f_ctrl_get(pt, valueof(ts_ctrl_ratectr(grp, instance, name)), on_err := "-1")); } function f_ctrl_get_exp_ratectr_abs(IPA_CTRL_PT pt, CtrlVariable grp, integer instance, @@ -231,6 +235,18 @@ return vals; } + function f_counter_name_vals_make(CounterNameVals counternames, integer val) + return CounterNameVals { + var CounterNameVals vals; + for (var integer i := 0; i < lengthof(counternames); i := i + 1) { + vals[i] := { + name := counternames[i].name, + val := val + }; + } + return vals; + } + /* Retrieve the first N instances' rate counter values of the given names */ function f_counter_name_vals_get_n(IPA_CTRL_PT pt, charstring instance_name := "msc", integer instance_count, CounterNameVals counternames, @@ -238,7 +254,13 @@ return CounterNameValsList { var CounterNameValsList valslist; for (var integer instance_nr := start_idx; instance_nr < start_idx + instance_count; instance_nr := instance_nr + 1) { - valslist[instance_nr] := f_counter_name_vals_get(pt, instance_name, instance_nr, counternames); + var CounterNameVals vals := f_counter_name_vals_get(pt, instance_name, instance_nr, counternames); + if (not ispresent(vals)) { + /* If that instance is not available on the CTRL interface, set all counters for this + * instance to -1. */ + vals := f_counter_name_vals_make(counternames, -1); + } + valslist[instance_nr] := vals; } log("retrieved rate counters: ", instance_name, ": ", valslist); return valslist; @@ -260,6 +282,22 @@ } } + /* In a list of one instance's counters, set a specifically named counter to a specific value. */ + function f_counter_name_vals_set(inout CounterNameVals vals, charstring countername, integer val := 1) + { + for (var integer i := 0; i < lengthof(vals); i := i + 1) { + if (vals[i].name == countername) { + vals[i].val := val; + return; + } + } + /* name not found, append */ + vals[lengthof(vals)] := { + name := countername, + val := val + } + } + /* In a list of several instances' counters, increment a specific instance's specifically named counter. */ function f_counter_name_vals_list_add(inout CounterNameValsList vals, integer instance_nr, charstring countername, integer val := 1) @@ -267,6 +305,14 @@ f_counter_name_vals_add(vals[instance_nr], countername, val); } + /* In a list of several instances' counters, set a specific instance's specifically named counter to a specific + * value. */ + function f_counter_name_vals_list_set(inout CounterNameValsList vals, integer instance_nr, + charstring countername, integer val := 0) + { + f_counter_name_vals_set(vals[instance_nr], countername, val); + } + /* For a specific instance, call f_counter_name_vals_get() and compare with expected counter values. * Set the test verdict accordingly. */ function f_counter_name_vals_expect(IPA_CTRL_PT pt, charstring instance_name, integer instance_nr, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibec009203d38f65714561b7c28edbdbd8b34e704 Gerrit-Change-Number: 37077 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[M] Change in osmo-hnbgw[master]: hnb_persistent: introduce disconnected timeout

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894?usp=email ) Change subject: hnb_persistent: introduce disconnected timeout ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic819d7cbc03fb39e98c204b70d016c5170dc6307 Gerrit-Change-Number: 36894 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jun 2024 05:20:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024