June 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-s1gw[master]: s1ap_proxy: implement patching of INITIAL CONTEXT SETUP REQ/RSP

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37072?usp=email ) Change subject: s1ap_proxy: implement patching of INITIAL CONTEXT SETUP REQ/RSP ...................................................................... s1ap_proxy: implement patching of INITIAL CONTEXT SETUP REQ/RSP Change-Id: Ia0d8f8d81756bcce5f518caee8887cf5822aaa08 --- M src/s1ap_proxy.erl M test/s1ap_proxy_test.erl 2 files changed, 132 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-s1gw refs/changes/72/37072/1 diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 0c6cba0..82e4039 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -124,6 +124,26 @@ NewContent = Content#'E-RABModificationIndication'{protocolIEs = IEs2}, handle_pdu_new(Data, {Outcome, Pdu#'InitiatingMessage'{value = NewContent}}); +%% 9.1.4.1 INITIAL CONTEXT SETUP REQUEST +handle_pdu(Data, {Outcome = initiatingMessage, + #'InitiatingMessage'{procedureCode = ?'id-InitialContextSetup', + value = Content} = Pdu}) -> + logger:debug("Patching INITIAL CONTEXT SETUP REQUEST"), + IEs = handle_ies(Content#'InitialContextSetupRequest'.protocolIEs, + ?'id-E-RABToBeSetupListCtxtSUReq'), + NewContent = Content#'InitialContextSetupRequest'{protocolIEs = IEs}, + handle_pdu_new(Data, {Outcome, Pdu#'InitiatingMessage'{value = NewContent}}); + +%% 9.1.4.3 INITIAL CONTEXT SETUP RESPONSE +handle_pdu(Data, {Outcome = successfulOutcome, + #'SuccessfulOutcome'{procedureCode = ?'id-InitialContextSetup', + value = Content} = Pdu}) -> + logger:debug("Patching INITIAL CONTEXT SETUP RESPONSE"), + IEs = handle_ies(Content#'InitialContextSetupResponse'.protocolIEs, + ?'id-E-RABSetupListCtxtSURes'), + NewContent = Content#'InitialContextSetupResponse'{protocolIEs = IEs}, + handle_pdu_new(Data, {Outcome, Pdu#'SuccessfulOutcome'{value = NewContent}}); + %% Proxy all other messages unmodified handle_pdu(Data, _Pdu) -> Data. @@ -179,6 +199,30 @@ TLA = transp_layer_addr(mme_loc_addr), Content#'E-RABNotToBeModifiedItemBearerModInd'{transportLayerAddress = TLA}; +%% INITIAL CONTEXT SETUP REQUEST related IEs +handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeSetupListCtxtSUReq', + value = Content}) -> + %% This IE contains a list of CtxtSUReq, so patch inner IEs + handle_ies(Content, ?'id-E-RABToBeSetupItemCtxtSUReq'); + +handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeSetupItemCtxtSUReq', + value = Content}) -> + %% eNB -> MME direction: we pass our MME facing local address + TLA = transp_layer_addr(mme_loc_addr), + Content#'E-RABToBeSetupItemCtxtSUReq'{transportLayerAddress = TLA}; + +%% INITIAL CONTEXT SETUP RESPONSE related IEs +handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABSetupListCtxtSURes', + value = Content}) -> + %% This IE contains a list of CtxtSURes, so patch inner IEs + handle_ies(Content, ?'id-E-RABSetupItemCtxtSURes'); + +handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABSetupItemCtxtSURes', + value = Content}) -> + %% MME -> eNB direction: we pass our eNB facing local address + TLA = transp_layer_addr(s1gw_bind_addr), + Content#'E-RABSetupItemCtxtSURes'{transportLayerAddress = TLA}; + %% Catch-all variant, which should not be called normally handle_ie(#'ProtocolIE-Field'{value = Content} = IE) -> logger:error("[BUG] Unhandled S1AP IE: ~p", [IE]), diff --git a/test/s1ap_proxy_test.erl b/test/s1ap_proxy_test.erl index 4123085..e694197 100644 --- a/test/s1ap_proxy_test.erl +++ b/test/s1ap_proxy_test.erl @@ -110,4 +110,83 @@ application:set_env(osmo_s1gw, mme_loc_addr, ?EXP_ADDR_STR), ?assertEqual(ExpData, s1ap_proxy:handle_pdu(OrigData)). + +%% [eNB -> MME] INITIAL CONTEXT SETUP REQUEST +initial_context_setup_req_pdu(TLA, TEID) when is_binary(TLA), + is_binary(TEID) -> + << 16#00, 16#09, 16#00, 16#81, 16#10, 16#00, 16#00, 16#07, + 16#00, 16#00, 16#00, 16#02, 16#00, 16#01, 16#00, 16#08, + 16#00, 16#02, 16#00, 16#01, 16#00, 16#42, 16#00, 16#0a, + 16#18, 16#3b, 16#9a, 16#ca, 16#00, 16#60, 16#3b, 16#9a, + 16#ca, 16#00, 16#00, 16#18, 16#00, 16#80, 16#b5, 16#00, + 16#00, 16#34, 16#00, 16#80, 16#af, 16#45, 16#00, 16#09, + 16#20, 16#0f, 16#80, + TLA/bytes, %% transportLayerAddress (IPv4) + TEID/bytes, %% GTP-TEID + 16#80, 16#9f, 16#27, 16#bd, 16#de, + 16#61, 16#4e, 16#02, 16#07, 16#42, 16#02, 16#29, 16#06, + 16#40, 16#32, 16#f8, 16#10, 16#00, 16#01, 16#00, 16#6e, + 16#52, 16#05, 16#c1, 16#01, 16#09, 16#09, 16#08, 16#69, + 16#6e, 16#74, 16#65, 16#72, 16#6e, 16#65, 16#74, 16#05, + 16#01, 16#c0, 16#a8, 16#64, 16#02, 16#5e, 16#06, 16#fe, + 16#fe, 16#fa, 16#fa, 16#02, 16#02, 16#58, 16#32, 16#27, + 16#4d, 16#80, 16#80, 16#21, 16#10, 16#02, 16#00, 16#00, + 16#10, 16#81, 16#06, 16#08, 16#08, 16#08, 16#08, 16#83, + 16#06, 16#08, 16#08, 16#04, 16#04, 16#00, 16#0d, 16#04, + 16#08, 16#08, 16#08, 16#08, 16#00, 16#0d, 16#04, 16#08, + 16#08, 16#04, 16#04, 16#00, 16#03, 16#10, 16#20, 16#01, + 16#48, 16#60, 16#48, 16#60, 16#00, 16#00, 16#00, 16#00, + 16#00, 16#00, 16#00, 16#00, 16#88, 16#88, 16#00, 16#03, + 16#10, 16#20, 16#01, 16#48, 16#60, 16#48, 16#60, 16#00, + 16#00, 16#00, 16#00, 16#00, 16#00, 16#00, 16#00, 16#88, + 16#44, 16#00, 16#10, 16#02, 16#05, 16#aa, 16#50, 16#0b, + 16#f6, 16#32, 16#f8, 16#10, 16#00, 16#02, 16#01, 16#c0, + 16#00, 16#02, 16#86, 16#13, 16#32, 16#f8, 16#10, 16#00, + 16#01, 16#23, 16#05, 16#f4, 16#04, 16#94, 16#25, 16#f8, + 16#64, 16#02, 16#01, 16#08, 16#00, 16#6b, 16#00, 16#05, + 16#1c, 16#00, 16#0e, 16#00, 16#00, 16#00, 16#49, 16#00, + 16#20, 16#57, 16#5d, 16#d3, 16#66, 16#69, 16#73, 16#4c, + 16#8c, 16#48, 16#42, 16#76, 16#5f, 16#fe, 16#f9, 16#bd, + 16#d5, 16#89, 16#08, 16#ae, 16#f6, 16#f4, 16#88, 16#62, + 16#22, 16#d7, 16#80, 16#fb, 16#36, 16#33, 16#d9, 16#9e, + 16#9f, 16#00, 16#c0, 16#40, 16#08, 16#35, 16#87, 16#61, + 16#10, 16#03, 16#ff, 16#ff, 16#74 + >>. + +initial_context_setup_req_test() -> + %% Original input data + TEID = << 16#00, 16#00, 16#71, 16#23 >>, + OrigTLA = << 16#c0, 16#a8, 16#02, 16#d2 >>, + OrigData = initial_context_setup_req_pdu(OrigTLA, TEID), + + %% Expected output data + ExpData = initial_context_setup_req_pdu(?EXP_ADDR_BIN, TEID), + + application:set_env(osmo_s1gw, mme_loc_addr, ?EXP_ADDR_STR), + ?assertEqual(ExpData, s1ap_proxy:handle_pdu(OrigData)). + + +%% [MME -> eNB] INITIAL CONTEXT SETUP RESPONSE +initial_context_setup_rsp_pdu(TLA, TEID) when is_binary(TLA), + is_binary(TEID) -> + << 16#20, 16#09, 16#00, 16#22, 16#00, 16#00, 16#03, 16#00, + 16#00, 16#40, 16#02, 16#00, 16#01, 16#00, 16#08, 16#40, + 16#02, 16#00, 16#01, 16#00, 16#33, 16#40, 16#0f, 16#00, + 16#00, 16#32, 16#40, 16#0a, 16#0a, 16#1f, + TLA/bytes, %% transportLayerAddress (IPv4) + TEID/bytes %% GTP-TEID + >>. + +initial_context_setup_rsp_test() -> + %% Original input data + TEID = << 16#00, 16#00, 16#00, 16#01 >>, + OrigTLA = << 16#c0, 16#a8, 16#02, 16#cb >>, + OrigData = initial_context_setup_rsp_pdu(OrigTLA, TEID), + + %% Expected output data + ExpData = initial_context_setup_rsp_pdu(?EXP_ADDR_BIN, TEID), + + application:set_env(osmo_s1gw, s1gw_bind_addr, ?EXP_ADDR_STR), + ?assertEqual(ExpData, s1ap_proxy:handle_pdu(OrigData)). + %% vim:set ts=4 sw=4 et: -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37072?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ia0d8f8d81756bcce5f518caee8887cf5822aaa08 Gerrit-Change-Number: 37072 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[M] Change in osmo-s1gw[master]: s1ap_proxy: implement patching of E-RAB MODIFICATION IND

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37071?usp=email ) Change subject: s1ap_proxy: implement patching of E-RAB MODIFICATION IND ...................................................................... s1ap_proxy: implement patching of E-RAB MODIFICATION IND Change-Id: I054b874b39d4e39a51c00385d1553da065131047 --- M src/s1ap_proxy.erl M test/s1ap_proxy_test.erl 2 files changed, 71 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-s1gw refs/changes/71/37071/1 diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index f24f3c8..0c6cba0 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -91,7 +91,7 @@ end. -%% E-RAB SETUP REQUEST +%% 9.1.3.1 E-RAB SETUP REQUEST handle_pdu(Data, {Outcome = initiatingMessage, #'InitiatingMessage'{procedureCode = ?'id-E-RABSetup', value = Content} = Pdu}) -> @@ -101,7 +101,7 @@ NewContent = Content#'E-RABSetupRequest'{protocolIEs = IEs}, handle_pdu_new(Data, {Outcome, Pdu#'InitiatingMessage'{value = NewContent}}); -%% E-RAB SETUP RESPONSE +%% 9.1.3.2 E-RAB SETUP RESPONSE handle_pdu(Data, {Outcome = successfulOutcome, #'SuccessfulOutcome'{procedureCode = ?'id-E-RABSetup', value = Content} = Pdu}) -> @@ -111,6 +111,19 @@ NewContent = Content#'E-RABSetupResponse'{protocolIEs = IEs}, handle_pdu_new(Data, {Outcome, Pdu#'SuccessfulOutcome'{value = NewContent}}); +%% 9.1.3.8 E-RAB MODIFICATION INDICATION +handle_pdu(Data, {Outcome = initiatingMessage, + #'InitiatingMessage'{procedureCode = ?'id-E-RABModificationIndication', + value = Content} = Pdu}) -> + logger:debug("Patching E-RAB MODIFICATION INDICATION"), + IEs = Content#'E-RABModificationIndication'.protocolIEs, + %% E-RAB to be Modified List + IEs1 = handle_ies(IEs, ?'id-E-RABToBeModifiedListBearerModInd'), + %% E-RAB not to be Modified List + IEs2 = handle_ies(IEs1, ?'id-E-RABNotToBeModifiedListBearerModInd'), + NewContent = Content#'E-RABModificationIndication'{protocolIEs = IEs2}, + handle_pdu_new(Data, {Outcome, Pdu#'InitiatingMessage'{value = NewContent}}); + %% Proxy all other messages unmodified handle_pdu(Data, _Pdu) -> Data. @@ -143,6 +156,29 @@ TLA = transp_layer_addr(s1gw_bind_addr), Content#'E-RABSetupItemBearerSURes'{transportLayerAddress = TLA}; +%% E-RAB MODIFICATION INDICATION related IEs +handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeModifiedListBearerModInd', + value = Content}) -> + %% This IE contains a list of BearerModInd, so patch inner IEs + handle_ies(Content, ?'id-E-RABToBeModifiedItemBearerModInd'); + +handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeModifiedItemBearerModInd', + value = Content}) -> + %% eNB -> MME direction: we pass our MME facing local address + TLA = transp_layer_addr(mme_loc_addr), + Content#'E-RABToBeModifiedItemBearerModInd'{transportLayerAddress = TLA}; + +handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABNotToBeModifiedListBearerModInd', + value = Content}) -> + %% This IE contains a list of BearerModInd, so patch inner IEs + handle_ies(Content, ?'id-E-RABNotToBeModifiedItemBearerModInd'); + +handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABNotToBeModifiedItemBearerModInd', + value = Content}) -> + %% eNB -> MME direction: we pass our MME facing local address + TLA = transp_layer_addr(mme_loc_addr), + Content#'E-RABNotToBeModifiedItemBearerModInd'{transportLayerAddress = TLA}; + %% Catch-all variant, which should not be called normally handle_ie(#'ProtocolIE-Field'{value = Content} = IE) -> logger:error("[BUG] Unhandled S1AP IE: ~p", [IE]), diff --git a/test/s1ap_proxy_test.erl b/test/s1ap_proxy_test.erl index 2bc8392..4123085 100644 --- a/test/s1ap_proxy_test.erl +++ b/test/s1ap_proxy_test.erl @@ -86,4 +86,28 @@ application:set_env(osmo_s1gw, s1gw_bind_addr, ?EXP_ADDR_STR), ?assertEqual(ExpData, s1ap_proxy:handle_pdu(OrigData)). + +%% [eNB -> MME] E-RAB MODIFICATION INDICATION +e_rab_modify_ind_pdu(TLA, TEID) when is_binary(TLA), + is_binary(TEID) -> + << 16#00, 16#32, 16#00, 16#24, 16#00, 16#00, 16#03, 16#00, + 16#00, 16#00, 16#02, 16#00, 16#02, 16#00, 16#08, 16#00, + 16#04, 16#80, 16#06, 16#69, 16#2d, 16#00, 16#c7, 16#00, + 16#0f, 16#00, 16#00, 16#c8, 16#00, 16#0a, 16#0a, 16#1f, + TLA/bytes, %% transportLayerAddress (IPv4) + TEID/bytes %% GTP-TEID + >>. + +e_rab_modify_ind_test() -> + %% Original input data + TEID = << 16#3d, 16#b0, 16#b5, 16#1d >>, + OrigTLA = << 16#c0, 16#a8, 16#12, 16#c6 >>, + OrigData = e_rab_modify_ind_pdu(OrigTLA, TEID), + + %% Expected output data + ExpData = e_rab_modify_ind_pdu(?EXP_ADDR_BIN, TEID), + + application:set_env(osmo_s1gw, mme_loc_addr, ?EXP_ADDR_STR), + ?assertEqual(ExpData, s1ap_proxy:handle_pdu(OrigData)). + %% vim:set ts=4 sw=4 et: -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37071?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I054b874b39d4e39a51c00385d1553da065131047 Gerrit-Change-Number: 37071 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[L] Change in osmo-s1gw[master]: Add COPYING and license headers to *.erl files

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37069?usp=email ) Change subject: Add COPYING and license headers to *.erl files ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37069?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8b38d05299211da187ca74812b228b4f30708193 Gerrit-Change-Number: 37069 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jun 2024 21:16:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-s1gw[master]: sctp_{server,proxy}: cosmetic: improve logging

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37068?usp=email ) Change subject: sctp_{server,proxy}: cosmetic: improve logging ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I6287a5ec775e3aba18e16470388888c43104e963 Gerrit-Change-Number: 37068 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jun 2024 21:15:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in docker-playground[master]: asterisk: pjsip.conf: Update IMS port asterisk config

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37012?usp=email ) Change subject: asterisk: pjsip.conf: Update IMS port asterisk config ...................................................................... asterisk: pjsip.conf: Update IMS port asterisk config The config names changes recently during development. Adapt to the new range style fields. Change-Id: I4aceb3b62ce7f446abd02b1a53993a3baecf2f20 --- M ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified jolly: Looks good to me, approved diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf index b776e0e..0e9b201 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf @@ -77,8 +77,10 @@ type=transport protocol=tcp bind=172.18.11.10:5060 -ims_port_c=5555 -ims_port_s=5060 +sec_port_c_min=5555 +sec_port_c_max=5559 +sec_port_s_min=5060 +sec_port_s_max=5069 [volte_ims] type=registration -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37012?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4aceb3b62ce7f446abd02b1a53993a3baecf2f20 Gerrit-Change-Number: 37012 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[S] Change in docker-playground[master]: asterisk: pjsip.conf: Update IMS port asterisk config

by jolly

Attention is currently required from: Hoernchen, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37012?usp=email ) Change subject: asterisk: pjsip.conf: Update IMS port asterisk config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37012?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4aceb3b62ce7f446abd02b1a53993a3baecf2f20 Gerrit-Change-Number: 37012 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jun 2024 19:02:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in libosmocore[master]: [cosmetic] libosmosim/class_tables: Add a quick reminder about the cases

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37067?usp=email ) Change subject: [cosmetic] libosmosim/class_tables: Add a quick reminder about the cases ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37067?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5280b6431b18ec36c3186460bebeb6321996c35f Gerrit-Change-Number: 37067 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jun 2024 18:46:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in libosmocore[master]: libosmosim: class_tables: Resolve conflicting CLA=8x INS=F2 definitions

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36501?usp=email ) Change subject: libosmosim: class_tables: Resolve conflicting CLA=8x INS=F2 definitions ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > this is still untested Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36501?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8dd317ef8f942542e412b18c834a0467c51291c3 Gerrit-Change-Number: 36501 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Jun 2024 18:45:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year

1
0
0 0

[L] Change in osmo-s1gw[master]: Add COPYING and license headers to *.erl files

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37069?usp=email ) Change subject: Add COPYING and license headers to *.erl files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37069?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8b38d05299211da187ca74812b228b4f30708193 Gerrit-Change-Number: 37069 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jun 2024 18:44:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-s1gw[master]: sctp_{server,proxy}: cosmetic: improve logging

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37068?usp=email ) Change subject: sctp_{server,proxy}: cosmetic: improve logging ...................................................................... sctp_{server,proxy}: cosmetic: improve logging Change-Id: I6287a5ec775e3aba18e16470388888c43104e963 --- M src/sctp_proxy.erl M src/sctp_server.erl 2 files changed, 17 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-s1gw refs/changes/68/37068/1 diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index 2cc6165..ffa9111 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -119,7 +119,7 @@ %% Handle an #sctp_sndrcvinfo event (MME -> eNB data) connected(info, {sctp, _Socket, MmeAddr, MmePort, {[#sctp_sndrcvinfo{assoc_id = Aid}], Data}}, S) -> - logger:info("MME connection (id=~p, ~p:~p) Rx ~p", + logger:debug("MME connection (id=~p, ~p:~p) -> eNB: ~p", [Aid, MmeAddr, MmePort, Data]), sctp_server:send_data(maps:get(enb_aid, S), s1ap_proxy:handle_pdu(Data)), diff --git a/src/sctp_server.erl b/src/sctp_server.erl index a2b722a..c55c27d 100644 --- a/src/sctp_server.erl +++ b/src/sctp_server.erl @@ -118,17 +118,17 @@ assoc_id = Aid}}) -> case ConnState of comm_up -> - logger:notice("Connection (id=~p, ~p:~p) established", [Aid, FromAddr, FromPort]), + logger:notice("eNB connection (id=~p, ~p:~p) established", [Aid, FromAddr, FromPort]), Clients = client_add(State#server_state.clients, Aid, FromAddr, FromPort, State#server_state.mme_addr_port); shutdown_comp -> - logger:notice("Connection (id=~p, ~p:~p) closed", [Aid, FromAddr, FromPort]), + logger:notice("eNB connection (id=~p, ~p:~p) closed", [Aid, FromAddr, FromPort]), Clients = client_del(State#server_state.clients, Aid); comm_lost -> - logger:notice("Connection (id=~p, ~p:~p) lost", [Aid, FromAddr, FromPort]), + logger:notice("eNB connection (id=~p, ~p:~p) lost", [Aid, FromAddr, FromPort]), Clients = client_del(State#server_state.clients, Aid); _ -> - logger:notice("Connection (id=~p, ~p:~p) state ~p", + logger:notice("eNB connection (id=~p, ~p:~p) state ~p", [Aid, FromAddr, FromPort, ConnState]), Clients = State#server_state.clients end, @@ -137,12 +137,12 @@ %% Handle an #sctp_sndrcvinfo event (incoming data) sctp_recv(State, {FromAddr, FromPort, [#sctp_sndrcvinfo{assoc_id = Aid}], Data}) -> - logger:info("Connection (id=~p, ~p:~p) Rx ~p", [Aid, FromAddr, FromPort, Data]), + logger:debug("eNB connection (id=~p, ~p:~p) -> MME: ~p", [Aid, FromAddr, FromPort, Data]), case dict:find(Aid, State#server_state.clients) of {ok, #client_state{pid = Pid}} -> sctp_proxy:send_data(Pid, Data); error -> - logger:error("Connection (id=~p, ~p:~p) is not known to us?!?", + logger:error("eNB connection (id=~p, ~p:~p) is not known to us?!?", [Aid, FromAddr, FromPort]) end, State; @@ -194,7 +194,7 @@ close_conns(Sock, [{Aid, Client} | Clients]) -> {FromAddr, FromPort} = Client#client_state.addr_port, - logger:notice("Terminating connection (id=~p, ~p:~p)", [Aid, FromAddr, FromPort]), + logger:notice("Terminating eNB connection (id=~p, ~p:~p)", [Aid, FromAddr, FromPort]), %% request to terminate an MME connection sctp_proxy:shutdown(Client#client_state.pid), %% gracefully close an eNB connection -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I6287a5ec775e3aba18e16470388888c43104e963 Gerrit-Change-Number: 37068 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024