June 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-hnbgw[master]: 3-digit MNC: use osmo_plmn_id in struct umts_cell_id

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36893?usp=email ) Change subject: 3-digit MNC: use osmo_plmn_id in struct umts_cell_id ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36893?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id9a91c80cd2745424a916aef4736993bb7cd8ba0 Gerrit-Change-Number: 36893 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jun 2024 05:20:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year

1
0
0 0

[L] Change in osmo-hnbgw[master]: add umts_cell_id_test.c

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36892?usp=email ) Change subject: add umts_cell_id_test.c ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ibbb61a2c53a11dea794f451d3074bc9ba50862fe Gerrit-Change-Number: 36892 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jun 2024 05:20:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-hnbgw[master]: umts_cell_id: add umts_cell_id_to_str_buf()

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36891?usp=email ) Change subject: umts_cell_id: add umts_cell_id_to_str_buf() ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3cc0169593c73c2e658637e4116ddd578f83df6d Gerrit-Change-Number: 36891 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jun 2024 05:20:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-hnbgw[master]: rename to umts_cell_id_to_str()

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36890?usp=email ) Change subject: rename to umts_cell_id_to_str() ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3124d1f5e634bc895ec347cb1a9816789fd9ab69 Gerrit-Change-Number: 36890 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jun 2024 05:20:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-hnbgw[master]: fix stat_item leak in hnb_persistent_free()

by neels

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37074?usp=email to look at the new patch set (#2). Change subject: fix stat_item leak in hnb_persistent_free() ...................................................................... fix stat_item leak in hnb_persistent_free() Add missing stat_item free in hnb_persistent_free(). We recently fixed a rate_ctr leak in I14e050bfb91b993f194e3800eacdc0d10f2b1a4e, but missed the also leaking stat_item. Particularly relevant with upcoming patch Ic819d7cbc03fb39e98c204b70d016c5170dc6307 -- testing that patch revealed the leak. Related: osmo-ttcn3-hacks Ibec009203d38f65714561b7c28edbdbd8b34e704 Change-Id: I7326c53d595dce7b442eced89ff8f4b972bd2a82 --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/74/37074/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37074?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7326c53d595dce7b442eced89ff8f4b972bd2a82 Gerrit-Change-Number: 37074 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year

1
0
0 0

[S] Change in osmo-hnbgw[master]: warn earlier for missing nftables support

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37076?usp=email ) Change subject: warn earlier for missing nftables support ...................................................................... warn earlier for missing nftables support Change-Id: Ib19a3f671b096c349c13ed650837c621ac7ecd20 --- M src/osmo-hnbgw/hnbgw_vty.c 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/76/37076/1 diff --git a/src/osmo-hnbgw/hnbgw_vty.c b/src/osmo-hnbgw/hnbgw_vty.c index d719c29..f20dbff 100644 --- a/src/osmo-hnbgw/hnbgw_vty.c +++ b/src/osmo-hnbgw/hnbgw_vty.c @@ -887,6 +887,7 @@ NFT_KPI_STR "Set a custom nft table name to use, instead of 'osmo-hnbgw'\n") { +#if ENABLE_NFTABLES const char *set_table_name = NULL; if (argc > 0) set_table_name = argv[0]; @@ -898,12 +899,18 @@ osmo_talloc_replace_string(g_hnbgw, &g_hnbgw->config.nft_kpi.table_name, set_table_name); return CMD_SUCCESS; +#else + /* This VTY cmd is trying to enable nft-kpi, but this binary does not support nftables. Error immediately. */ + vty_out(vty, "%% ERROR: Built without libnftables support, cannot enable nft-kpi%s", VTY_NEWLINE); + return CMD_WARNING; +#endif } DEFUN(cfg_hnbgw_no_nft_kpi, cfg_hnbgw_no_nft_kpi_cmd, "no nft-kpi", NO_STR NFT_KPI_STR) { + /* This function has no #if ENABLE_NFTABLES: always allow to switch off nft-kpi. */ if (vty->type == VTY_TERM) vty_out(vty, "%% WARNING: nft configuration changes need a restart of osmo-hnbgw%s", VTY_NEWLINE); g_hnbgw->config.nft_kpi.enable = false; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib19a3f671b096c349c13ed650837c621ac7ecd20 Gerrit-Change-Number: 37076 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in osmo-hnbgw[master]: add LOG_HNBP() for hnb_persistent

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37075?usp=email ) Change subject: add LOG_HNBP() for hnb_persistent ...................................................................... add LOG_HNBP() for hnb_persistent Add macro for the pattern LOGP(DHNB, ..., "%s: ...", hnbp->id_str) and use where applicable. Change-Id: I23334124074491fb3b91e720b67c97181c16bc21 --- M include/osmocom/hnbgw/hnbgw.h M src/osmo-hnbgw/hnbgw.c 2 files changed, 23 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/75/37075/1 diff --git a/include/osmocom/hnbgw/hnbgw.h b/include/osmocom/hnbgw/hnbgw.h index 9b07584..c28f8bc 100644 --- a/include/osmocom/hnbgw/hnbgw.h +++ b/include/osmocom/hnbgw/hnbgw.h @@ -41,6 +41,12 @@ #define LOGHNB(HNB_CTX, ss, lvl, fmt, args ...) \ LOGP(ss, lvl, "(%s) " fmt, hnb_context_name(HNB_CTX), ## args) +#define LOG_HNBP(HNBP, lvl, fmt, args...) \ + LOGP(DHNB, lvl, "(%s) " fmt, \ + (HNBP) ? \ + (((HNBP)->id_str && *(HNBP)->id_str) ? (HNBP)->id_str : "no-cell-id") \ + : "null", ## args) + #define DOMAIN_CS RANAP_CN_DomainIndicator_cs_domain #define DOMAIN_PS RANAP_CN_DomainIndicator_ps_domain diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 20a665e..20d6aa6 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -613,19 +613,17 @@ fd = osmo_stream_srv_get_fd(hnbp->ctx->conn); if (fd < 0) { - LOGP(DHNB, LOGL_ERROR, "%s: no active socket fd, cannot set up traffic counters\n", hnbp->id_str); + LOG_HNBP(hnbp, LOGL_ERROR, "no active socket fd, cannot set up traffic counters\n"); return; } socklen = sizeof(struct osmo_sockaddr); if (getpeername(fd, &osa.u.sa, &socklen)) { - LOGP(DHNB, LOGL_ERROR, "%s: cannot read remote address, cannot set up traffic counters\n", - hnbp->id_str); + LOG_HNBP(hnbp, LOGL_ERROR, "cannot read remote address, cannot set up traffic counters\n"); return; } if (osmo_sockaddr_str_from_osa(&remote_str, &osa)) { - LOGP(DHNB, LOGL_ERROR, "%s: cannot parse remote address, cannot set up traffic counters\n", - hnbp->id_str); + LOG_HNBP(hnbp, LOGL_ERROR, "cannot parse remote address, cannot set up traffic counters\n"); return; } @@ -634,7 +632,7 @@ remote_str.port = 2152; if (nft_kpi_hnb_start(hnbp, &remote_str)) - LOGP(DHNB, LOGL_ERROR, "%s: failed to set up traffic counters\n", hnbp->id_str); + LOG_HNBP(hnbp, LOGL_ERROR, "failed to set up traffic counters\n"); } /* Whenever HNBAP registers a HNB, hnbgw_hnbap.c calls this function to let the hnb_persistent update its state to the @@ -643,7 +641,7 @@ void hnb_persistent_registered(struct hnb_persistent *hnbp) { if (!hnbp->ctx) { - LOGP(DHNB, LOGL_ERROR, "hnb_persistent_registered() invoked, but there is no hnb_ctx\n"); + LOG_HNBP(hnbp, LOGL_ERROR, "hnb_persistent_registered() invoked, but there is no hnb_ctx\n"); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37075?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I23334124074491fb3b91e720b67c97181c16bc21 Gerrit-Change-Number: 37075 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in osmo-hnbgw[master]: fix stat_item leak in hnb_persistent_free()

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37074?usp=email ) Change subject: fix stat_item leak in hnb_persistent_free() ...................................................................... fix stat_item leak in hnb_persistent_free() Add missing stat_item free in hnb_persistent_free(). We recently fixed a rate_ctr leak in I14e050bfb91b993f194e3800eacdc0d10f2b1a4e, but missed the also leaking stat_item. Particularly relevant with upcoming patch Ic819d7cbc03fb39e98c204b70d016c5170dc6307 -- testing that patch revealed the leak. Change-Id: I7326c53d595dce7b442eced89ff8f4b972bd2a82 --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/74/37074/1 diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 43162fc..8dcf5f2 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -663,6 +663,7 @@ /* FIXME: check if in use? */ nft_kpi_hnb_stop(hnbp); nft_kpi_hnb_persistent_remove(hnbp); + osmo_stat_item_group_free(hnbp->statg); rate_ctr_group_free(hnbp->ctrs); llist_del(&hnbp->list); hash_del(&hnbp->node_by_id); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37074?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7326c53d595dce7b442eced89ff8f4b972bd2a82 Gerrit-Change-Number: 37074 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in osmo-s1gw[master]: s1ap_proxy: add TODOs for PDUs also containing TLA

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37073?usp=email ) Change subject: s1ap_proxy: add TODOs for PDUs also containing TLA ...................................................................... s1ap_proxy: add TODOs for PDUs also containing TLA Change-Id: I1d420481cf78c75c2b7a7a3df5ffb1af1ba9aaa0 --- M src/s1ap_proxy.erl 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-s1gw refs/changes/73/37073/1 diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 82e4039..d50d765 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -111,6 +111,8 @@ NewContent = Content#'E-RABSetupResponse'{protocolIEs = IEs}, handle_pdu_new(Data, {Outcome, Pdu#'SuccessfulOutcome'{value = NewContent}}); +%% TODO: 9.1.3.3 E-RAB MODIFY REQUEST / (Optional) Transport Information + %% 9.1.3.8 E-RAB MODIFICATION INDICATION handle_pdu(Data, {Outcome = initiatingMessage, #'InitiatingMessage'{procedureCode = ?'id-E-RABModificationIndication', @@ -144,6 +146,13 @@ NewContent = Content#'InitialContextSetupResponse'{protocolIEs = IEs}, handle_pdu_new(Data, {Outcome, Pdu#'SuccessfulOutcome'{value = NewContent}}); +%% TODO: 9.1.5.2 HANDOVER COMMAND :: (O) UL/DL Transport Layer Address +%% TODO: 9.1.5.4 HANDOVER REQUEST :: (M) Transport Layer Address +%% TODO: 9.1.5.5 HANDOVER REQUEST ACKNOWLEDGE :: (M) Transport Layer Address, +%% (O) UL/DL Transport Layer Address +%% TODO: 9.1.5.8 PATH SWITCH REQUEST :: (M) Transport Layer Address +%% TODO: 9.1.5.9 PATH SWITCH REQUEST ACKNOWLEDGE :: (M) Transport Layer Address + %% Proxy all other messages unmodified handle_pdu(Data, _Pdu) -> Data. -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37073?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I1d420481cf78c75c2b7a7a3df5ffb1af1ba9aaa0 Gerrit-Change-Number: 37073 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in osmo-s1gw[master]: test/s1ap_proxy_test: minor/cosmetic improvements

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37070?usp=email ) Change subject: test/s1ap_proxy_test: minor/cosmetic improvements ...................................................................... test/s1ap_proxy_test: minor/cosmetic improvements Change-Id: I91650bef356b4010d16de9c708381ef8de14fe85 --- M test/s1ap_proxy_test.erl 1 file changed, 18 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-s1gw refs/changes/70/37070/1 diff --git a/test/s1ap_proxy_test.erl b/test/s1ap_proxy_test.erl index 0c4bbbf..2bc8392 100644 --- a/test/s1ap_proxy_test.erl +++ b/test/s1ap_proxy_test.erl @@ -2,6 +2,9 @@ -include_lib("eunit/include/eunit.hrl"). +-define(EXP_ADDR_STR, "127.0.0.1"). +-define(EXP_ADDR_BIN, << 16#7f, 16#00, 16#00, 16#01 >>). + %% ------------------------------------------------------------------ %% testcases %% ------------------------------------------------------------------ @@ -20,7 +23,7 @@ ?assertEqual(OrigData, s1ap_proxy:handle_pdu(OrigData)). -%% E-RAB SETUP REQUEST +%% [eNB -> MME] E-RAB SETUP REQUEST e_rab_setup_req_pdu(TLA, TEID) when is_binary(TLA), is_binary(TEID) -> << 16#00, 16#05, 16#00, 16#80, 16#9b, 16#00, 16#00, 16#03, @@ -54,14 +57,13 @@ OrigData = e_rab_setup_req_pdu(OrigTLA, TEID), %% Expected output data - ExpTLA = << 16#7f, 16#00, 16#00, 16#01 >>, - ExpData = e_rab_setup_req_pdu(ExpTLA, TEID), + ExpData = e_rab_setup_req_pdu(?EXP_ADDR_BIN, TEID), - application:set_env(osmo_s1gw, mme_loc_addr, "127.0.0.1"), + application:set_env(osmo_s1gw, mme_loc_addr, ?EXP_ADDR_STR), ?assertEqual(ExpData, s1ap_proxy:handle_pdu(OrigData)). -%% E-RAB SETUP RESPONSE +%% [MME -> eNB] E-RAB SETUP RESPONSE e_rab_setup_rsp_pdu(TLA, TEID) when is_binary(TLA), is_binary(TEID) -> << 16#20, 16#05, 16#00, 16#22, 16#00, 16#00, 16#03, 16#00, @@ -79,10 +81,9 @@ OrigData = e_rab_setup_rsp_pdu(OrigTLA, TEID), %% Expected output data - ExpTLA = << 16#7f, 16#00, 16#00, 16#01 >>, - ExpData = e_rab_setup_rsp_pdu(ExpTLA, TEID), + ExpData = e_rab_setup_rsp_pdu(?EXP_ADDR_BIN, TEID), - application:set_env(osmo_s1gw, s1gw_bind_addr, "127.0.0.1"), + application:set_env(osmo_s1gw, s1gw_bind_addr, ?EXP_ADDR_STR), ?assertEqual(ExpData, s1ap_proxy:handle_pdu(OrigData)). %% vim:set ts=4 sw=4 et: -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37070?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I91650bef356b4010d16de9c708381ef8de14fe85 Gerrit-Change-Number: 37070 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024