May 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: osmo-bts-{trx,virtual}: do not advertise TCH/F14.4 NT

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/36709?usp=email ) Change subject: osmo-bts-{trx,virtual}: do not advertise TCH/F14.4 NT ...................................................................... osmo-bts-{trx,virtual}: do not advertise TCH/F14.4 NT This mode is currently not supported. Change-Id: I8a068162400c8efb194f2a169a67ee6ea5f081ca Related: OS#6167 --- M src/osmo-bts-trx/main.c M src/osmo-bts-virtual/main.c 2 files changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/09/36709/1 diff --git a/src/osmo-bts-trx/main.c b/src/osmo-bts-trx/main.c index 9809e6c..ddc4428 100644 --- a/src/osmo-bts-trx/main.c +++ b/src/osmo-bts-trx/main.c @@ -196,8 +196,9 @@ trx->support.chan_modes = NM_IPAC_MASK_CHANM_SPEECH | NM_IPAC_MASK_CHANM_CSD_NT | NM_IPAC_MASK_CHANM_CSD_T; - /* TODO: NM_IPAC_F_CHANM_CSD_T_14k4 (see OS#6167) */ + /* TODO: missing rate adaptation for TCH/F14.4 (see OS#6167) */ trx->support.chan_modes &= ~NM_IPAC_F_CHANM_CSD_T_14k4; + trx->support.chan_modes &= ~NM_IPAC_F_CHANM_CSD_NT_14k4; /* The nominal value for each TRX is later overwritten through VTY cmd * 'nominal-tx-power' if present, otherwise through TRXC cmd NOMTXPOWER. diff --git a/src/osmo-bts-virtual/main.c b/src/osmo-bts-virtual/main.c index 367d923..82becc3 100644 --- a/src/osmo-bts-virtual/main.c +++ b/src/osmo-bts-virtual/main.c @@ -99,8 +99,9 @@ trx->support.chan_modes = NM_IPAC_MASK_CHANM_SPEECH | NM_IPAC_MASK_CHANM_CSD_NT | NM_IPAC_MASK_CHANM_CSD_T; - /* TODO: NM_IPAC_F_CHANM_CSD_T_14k4 (see OS#6167) */ + /* TODO: missing rate adaptation for TCH/F14.4 (see OS#6167) */ trx->support.chan_modes &= ~NM_IPAC_F_CHANM_CSD_T_14k4; + trx->support.chan_modes &= ~NM_IPAC_F_CHANM_CSD_NT_14k4; return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36709?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8a068162400c8efb194f2a169a67ee6ea5f081ca Gerrit-Change-Number: 36709 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-trx[master]: transceiver: use log level cache

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email ) Change subject: transceiver: use log level cache ...................................................................... transceiver: use log level cache This uses the newly added log level caching in libosmocore, which prevents lock contention during the massive amount of usually disabled but concurrent (threads) log statements. Depends: libosmocore.git I539872fc9e3c50b407e6bc388f1e091fa2c826c3 Change-Id: Ic9f0e81c89827f2696ce046a3396f041703d6ae5 --- M TODO-RELEASE M Transceiver52M/osmo-trx.cpp 2 files changed, 16 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index e69de29..1011784 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -0,0 +1 @@ +libosmocore > 1.9.2 requires log_cache_enable call diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index 8f5cc85..c460e98 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -645,6 +645,7 @@ osmo_init_logging2(tall_trx_ctx, &log_info); log_enable_multithread(); + log_cache_enable(); osmo_stats_init(tall_trx_ctx); vty_init(&g_vty_info); logging_vty_add_cmds(); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic9f0e81c89827f2696ce046a3396f041703d6ae5 Gerrit-Change-Number: 36386 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-trx[master]: transceiver: use log level cache

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email ) Change subject: transceiver: use log level cache ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic9f0e81c89827f2696ce046a3396f041703d6ae5 Gerrit-Change-Number: 36386 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 May 2024 11:51:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: jobs/update-osmo-python: remove build3

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36708?usp=email ) Change subject: jobs/update-osmo-python: remove build3 ...................................................................... jobs/update-osmo-python: remove build3 build3 does not exist anymore, but it was still referenced here, leading to the job waiting forever until build3 comes online. Related: OS#6186 Change-Id: Idba77a3b9595c234ee21dfd1d0e267021a17bb03 --- M jobs/update-osmo-python-on-slaves.yml 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/jobs/update-osmo-python-on-slaves.yml b/jobs/update-osmo-python-on-slaves.yml index 0842fba..fad1cf6 100644 --- a/jobs/update-osmo-python-on-slaves.yml +++ b/jobs/update-osmo-python-on-slaves.yml @@ -8,7 +8,6 @@ values: - build2-deb10build-ansible - build2-deb11build-ansible - - build3-deb11build-ansible - build4-deb12build-ansible - host2-deb11build-ansible - rpi4-raspbian11build-ansible-1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idba77a3b9595c234ee21dfd1d0e267021a17bb03 Gerrit-Change-Number: 36708 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: jobs/update-osmo-python: remove build3

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36708?usp=email ) Change subject: jobs/update-osmo-python: remove build3 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idba77a3b9595c234ee21dfd1d0e267021a17bb03 Gerrit-Change-Number: 36708 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 May 2024 11:50:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: jobs/update-osmo-python: remove build3

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36708?usp=email ) Change subject: jobs/update-osmo-python: remove build3 ...................................................................... jobs/update-osmo-python: remove build3 build3 does not exist anymore, but it was still referenced here, leading to the job waiting forever until build3 comes online. Related: OS#6186 Change-Id: Idba77a3b9595c234ee21dfd1d0e267021a17bb03 --- M jobs/update-osmo-python-on-slaves.yml 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/08/36708/1 diff --git a/jobs/update-osmo-python-on-slaves.yml b/jobs/update-osmo-python-on-slaves.yml index 0842fba..fad1cf6 100644 --- a/jobs/update-osmo-python-on-slaves.yml +++ b/jobs/update-osmo-python-on-slaves.yml @@ -8,7 +8,6 @@ values: - build2-deb10build-ansible - build2-deb11build-ansible - - build3-deb11build-ansible - build4-deb12build-ansible - host2-deb11build-ansible - rpi4-raspbian11build-ansible-1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idba77a3b9595c234ee21dfd1d0e267021a17bb03 Gerrit-Change-Number: 36708 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-trx[master]: transceiver: use log level cache

by fixeria

Attention is currently required from: Hoernchen, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email ) Change subject: transceiver: use log level cache ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS1: > Ack Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic9f0e81c89827f2696ce046a3396f041703d6ae5 Gerrit-Change-Number: 36386 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 07 May 2024 08:02:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-trx[master]: transceiver: use log level cache

by Hoernchen

Attention is currently required from: Hoernchen, fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: transceiver: use log level cache ...................................................................... transceiver: use log level cache This uses the newly added log level caching in libosmocore, which prevents lock contention during the massive amount of usually disabled but concurrent (threads) log statements. Depends: libosmocore.git I539872fc9e3c50b407e6bc388f1e091fa2c826c3 Change-Id: Ic9f0e81c89827f2696ce046a3396f041703d6ae5 --- M TODO-RELEASE M Transceiver52M/osmo-trx.cpp 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/86/36386/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic9f0e81c89827f2696ce046a3396f041703d6ae5 Gerrit-Change-Number: 36386 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: drop legacy hack: do not start MGW endp in loopback mode

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36634?usp=email ) Change subject: drop legacy hack: do not start MGW endp in loopback mode ...................................................................... drop legacy hack: do not start MGW endp in loopback mode We used to tell osmo-mgw to create an IuUP endpoint in loopback mode, in order to hack it into responding to an IuUP Initialization. The loopback mode here in osmo-hnbgw is a leftover from that hack. Drop it. Change-Id: I0eca75d7abf66f8b9fde9c68ec10d4265f64a189 --- M TODO-RELEASE M src/osmo-hnbgw/mgw_fsm.c 2 files changed, 18 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index b5a838d..a80e188 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,4 +7,7 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -osmo-iuh >1.5.0 proper decoding of X.213 IPv4 address len=7 \ No newline at end of file +osmo-iuh >1.5.0 proper decoding of X.213 IPv4 address len=7 + +MGW MGCP CRCX osmo-hnbgw used to CRCX in loopback mode, to trigger a legacy IuUP hack. CRCX is no + longer in loopback mode now, so older osmo-mgw may fail to respond to IuUP Initialization. diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index d0dc6df..48b4899 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -175,7 +175,7 @@ mgw_info = (struct mgcp_conn_peer) { .call_id = (map->rua_ctx_id << 8) | mgw_fsm_priv->rab_id, .ptime = 20, - .conn_mode = MGCP_CONN_LOOPBACK, + .conn_mode = MGCP_CONN_RECV_SEND, }; mgw_info.codecs[0] = CODEC_IUFP; mgw_info.codecs_len = 1; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36634?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0eca75d7abf66f8b9fde9c68ec10d4265f64a189 Gerrit-Change-Number: 36634 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the ...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email ) Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground" ...................................................................... Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground" This reverts commit e9c6c7b97ee5b870212c54a08064acbde5670d5d which breaks all of the test cases reliably. I'm surprised how it got submitted in the first place, as it can never have worked. It uses 127.0.0.1:2905 on both the STP and the HNBGW side. Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9 --- M hnbgw/osmo-hnbgw.cfg 1 file changed, 18 insertions(+), 27 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/hnbgw/osmo-hnbgw.cfg b/hnbgw/osmo-hnbgw.cfg index 2ed6905..8a9774b 100644 --- a/hnbgw/osmo-hnbgw.cfg +++ b/hnbgw/osmo-hnbgw.cfg @@ -2,26 +2,18 @@ ! OsmoHNBGW (1.1.0) configuration saved from vty !! ! -log gsmtap 127.0.0.1 - logging level set-all debug - logging filter all 1 -! log stderr logging filter all 1 - logging color 0 - logging print category-hex 0 + logging color 1 + logging print category-hex 1 logging print category 1 - logging print level 1 logging print thread-id 0 logging print extended-timestamp 1 - logging print file basename last + logging print file 1 logging level set-all debug ! line vty no login - bind 0.0.0.0 -ctrl - bind 0.0.0.0 ! stats interval 0 @@ -35,42 +27,30 @@ enable cs7 instance 0 - asp asp-clnt-msc-0 2905 2905 m3ua - local-ip 127.0.0.1 - remote-ip 127.0.0.2 - role asp - sctp-role client point-code 0.23.5 + sccp-address msc-naught - routing-indicator PC point-code 0.23.4 sccp-address msc-one - routing-indicator PC point-code 0.0.2 sccp-address msc-two - routing-indicator PC point-code 0.0.3 sccp-address msc-three - routing-indicator PC point-code 0.0.4 sccp-address sgsn-naught - routing-indicator PC point-code 0.23.1 sccp-address sgsn-one - routing-indicator PC point-code 0.1.2 sccp-address sgsn-two - routing-indicator PC point-code 0.1.3 sccp-address sgsn-three - routing-indicator PC point-code 0.1.4 hnbgw @@ -79,9 +59,6 @@ local-ip 127.0.0.1 local-port 29169 hnbap-allow-tmsi 1 - mgw 0 - mgw local-ip 127.0.0.1 - mgw remote-ip 127.0.0.1 # don't spam RANAP RESET messages for up to eight CN links across all tests timer hnbgw T4 60 # reduce default X31 from 15 seconds -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9 Gerrit-Change-Number: 36619 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024