falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/36712?usp=email )
Change subject: rsl.adoc: mention currently undocumented IEs
......................................................................
rsl.adoc: mention currently undocumented IEs
RSL_IE_OSMO_TEMP_OVP_ACCH_CAP and RSL_IE_OSMO_OSMUX_CID have been
defined for a while now, but are still not documented. Until someone
who knows them can document them properly, we need to at least
acknowledge their existence, and show the IEI code points that
have been allocated to them, so it is clear from the documentation
what IEI code points have already been allocated and where new
extensions are to be added.
Change-Id: I55d7eef946c24cd0e224157d95fdac3243a374ef
---
M doc/manuals/abis/rsl.adoc
1 file changed, 29 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/12/36712/1
diff --git a/doc/manuals/abis/rsl.adoc b/doc/manuals/abis/rsl.adoc
index e627f5c..6e8746a 100644
--- a/doc/manuals/abis/rsl.adoc
+++ b/doc/manuals/abis/rsl.adoc
@@ -867,6 +867,8 @@
| 0x01 | RSL_IE_CHAN_NR | <<RSL_IE_CHAN_NR>>
| 0x60 | RSL_IE_OSMO_REP_ACCH_CAP | <<RSL_IE_OSMO_REP_ACCH_CAP>>
| 0x61 | RSL_IE_OSMO_TRAINING_SEQUENCE | <<RSL_IE_OSMO_TRAINING_SEQUENCE>>
+| 0x62 | RSL_IE_OSMO_TEMP_OVP_ACCH_CAP | <<RSL_IE_OSMO_TEMP_OVP_ACCH_CAP>>
+| 0x63 | RSL_IE_OSMO_OSMUX_CID | <<RSL_IE_OSMO_OSMUX_CID>>
| 0xf0 | RSL_IE_IPAC_REMOTE_IP | <<RSL_IE_IPAC_REMOTE_IP>>
| 0xf1 | RSL_IE_IPAC_REMOTE_PORT | <<RSL_IE_IPAC_REMOTE_PORT>>
| 0xf3 | RSL_IE_IPAC_LOCAL_PORT | <<RSL_IE_IPAC_LOCAL_PORT>>
@@ -1089,6 +1091,16 @@
| 8..255 | reserved values
|===
+[[RSL_IE_OSMO_TEMP_OVP_ACCH_CAP]]
+==== RSL_IE_OSMO_TEMP_OVP_ACCH_CAP
+
+FIXME: this IE has been defined, but remains to be documented.
+
+[[RSL_IE_OSMO_OSMUX_CID]]
+==== RSL_IE_OSMO_OSMUX_CID
+
+FIXME: this IE has been defined, but remains to be documented.
+
[[RSL_IE_IPAC_RTP_CSD_FORMAT]]
==== RSL_IE_IPAC_RTP_CSD_FORMAT
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36712?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I55d7eef946c24cd0e224157d95fdac3243a374ef
Gerrit-Change-Number: 36712
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-MessageType: newchange
Attention is currently required from: pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36706?usp=email )
Change subject: rsl.adoc: document RSL_IE_OSMO_RTP_EXTENSIONS
......................................................................
Patch Set 1:
(2 comments)
File doc/manuals/abis/rsl.adoc:
https://gerrit.osmocom.org/c/osmo-bts/+/36706/comment/8b58b70a_77cfacb1
PS1, Line 872: | 0x62 | RSL_IE_OSMO_TEMP_OVP_ACCH_CAP | <<RSL_IE_OSMO_TEMP_OVP_ACCH_CAP>>
> These 2 above seem to actually be missing but not really related to this patch, so perhaps submit th […]
The current state of the doc covers IEIs up to 0x61, but libosmocore has definitions up to 0x63. I picked 0x64 for my new IE, but attempting to document 0x64 right after 0x61 makes it obvious that the documentation step got skipped for 0x62 and 0x63. But yes, I will split this part off into a separate pre-patch.
https://gerrit.osmocom.org/c/osmo-bts/+/36706/comment/234cb521_8172cf88
PS1, Line 1110: This information element requests the use of non-standard enhanced RTP
> I'm maybe missing some sort of packetdiag output (see for instance packetdiag examples in . […]
About TLV: I am open to changing this IE to TV. For context, please read TW-TS-003:
https://www.freecalypso.org/specs/tw-ts-003-v010001.txt
TW-TS-003 defines one new IE on AoIP BSSMAP interface, and that one is of fixed-length TV format. Now we need to propagate the same signaling from the BSC to the BTS - but for Abis-IP, unlike AoIP, there are no 3GPP specs at all, hence nothing to extend with TW-TS-* specs - instead all Abis-IP definitions have to be worked out in Osmocom only.
For the Osmocom-controlled IE from OsmoBSC to OsmoBTS, my first thought was to make it TV and define it as an exact copy of TW-TS-003 on AoIP. But then I saw that all other Osmocom extension IEs, e.g., RSL_IE_OSMO_OSMUX_CID, are defined as TLV, even though Osmux CID for example is always one byte. Hence I followed suit with my new IE.
Maybe we can now decide if the new IE (that replicates TW-TS-003 on Abis-IP) should be TV or TLV, and then document it accordingly?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36706?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6117049b17ced5fb6635ac70d9238169033af4de
Gerrit-Change-Number: 36706
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 May 2024 17:24:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, jolly, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36711?usp=email )
Change subject: asterisk: Introduce AMI_Adapter_CT
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
FYI, I plan to submit a follow-up patch to this one which changes Telnet_PT to a regular TCP socket for the AMI interface.
This is a step forward towards separating the wire coding from ttcn3 message encoding.
I started using Telnet_PT port since initial use of the interface was done through telnet, but it's not really a telnet interface and stuff starts becoming difficult to maintain properly when events (generated by Asterisk at any time) arrive.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36711?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibf230d2302fecf443f34e1c4d4acfd4802f4cc79
Gerrit-Change-Number: 36711
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 May 2024 15:06:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email )
Change subject: SIP_Emulation: Rename component id
......................................................................
SIP_Emulation: Rename component id
Remove the dash character, since it makes it impossible to reference the
component name under TESTPORT_PARAMETERS in .default/.cfg files.
While at it, actually, allow the test to provide a full id instead of
always appending the suffix to it. This provides more freedom on the
testsuite to provide a fitting component name.
Change-Id: Iecefe7d98a5842872f1efc55e013f672186ef1a8
---
M asterisk/Asterisk_Tests.ttcn
M library/SIP_Emulation.ttcn
M sip/SIP_Tests.ttcn
3 files changed, 19 insertions(+), 5 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
pespin: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn
index b164ee5..caa941c 100644
--- a/asterisk/Asterisk_Tests.ttcn
+++ b/asterisk/Asterisk_Tests.ttcn
@@ -66,7 +66,7 @@
function f_init() runs on test_CT {
f_init_ami();
- f_init_sip(vc_SIP, "Asterisk_Test");
+ f_init_sip(vc_SIP, "Asterisk_Test_SIP_EMU");
log("end of f_init");
}
diff --git a/library/SIP_Emulation.ttcn b/library/SIP_Emulation.ttcn
index 1b357b7..a5ebcfb 100644
--- a/library/SIP_Emulation.ttcn
+++ b/library/SIP_Emulation.ttcn
@@ -226,9 +226,7 @@
SipCreateCallback create_cb
};
-function f_init_sip(inout SIP_Emulation_CT ct, charstring id) {
- id := id & "-SIP";
-
+function f_init_sip(inout SIP_Emulation_CT ct, charstring id := "SIP_EMU") {
var SipOps ops := {
create_cb := refers(SIP_Emulation.ExpectedCreateCallback)
};
diff --git a/sip/SIP_Tests.ttcn b/sip/SIP_Tests.ttcn
index 95f09e8..5899311 100644
--- a/sip/SIP_Tests.ttcn
+++ b/sip/SIP_Tests.ttcn
@@ -131,7 +131,7 @@
//f_ipa_ctrl_start_client(mp_osmosip_host, mp_osmosip_port_ctrl);
f_init_mncc("SIP_Test");
log("end of f_init_mncc");
- f_init_sip(vc_SIP, "SIP_Test");
+ f_init_sip(vc_SIP, "SIP_Test_SIP_EMU");
log("end of f_init_sip");
map(self:SIPVTY, system:SIPVTY);
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iecefe7d98a5842872f1efc55e013f672186ef1a8
Gerrit-Change-Number: 36641
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/36702?usp=email )
Change subject: VTY: sync default UMTS UEA config with osmo-msc
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
so iiuc this patch is actually enabling EUA1 and EUA2 and removing EUA2 when default config is used?
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/36702?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I4eb9451b4267fc1436ed90a55ff200cf36f16bf6
Gerrit-Change-Number: 36702
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 May 2024 14:43:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment