April 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the ...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email ) Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground" ...................................................................... Patch Set 1: (1 comment) File hnbgw/osmo-hnbgw.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619/comment/e7de9d1c_79f0… PS1, Line 38: asp asp-clnt-msc-0 2905 2905 m3ua > I tried for >= 10 minutes in several iterations to adjust osmo-stp config to get it to work with you […] To make it clear: This patch slowed me down significantly in working on tests for new customer-relevant features. I introduced significant changes in the HNBGW test suite, and everything broke. Of course I was assuming that my test suite changes have broken things. and after loooong debugging, I discovered that an untested config change was merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9 Gerrit-Change-Number: 36619 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Apr 2024 11:01:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the ...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email ) Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground" ...................................................................... Patch Set 1: (1 comment) File hnbgw/osmo-hnbgw.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619/comment/9758ec6f_36b7… PS1, Line 38: asp asp-clnt-msc-0 2905 2905 m3ua > That was my fault, I wrongly assumed the osmo-stp was listneing on 127.0.0.2 only. […] I tried for >= 10 minutes in several iterations to adjust osmo-stp config to get it to work with your change here, but failed to. I'm not arguing against the goal of this patch. I'm arguing for reverting what seems an untested patch that causes regressions. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9 Gerrit-Change-Number: 36619 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Apr 2024 10:59:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: Allow API users to enable/disable SSL

by dexter

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: Allow API users to enable/disable SSL ...................................................................... HTTP_Adapter: Allow API users to enable/disable SSL At the moment HTTP_Adapter has no option to enable SSL Related: SYS#6824 Change-Id: I6487deea50cd9b4ed4905d9a3a78e00def8ea319 --- M library/HTTP_Adapter.ttcn 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/36506/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36506?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6487deea50cd9b4ed4905d9a3a78e00def8ea319 Gerrit-Change-Number: 36506 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the ...

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email ) Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground" ...................................................................... Patch Set 1: (1 comment) File hnbgw/osmo-hnbgw.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619/comment/6089fd75_f6dc… PS1, Line 38: asp asp-clnt-msc-0 2905 2905 m3ua That was my fault, I wrongly assumed the osmo-stp was listneing on 127.0.0.2 only. Still I think it makes sense to simply fix the local port in here to 0 or alike, since the other config changes are useful and updating from old setups where syntax was deprecated or expected to provide explicit config. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9 Gerrit-Change-Number: 36619 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Apr 2024 10:35:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: put HTTP config options into a record

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: put HTTP config options into a record ...................................................................... HTTP_Adapter: put HTTP config options into a record The function f_http_init currently takes only two config options. For the moment this is not a problem, but the amount of additional options may grow in the future. So let's put the options in a record to have them separate. Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d Related: SYS#6824 --- M cbc/CBC_Tests.ttcn M library/HTTP_Adapter.ttcn M remsim/RemsimServer_Tests.ttcn 3 files changed, 36 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/36603/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d Gerrit-Change-Number: 36603 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the ...

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email ) Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground" ...................................................................... Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground" This reverts commit e9c6c7b97ee5b870212c54a08064acbde5670d5d which breaks all of the test cases reliably. I'm surprised how it got submitted in the first place, as it can never have worked. It uses 127.0.0.1:2905 on both the STP and the HNBGW side. Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9 --- M hnbgw/osmo-hnbgw.cfg 1 file changed, 18 insertions(+), 27 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/36619/1 diff --git a/hnbgw/osmo-hnbgw.cfg b/hnbgw/osmo-hnbgw.cfg index 2ed6905..8a9774b 100644 --- a/hnbgw/osmo-hnbgw.cfg +++ b/hnbgw/osmo-hnbgw.cfg @@ -2,26 +2,18 @@ ! OsmoHNBGW (1.1.0) configuration saved from vty !! ! -log gsmtap 127.0.0.1 - logging level set-all debug - logging filter all 1 -! log stderr logging filter all 1 - logging color 0 - logging print category-hex 0 + logging color 1 + logging print category-hex 1 logging print category 1 - logging print level 1 logging print thread-id 0 logging print extended-timestamp 1 - logging print file basename last + logging print file 1 logging level set-all debug ! line vty no login - bind 0.0.0.0 -ctrl - bind 0.0.0.0 ! stats interval 0 @@ -35,42 +27,30 @@ enable cs7 instance 0 - asp asp-clnt-msc-0 2905 2905 m3ua - local-ip 127.0.0.1 - remote-ip 127.0.0.2 - role asp - sctp-role client point-code 0.23.5 + sccp-address msc-naught - routing-indicator PC point-code 0.23.4 sccp-address msc-one - routing-indicator PC point-code 0.0.2 sccp-address msc-two - routing-indicator PC point-code 0.0.3 sccp-address msc-three - routing-indicator PC point-code 0.0.4 sccp-address sgsn-naught - routing-indicator PC point-code 0.23.1 sccp-address sgsn-one - routing-indicator PC point-code 0.1.2 sccp-address sgsn-two - routing-indicator PC point-code 0.1.3 sccp-address sgsn-three - routing-indicator PC point-code 0.1.4 hnbgw @@ -79,9 +59,6 @@ local-ip 127.0.0.1 local-port 29169 hnbap-allow-tmsi 1 - mgw 0 - mgw local-ip 127.0.0.1 - mgw remote-ip 127.0.0.1 # don't spam RANAP RESET messages for up to eight CN links across all tests timer hnbgw T4 60 # reduce default X31 from 15 seconds -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9 Gerrit-Change-Number: 36619 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: RUA_Emulation: Support decode of L3/DTAP inside RANAP

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36620?usp=email ) Change subject: RUA_Emulation: Support decode of L3/DTAP inside RANAP ...................................................................... RUA_Emulation: Support decode of L3/DTAP inside RANAP ... similar to what we support in the RAN_Emulation module. Change-Id: Id934e73ace7d0a0eb7242a8fa926b7eabe0c7770 --- M hnbgw/HNBGW_Tests.ttcn M library/RAN_Emulation.ttcnpp M library/rua/RUA_Emulation.ttcn 3 files changed, 127 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/36620/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 3369e37..a53187a 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -499,7 +499,9 @@ /* RUA/RANAP emulation on top of lower-layer Iuh */ var RuaOps rua_ops := { create_cb := refers(IuhRanapCreateCallback), - unitdata_cb := refers(IuhRanapUnitdataCallback) + unitdata_cb := refers(IuhRanapUnitdataCallback), + decode_dtap := false, + role_ms := true }; for (var integer i := 0; i < g_num_hnbs; i := i+1) { g_hnb_cfg[i] := { diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp index fbe921d..25c6a49 100644 --- a/library/RAN_Emulation.ttcnpp +++ b/library/RAN_Emulation.ttcnpp @@ -62,6 +62,8 @@ import from RANAP_Templates all; #endif +friend module RUA_Emulation; + /* General "base class" component definition, of which specific implementations * derive themselves by means of the "extends" feature */ type component RAN_ConnHdlr { @@ -580,7 +582,7 @@ ranap := ranap }; -private function fake_dlci_from_sapi(template (omit) SAPI sapi) return template (omit) OCT1 +friend function fake_dlci_from_sapi(template (omit) SAPI sapi) return template (omit) OCT1 { if (istemplatekind(sapi, "omit")) { return omit; diff --git a/library/rua/RUA_Emulation.ttcn b/library/rua/RUA_Emulation.ttcn index a9c445e..4560ad2 100644 --- a/library/rua/RUA_Emulation.ttcn +++ b/library/rua/RUA_Emulation.ttcn @@ -17,7 +17,7 @@ * If a pre-existing component wants to register to handle future inbound connection, * it can do so by registering an "expect" with the expected RANAP payload. - * (C) 2022 by Harald Welte <laforge(a)gnumonks.org> + * (C) 2022-2024 by Harald Welte <laforge(a)gnumonks.org> * All rights reserved. * * Released under the terms of GNU General Public License, Version 2 or @@ -26,8 +26,10 @@ import from General_Types all; import from Osmocom_Types all; +import from MobileL3_Types all; import from Iuh_Emulation all; +import from RAN_Emulation all; // for PDU_DTAP_MO / PDU_DTAP_MT import from RUA_Templates all; //import from RUA_Constants all; @@ -54,6 +56,8 @@ /* port between individual per-connection components and this dispatcher */ type port RUA_Conn_PT message { inout RANAP_PDU, + PDU_DTAP_MO, PDU_DTAP_MT, + PDU_DTAP_PS_MO, PDU_DTAP_PS_MT, RUA_Conn_Req, RUA_Disc_Req, RUA_Disc_Ind; @@ -113,9 +117,9 @@ type record RuaOps { RanapCreateCallback create_cb optional, - RanapUnitdataCallback unitdata_cb optional - //boolean deode_dtap - //boolean role_ms + RanapUnitdataCallback unitdata_cb optional, + boolean decode_dtap, + boolean role_ms }; private function f_context_id_known(ContextId context_id) @@ -240,10 +244,56 @@ return g_rua_ops.unitdata_cb.apply(ranap); } -private function f_handle_userData_RANAP(RUA_ConnHdlr client, RANAP_PDU ranap) +private function f_handle_userData_RANAP(RUA_ConnHdlr client, RUA_IEs.CN_DomainIndicator domain_ind, RANAP_PDU ranap) runs on RUA_Emulation_CT { - /* TODO: L3 decoding, if requested */ - CLIENT.send(ranap) to client; + var template (omit) octetstring l3 := f_ranap_extract_l3(ranap); + if (istemplatekind(l3, "omit") or not g_rua_ops.decode_dtap) { + CLIENT.send(ranap) to client; + } else { + var template (omit) SAPI sapi := f_ranap_extract_sapi(ranap); + var template (omit) OCT1 dlci := fake_dlci_from_sapi(sapi); + if (g_rua_ops.role_ms) { + if (domain_ind == ps_domain) { + var PDU_DTAP_PS_MT mt := { + dlci := omit, + dtap := dec_PDU_L3_SGSN_MS(valueof(l3)) + }; + if (isvalue(dlci)) { + mt.dlci := valueof(dlci); + } + CLIENT.send(mt) to client; + } else { + var PDU_DTAP_MT mt := { + dlci := omit, + dtap := dec_PDU_ML3_NW_MS(valueof(l3)) + }; + if (isvalue(dlci)) { + mt.dlci := valueof(dlci); + } + CLIENT.send(mt) to client; + } + } else { + if (domain_ind == ps_domain) { + var PDU_DTAP_PS_MO mo := { + dlci := omit, + dtap := dec_PDU_L3_MS_SGSN(valueof(l3)) + }; + if (isvalue(dlci)) { + mo.dlci := valueof(dlci); + } + CLIENT.send(mo) to client; + } else { + var PDU_DTAP_MO mo := { + dlci := omit, + dtap := dec_PDU_ML3_MS_NW(valueof(l3)) + }; + if (isvalue(dlci)) { + mo.dlci := valueof(dlci); + } + CLIENT.send(mo) to client; + } + } + } } @@ -289,26 +339,28 @@ f_conn_table_add(vc_conn, domain_ind, context_id); /* TODO: notify user about incoming connection? */ /* handle user payload */ - f_handle_userData_RANAP(vc_conn, ranap); + f_handle_userData_RANAP(vc_conn, domain_ind, ranap); } /* RUA -> Client: connection-oriented data in existing connection */ [] RUA.receive(tr_RUA_DirectTransfer) -> value rua { + domain_ind := rua.initiatingMessage.value_.directTransfer.protocolIEs[0].value_.cN_DomainIndicator; context_id := rua.initiatingMessage.value_.directTransfer.protocolIEs[1].value_.context_ID; vc_conn := f_comp_by_context_id(context_id); ranap_enc := rua.initiatingMessage.value_.directTransfer.protocolIEs[2].value_.rANAP_Message; - f_handle_userData_RANAP(vc_conn, dec_RANAP_PDU(ranap_enc)); + f_handle_userData_RANAP(vc_conn, domain_ind, dec_RANAP_PDU(ranap_enc)); } /* RUA -> Client: disconnect of an existing connection */ [] RUA.receive(tr_RUA_Disconnect_opt_ranap) -> value rua { + domain_ind := rua.initiatingMessage.value_.disconnect_.protocolIEs[0].value_.cN_DomainIndicator; cause := rua.initiatingMessage.value_.disconnect_.protocolIEs[2].value_.cause; context_id := rua.initiatingMessage.value_.disconnect_.protocolIEs[1].value_.context_ID; vc_conn := f_comp_by_context_id(context_id); /* send contained RANAP message to user */ if (lengthof(rua.initiatingMessage.value_.disconnect_.protocolIEs) > 3) { ranap_enc := rua.initiatingMessage.value_.disconnect_.protocolIEs[3].value_.rANAP_Message; - f_handle_userData_RANAP(vc_conn, dec_RANAP_PDU(ranap_enc)); + f_handle_userData_RANAP(vc_conn, domain_ind, dec_RANAP_PDU(ranap_enc)); } /* notify user of disconnect */ if (CLIENT.checkstate("Connected")) { @@ -380,6 +432,20 @@ } } +private function f_xmit_raw_l3(RUA_IEs.CN_DomainIndicator domain_ind, integer context_id, OCT1 dlci, octetstring l3_enc) runs on RUA_Emulation_CT +{ + var template (omit) RANAP_IEs.SAPI sapi := omit; + var RANAP_PDU ranap; + + if (dlci and4b '07'O == '03'O) { + sapi := sapi_3; + } + + ranap := valueof(ts_RANAP_DirectTransfer(l3_enc, sapi := sapi)); + RUA.send(ts_RUA_DirectTransfer(domain_ind, int2bit(context_id, 24), enc_RANAP_PDU(ranap))); +} + + function main(RuaOps ops, charstring id) runs on RUA_Emulation_CT { g_rua_id := id; g_rua_ops := ops; @@ -387,9 +453,43 @@ //f_expect_table_init(); while (true) { + var RUA_ConnHdlr vc_conn; + var PDU_DTAP_MO dtap_mo; + var PDU_DTAP_MT dtap_mt; + var PDU_DTAP_PS_MO dtap_mo_ps; + var PDU_DTAP_PS_MT dtap_mt_ps; + alt { [] as_main_rua(); + [g_rua_ops.role_ms] CLIENT.receive(PDU_DTAP_MO:?) -> value dtap_mo sender vc_conn { + var integer idx := f_idx_by_comp(vc_conn); + /* convert from decoded DTAP to encoded DTAP */ + var octetstring l3_enc := enc_PDU_ML3_MS_NW(dtap_mo.dtap); + /* TODO: patch correct L3 send sequence number N(SD) into l3_enc */ + f_xmit_raw_l3(ConnectionTable[idx].domain, ConnectionTable[idx].context_id, dtap_mo.dlci, l3_enc); + } + + [not g_rua_ops.role_ms] CLIENT.receive(PDU_DTAP_MT:?) -> value dtap_mt sender vc_conn { + var integer idx := f_idx_by_comp(vc_conn); + /* convert from decoded DTAP to encoded DTAP */ + var octetstring l3_enc := enc_PDU_ML3_NW_MS(dtap_mt.dtap); + f_xmit_raw_l3(ConnectionTable[idx].domain, ConnectionTable[idx].context_id, dtap_mo.dlci, l3_enc); + } + + [g_rua_ops.role_ms] CLIENT.receive(PDU_DTAP_PS_MO:?) -> value dtap_mo_ps sender vc_conn { + var integer idx := f_idx_by_comp(vc_conn); + var octetstring l3_enc := enc_PDU_L3_MS_SGSN(dtap_mo_ps.dtap); + /* TODO: patch correct L3 send sequence number N(SD) into l3_enc */ + f_xmit_raw_l3(ConnectionTable[idx].domain, ConnectionTable[idx].context_id, dtap_mo_ps.dlci, l3_enc); + } + + [not g_rua_ops.role_ms] CLIENT.receive(PDU_DTAP_PS_MT:?) -> value dtap_mt_ps sender vc_conn { + var integer idx := f_idx_by_comp(vc_conn); + var octetstring l3_enc := enc_PDU_L3_SGSN_MS(dtap_mt_ps.dtap); + f_xmit_raw_l3(ConnectionTable[idx].domain, ConnectionTable[idx].context_id, dtap_mt_ps.dlci, l3_enc); + } + /* [] PROC.getcall(RUA_Register:{?,?}) -> param(l3_info, vc_hdlr) { f_create_expect(l3_info, vc_hdlr); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36620?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id934e73ace7d0a0eb7242a8fa926b7eabe0c7770 Gerrit-Change-Number: 36620 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: fixup: sgsn: fix unused param in f_routing_area_update()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36613?usp=email ) Change subject: fixup: sgsn: fix unused param in f_routing_area_update() ...................................................................... fixup: sgsn: fix unused param in f_routing_area_update() In 1ee1edd2 I changed f_routing_area_update() to actually use the given RAI as Old RAI in the Routing Area Update Request. Not only this broke the testcase scenario (Old RAI shall remain unchanged!), but also started triggering a use-after-free bug in osmo-sgsn. Passing 'ran_index := 1' is enough for the second Routing Area Update Request to show up with a different RAI (at BSSGP level), however the Old RAI IE shall obviously indicate the *old* RAI, not the new one. A follow-up commit will add a separate testcase to reproduce the use-after-free problem in osmo-sgsn. Change-Id: Ib16985cb08834a238ca4f7a747c43097f430ed6f Fixes: 1ee1edd2 "sgsn: fix unused param in f_routing_area_update()" Related: OS#6439 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 24 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 67e815b..0371e29 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -2734,7 +2734,7 @@ f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[1]); log("sending second RAU via different RA"); - f_routing_area_update(f_cellid_to_RAI(g_pars.bssgp_cell_id[1]), ran_index := 1); + f_routing_area_update(old_ra := g_pars.ra, ran_index := 1); f_detach_mo(c_GMM_DTT_MO_GPRS, true, true, 1); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36613?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib16985cb08834a238ca4f7a747c43097f430ed6f Gerrit-Change-Number: 36613 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: fixup: sgsn: fix unused param in f_routing_area_update()

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36613?usp=email ) Change subject: fixup: sgsn: fix unused param in f_routing_area_update() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Merging myself to fix ttcn3-sgsn-test on Jenkins. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36613?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib16985cb08834a238ca4f7a747c43097f430ed6f Gerrit-Change-Number: 36613 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Apr 2024 09:52:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: put HTTP config options into a record

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: HTTP_Adapter: put HTTP config options into a record ...................................................................... HTTP_Adapter: put HTTP config options into a record The function f_http_init currently takes only two config options. For the moment this is not a problem, but the amount of additional options may grow in the future. So let's put the options in a record to have them separate. Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d Related: SYS#6824 --- M cbc/CBC_Tests.ttcn M library/HTTP_Adapter.ttcn M remsim/RemsimServer_Tests.ttcn 3 files changed, 34 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/36603/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4c1c204ea38d76d5fdd7e539d56ca2bf9f693d7d Gerrit-Change-Number: 36603 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2024