April 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: vty: fix 'write file FILE' breaking 'show startup-config'

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36617?usp=email ) Change subject: vty: fix 'write file FILE' breaking 'show startup-config' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36617?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I224ae41096c12f544dfe35a2c3f381b3bb3ba75e Gerrit-Change-Number: 36617 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Apr 2024 09:11:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in libosmocore[master]: vty: fix memleak in host_config_set()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36616?usp=email ) Change subject: vty: fix memleak in host_config_set() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36616?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I356818aae3addab6db39de9a625453b7435b7cc1 Gerrit-Change-Number: 36616 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Apr 2024 09:10:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in libosmocore[master]: tests: rename logging_test_gsmtap -> logging_gsmtap_test

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email ) Change subject: tests: rename logging_test_gsmtap -> logging_gsmtap_test ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I280fc0cc1bda9ba445af71f00bc8f1ccfd2b2091 Gerrit-Change-Number: 36615 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Apr 2024 09:09:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in libosmocore[master]: tests: do not copy *.cfg files to the build directory

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36614?usp=email ) Change subject: tests: do not copy *.cfg files to the build directory ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36614?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I74e428f0548418fdecada3d25049d6e110e790fe Gerrit-Change-Number: 36614 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Apr 2024 09:03:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[M] Change in meta-telephony[201705]: Remove User= and Group= from systemd service files

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email ) Change subject: Remove User= and Group= from systemd service files ...................................................................... Patch Set 2: Verified+1 (1 comment) Patchset: PS2: did a test build on deb8-oe-userbuilds -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I68a8fba034aeb0e2923b2958b8d6842410d8b23c Gerrit-Change-Number: 36618 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Apr 2024 08:48:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[M] Change in meta-telephony[201705]: Remove User= and Group= from systemd service files

by osmith

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email ) Change subject: Remove User= and Group= from systemd service files ...................................................................... Remove User= and Group= from systemd service files Service files of Osmocom programs will have User= and Group= in the future, so these don't run as root. It was decided that for OE-based systems, we will still run them as root for now. Related: OS#5684, OS#4107 Change-Id: I68a8fba034aeb0e2923b2958b8d6842410d8b23c --- M recipes-osmocom/libosmo-sccp/libosmo-sccp.inc M recipes-osmocom/osmo-bsc/osmo-bsc.inc M recipes-osmocom/osmo-gbproxy/osmo-gbproxy.inc M recipes-osmocom/osmo-ggsn/osmo-ggsn.inc M recipes-osmocom/osmo-hlr/osmo-hlr.inc M recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc M recipes-osmocom/osmo-mgw/osmo-mgw.inc M recipes-osmocom/osmo-msc/osmo-msc.inc M recipes-osmocom/osmo-pcap/osmo-pcap.inc M recipes-osmocom/osmo-sgsn/osmo-sgsn.inc M recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc 11 files changed, 83 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/18/36618/2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I68a8fba034aeb0e2923b2958b8d6842410d8b23c Gerrit-Change-Number: 36618 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

[M] Change in meta-telephony[201705]: Remove User= and Group= from systemd service files

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email ) Change subject: Remove User= and Group= from systemd service files ...................................................................... Remove User= and Group= from systemd service files Service files of Osmocom programs will have User= and Group= in the future, so these don't run as root. It was decided that for OE-based systems, we will still run them as root for now. Related: OS#5684, OS#4107 Change-Id: I68a8fba034aeb0e2923b2958b8d6842410d8b23c --- M recipes-osmocom/libosmo-sccp/libosmo-sccp.inc M recipes-osmocom/osmo-bsc/osmo-bsc.inc M recipes-osmocom/osmo-gbproxy/osmo-gbproxy.inc M recipes-osmocom/osmo-ggsn/osmo-ggsn.inc M recipes-osmocom/osmo-hlr/osmo-hlr.inc M recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc M recipes-osmocom/osmo-mgw/osmo-mgw.inc M recipes-osmocom/osmo-msc/osmo-msc.inc M recipes-osmocom/osmo-pcap/osmo-pcap.inc M recipes-osmocom/osmo-sgsn/osmo-sgsn.inc M recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc 11 files changed, 81 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/18/36618/1 diff --git a/recipes-osmocom/libosmo-sccp/libosmo-sccp.inc b/recipes-osmocom/libosmo-sccp/libosmo-sccp.inc index 0f1f28d..34454b1 100644 --- a/recipes-osmocom/libosmo-sccp/libosmo-sccp.inc +++ b/recipes-osmocom/libosmo-sccp/libosmo-sccp.inc @@ -3,7 +3,7 @@ HOMEPAGE = "https://osmocom.org/projects/libosmo-sccp" LICENSE = "AGPLv3" -INC_PR="r2.${META_TELEPHONY_OSMO_INC}" +INC_PR="r3.${META_TELEPHONY_OSMO_INC}" LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe" @@ -18,10 +18,14 @@ # access symbols not starting with osmo_* EXTRA_OECONF_remove = "--disable-static" -# StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): do_install_append() { + # StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): sed -i '/^StateDirectory=/d' "${D}${systemd_system_unitdir}/osmo-stp.service" sed -i '/^WorkingDirectory=/d' "${D}${systemd_system_unitdir}/osmo-stp.service" + + # Run as root (OS#5684): + sed -i '/^User=/d' "${D}${systemd_system_unitdir}/osmo-stp.service" + sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/osmo-stp.service" } PACKAGES =+ "osmo-stp" diff --git a/recipes-osmocom/osmo-bsc/osmo-bsc.inc b/recipes-osmocom/osmo-bsc/osmo-bsc.inc index 50e8f9b..1c56123 100644 --- a/recipes-osmocom/osmo-bsc/osmo-bsc.inc +++ b/recipes-osmocom/osmo-bsc/osmo-bsc.inc @@ -5,7 +5,7 @@ DEPENDS = "sqlite3 libpcap libosmocore libosmo-abis libosmo-sccp libosmo-netif osmo-mgw" -INC_PR="r2.${META_TELEPHONY_OSMO_INC}" +INC_PR="r3.${META_TELEPHONY_OSMO_INC}" inherit autotools pkgconfig systemd @@ -14,10 +14,14 @@ " PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir" -# StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): do_install_append() { + # StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): sed -i '/^StateDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" sed -i '/^WorkingDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" + + # Run as root (OS#5684): + sed -i '/^User=/d' "${D}${systemd_system_unitdir}/${PN}.service" + sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/${PN}.service" } PACKAGES =+ "meas-utils ipaccess-utils bs11-utils abisip-find" diff --git a/recipes-osmocom/osmo-gbproxy/osmo-gbproxy.inc b/recipes-osmocom/osmo-gbproxy/osmo-gbproxy.inc index aff20fa..6c87dda 100644 --- a/recipes-osmocom/osmo-gbproxy/osmo-gbproxy.inc +++ b/recipes-osmocom/osmo-gbproxy/osmo-gbproxy.inc @@ -5,7 +5,7 @@ DEPENDS = "libosmocore" -INC_PR="r1.${META_TELEPHONY_OSMO_INC}" +INC_PR="r2.${META_TELEPHONY_OSMO_INC}" inherit autotools pkgconfig systemd @@ -14,10 +14,14 @@ " PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir" -# StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): do_install_append() { + # StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): sed -i '/^StateDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" sed -i '/^WorkingDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" + + # Run as root (OS#5684): + sed -i '/^User=/d' "${D}${systemd_system_unitdir}/${PN}.service" + sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/${PN}.service" } SYSTEMD_SERVICE_osmo-gbproxy = "osmo-gbproxy.service" diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc b/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc index 58b93f0..276ac47 100644 --- a/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc +++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn.inc @@ -5,7 +5,7 @@ DEPENDS = "libosmocore" -INC_PR="r3.${META_TELEPHONY_OSMO_INC}" +INC_PR="r4.${META_TELEPHONY_OSMO_INC}" inherit autotools pkgconfig systemd @@ -14,10 +14,14 @@ " PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir" -# StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): do_install_append() { + # StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): sed -i '/^StateDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" sed -i '/^WorkingDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" + + # Run as root (OS#5684): + sed -i '/^User=/d' "${D}${systemd_system_unitdir}/${PN}.service" + sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/${PN}.service" } PACKAGES =+ " libgtp libgtp-dev libgtp-staticdev osmo-sgsnemu" diff --git a/recipes-osmocom/osmo-hlr/osmo-hlr.inc b/recipes-osmocom/osmo-hlr/osmo-hlr.inc index 4229e7b..77b1c94 100644 --- a/recipes-osmocom/osmo-hlr/osmo-hlr.inc +++ b/recipes-osmocom/osmo-hlr/osmo-hlr.inc @@ -5,7 +5,7 @@ DEPENDS = "libtalloc libosmocore libosmo-abis sqlite3 sqlite3-native" -INC_PR="r3.${META_TELEPHONY_OSMO_INC}" +INC_PR="r4.${META_TELEPHONY_OSMO_INC}" inherit autotools pkgconfig systemd @@ -21,6 +21,10 @@ # StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): sed -i '/^StateDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" sed -i '/^WorkingDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" + + # Run as root (OS#5684): + sed -i '/^User=/d' "${D}${systemd_system_unitdir}/${PN}.service" + sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/${PN}.service" } PACKAGECONFIG ??= "\ diff --git a/recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc b/recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc index 6bf01d3..c83ce12 100644 --- a/recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc +++ b/recipes-osmocom/osmo-hnbgw/osmo-hnbgw.inc @@ -5,7 +5,7 @@ DEPENDS = "libosmocore libosmo-netif libosmo-sccp osmo-iuh libasn1c lksctp-tools osmo-mgw" -INC_PR="r1.${META_TELEPHONY_OSMO_INC}" +INC_PR="r2.${META_TELEPHONY_OSMO_INC}" # Workaround to oe-core meta/site/* CONFIG_SITE files passed to autoconf forcing unavailability of netinet/sctp.h. # Patch fixing issue upstream: https://patchwork.openembedded.org/patch/168892/ @@ -19,8 +19,13 @@ PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir" do_install_append() { + # StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): sed -i '/^StateDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" sed -i '/^WorkingDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" + + # Run as root (OS#5684): + sed -i '/^User=/d' "${D}${systemd_system_unitdir}/${PN}.service" + sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/${PN}.service" } SYSTEMD_SERVICE_${PN} = "${PN}.service" diff --git a/recipes-osmocom/osmo-mgw/osmo-mgw.inc b/recipes-osmocom/osmo-mgw/osmo-mgw.inc index a9a60b4..5e740db 100644 --- a/recipes-osmocom/osmo-mgw/osmo-mgw.inc +++ b/recipes-osmocom/osmo-mgw/osmo-mgw.inc @@ -5,7 +5,7 @@ DEPENDS = "libosmocore libosmo-netif" -INC_PR="r3.${META_TELEPHONY_OSMO_INC}" +INC_PR="r4.${META_TELEPHONY_OSMO_INC}" inherit autotools pkgconfig systemd @@ -14,10 +14,14 @@ " PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir" -# StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): do_install_append() { + # StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): sed -i '/^StateDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" sed -i '/^WorkingDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" + + # Run as root (OS#5684): + sed -i '/^User=/d' "${D}${systemd_system_unitdir}/${PN}.service" + sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/${PN}.service" } PACKAGES =+ "libosmo-mgcp libosmo-mgcp-dev libosmo-mgcp-client libosmo-mgcp-client-dev" diff --git a/recipes-osmocom/osmo-msc/osmo-msc.inc b/recipes-osmocom/osmo-msc/osmo-msc.inc index c60fd07..23a762a 100644 --- a/recipes-osmocom/osmo-msc/osmo-msc.inc +++ b/recipes-osmocom/osmo-msc/osmo-msc.inc @@ -5,7 +5,7 @@ DEPENDS = "libdbi libosmocore libosmo-abis libosmo-sccp libosmo-netif osmo-mgw osmo-hlr" -INC_PR="r3.${META_TELEPHONY_OSMO_INC}" +INC_PR="r4.${META_TELEPHONY_OSMO_INC}" inherit autotools pkgconfig systemd @@ -18,10 +18,14 @@ PACKAGECONFIG[iu] = "--enable-iu,--disable-iu,libasn1c osmo-iuh," PACKAGECONFIG[smpp] = "--enable-smpp,--disable-smpp,libsmpp34," -# StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): do_install_append() { + # StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): sed -i '/^StateDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" sed -i '/^WorkingDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" + + # Run as root (OS#5684): + sed -i '/^User=/d' "${D}${systemd_system_unitdir}/${PN}.service" + sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/${PN}.service" } RDEPENDS_${PN} = "libdbd-sqlite3" diff --git a/recipes-osmocom/osmo-pcap/osmo-pcap.inc b/recipes-osmocom/osmo-pcap/osmo-pcap.inc index 3f39103..e64ca88 100644 --- a/recipes-osmocom/osmo-pcap/osmo-pcap.inc +++ b/recipes-osmocom/osmo-pcap/osmo-pcap.inc @@ -5,7 +5,7 @@ DEPENDS = "libosmocore zeromq libpcap gnutls" -INC_PR="r1.${META_TELEPHONY_OSMO_INC}" +INC_PR="r2.${META_TELEPHONY_OSMO_INC}" inherit autotools pkgconfig systemd @@ -14,12 +14,18 @@ " PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir" -# StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): do_install_append() { + # StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): sed -i '/^StateDirectory=/d' "${D}${systemd_system_unitdir}/osmo-pcap-server.service" sed -i '/^WorkingDirectory=/d' "${D}${systemd_system_unitdir}/osmo-pcap-server.service" sed -i '/^StateDirectory=/d' "${D}${systemd_system_unitdir}/osmo-pcap-client.service" sed -i '/^WorkingDirectory=/d' "${D}${systemd_system_unitdir}/osmo-pcap-client.service" + + # Run as root (OS#5684): + sed -i '/^User=/d' "${D}${systemd_system_unitdir}/osmo-pcap-server.service" + sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/osmo-pcap-server.service" + sed -i '/^User=/d' "${D}${systemd_system_unitdir}/osmo-pcap-client.service" + sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/osmo-pcap-client.service" } PACKAGES =+ "osmo-pcap-server osmo-pcap-client" diff --git a/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc b/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc index 9463047..10fe745 100644 --- a/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc +++ b/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc @@ -16,12 +16,18 @@ PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir" PACKAGECONFIG[iu] = "--enable-iu,--disable-iu,libasn1c libosmo-sccp osmo-iuh," -# StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): do_install_append() { + # StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): sed -i '/^StateDirectory=/d' "${D}${systemd_system_unitdir}/osmo-sgsn.service" sed -i '/^WorkingDirectory=/d' "${D}${systemd_system_unitdir}/osmo-sgsn.service" sed -i '/^StateDirectory=/d' "${D}${systemd_system_unitdir}/osmo-gtphub.service" sed -i '/^WorkingDirectory=/d' "${D}${systemd_system_unitdir}/osmo-gtphub.service" + + # Run as root (OS#5684): + sed -i '/^User=/d' "${D}${systemd_system_unitdir}/osmo-sgsn.service" + sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/osmo-sgsn.service" + sed -i '/^User=/d' "${D}${systemd_system_unitdir}/osmo-gtphub.service" + sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/osmo-gtphub.service" } PACKAGES =+ "osmo-gtphub-doc osmo-gtphub" diff --git a/recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc b/recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc index 7aabf20..7c473b3 100644 --- a/recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc +++ b/recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc @@ -14,10 +14,14 @@ " PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir" -# StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): do_install_append() { + # StateDirectory requires systemd >= v235, but poky pyro ships with v232 (SYS#6340): sed -i '/^StateDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" sed -i '/^WorkingDirectory=/d' "${D}${systemd_system_unitdir}/${PN}.service" + + # Run as root (OS#5684): + sed -i '/^User=/d' "${D}${systemd_system_unitdir}/${PN}.service" + sed -i '/^Group=/d' "${D}${systemd_system_unitdir}/${PN}.service" } SYSTEMD_SERVICE_${PN} = "${PN}.service" -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/36618?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I68a8fba034aeb0e2923b2958b8d6842410d8b23c Gerrit-Change-Number: 36618 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match PDP Context IE

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Apr 2024 06:01:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in libosmocore[master]: vty: fix 'write file FILE' breaking 'show startup-config'

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/36617?usp=email ) Change subject: vty: fix 'write file FILE' breaking 'show startup-config' ...................................................................... vty: fix 'write file FILE' breaking 'show startup-config' Change-Id: I224ae41096c12f544dfe35a2c3f381b3bb3ba75e Related: OS#6440 --- M src/vty/command.c 1 file changed, 17 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/17/36617/1 diff --git a/src/vty/command.c b/src/vty/command.c index 1719690..d37516a 100644 --- a/src/vty/command.c +++ b/src/vty/command.c @@ -3490,6 +3490,7 @@ "Write to configuration file\n" "Set file path to store the config, or replace if already exists\n") { + const char *config_file; char *failed_file; int rc; @@ -3503,15 +3504,16 @@ } if (argc == 1) - host_config_set(argv[0]); - - if (host.config == NULL) { + config_file = argv[0]; + else /* write to the startup config file */ + config_file = host_config_file(); + if (config_file == NULL) { vty_out(vty, "Can't save to configuration file, using vtysh.%s", VTY_NEWLINE); return CMD_WARNING; } - rc = write_config_file(host.config, &failed_file); + rc = write_config_file(config_file, &failed_file); switch (rc) { case -1: vty_out(vty, "Can't open configuration file %s.%s", @@ -3544,7 +3546,7 @@ rc = CMD_WARNING; break; default: - vty_out(vty, "Configuration saved to %s%s", host.config, VTY_NEWLINE); + vty_out(vty, "Configuration saved to %s%s", config_file, VTY_NEWLINE); rc = CMD_SUCCESS; break; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36617?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I224ae41096c12f544dfe35a2c3f381b3bb3ba75e Gerrit-Change-Number: 36617 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

[S] Change in libosmocore[master]: tests: rename logging_test_gsmtap -> logging_gsmtap_test

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email ) Change subject: tests: rename logging_test_gsmtap -> logging_gsmtap_test ...................................................................... tests: rename logging_test_gsmtap -> logging_gsmtap_test This way the naming is consistent with existing tests and matches the 'tests/*/*_test' pattern in .gitignore. Change-Id: I280fc0cc1bda9ba445af71f00bc8f1ccfd2b2091 --- M tests/Makefile.am R tests/logging/logging_gsmtap_test.c R tests/logging/logging_gsmtap_test.err M tests/testsuite.at 4 files changed, 19 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/15/36615/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 45490f2..3b4325e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -15,7 +15,7 @@ gsm0808/gsm0808_test gsm0408/gsm0408_test \ gprs/gprs_test kasumi/kasumi_test gea/gea_test \ logging/logging_test codec/codec_test \ - logging/logging_test_gsmtap \ + logging/logging_gsmtap_test \ loggingrb/loggingrb_test strrb/strrb_test \ comp128/comp128_test \ bitvec/bitvec_test msgb/msgb_test bits/bitcomp_test \ @@ -246,7 +246,7 @@ logging_logging_vty_test_SOURCES = logging/logging_vty_test.c logging_logging_vty_test_LDADD = $(top_builddir)/src/vty/libosmovty.la $(LDADD) -logging_logging_test_gsmtap_SOURCES = logging/logging_test_gsmtap.c +logging_logging_gsmtap_test_SOURCES = logging/logging_gsmtap_test.c vty_vty_transcript_test_SOURCES = vty/vty_transcript_test.c vty_vty_transcript_test_LDADD = $(top_builddir)/src/vty/libosmovty.la $(LDADD) @@ -431,7 +431,7 @@ msgfile/msgfile_test.ok msgfile/msgconfig.cfg \ logging/logging_test.ok logging/logging_test.err \ logging/logging_vty_test.vty \ - logging/logging_test_gsmtap.err \ + logging/logging_gsmtap_test.err \ fr/fr_test.ok loggingrb/logging_test.ok \ loggingrb/logging_test.err strrb/strrb_test.ok \ codec/codec_test.ok \ @@ -589,8 +589,8 @@ logging/logging_test \ >$(srcdir)/logging/logging_test.ok \ 2>$(srcdir)/logging/logging_test.err - logging/logging_test_gsmtap \ - 2>&1 |grep -v "enqueueing message failed" >$(srcdir)/logging/logging_test_gsmtap.err + logging/logging_gsmtap_test \ + 2>&1 |grep -v "enqueueing message failed" >$(srcdir)/logging/logging_gsmtap_test.err codec/codec_test \ >$(srcdir)/codec/codec_test.ok codec/codec_ecu_fr_test \ diff --git a/tests/logging/logging_test_gsmtap.c b/tests/logging/logging_gsmtap_test.c similarity index 100% rename from tests/logging/logging_test_gsmtap.c rename to tests/logging/logging_gsmtap_test.c diff --git a/tests/logging/logging_test_gsmtap.err b/tests/logging/logging_gsmtap_test.err similarity index 100% rename from tests/logging/logging_test_gsmtap.err rename to tests/logging/logging_gsmtap_test.err diff --git a/tests/testsuite.at b/tests/testsuite.at index 9f17ba3..e721b93 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -202,8 +202,8 @@ AT_SETUP([logging_gsmtap]) AT_KEYWORDS([logging_gsmtap]) -cat $abs_srcdir/logging/logging_test_gsmtap.err > experr -AT_CHECK([$abs_top_builddir/tests/logging/logging_test_gsmtap 3>&1 1>&2 2>&3 |grep -v "enqueueing message failed" 3>&1 1>&2 2>&3 ], [], [ignore], [experr]) +cat $abs_srcdir/logging/logging_gsmtap_test.err > experr +AT_CHECK([$abs_top_builddir/tests/logging/logging_gsmtap_test 3>&1 1>&2 2>&3 |grep -v "enqueueing message failed" 3>&1 1>&2 2>&3 ], [], [ignore], [experr]) AT_CLEANUP AT_SETUP([codec]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I280fc0cc1bda9ba445af71f00bc8f1ccfd2b2091 Gerrit-Change-Number: 36615 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2024