fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email )
Change subject: ttcn3-sgsn-test: add config files for running SNS testcases
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36623?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I767ec223585002d6420eda27ed338722f764c902
Gerrit-Change-Number: 36623
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 22 Apr 2024 12:30:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email
to look at the new patch set (#2).
Change subject: ttcn3-sgsn-test: add missing SGSN_Tests_NS.control
......................................................................
ttcn3-sgsn-test: add missing SGSN_Tests_NS.control
This does not enable the SNS testcases though. We need a separate
job with its own configuration files for running the SNS testcases.
Change-Id: I605526dff6d3c0ec4c5dc58dc00ca51b4ccd68a7
Related: osmo-ttcn3-hacks.git Ib2bffbb110961474928f35d212cb492d4b6fdee0
---
M ttcn3-sgsn-test/SGSN_Tests.cfg
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/22/36622/2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36622?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I605526dff6d3c0ec4c5dc58dc00ca51b4ccd68a7
Gerrit-Change-Number: 36622
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Attention is currently required from: daniel, laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email )
Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE
......................................................................
Patch Set 6:
(1 comment)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601/comment/be34a9b2_441b…
PS6, Line 3748: f_pdp_ctx_act(apars);
> @vyanitskiy@sysmocom. […]
I don't think it really matters for this specific test scenario whether the requested IP address matches the assigned one. Likewise, I don't think it matters here whether we allocate IP address statically or dynamically.
Just to clarify: I was not the one implementing `f_pdp_ctx_act()`, so I am simply trying to use the existing code base. What you suggest makes sense for those testcases specifically testing the PDP Context Activation procedure. And AFAICS, the existing testcases do not cover these scenarios, unfortunately.
Here I just want to make sure that osmo-sgsn provides the `PDP Context IE` in `SGSN Context Response`. The IP address assignment approach is a less significant detail preceding the "core" phase of the test scenario.
I have two options with the existing code base:
* a) leave `apars.addr.addressInfo` empty (`omit`) - this is the default, and this results in a PDP Context activated with no address at all. The testcase is failing because osmo-sgsn does not include the `PDP Context IE`.
* b) assign a valid address to `apars.addr.addressInfo` - this is what I did in the last patch revision and got the testcase passing.
Regarding a), @dwillmann@sysmocom.de told me that it's impossible to encode a `PDP Context IE` in `SGSN Context Response` without an IP address. I just checked 3GPP TS 29.060, section 7.7.29 myself, and AFAICS it **is** possible: we can simply set `PDP Address Length` to 0.
So all in all, I can:
* stick to b) merging the current patch revision;
* fix osmo-sgsn to handle PCP contexts with empty IP address correctly (is this even a valid scenario on practice?) and revert back to the previous patch revision a);
* spend more hours on improving the testsuite, implementing additional testcases for static vs dynamic + requested != assigned scenarios (this goes beyond the scope of OS#6294).
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646
Gerrit-Change-Number: 36601
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Apr 2024 12:02:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email )
Change subject: Revert "hnbgw: osmo-hnbgw.cfg: Update file to make it similar to the one in docker-playground"
......................................................................
Patch Set 1:
(1 comment)
File hnbgw/osmo-hnbgw.cfg:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619/comment/347713cd_c845…
PS1, Line 38: asp asp-clnt-msc-0 2905 2905 m3ua
> To make it clear: This patch slowed me down significantly in working on tests for new customer-relev […]
I'm sorry for that. Next time I'll better leave it as WIP for somebody using the osmo-ttcn3-hacks setup directly to give it a try to avoid unexpected breakage.
Maybe simply drop the "asp" node in here for now but leave the other stuff not revertd, afaict that should be fine.
Feel free to merge this patch if it's still causing hassle.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36619?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia7d9a743e0359ce7220c42597ded670967d562a9
Gerrit-Change-Number: 36619
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 22 Apr 2024 11:53:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment