Attention is currently required from: char.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36376?usp=email )
Change subject: add missing modules to setup.py
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> These missing modules caused `pySim-shell. […]
Thanks, the fix looks good. It's actually not the first time we're forgetting to update `packages[]`, so we should consider improving the build verification somehow.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36376?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I330d5e35e5f1b508c6209b6894009b5fdd35d660
Gerrit-Change-Number: 36376
Gerrit-PatchSet: 2
Gerrit-Owner: char <osmocom(a)hypodyne.net>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: char <osmocom(a)hypodyne.net>
Gerrit-Comment-Date: Thu, 21 Mar 2024 05:28:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: char <osmocom(a)hypodyne.net>
Gerrit-MessageType: comment
char has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36376?usp=email )
Change subject: add missing modules to setup.py
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
These missing modules caused `pySim-shell.py` to crash on startup for me when I installed pySim using the Arch Linux Package method described in the README.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36376?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I330d5e35e5f1b508c6209b6894009b5fdd35d660
Gerrit-Change-Number: 36376
Gerrit-PatchSet: 2
Gerrit-Owner: char <osmocom(a)hypodyne.net>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Mar 2024 22:08:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/36376?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: add missing modules to setup.py
......................................................................
add missing modules to setup.py
Change-Id: I330d5e35e5f1b508c6209b6894009b5fdd35d660
---
M setup.py
1 file changed, 18 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/76/36376/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36376?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I330d5e35e5f1b508c6209b6894009b5fdd35d660
Gerrit-Change-Number: 36376
Gerrit-PatchSet: 2
Gerrit-Owner: char <osmocom(a)hypodyne.net>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36373?usp=email )
Change subject: ms: add config file
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-trx/+/36373/comment/de85458a_bbb133d3
PS2, Line 7: ms: add config file
This is quite misleading, this commit is doing tons of stuff other than "adding a config file".
Maybe "Make app configurable" or alike.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36373?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ibd432f7abbd00065a59104d2c006b676d5db7b47
Gerrit-Change-Number: 36373
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Mar 2024 19:24:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hoernchen has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-trx/+/36373?usp=email )
Change subject: ms: add config file
......................................................................
ms: add config file
This adds proper config options.
The ul/dl freq lines can be copied from the osmo-trx (network side) cfg.
Change-Id: Ibd432f7abbd00065a59104d2c006b676d5db7b47
---
M Transceiver52M/Makefile.am
M Transceiver52M/ms/bladerf_specific.h
M Transceiver52M/ms/ms.h
M Transceiver52M/ms/ms_rx_lower.cpp
M Transceiver52M/ms/ms_upper.cpp
M Transceiver52M/ms/ms_upper.h
A Transceiver52M/ms/mssdr_vty.c
A Transceiver52M/ms/mssdr_vty.h
M doc/examples/Makefile.am
A doc/examples/osmo-trx-ms-blade/mssdr.cfg
10 files changed, 580 insertions(+), 196 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/73/36373/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36373?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ibd432f7abbd00065a59104d2c006b676d5db7b47
Gerrit-Change-Number: 36373
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36373?usp=email )
Change subject: ms: add config file
......................................................................
Patch Set 1:
(1 comment)
File Transceiver52M/ms/mssdr_vty.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15283):
https://gerrit.osmocom.org/c/osmo-trx/+/36373/comment/c96a0196_5f378439
PS1, Line 264: }
adding a line without newline at end of file
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36373?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ibd432f7abbd00065a59104d2c006b676d5db7b47
Gerrit-Change-Number: 36373
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Mar 2024 18:48:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
