laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36422?usp=email )
Change subject: README.md: Add links to forum and issue tracker
......................................................................
README.md: Add links to forum and issue tracker
Change-Id: If5b028d5de19fb456ec91a7f94612131ee42c47c
---
M README.md
1 file changed, 25 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/22/36422/1
diff --git a/README.md b/README.md
index f1970d8..ffc666b 100644
--- a/README.md
+++ b/README.md
@@ -37,6 +37,13 @@
as well as the VTY reference manuals
* [VTY Reference Manual for osmo-stp](https://ftp.osmocom.org/docs/latest/osmostp-vty-reference.pdf)
+Forum
+-----
+
+We welcome any libosmo-sigtran + osmo-stp related discussions in the
+[Cellular Network Infrastructure -> 2G/3G Core Network](https://discourse.osmocom.org/c/cni/2g-3g-cn/)
+section of the osmocom discourse (web based Forum).
+
Mailing List
------------
@@ -49,6 +56,15 @@
Rules](https://osmocom.org/projects/cellular-infrastructure/wiki/Mailing_Li…
when posting.
+Issue Tracker
+-------------
+
+We use the issue trackers of smocom.org for tracking the state of bug reports and feature requests. Feel free
+to submit any issues you may find, or help us out by resolving existing issues.
+
+* [osmo-stp issue tracker](https://osmocom.org/projects/osmo-stp/issues)
+* [libosmo-sigtran issue tracker](https://osmocom.org/projects/libosmo-sccp/issues)
+
Contributing
------------
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36422?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: If5b028d5de19fb456ec91a7f94612131ee42c47c
Gerrit-Change-Number: 36422
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: osmith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libasn1c/+/36419?usp=email )
Change subject: Add README.md to explain what this is all about
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libasn1c/+/36419?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Change-Id: Idb8b7ac9ee93e93971376644444e434c41aa18fa
Gerrit-Change-Number: 36419
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 23 Mar 2024 12:08:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libasn1c/+/36419?usp=email )
Change subject: Add README.md to explain what this is all about
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
something really weird is happening in build verification of this patch. @osmith@sysmocom.de to the rescue, please
--
To view, visit https://gerrit.osmocom.org/c/libasn1c/+/36419?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Change-Id: Idb8b7ac9ee93e93971376644444e434c41aa18fa
Gerrit-Change-Number: 36419
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 23 Mar 2024 12:08:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36417?usp=email )
Change subject: README.md: Major update / meaningful content
......................................................................
README.md: Major update / meaningful content
Change-Id: Iec6a38bc34fdb0f9f0427df1c0fa53d513655a2a
---
M README.md
1 file changed, 65 insertions(+), 67 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/README.md b/README.md
index 8f2657f..2aa3af5 100644
--- a/README.md
+++ b/README.md
@@ -1,89 +1,78 @@
osmo-remsim - Osmocom remote SIM software suite
===============================================
-This software suite is a work in progress.
+osmo-remsim is a suite of software programs enabling physical/geographic separation of a cellular phone (or
+modem) on the one hand side and the SIM/USIM/ISIM card on the other side.
+
+Using osmo-remsim, you can operate an entire fleet of modems/phones, as well as banks of SIM cards and
+dynamically establish or remove the connections between modems/phones and cards.
+
+So in technical terms, it behaves like a proxy for the ISO 7816 smart card interface between the MS/UE and the
+UICC/SIM/USIM/ISIM.
+
+While originally designed to be used in context of cellular networks, there is nothing cellular specific in
+the system. It can therefore also be used with other systems that use contact based smart cards according to
+ISO 7816. Currently only the T=0 protocol with standard (non-extended) APDUs is supported.
+
+Homepage
+--------
+Please visit the [official homepage](https://osmocom.org/projects/osmo-remsim/wiki)
+for usage instructions, manual and examples.
-osmo-remsim-client
-------------------
+GIT Repository
+--------------
-The client interfaces with GSM phones / modems via dedicated "Card
-Emulation" devices such as the Osmocom SIMtrace2 or sysmocom sysmoQMOD
-board + firmware. This hardware implements the ISO7816-3 electrical
-interface and protocol handling and passes any TPDU headers received
-from the phone/modem to osmo-remsim-client for further processing of the
-TPDUs associated to the given APDU transfer.
+You can clone from the official osmo-remsim.git repository using
-osmo-remsim-client connects via a RSPRO control connection to
-osmo-remsim-server at startup and registers itself. It will receive
-configuration data such as the osmo-remsim-bankd IP+Port and the
-ClientId from osmo-remsim-server.
+ git clone https://gitea.osmocom.org/sim-card/osmo-remsim
-After receiving the configuration, osmo-remsim-client will establish a
-RSPRO data connection to the osmo-remsim-bankd IP:Port.
+There is a web interface at <https://gitea.osmocom.org/sim-card/osmo-remsim>.
-As the USB interface for remote SIM in simtrace2.git uses one interface
-per slot, we can implement the client in blocking mode, i.e. use
-blocking I/O on the TCP/RSPRO side. This simplifies the code compared
-to a more complex async implementation.
+Documentation
+-------------
+
+The User Manual is [optionally] built in PDF form as part of the build process.
+
+A pre-rendered PDF version of the current `master` can be found at
+[User Manual](https://downloads.osmocom.org/docs/latest/osmo-remsim-usermanual.pd….
-osmo-remsim-bankd
------------------
+Forum
+-----
-The osmo-remsim-bankd (SIM Bank Daemon) manages one given SIM bank. The
-initial implementation supports a PC/SC driver to expose any PC/SC
-compatible card readers as SIM bank.
+We welcome any osmo-remsim related discussions in the
+[SIM Card Technology](https://discourse.osmocom.org/c/sim-card-technology/)
+section of the osmocom discourse (web based Forum).
-osmo-remsim-bankd initially connects via a RSPRO control connection to
-osmo-remsim-server at startup, and will in turn receive a set of initial
-[client,slot]:[bankd,slot] mappings. These mappings determine which
-slot on the client (corresponding to a modem) is mapped to which slot on
-the SIM bank. Mappings can be updated by osmo-remsim-server at any given
-point in time.
-osmo-remsim-bankd implements a RSPRO server, where it listens to
-connections from osmo-remsim-clients.
+Mailing List
+------------
-As PC/SC only offers a blocking API, there is one thread per PC/SC slot.
-This thread will perform blocking I/O on the socket towards the client,
-and blocking API calls on PC/SC.
+There is no separate mailing list for this project. However,
+discussions related to pySim are happening on the simtrace
+<simtrace(a)lists.osmocom.org> mailing list, please see
+<https://lists.osmocom.org/mailman/listinfo/simtrace> for subscription
+options and the list archive.
-In terms of thread handling, we do:
+Please observe the [Osmocom Mailing List
+Rules](https://osmocom.org/projects/cellular-infrastructure/wiki/Mailing_List_Rules)
+when posting.
-* accept() handling in [spare] worker threads
-** this means blocking I/O can be used, as each worker thread only has
- one TCP connection
-** client identifies itself with client:slot
-** lookup mapping based on client:slot (using mutex for protection)
-** open the reader based on the lookup result
-The worker threads initially don't have any mapping to a specific
-reader, and that mapping is only established at a later point after the
-client has identified itself. The advantage is that the entire bankd
-can live without any non-blocking I/O.
+Issue Tracker
+-------------
-The main thread handles the connection to osmo-remsim-server, where it
-can also use non-blocking I/O. However, re-connection would be
-required, to avoid stalling all banks/cards in the event of a connection
-loss to the server.
+We use the [issue tracker of the osmo-remsim project on osmocom.org](https://osmocom.org/projects/osmo-remsim/issues) for
+tracking the state of bug reports and feature requests. Feel free to submit any issues you may find, or help
+us out by resolving existing issues.
-worker threads have the following states:
-* INIT (just started)
-* ACCEPTING (they're blocking in the accept() call on the server socket fd)
-* CONNECTED_WAIT_ID (TCP established, but peer not yet identified itself)
-* CONNECTED_CLIENT (TCP established, client has identified itself, no mapping)
-* CONNECTED_CLIENT_MAPPED (TCP established, client has identified itself, mapping exists)
-* CONNECTED_CLIENT_MAPPED_CARD (TCP established, client identified, mapping exists, card opened)
-* CONNECTED_SERVER (TCP established, server has identified itself)
-Once the client disconnects, or any other error occurs (such as card I/O
-errors), the worker thread either returns to INIT state (closing client
-socket and reader), or it terminates. Termination would mean that the
-main thread would have to do non-blocking join to detect client
-termination and then re-spawn clients, so the "return to INIT state"
-approach seems to make more sense.
+Contributing
+------------
-Open topics:
-* detecting multiple connections from a server, logging this or even
- avoiding that situation
+Our coding standards are described at
+<https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards>
+
+We are using a gerrit-based patch review process explained at
+<https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit>
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36417?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Iec6a38bc34fdb0f9f0427df1c0fa53d513655a2a
Gerrit-Change-Number: 36417
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libasn1c/+/36419?usp=email )
Change subject: Add README.md to explain what this is all about
......................................................................
Add README.md to explain what this is all about
Change-Id: Idb8b7ac9ee93e93971376644444e434c41aa18fa
---
A README.md
1 file changed, 46 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/19/36419/1
diff --git a/README.md b/README.md
new file mode 100644
index 0000000..2fa43c2
--- /dev/null
+++ b/README.md
@@ -0,0 +1,37 @@
+libasn1c - shared library of asn1c runtime
+==========================================
+
+This repository contains a shared library built from the asn1c runtime files.
+
+Normally, the upstream asn1c copies an identical set of source code files into each and every project using
+asn1c. This becomes problematic if a single program uses multiple different ASN.1 specifications, where then
+those source files woudl clash.
+
+Let's instead move those runtime files into a shared library (*libasn1c*), which is then linked once by each program
+needing it, no matter how many asn1c-generated specifications/syntax it uses.
+
+**The version of the asn1c compiler must match the version of libasn1c**. We are using this shared library in
+combination with the [osmocom fork of asn1c](https://gitea.osmocom.org/osmocom/asn1c).
+
+
+GIT Repository
+--------------
+
+You can clone from the official libosmocore.git repository using
+
+ git clone https://gitea.osmocom.org/cellular-infrastructure/libasn1c
+
+There is a web interface at <https://gitea.osmocom.org/cellular-infrastructure/libasn1c>
+
+
+Mailing List
+------------
+
+Discussions related to libasn1c are happening on the
+openbsc(a)lists.osmocom.org mailing list, please see
+<https://lists.osmocom.org/mailman/listinfo/openbsc> for subscription
+options and the list archive.
+
+Please observe the [Osmocom Mailing List
+Rules](https://osmocom.org/projects/cellular-infrastructure/wiki/Mailing_List_Rules)
+when posting.
--
To view, visit https://gerrit.osmocom.org/c/libasn1c/+/36419?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Change-Id: Idb8b7ac9ee93e93971376644444e434c41aa18fa
Gerrit-Change-Number: 36419
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: add osmo_pfcp_ip_addrs_get
......................................................................
add osmo_pfcp_ip_addrs_get
This pattern shows up a lot when working with PFCP. Let's make it easier
to handle IPv4 and v6 at the same time.
Change-Id: I4338a83f26ef2443f90cf835621e73aed5eac521
---
M include/osmocom/pfcp/pfcp_ies_custom.h
M src/libosmo-pfcp/pfcp_msg.c
2 files changed, 50 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/48/36348/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I4338a83f26ef2443f90cf835621e73aed5eac521
Gerrit-Change-Number: 36348
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348?usp=email )
Change subject: add osmo_pfcp_ip_addrs_get
......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-pfcp/pfcp_msg.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348/comment/ba463341_162c07fa
PS1, Line 523: *v4 = (struct osmo_sockaddr){};
> you probably want to set sa_family to AF_UNSPEC here. […]
i doubt that it's needed, but simple enough.
BTW for the sockaddr_str below it suffices to have .ip[0] == 0.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I4338a83f26ef2443f90cf835621e73aed5eac521
Gerrit-Change-Number: 36348
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 23 Mar 2024 12:03:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment