March 2024 - gerrit-log - lists.osmocom.org

[M] Change in ...osmo-epdg[master]: Implement sim auth resync

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36217?usp=email ) Change subject: Implement sim auth resync ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I75413b0c4b491425c3b01d75fdd1674cf7f3bbde Gerrit-Change-Number: 36217 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 11 Mar 2024 10:13:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in ...osmo-epdg[master]: Implement sim auth resync

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36217?usp=email ) Change subject: Implement sim auth resync ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I75413b0c4b491425c3b01d75fdd1674cf7f3bbde Gerrit-Change-Number: 36217 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 11 Mar 2024 10:11:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: epdg: Add expected-results.xml

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36219?usp=email ) Change subject: epdg: Add expected-results.xml ...................................................................... epdg: Add expected-results.xml Change-Id: I73b988220d58c36de99baf43e88ac70f646bbe3a --- A epdg/expected-results.xml 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/epdg/expected-results.xml b/epdg/expected-results.xml new file mode 100644 index 0000000..6507cc2 --- /dev/null +++ b/epdg/expected-results.xml @@ -0,0 +1,14 @@ +<?xml version="1.0"?> +<testsuite name='EPDG_Tests' tests='11' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> + <testcase classname='EPDG_Tests' name='TC_authinfo_normal' time='MASKED'/> + <testcase classname='EPDG_Tests' name='TC_authinfo_MAA_unknown_user' time='MASKED'/> + <testcase classname='EPDG_Tests' name='TC_authinfo_twice' time='MASKED'/> + <testcase classname='EPDG_Tests' name='TC_authinfo_fail_resync' time='MASKED'/> + <testcase classname='EPDG_Tests' name='TC_ho_lte_to_wifi' time='MASKED'/> + <testcase classname='EPDG_Tests' name='TC_ho_wifi_to_lte' time='MASKED'/> + <testcase classname='EPDG_Tests' name='TC_s2b_CreateSession_rejected' time='MASKED'/> + <testcase classname='EPDG_Tests' name='TC_concurrent_ues2' time='MASKED'/> + <testcase classname='EPDG_Tests' name='TC_concurrent_ues100' time='MASKED'/> + <testcase classname='EPDG_Tests' name='TC_upf_echo_req' time='MASKED'/> + <testcase classname='EPDG_Tests' name='TC_mt_ipv4_echo_req' time='MASKED'/> +</testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I73b988220d58c36de99baf43e88ac70f646bbe3a Gerrit-Change-Number: 36219 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Introduce test TC_authinfo_fail_resync

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36218?usp=email ) Change subject: epdg: Introduce test TC_authinfo_fail_resync ...................................................................... epdg: Introduce test TC_authinfo_fail_resync Related: OS#6396 Change-Id: I2769d331740324200b4512a154e1321bd5825b04 --- M epdg/EPDG_Tests.ttcn M library/GSUP_Templates.ttcn 2 files changed, 69 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index 164f14b..d8112e8 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -422,9 +422,24 @@ } /* Diameter SWx MAR + MAA. */ -private altstep as_DIA_SWx_MA_success() runs on EPDG_ConnHdlr { +private altstep as_DIA_SWx_MA_success(boolean exp_req_resync := false) runs on EPDG_ConnHdlr { var PDU_DIAMETER rx_dia; [] SWx.receive(tr_DIA_SWx_MAR(g_pars.imsi)) -> value rx_dia { + if (exp_req_resync) { + var octetstring rand_autn_concatenated := g_pars.vec.rand & g_pars.vec.auts; + var AVP avp_grp; + var GenericAVP sip_auth_avp; + + avp_grp := f_DIAMETER_get_avp_or_fail(rx_dia, c_AVP_Code_CxDx_3GPP_SIP_Auth_Data_Item); + sip_auth_avp.avp := f_AVP_Grouped_get_avp_or_fail(avp_grp.avp_data.avp_CxDx_3GPP_SIP_Auth_Data_Item, + c_AVP_Code_CxDx_3GPP_SIP_Authorization); + + if (not match(sip_auth_avp, tr_AVP_3GPP_SIPAuthorization(rand_autn_concatenated))) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Unexpected Diameter AVP SIP-Authorization: ", sip_auth_avp, + " vs exp ", tr_AVP_3GPP_SIPAuthorization(rand_autn_concatenated))); + } + } f_DIA_SWx_tx_MAA_success(rx_dia); setverdict(pass); } @@ -754,13 +769,19 @@ } } -private function f_GSUP_tx_SAI_REQ() runs on EPDG_ConnHdlr { +private function f_GSUP_tx_SAI_REQ(boolean req_resync := false) runs on EPDG_ConnHdlr { var GSUP_PDU rx_gsup; var template (value) GSUP_IEs pdp_info; pdp_info := { ts_GSUP_IE_PDP_CONTEXT_ID('00'O), ts_GSUP_IE_PDP_ADDRESS(ts_EuaIPv4Dyn), ts_GSUP_IE_APN(f_enc_dns_hostname(g_pars.apn)) }; - GSUP.send(ts_GSUP_SAI_REQ_PDP_INFO(g_pars.imsi, pdp_info)); + if (req_resync) { + GSUP.send(ts_GSUP_SAI_REQ_PDP_INFO_UMTS_AKA_RESYNC( + g_pars.imsi, pdp_info, + g_pars.vec.auts, g_pars.vec.rand)); + } else { + GSUP.send(ts_GSUP_SAI_REQ_PDP_INFO(g_pars.imsi, pdp_info)); + } } @@ -791,9 +812,9 @@ } /* GSUP AuthInfo Req + Resp, triggers SWx MAR + MAA. */ -private function f_GSUP_AI_success() runs on EPDG_ConnHdlr { - f_GSUP_tx_SAI_REQ(); - as_DIA_SWx_MA_success(); +private function f_GSUP_AI_success(boolean req_resync := false) runs on EPDG_ConnHdlr { + f_GSUP_tx_SAI_REQ(req_resync); + as_DIA_SWx_MA_success(req_resync); as_GSUP_rx_SAI_RES(); setverdict(pass); } @@ -942,6 +963,23 @@ setverdict(pass); } +/* Emulate UE doing MAR+MAA, then UE requesting again due to resync needed */ +private function f_TC_authinfo_fail_resync(charstring id) runs on EPDG_ConnHdlr { + f_GSUP_AI_success(false); + f_GSUP_AI_success(true); + f_GSUP_LU_success(); + f_GSUP_EPDGTunnel_success(); + f_GSUP_PurgeMS_success(); +} +testcase TC_authinfo_fail_resync() runs on MTC_CT { + var EPDG_ConnHdlrPars pars := f_init_pars(); + var EPDG_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_authinfo_fail_resync), pars); + vc_conn.done; + setverdict(pass); +} + private function f_TC_ho_lte_to_wifi(charstring id) runs on EPDG_ConnHdlr { f_initial_attach(); /* Whenever UE comes from 3GPP, PGW may activate a dedicated S2b bearer @@ -1079,6 +1117,7 @@ execute ( TC_authinfo_normal() ); execute ( TC_authinfo_MAA_unknown_user() ); execute ( TC_authinfo_twice() ); + execute ( TC_authinfo_fail_resync() ); execute ( TC_ho_lte_to_wifi() ); execute ( TC_ho_wifi_to_lte() ); execute ( TC_s2b_CreateSession_rejected() ); diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index dcf086d..403af74 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -356,6 +356,18 @@ valueof(ts_GSUP_IE_PdpInfo_ie(pdp_info)) }); +template GSUP_PDU ts_GSUP_SAI_REQ_PDP_INFO_UMTS_AKA_RESYNC( + template (value) hexstring imsi, + template (value) GSUP_IEs pdp_info, + template (value) octetstring auts, + template (value) octetstring rand) := + ts_GSUP(OSMO_GSUP_MSGT_SEND_AUTH_INFO_REQUEST, { + valueof(ts_GSUP_IE_IMSI(imsi)), + valueof(ts_GSUP_IE_PdpInfo_ie(pdp_info)), + valueof(ts_GSUP_IE_AUTS(auts)), + valueof(ts_GSUP_IE_RAND(rand)) + }); + template GSUP_PDU tr_GSUP_SAI_REQ(template hexstring imsi) := tr_GSUP_IMSI(OSMO_GSUP_MSGT_SEND_AUTH_INFO_REQUEST, imsi); @@ -644,7 +656,7 @@ } } -template (value) GSUP_IE ts_GSUP_IE_AUTS(octetstring auts) := { +template (value) GSUP_IE ts_GSUP_IE_AUTS(template (value) octetstring auts) := { tag := OSMO_GSUP_AUTS_IE, len := 0, /* overwritten */ val := { @@ -660,7 +672,7 @@ } } -template (value) GSUP_IE ts_GSUP_IE_RAND(octetstring rand) := { +template (value) GSUP_IE ts_GSUP_IE_RAND(template (value) octetstring rand) := { tag := OSMO_GSUP_RAND_IE, len := 0, /* overwritten */ val := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36218?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2769d331740324200b4512a154e1321bd5825b04 Gerrit-Change-Number: 36218 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Introduce test TC_authinfo_fail_resync

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36218?usp=email ) Change subject: epdg: Introduce test TC_authinfo_fail_resync ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36218?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2769d331740324200b4512a154e1321bd5825b04 Gerrit-Change-Number: 36218 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Mar 2024 10:00:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-pcu[master]: doc: Mention the `gb-dialect` vty option, as it is quite essential

by pespin

Attention is currently required from: daniel, laforge, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36220?usp=email ) Change subject: doc: Mention the `gb-dialect` vty option, as it is quite essential ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36220?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I83709b7231c2a3930e1b3f09b737319fb7d7e741 Gerrit-Change-Number: 36220 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 11 Mar 2024 09:42:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: cosmetic: talk about cs_rab_ass_* when working in CS domain

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36216?usp=email ) Change subject: cosmetic: talk about cs_rab_ass_* when working in CS domain ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id49ef931e11958315d612d764bbc488ef43f4290 Gerrit-Change-Number: 36216 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 11 Mar 2024 09:29:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: cosmetic: Fix comment in mgw_fsm.c: One RAB per context_map, not hnb!

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36215?usp=email ) Change subject: cosmetic: Fix comment in mgw_fsm.c: One RAB per context_map, not hnb! ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0cecccd94ba9c1b14de083265a394a210b758b92 Gerrit-Change-Number: 36215 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 11 Mar 2024 09:29:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-hnbgw[master]: stats: Introduce basic counters for RANAP unit-data from CN links

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36213?usp=email ) Change subject: stats: Introduce basic counters for RANAP unit-data from CN links ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ibe4c73b0288ea20ca3d54519b42bc7cb0e9e61b2 Gerrit-Change-Number: 36213 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 11 Mar 2024 09:28:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: stats: Introduce CNPOOL counter macro

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36212?usp=email ) Change subject: stats: Introduce CNPOOL counter macro ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5b9e6b2069eed533c472cea8483a370f7fcc8e74 Gerrit-Change-Number: 36212 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 11 Mar 2024 09:26:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024